Re: [PR] Add scan planning api request and response models, parsers [iceberg]

github-actions[bot] commented on PR #11369: URL: https://github.com/apache/iceberg/pull/11369#issuecomment-2689398791 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1929038949 ## core/src/main/java/org/apache/iceberg/ContentFileParser.java: ## @@ -27,7 +27,7 @@ import org.apache.iceberg.relocated.com.google.common.base.Preconditions; impo

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1926051437 ## core/src/main/java/org/apache/iceberg/UnboundBaseFileScanTask.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1926051437 ## core/src/main/java/org/apache/iceberg/UnboundBaseFileScanTask.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rdblue commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1925975943 ## core/src/main/java/org/apache/iceberg/UnboundBaseFileScanTask.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rdblue commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1925975079 ## core/src/main/java/org/apache/iceberg/UnboundBaseFileScanTask.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rdblue commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1925973465 ## core/src/main/java/org/apache/iceberg/ContentFileParser.java: ## @@ -48,6 +48,97 @@ class ContentFileParser { private ContentFileParser() {} + public static

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rdblue commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1925971968 ## core/src/main/java/org/apache/iceberg/ContentFileParser.java: ## @@ -48,6 +48,97 @@ class ContentFileParser { private ContentFileParser() {} + public static

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rdblue commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1925958651 ## core/src/main/java/org/apache/iceberg/ContentFileParser.java: ## @@ -48,6 +48,97 @@ class ContentFileParser { private ContentFileParser() {} + public static

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rdblue commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1925939554 ## core/src/main/java/org/apache/iceberg/ContentFileParser.java: ## @@ -48,6 +48,97 @@ class ContentFileParser { private ContentFileParser() {} + public static

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rdblue commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1925939188 ## core/src/main/java/org/apache/iceberg/ContentFileParser.java: ## @@ -27,7 +27,7 @@ import org.apache.iceberg.relocated.com.google.common.base.Preconditions; impor

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rdblue commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1925938262 ## core/src/main/java/org/apache/iceberg/ContentFileParser.java: ## @@ -48,6 +48,97 @@ class ContentFileParser { private ContentFileParser() {} + public static

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rdblue commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1925935152 ## core/src/main/java/org/apache/iceberg/ContentFileParser.java: ## @@ -48,6 +48,97 @@ class ContentFileParser { private ContentFileParser() {} + public static

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on PR #11369: URL: https://github.com/apache/iceberg/pull/11369#issuecomment-2606180047 Reviving this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

github-actions[bot] closed pull request #11369: Add scan planning api request and response models, parsers URL: https://github.com/apache/iceberg/pull/11369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

github-actions[bot] commented on PR #11369: URL: https://github.com/apache/iceberg/pull/11369#issuecomment-2599402066 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

github-actions[bot] commented on PR #11369: URL: https://github.com/apache/iceberg/pull/11369#issuecomment-2581488348 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on PR #11369: URL: https://github.com/apache/iceberg/pull/11369#issuecomment-2532787657 @amogh-jahagirdar Was wondering if there is another issues, or if you think we can land this? -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1866348249 ## core/src/main/java/org/apache/iceberg/RESTFileScanTaskParser.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1861354496 ## core/src/test/java/org/apache/iceberg/rest/requests/TestPlanTableScanRequestParser.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1861350352 ## core/src/test/java/org/apache/iceberg/rest/responses/TestPlanTableScanResponseParser.java: ## @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1861347016 ## core/src/test/java/org/apache/iceberg/rest/responses/TestFetchScanTasksResponseParser.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1861347257 ## core/src/test/java/org/apache/iceberg/rest/responses/TestFetchScanTasksResponseParser.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1861334737 ## core/src/test/java/org/apache/iceberg/rest/responses/TestFetchScanTasksResponseParser.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1861310725 ## api/src/main/java/org/apache/iceberg/exceptions/EntityNotFoundException.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1861314221 ## core/src/test/java/org/apache/iceberg/rest/responses/TestFetchScanTasksResponseParser.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1861313142 ## core/src/test/java/org/apache/iceberg/rest/responses/TestFetchScanTasksResponseParser.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1861311628 ## core/src/main/java/org/apache/iceberg/rest/requests/PlanTableScanRequestParser.java: ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1861239915 ## core/src/test/java/org/apache/iceberg/rest/responses/TestFetchScanTasksResponseParser.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1861183796 ## core/src/test/java/org/apache/iceberg/rest/responses/TestFetchScanTasksResponseParser.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1861183629 ## core/src/main/java/org/apache/iceberg/RESTFileScanTaskParser.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1861181045 ## core/src/main/java/org/apache/iceberg/rest/requests/PlanTableScanRequestParser.java: ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1861165401 ## core/src/main/java/org/apache/iceberg/rest/requests/FetchScanTasksRequest.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1861173069 ## core/src/main/java/org/apache/iceberg/rest/requests/PlanTableScanRequestParser.java: ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1861149852 ## core/src/main/java/org/apache/iceberg/rest/requests/FetchScanTasksRequest.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1861148874 ## core/src/main/java/org/apache/iceberg/ContentFileParser.java: ## @@ -48,6 +48,97 @@ class ContentFileParser { private ContentFileParser() {} + public stati

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1861144615 ## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ## @@ -511,7 +511,6 @@ public Table loadTable(SessionContext context, TableIdentifier identifi

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1859956563 ## core/src/test/java/org/apache/iceberg/rest/responses/TestFetchScanTasksResponseParser.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1859959392 ## core/src/test/java/org/apache/iceberg/rest/requests/TestPlanTableScanRequestParser.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1859958795 ## core/src/test/java/org/apache/iceberg/rest/responses/TestPlanTableScanResponseParser.java: ## @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1859957950 ## core/src/test/java/org/apache/iceberg/rest/responses/TestFetchScanTasksResponseParser.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1859939105 ## core/src/test/java/org/apache/iceberg/rest/responses/TestFetchScanTasksResponseParser.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1859932083 ## core/src/test/java/org/apache/iceberg/rest/responses/TestFetchScanTasksResponseParser.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1859909899 ## core/src/main/java/org/apache/iceberg/rest/requests/PlanTableScanRequestParser.java: ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1859891750 ## core/src/main/java/org/apache/iceberg/ContentFileParser.java: ## @@ -48,6 +48,97 @@ class ContentFileParser { private ContentFileParser() {} + pub

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on PR #11369: URL: https://github.com/apache/iceberg/pull/11369#issuecomment-2499254860 @nastra @amogh-jahagirdar Have addressed the comments from the main pr: https://github.com/apache/iceberg/pull/11180/files to this models only pr. If something looks off please let me k

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1857427945 ## core/src/test/java/org/apache/iceberg/TestBase.java: ## @@ -63,7 +64,9 @@ public class TestBase { public static final PartitionSpec SPEC = Parti

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1852965609 ## api/src/main/java/org/apache/iceberg/exceptions/EntityNotFoundException.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1852964353 ## core/src/main/java/org/apache/iceberg/rest/responses/FetchPlanningResultResponse.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1829479240 ## core/src/main/java/org/apache/iceberg/UnboundBaseFileScanTask.java: ## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1811606245 ## core/src/main/java/org/apache/iceberg/rest/requests/PlanTableScanRequestParser.java: ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on PR #11369: URL: https://github.com/apache/iceberg/pull/11369#issuecomment-2444675563 > @rahil-c can you please make sure that my comments from #11180 are addressed here? @nastra yes will try to address the comments from the original pr here. cc @amogh-jahag

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

nastra commented on PR #11369: URL: https://github.com/apache/iceberg/pull/11369#issuecomment-2443654429 @rahil-c can you please make sure that my comments from https://github.com/apache/iceberg/pull/11180 are addressed here? -- This is an automated message from the Apache Git Service. To

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1809651581 ## core/src/main/java/org/apache/iceberg/rest/requests/PlanTableScanRequestParser.java: ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1809651428 ## core/src/main/java/org/apache/iceberg/rest/requests/PlanTableScanRequest.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1809597784 ## api/src/main/java/org/apache/iceberg/exceptions/EntityNotFoundException.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1809595809 ## core/src/main/java/org/apache/iceberg/UnboundBaseFileScanTask.java: ## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1809592523 ## core/src/main/java/org/apache/iceberg/rest/responses/FetchPlanningResultResponse.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1809592523 ## core/src/main/java/org/apache/iceberg/rest/responses/FetchPlanningResultResponse.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1809592523 ## core/src/main/java/org/apache/iceberg/rest/responses/FetchPlanningResultResponse.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1809592523 ## core/src/main/java/org/apache/iceberg/rest/responses/FetchPlanningResultResponse.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1809454055 ## core/src/main/java/org/apache/iceberg/rest/responses/FetchPlanningResultResponse.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Add scan planning api request and response models, parsers [iceberg]

rahil-c commented on PR #11369: URL: https://github.com/apache/iceberg/pull/11369#issuecomment-2427454239 Thanks @amogh-jahagirdar for helping clean up the pr, it is greatly appreciated! -- This is an automated message from the Apache Git Service. To respond to the message, please log on