amogh-jahagirdar commented on code in PR #11369: URL: https://github.com/apache/iceberg/pull/11369#discussion_r1859958795
########## core/src/test/java/org/apache/iceberg/rest/responses/TestPlanTableScanResponseParser.java: ########## @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.rest.responses; + +import static org.apache.iceberg.TestBase.FILE_A; +import static org.apache.iceberg.TestBase.FILE_A_DELETES; +import static org.apache.iceberg.TestBase.PARTITION_SPECS_BY_ID; +import static org.apache.iceberg.TestBase.SCHEMA; +import static org.apache.iceberg.TestBase.SPEC; +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatThrownBy; + +import com.fasterxml.jackson.databind.JsonNode; +import java.util.List; +import org.apache.iceberg.BaseFileScanTask; +import org.apache.iceberg.DeleteFile; +import org.apache.iceberg.FileScanTask; +import org.apache.iceberg.PartitionSpecParser; +import org.apache.iceberg.SchemaParser; +import org.apache.iceberg.expressions.Expressions; +import org.apache.iceberg.expressions.ResidualEvaluator; +import org.apache.iceberg.rest.PlanStatus; +import org.junit.jupiter.api.Test; + +public class TestPlanTableScanResponseParser { + @Test + public void nullAndEmptyCheck() { + assertThatThrownBy(() -> PlanTableScanResponseParser.toJson(null)) + .isInstanceOf(IllegalArgumentException.class) + .hasMessage("Invalid response: planTableScanResponse null"); + + assertThatThrownBy(() -> PlanTableScanResponseParser.fromJson((JsonNode) null)) + .isInstanceOf(IllegalArgumentException.class) + .hasMessage("Cannot parse planTableScan response from empty or null object"); + } + + @Test + public void roundTripSerdeWithEmptyObject() { + + assertThatThrownBy(() -> PlanTableScanResponse.builder().build()) + .isInstanceOf(IllegalArgumentException.class) + .hasMessage("Invalid response: plan status must be defined"); + + String emptyJson = "{ }"; + assertThatThrownBy(() -> PlanTableScanResponseParser.fromJson(emptyJson)) + .isInstanceOf(IllegalArgumentException.class) + .hasMessage("Cannot parse planTableScan response from empty or null object"); + } + + @Test + public void missingRequiredField() { + String missingRequiredFieldJson = "{\"x\": \"val\"}"; + assertThatThrownBy(() -> PlanTableScanResponseParser.fromJson(missingRequiredFieldJson)) + .isInstanceOf(IllegalArgumentException.class) + .hasMessage("Cannot parse missing string: plan-status"); + } + + @Test + public void roundTripSerdeWithInvalidPlanStatus() { + String invalidStatusJson = "{\"plan-status\": \"someStatus\"}"; + assertThatThrownBy(() -> PlanTableScanResponseParser.fromJson(invalidStatusJson)) + .isInstanceOf(IllegalArgumentException.class) + .hasMessage("Invalid status name: someStatus"); + } + + @Test + public void roundTripSerdeWithInvalidPlanStatusSubmittedWithoutPlanId() { + PlanStatus planStatus = PlanStatus.fromName("submitted"); + + assertThatThrownBy(() -> PlanTableScanResponse.builder().withPlanStatus(planStatus).build()) + .isInstanceOf(IllegalArgumentException.class) + .hasMessage("Invalid response: plan id should be defined when status is 'submitted'"); + + String invalidJson = "{\"plan-status\":\"submitted\"}"; + assertThatThrownBy(() -> PlanTableScanResponseParser.fromJson(invalidJson)) + .isInstanceOf(IllegalArgumentException.class) + .hasMessage("Invalid response: plan id should be defined when status is 'submitted'"); + } + + @Test + public void roundTripSerdeWithInvalidPlanStatusCancelled() { + PlanStatus planStatus = PlanStatus.fromName("cancelled"); + assertThatThrownBy(() -> PlanTableScanResponse.builder().withPlanStatus(planStatus).build()) + .isInstanceOf(IllegalArgumentException.class) + .hasMessage("Invalid response: 'cancelled' is not a valid status for planTableScan"); + + String invalidJson = "{\"plan-status\":\"cancelled\"}"; + assertThatThrownBy(() -> PlanTableScanResponseParser.fromJson(invalidJson)) + .isInstanceOf(IllegalArgumentException.class) + .hasMessage("Invalid response: 'cancelled' is not a valid status for planTableScan"); + } + + @Test + public void roundTripSerdeWithInvalidPlanStatusSubmittedWithTasksPresent() { + PlanStatus planStatus = PlanStatus.fromName("submitted"); + assertThatThrownBy( + () -> + PlanTableScanResponse.builder() + .withPlanStatus(planStatus) + .withPlanId("somePlanId") + .withPlanTasks(List.of("task1", "task2")) + .build()) + .isInstanceOf(IllegalArgumentException.class) + .hasMessage("Invalid response: tasks can only be returned in a 'completed' status"); + + String invalidJson = + "{\"plan-status\":\"submitted\"," + + "\"plan-id\":\"somePlanId\"," + + "\"plan-tasks\":[\"task1\",\"task2\"]}"; + + assertThatThrownBy(() -> PlanTableScanResponseParser.fromJson(invalidJson)) + .isInstanceOf(IllegalArgumentException.class) + .hasMessage("Invalid response: tasks can only be returned in a 'completed' status"); + } + + @Test + public void roundTripSerdeWithInvalidPlanIdWithIncorrectStatus() { + PlanStatus planStatus = PlanStatus.fromName("failed"); + assertThatThrownBy( + () -> + PlanTableScanResponse.builder() + .withPlanStatus(planStatus) + .withPlanId("somePlanId") + .build()) + .isInstanceOf(IllegalArgumentException.class) + .hasMessage("Invalid response: plan id can only be returned in a 'submitted' status"); + + String invalidJson = "{\"plan-status\":\"failed\"," + "\"plan-id\":\"somePlanId\"}"; + + assertThatThrownBy(() -> PlanTableScanResponseParser.fromJson(invalidJson)) + .isInstanceOf(IllegalArgumentException.class) + .hasMessage("Invalid response: plan id can only be returned in a 'submitted' status"); + } + + @Test + public void roundTripSerdeWithInvalidPlanStatusSubmittedWithDeleteFilesNoFileScanTasksPresent() { Review Comment: I don't think any of the failure case tests should have the prefix "round trip", nothing is really roundtripping here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
