rdblue commented on code in PR #11369:
URL: https://github.com/apache/iceberg/pull/11369#discussion_r1925935152
##########
core/src/main/java/org/apache/iceberg/ContentFileParser.java:
##########
@@ -48,6 +48,97 @@ class ContentFileParser {
private ContentFileParser() {}
+ public static void unboundContentFileToJson(
+ ContentFile<?> contentFile, PartitionSpec spec, JsonGenerator generator)
throws IOException {
+ Preconditions.checkArgument(contentFile != null, "Invalid content file:
null");
+ Preconditions.checkArgument(spec != null, "Invalid partition spec: null");
+ Preconditions.checkArgument(generator != null, "Invalid JSON generator:
null");
Review Comment:
We generally try to avoid exposing `JsonGenerator` or other Jackson classes
in public methods. Can this be package-private? See [`SnapshotParser` for an
example](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/SnapshotParser.java#L55)
of how other parsers handle visibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
