amogh-jahagirdar commented on code in PR #11369:
URL: https://github.com/apache/iceberg/pull/11369#discussion_r1857427945


##########
core/src/test/java/org/apache/iceberg/TestBase.java:
##########
@@ -63,7 +64,9 @@ public class TestBase {
   public static final PartitionSpec SPEC =
       PartitionSpec.builderFor(SCHEMA).bucket("data", BUCKETS_NUMBER).build();
 
-  static final DataFile FILE_A =
+  public static final Map<Integer, PartitionSpec> PARTITION_SPECS_BY_ID = 
Map.of(0, SPEC);
+
+  public static final DataFile FILE_A =

Review Comment:
   Following up on 
https://github.com/apache/iceberg/pull/11180#discussion_r1857154984, I'm good 
if we want to make these public. Would've been nice to keep package private but 
the original concern was that we were sort of breaking the existing pattern, 
but as @rahil-c mentioned, `SPEC` and `SCHEMA`  are already public. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to