rahil-c commented on code in PR #11369:
URL: https://github.com/apache/iceberg/pull/11369#discussion_r1929038949
##########
core/src/main/java/org/apache/iceberg/ContentFileParser.java:
##########
@@ -27,7 +27,7 @@
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
import org.apache.iceberg.util.JsonUtil;
-class ContentFileParser {
+public class ContentFileParser {
Review Comment:
@rdblue @amogh-jahagirdar
Currently the `ContentFileParser` is located within package
`org.apache.iceberg` as opposed to something like
`org.apache.iceberg.rest.responses`. The reason this parser is located within
this package is that it is able to access private classes such as
`ContentFile`, `GenericDataFile` etc.
However it seems we have placed the `TableScanResponseParser` which is what
is used by the majority of endpoints in `org.apache.iceberg.rest.responses`,
and this invokes the `ContentFileParser`. When i tried removing the `public`
from content file parser naturally got issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
