Re: [PR] Add Python version 3.13 to test matrix. [iceberg-python]

2025-05-03 Thread via GitHub
JE-Chen commented on PR #1377: URL: https://github.com/apache/iceberg-python/pull/1377#issuecomment-2849025597 Do I need to update this list? ![image](https://github.com/user-attachments/assets/5df35483-c40a-4f70-8351-cfa39b17792a) -- This is an automated message from the Apach

Re: [PR] Flink: Maintenance - RewriteDataFiles [iceberg]

2025-05-03 Thread via GitHub
stevenzwu commented on code in PR #11497: URL: https://github.com/apache/iceberg/pull/11497#discussion_r2072517185 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/DataFileRewriteRunner.java: ## @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Sof

Re: [PR] Build: Bump com.azure:azure-sdk-bom from 1.2.31 to 1.2.33 [iceberg]

2025-05-03 Thread via GitHub
dependabot[bot] commented on PR #12689: URL: https://github.com/apache/iceberg/pull/12689#issuecomment-2849001125 Superseded by #12962. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[PR] Build: Bump org.openapitools:openapi-generator-gradle-plugin from 7.12.0 to 7.13.0 [iceberg]

2025-05-03 Thread via GitHub
dependabot[bot] opened a new pull request, #12966: URL: https://github.com/apache/iceberg/pull/12966 Bumps [org.openapitools:openapi-generator-gradle-plugin](https://github.com/OpenAPITools/openapi-generator) from 7.12.0 to 7.13.0. Release notes Sourced from https://github.com/Ope

[PR] Build: Bump software.amazon.awssdk:bom from 2.31.30 to 2.31.35 [iceberg]

2025-05-03 Thread via GitHub
dependabot[bot] opened a new pull request, #12967: URL: https://github.com/apache/iceberg/pull/12967 Bumps software.amazon.awssdk:bom from 2.31.30 to 2.31.35. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=soft

[PR] Build: Bump net.snowflake:snowflake-jdbc from 3.23.2 to 3.24.0 [iceberg]

2025-05-03 Thread via GitHub
dependabot[bot] opened a new pull request, #12965: URL: https://github.com/apache/iceberg/pull/12965 Bumps [net.snowflake:snowflake-jdbc](https://github.com/snowflakedb/snowflake-jdbc) from 3.23.2 to 3.24.0. Release notes Sourced from https://github.com/snowflakedb/snowflake-jdbc/

[PR] Build: Bump com.azure:azure-sdk-bom from 1.2.31 to 1.2.34 [iceberg]

2025-05-03 Thread via GitHub
dependabot[bot] opened a new pull request, #12962: URL: https://github.com/apache/iceberg/pull/12962 Bumps [com.azure:azure-sdk-bom](https://github.com/azure/azure-sdk-for-java) from 1.2.31 to 1.2.34. Commits https://github.com/Azure/azure-sdk-for-java/commit/90f247db0f0c302557

[PR] Build: Bump com.aliyun.oss:aliyun-sdk-oss from 3.10.2 to 3.18.2 [iceberg]

2025-05-03 Thread via GitHub
dependabot[bot] opened a new pull request, #12968: URL: https://github.com/apache/iceberg/pull/12968 Bumps com.aliyun.oss:aliyun-sdk-oss from 3.10.2 to 3.18.2. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com

[PR] Build: Bump parquet from 1.15.1 to 1.15.2 [iceberg]

2025-05-03 Thread via GitHub
dependabot[bot] opened a new pull request, #12964: URL: https://github.com/apache/iceberg/pull/12964 Bumps `parquet` from 1.15.1 to 1.15.2. Updates `org.apache.parquet:parquet-avro` from 1.15.1 to 1.15.2 Release notes Sourced from https://github.com/apache/parquet-mr/releases";>o

[PR] Build: Bump nessie from 0.103.5 to 0.103.6 [iceberg]

2025-05-03 Thread via GitHub
dependabot[bot] opened a new pull request, #12963: URL: https://github.com/apache/iceberg/pull/12963 Bumps `nessie` from 0.103.5 to 0.103.6. Updates `org.projectnessie.nessie:nessie-client` from 0.103.5 to 0.103.6 Updates `org.projectnessie.nessie:nessie-jaxrs-testextension` from 0.

Re: [PR] Build: Bump com.azure:azure-sdk-bom from 1.2.31 to 1.2.33 [iceberg]

2025-05-03 Thread via GitHub
dependabot[bot] closed pull request #12689: Build: Bump com.azure:azure-sdk-bom from 1.2.31 to 1.2.33 URL: https://github.com/apache/iceberg/pull/12689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] chore: fix a build error due to name conflict [iceberg-cpp]

2025-05-03 Thread via GitHub
Fokko commented on PR #90: URL: https://github.com/apache/iceberg-cpp/pull/90#issuecomment-2849000484 Thanks @zhjwpku for fixing this right away, and thanks @lidavidm and @wgtmac for the quick review -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] chore: fix a build error due to name conflict [iceberg-cpp]

2025-05-03 Thread via GitHub
Fokko merged PR #90: URL: https://github.com/apache/iceberg-cpp/pull/90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] Build: Bump datamodel-code-generator from 0.28.5 to 0.30.0 [iceberg]

2025-05-03 Thread via GitHub
dependabot[bot] commented on PR #12849: URL: https://github.com/apache/iceberg/pull/12849#issuecomment-2848999220 Superseded by #12961. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Build: Bump datamodel-code-generator from 0.28.5 to 0.30.0 [iceberg]

2025-05-03 Thread via GitHub
dependabot[bot] closed pull request #12849: Build: Bump datamodel-code-generator from 0.28.5 to 0.30.0 URL: https://github.com/apache/iceberg/pull/12849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] Build: Bump datamodel-code-generator from 0.28.5 to 0.30.1 [iceberg]

2025-05-03 Thread via GitHub
dependabot[bot] opened a new pull request, #12961: URL: https://github.com/apache/iceberg/pull/12961 Bumps [datamodel-code-generator](https://github.com/koxudaxi/datamodel-code-generator) from 0.28.5 to 0.30.1. Release notes Sourced from https://github.com/koxudaxi/datamodel-code-

[I] Question: retry related properties [iceberg]

2025-05-03 Thread via GitHub
dentiny opened a new issue, #12960: URL: https://github.com/apache/iceberg/issues/12960 ### Query engine iceberg rust sdk: https://github.com/apache/iceberg-rust ### Question Hi team, when I checked [iceberg spec](https://iceberg.apache.org/docs/latest/configuration/#tab

Re: [PR] chore: fix a build error due to name conflict [iceberg-cpp]

2025-05-03 Thread via GitHub
zhjwpku commented on PR #90: URL: https://github.com/apache/iceberg-cpp/pull/90#issuecomment-2848976716 > +1 > > Where did you hit this issue? I just rebased the main branch and removed the build dir then started a new config/build, using the following: ``` cmake -S .

Re: [I] Integration tests performance degradation [iceberg-python]

2025-05-03 Thread via GitHub
kevinjqliu closed issue #604: Integration tests performance degradation URL: https://github.com/apache/iceberg-python/issues/604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[I] Document table properties [iceberg-python]

2025-05-03 Thread via GitHub
kevinjqliu opened a new issue, #1231: URL: https://github.com/apache/iceberg-python/issues/1231 ### Feature Request / Improvement While debugging, we noticed that certain table properties are not documented in the [configurations page](https://py.iceberg.apache.org/configuration/#wri

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
kevinjqliu commented on PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#issuecomment-2848894707 a meta question, wydt of moving the orphan file function to its own file/namespace, similar to how to use `.inspect`. i like the idea of having all the table maintenance

Re: [PR] Add Python version 3.13 to test matrix. [iceberg-python]

2025-05-03 Thread via GitHub
kevinjqliu commented on PR #1377: URL: https://github.com/apache/iceberg-python/pull/1377#issuecomment-2848893678 yep ray 2.45 has artifacts for python 3.13 https://pypi.org/project/ray/2.45.0/#files -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Merge python-integration.yml into python-ci.yml [iceberg-python]

2025-05-03 Thread via GitHub
kevinjqliu commented on code in PR #1963: URL: https://github.com/apache/iceberg-python/pull/1963#discussion_r2072495090 ## .github/workflows/python-ci.yml: ## @@ -66,3 +66,20 @@ jobs: run: make lint - name: Tests run: make test-coverage + + integration-test:

Re: [I] Add `GeometryType` / `GeographyType` [iceberg-python]

2025-05-03 Thread via GitHub
kevinjqliu commented on issue #1820: URL: https://github.com/apache/iceberg-python/issues/1820#issuecomment-2848891982 Looks like it'll be release as part of arrow 21.0.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [I] [Docs] Improve contributing instructions [iceberg-python]

2025-05-03 Thread via GitHub
kevinjqliu commented on issue #1964: URL: https://github.com/apache/iceberg-python/issues/1964#issuecomment-2848891806 Thanks for improving the docs! I think the issue here is the use of `virtualenv`. The project uses `poetry` to manage python environment. So we should install `poetry`

Re: [PR] [Docs] Improve contributing docs [iceberg-python]

2025-05-03 Thread via GitHub
kevinjqliu commented on code in PR #1965: URL: https://github.com/apache/iceberg-python/pull/1965#discussion_r2072493969 ## mkdocs/docs/contributing.md: ## @@ -37,7 +37,7 @@ The PyIceberg Project is hosted on GitHub at

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
kevinjqliu commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072493113 ## pyiceberg/table/__init__.py: ## @@ -1371,6 +1376,28 @@ def to_polars(self) -> pl.LazyFrame: return pl.scan_iceberg(self) +def delete_orpha

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
kevinjqliu commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072491310 ## pyiceberg/table/__init__.py: ## @@ -1371,6 +1376,28 @@ def to_polars(self) -> pl.LazyFrame: return pl.scan_iceberg(self) +def delete_orpha

Re: [PR] Status: Split read/write and add deletion vectors [iceberg]

2025-05-03 Thread via GitHub
singhpk234 commented on code in PR #12958: URL: https://github.com/apache/iceberg/pull/12958#discussion_r2072449201 ## site/docs/status.md: ## @@ -163,9 +163,18 @@ This section lists the libraries that implement the Apache Iceberg specification | Operation | Java

Re: [I] "Hadoop catalog type supports multi-tenant architecture" [iceberg]

2025-05-03 Thread via GitHub
github-actions[bot] commented on issue #11456: URL: https://github.com/apache/iceberg/issues/11456#issuecomment-2848872987 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [PR] API: Follow up on adding Variant data type to implement sanitizing fo… [iceberg]

2025-05-03 Thread via GitHub
github-actions[bot] closed pull request #12611: API: Follow up on adding Variant data type to implement sanitizing fo… URL: https://github.com/apache/iceberg/pull/12611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Spark:read iceberg table data error [iceberg]

2025-05-03 Thread via GitHub
github-actions[bot] closed issue #11336: Spark:read iceberg table data error URL: https://github.com/apache/iceberg/issues/11336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Spark:read iceberg table data error [iceberg]

2025-05-03 Thread via GitHub
github-actions[bot] commented on issue #11336: URL: https://github.com/apache/iceberg/issues/11336#issuecomment-2848872915 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [I] org.apache.iceberg.exceptions.NoSuchTableException after creating table [iceberg]

2025-05-03 Thread via GitHub
github-actions[bot] commented on issue #11445: URL: https://github.com/apache/iceberg/issues/11445#issuecomment-2848872977 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [I] flink write to iceberg raises warn: Unclosed S3FileIO instance in GlueTableOperations [iceberg]

2025-05-03 Thread via GitHub
github-actions[bot] closed issue #11364: flink write to iceberg raises warn: Unclosed S3FileIO instance in GlueTableOperations URL: https://github.com/apache/iceberg/issues/11364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [I] RewriteDataFiles: Support custom partition spec during compaction [iceberg]

2025-05-03 Thread via GitHub
github-actions[bot] commented on issue #11459: URL: https://github.com/apache/iceberg/issues/11459#issuecomment-2848872997 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [PR] Core: ability to inject an AuthManager in RESTCatalog [iceberg]

2025-05-03 Thread via GitHub
github-actions[bot] commented on PR #12655: URL: https://github.com/apache/iceberg/pull/12655#issuecomment-2848873065 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] API: Follow up on adding Variant data type to implement sanitizing fo… [iceberg]

2025-05-03 Thread via GitHub
github-actions[bot] commented on PR #12611: URL: https://github.com/apache/iceberg/pull/12611#issuecomment-2848873046 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [I] failed to access class org.apache.iceberg.flink.FlinkEnvironmentContext from class org.apache.iceberg.flink.TableLoader$HadoopTableLoader [iceberg]

2025-05-03 Thread via GitHub
github-actions[bot] commented on issue #11408: URL: https://github.com/apache/iceberg/issues/11408#issuecomment-2848872949 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [I] flink write to iceberg raises warn: Unclosed S3FileIO instance in GlueTableOperations [iceberg]

2025-05-03 Thread via GitHub
github-actions[bot] commented on issue #11364: URL: https://github.com/apache/iceberg/issues/11364#issuecomment-2848872930 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

[PR] Implement MemoryCatalog's table update/ commit path [iceberg-rust]

2025-05-03 Thread via GitHub
DerGut opened a new pull request, #1290: URL: https://github.com/apache/iceberg-rust/pull/1290 ## Which issue does this PR close? Relates to https://github.com/apache/iceberg-rust/issues/700 This is a first attempt at implementing the commit path for the `MemoryCatalog`. Happy abou

Re: [PR] [Docs] Improve contributing docs [iceberg-python]

2025-05-03 Thread via GitHub
petern48 commented on PR #1965: URL: https://github.com/apache/iceberg-python/pull/1965#issuecomment-2848814070 I originally was going to propose removing `install-poetry` from `install` in `Makefile`, but then realize it's still useful / convenienet for the CI commands, so I decided to lea

Re: [I] Add `GeometryType` / `GeographyType` [iceberg-python]

2025-05-03 Thread via GitHub
petern48 commented on issue #1820: URL: https://github.com/apache/iceberg-python/issues/1820#issuecomment-2848809289 Looking into this since it's now merge in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[PR] [Docs] Improve contributing docs [iceberg-python]

2025-05-03 Thread via GitHub
petern48 opened a new pull request, #1965: URL: https://github.com/apache/iceberg-python/pull/1965 Closes #1964 # Rationale for this change Following all steps in the contributing docs leads to error. Running `make install-poetry` should be done before the environme

[I] [Docs] Improve contributing instructions [iceberg-python]

2025-05-03 Thread via GitHub
petern48 opened a new issue, #1964: URL: https://github.com/apache/iceberg-python/issues/1964 ### Apache Iceberg version None ### Please describe the bug 🐞 Currently, the docs ask the developer to activate the environment and then run `make install`, which should run bot

[PR] Merge python-integration.yml into python-ci.yml [iceberg-python]

2025-05-03 Thread via GitHub
petern48 opened a new pull request, #1963: URL: https://github.com/apache/iceberg-python/pull/1963 Closes #1942 # Rationale for this change This condenses similar CI logic into one place # Are these changes tested? # Are there any user-facing changes?

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072452077 ## pyiceberg/table/__init__.py: ## @@ -1371,6 +1375,45 @@ def to_polars(self) -> pl.LazyFrame: return pl.scan_iceberg(self) +def delete_orph

Re: [PR] Add tests for optimistic concurrency [iceberg-python]

2025-05-03 Thread via GitHub
Fokko commented on code in PR #1962: URL: https://github.com/apache/iceberg-python/pull/1962#discussion_r2072447068 ## tests/integration/test_writes/test_optimistic_concurrency.py: ## @@ -0,0 +1,89 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contr

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072448127 ## pyiceberg/table/inspect.py: ## @@ -657,3 +665,37 @@ def all_manifests(self) -> "pa.Table": lambda args: self._generate_manifests_table(*args)

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072448127 ## pyiceberg/table/inspect.py: ## @@ -657,3 +665,37 @@ def all_manifests(self) -> "pa.Table": lambda args: self._generate_manifests_table(*args)

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072446025 ## pyiceberg/table/inspect.py: ## @@ -657,3 +665,37 @@ def all_manifests(self) -> "pa.Table": lambda args: self._generate_manifests_table(*args)

Re: [PR] Add Python version 3.13 to test matrix. [iceberg-python]

2025-05-03 Thread via GitHub
Fokko commented on PR #1377: URL: https://github.com/apache/iceberg-python/pull/1377#issuecomment-2848758717 @JE-Chen Could you do another attempt? We've bumped to Ray 2.45, but the issue is still open 🤔 -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072446025 ## pyiceberg/table/inspect.py: ## @@ -657,3 +665,37 @@ def all_manifests(self) -> "pa.Table": lambda args: self._generate_manifests_table(*args)

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072445679 ## pyiceberg/table/inspect.py: ## @@ -657,3 +665,37 @@ def all_manifests(self) -> "pa.Table": lambda args: self._generate_manifests_table(*args)

[PR] Status: Combine Table spec tables [iceberg]

2025-05-03 Thread via GitHub
Fokko opened a new pull request, #12959: URL: https://github.com/apache/iceberg/pull/12959 The V1/V2 tables are identical, so combining them into a single table makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] Status: Split read/write and add deletion vectors [iceberg]

2025-05-03 Thread via GitHub
Fokko opened a new pull request, #12958: URL: https://github.com/apache/iceberg/pull/12958 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] Site: Add open-api/ to site-ci [iceberg]

2025-05-03 Thread via GitHub
Fokko commented on PR #12947: URL: https://github.com/apache/iceberg/pull/12947#issuecomment-2848751204 I believe the REST Spec is being pulled directly by Swagger from GitHub: ![image](https://github.com/user-attachments/assets/6a011550-6d28-4b3b-a62a-4fdddf70f985) -- This is an a

Re: [PR] fix(catalog/glue): create table with required fields [iceberg-go]

2025-05-03 Thread via GitHub
Fokko commented on PR #410: URL: https://github.com/apache/iceberg-go/pull/410#issuecomment-2848749247 Thanks for working on this @zeroshade and thanks for the review @lliangyu-lin 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] fix(catalog/glue): create table with required fields [iceberg-go]

2025-05-03 Thread via GitHub
Fokko merged PR #410: URL: https://github.com/apache/iceberg-go/pull/410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [I] Glue catalog create table doesn't work with schema with required columns [iceberg-go]

2025-05-03 Thread via GitHub
Fokko closed issue #407: Glue catalog create table doesn't work with schema with required columns URL: https://github.com/apache/iceberg-go/issues/407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] fix(catalog/glue): create table with required fields [iceberg-go]

2025-05-03 Thread via GitHub
Fokko commented on code in PR #410: URL: https://github.com/apache/iceberg-go/pull/410#discussion_r2072443538 ## catalog/glue/glue.go: ## @@ -65,6 +65,10 @@ const ( Endpoint= "glue.endpoint" MaxRetries = "glue.max-retries" RetryMode = "

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072442519 ## pyiceberg/table/inspect.py: ## @@ -657,3 +665,37 @@ def all_manifests(self) -> "pa.Table": lambda args: self._generate_manifests_table(*args)

Re: [PR] Clear updates/requirements after commit [iceberg-python]

2025-05-03 Thread via GitHub
Fokko commented on code in PR #1961: URL: https://github.com/apache/iceberg-python/pull/1961#discussion_r2072439211 ## pyiceberg/table/__init__.py: ## @@ -774,13 +774,15 @@ def commit_transaction(self) -> Table: updates=self._updates, requiremen

Re: [PR] Clear updates/requirements after commit [iceberg-python]

2025-05-03 Thread via GitHub
Fokko commented on code in PR #1961: URL: https://github.com/apache/iceberg-python/pull/1961#discussion_r2072439106 ## pyiceberg/table/__init__.py: ## @@ -774,13 +774,15 @@ def commit_transaction(self) -> Table: updates=self._updates, requiremen

Re: [PR] Spark: Include manifest lists in `allFiles` in `TestRemoveOrphanFilesProcedure` [iceberg]

2025-05-03 Thread via GitHub
singhpk234 commented on code in PR #12957: URL: https://github.com/apache/iceberg/pull/12957#discussion_r2072437378 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRemoveOrphanFilesProcedure.java: ## @@ -635,6 +636,11 @@ public void testRemov

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072436797 ## pyiceberg/table/inspect.py: ## @@ -657,3 +665,37 @@ def all_manifests(self) -> "pa.Table": lambda args: self._generate_manifests_table(*args)

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
jayceslesar commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072436539 ## pyiceberg/table/inspect.py: ## @@ -657,3 +665,37 @@ def all_manifests(self) -> "pa.Table": lambda args: self._generate_manifests_table(*args)

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-05-03 Thread via GitHub
smaheshwar-pltr commented on code in PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2072429901 ## pyiceberg/table/inspect.py: ## @@ -657,3 +665,37 @@ def all_manifests(self) -> "pa.Table": lambda args: self._generate_manifests_table(*a

[PR] Spark: Include manifest lists in `allFiles` in `TestRemoveOrphanFilesProcedure` [iceberg]

2025-05-03 Thread via GitHub
smaheshwar-pltr opened a new pull request, #12957: URL: https://github.com/apache/iceberg/pull/12957 `all_files` in the `file_list_view` used in some `TestRemoveOrphanFilesProcedure` tests contained only the data files, manifests, and metadata JSONs but not manifest lists. This PR ma

Re: [PR] Spark: Add flag to handle missing files for `importSparkTable` [iceberg]

2025-05-03 Thread via GitHub
jshmchenxi commented on PR #12212: URL: https://github.com/apache/iceberg/pull/12212#issuecomment-2848663598 @RussellSpitzer Thanks for the review! I've pushed an update to address the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please

[PR] Add ManifestReader, which provides access to manifest metadata [iceberg-go]

2025-05-03 Thread via GitHub
jhump opened a new pull request, #417: URL: https://github.com/apache/iceberg-go/pull/417 This is an alternative to #415. This closes #386. This also exports the `ReadManifest` helper (previously named `readManifestEntries`), so the read flow has symmetry with the existing `Ne

Re: [PR] Spark: Add flag to handle missing files for `importSparkTable` [iceberg]

2025-05-03 Thread via GitHub
jshmchenxi commented on code in PR #12212: URL: https://github.com/apache/iceberg/pull/12212#discussion_r2072307409 ## spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java: ## @@ -2170,6 +2173,99 @@ public void testTableWithInt96Timesta

[I] Reading a manifest list fails if it does not have a "format-version" metadata key [iceberg-go]

2025-05-03 Thread via GitHub
jhump opened a new issue, #416: URL: https://github.com/apache/iceberg-go/issues/416 ### Apache Iceberg version None ### Please describe the bug 🐞 According to the [spec](https://iceberg.apache.org/spec/#manifest-lists), there is no requirement for such a metadata key in

Re: [PR] API, Build: Explicitly pass version into Git Properties Plugin [iceberg]

2025-05-03 Thread via GitHub
ajantha-bhat commented on code in PR #12949: URL: https://github.com/apache/iceberg/pull/12949#discussion_r2072346555 ## api/src/test/java/org/apache/iceberg/TestIcebergBuild.java: ## @@ -37,6 +41,34 @@ public void testFullVersion() { + ")"); } + @Test +