kevinjqliu commented on code in PR #1963:
URL: https://github.com/apache/iceberg-python/pull/1963#discussion_r2072495090
##########
.github/workflows/python-ci.yml:
##########
@@ -66,3 +66,20 @@ jobs:
run: make lint
- name: Tests
run: make test-coverage
+
+ integration-test:
+ runs-on: ubuntu-22.04
+
+ steps:
+ - uses: actions/checkout@v4
+ with:
+ fetch-depth: 2
+ - name: Install system dependencies
+ run: sudo apt-get update && sudo apt-get install -y libkrb5-dev # for
kerberos
+ - name: Install
+ run: make install
+ - name: Run integration tests
+ run: make test-integration
Review Comment:
I dont think we want to do this.
L68's `test-coverage` runs both the unit tests and integrations tests
This line here runs the integration tests again.
I think we'd want to get rid of one OR have one run unit tests and another
run integration tests.
Looking at both github actions. `python-ci` runs the matrix for python
v3.9-3.12 whereas `python-integration` only runs for the default python
version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
