kevinjqliu commented on code in PR #1965: URL: https://github.com/apache/iceberg-python/pull/1965#discussion_r2072493969
########## mkdocs/docs/contributing.md: ########## @@ -37,7 +37,7 @@ The PyIceberg Project is hosted on GitHub at <https://github.com/apache/iceberg- For the development, Poetry is used for packing and dependency management. You can install this using: ```bash -pip install poetry +make install-poetry ``` Make sure you're using an up-to-date environment from venv Review Comment: this is indeed out of date. poetry is used to manage the python environment. we dont need to use virtualenv at all ########## mkdocs/docs/contributing.md: ########## @@ -48,7 +48,7 @@ python -m venv ./venv source ./venv/bin/activate ``` -To get started, you can run `make install`, which installs Poetry and all the dependencies of the Iceberg library. This also installs the development dependencies. If you don't want to install the development dependencies, you need to install using `poetry install --no-dev`. +To get started, you can run `make install`, which installs all the dependencies of the Iceberg library. This also installs the development dependencies. If you don't want to install the development dependencies, you need to install using `poetry install --no-dev` instead of `make install`. Review Comment: nit: the previous wording is more clear to me `make install` runs both `install-poetry` (installs poetry) and `install-dependencies` (install all deps) https://github.com/apache/iceberg-python/blob/34c89494c39916b9b1aa7e6da2c24c34c4d7f058/Makefile#L40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
