singhpk234 commented on code in PR #12957:
URL: https://github.com/apache/iceberg/pull/12957#discussion_r2072437378
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRemoveOrphanFilesProcedure.java:
##########
@@ -635,6 +636,11 @@ public void testRemoveOrphanFilesProcedureWithPrefixMode()
allFiles.add(new FilePathLastModifiedRecord(manifest.path(),
lastModifiedTimestamp));
}
+ for (Snapshot snapshot : table.snapshots()) {
+ allFiles.add(
+ new FilePathLastModifiedRecord(snapshot.manifestListLocation(),
lastModifiedTimestamp));
+ }
Review Comment:
how about adding partition stats and table stat, thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
