jbonofre commented on code in PR #12365:
URL: https://github.com/apache/iceberg/pull/12365#discussion_r1967146075
##
aws-bundle/LICENSE:
##
@@ -219,7 +219,7 @@ License: The Apache Software License, Version 2.0 -
http://www.apache.org/licens
-
nastra commented on code in PR #12365:
URL: https://github.com/apache/iceberg/pull/12365#discussion_r1967144485
##
aws-bundle/LICENSE:
##
@@ -219,7 +219,7 @@ License: The Apache Software License, Version 2.0 -
http://www.apache.org/licens
---
huyuanfeng2018 commented on PR #12080:
URL: https://github.com/apache/iceberg/pull/12080#issuecomment-2677593994
Hi, @stevenzwu , The pr's been ready for a while. Have you had time to look
at it? Thansk~
--
This is an automated message from the Apache Git Service.
To respond to the me
mwullink commented on PR #12390:
URL: https://github.com/apache/iceberg/pull/12390#issuecomment-2677590076
Nice, thanks for the quick fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
qining-mj opened a new pull request, #12394:
URL: https://github.com/apache/iceberg/pull/12394
iceberg/docs/docs/hive.md In the document Hive table creation statement word
error,
STORED BY written as STORED AS.
**Incorrect statement**
 under one
+# or more contributor license agreements. See the
lidavidm commented on code in PR #966:
URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1967028458
##
bindings/c/CMakeLists.txt:
##
@@ -0,0 +1,61 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
Guosmilesmile commented on PR #12375:
URL: https://github.com/apache/iceberg/pull/12375#issuecomment-2677348578
@stevenzwu thx for the review！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Xuanwo closed issue #671: Enable "Always suggest updating pull request
branches" and "merge queue"
URL: https://github.com/apache/iceberg-rust/issues/671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
stevenzwu merged PR #12375:
URL: https://github.com/apache/iceberg/pull/12375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
xicm commented on code in PR #12392:
URL: https://github.com/apache/iceberg/pull/12392#discussion_r1967009129
##
hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreLock.java:
##
@@ -372,15 +393,30 @@ private LockInfo findLock() throws LockException,
InterruptedExcept
xicm commented on code in PR #12392:
URL: https://github.com/apache/iceberg/pull/12392#discussion_r1967008682
##
hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreLock.java:
##
@@ -74,7 +77,10 @@ class MetastoreLock implements HiveLock {
private static final long
xicm opened a new pull request, #12392:
URL: https://github.com/apache/iceberg/pull/12392
```
org.apache.iceberg.exceptions.CommitFailedException: Timed out after 181159
ms waiting for lock on table
at
org.apache.iceberg.hive.HiveTableOperations.acquireLock(HiveTableOperation
stevenzwu commented on PR #12375:
URL: https://github.com/apache/iceberg/pull/12375#issuecomment-2677346357
@Guosmilesmile thx for the fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
kumarpritam863 commented on code in PR #12372:
URL: https://github.com/apache/iceberg/pull/12372#discussion_r1966996956
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CommitterImpl.java:
##
@@ -57,49 +83,67 @@ public int compare(TopicPartition o1
kumarpritam863 commented on code in PR #12372:
URL: https://github.com/apache/iceberg/pull/12372#discussion_r1966996881
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/ResourceType.java:
##
@@ -0,0 +1,27 @@
+/*
+ *
+ * * Licensed to the Apache Software F
kumarpritam863 commented on code in PR #12372:
URL: https://github.com/apache/iceberg/pull/12372#discussion_r1966996671
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java:
##
@@ -46,26 +45,31 @@ public String version() {
@Override
jshmchenxi commented on PR #12212:
URL: https://github.com/apache/iceberg/pull/12212#issuecomment-2677323705
@RussellSpitzer Hi, does anything else need to be updated for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
sungwy commented on PR #1632:
URL: https://github.com/apache/iceberg-python/pull/1632#issuecomment-2677291293
I think it would make sense to break this PR up into two separate items:
1. one to introduce timestamp_ns and timestamptz_ns support
2. one to introduce parsing NS timestamps fr
github-actions[bot] commented on issue #1052:
URL:
https://github.com/apache/iceberg-python/issues/1052#issuecomment-2677208877
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the A
github-actions[bot] commented on PR #12080:
URL: https://github.com/apache/iceberg/pull/12080#issuecomment-2677206929
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
github-actions[bot] closed issue #10933: Contribution Proposal: Kafka to
Iceberg Tutorial Repo
URL: https://github.com/apache/iceberg/issues/10933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
github-actions[bot] commented on issue #11019:
URL: https://github.com/apache/iceberg/issues/11019#issuecomment-2677206765
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occur
github-actions[bot] closed issue #1052: Clean up TODOs in the codebase
URL: https://github.com/apache/iceberg-python/issues/1052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
github-actions[bot] commented on issue #1058:
URL:
https://github.com/apache/iceberg-python/issues/1058#issuecomment-2677208867
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the A
github-actions[bot] closed issue #1058: What should be Pyarrow's default buffer
size?
URL: https://github.com/apache/iceberg-python/issues/1058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
github-actions[bot] commented on PR #12083:
URL: https://github.com/apache/iceberg/pull/12083#issuecomment-2677206960
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
github-actions[bot] closed issue #10927: Spec: The spec about metadata key
`schema-id` in manifest file do not match the lib implementation
URL: https://github.com/apache/iceberg/issues/10927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
github-actions[bot] commented on issue #11014:
URL: https://github.com/apache/iceberg/issues/11014#issuecomment-2677206730
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occur
github-actions[bot] closed issue #10750: Is dataFiles() Method Retryable?
URL: https://github.com/apache/iceberg/issues/10750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on issue #11017:
URL: https://github.com/apache/iceberg/issues/11017#issuecomment-2677206743
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occur
github-actions[bot] commented on PR #12075:
URL: https://github.com/apache/iceberg/pull/12075#issuecomment-2677206910
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
github-actions[bot] commented on PR #12070:
URL: https://github.com/apache/iceberg/pull/12070#issuecomment-2677206886
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
github-actions[bot] commented on PR #12030:
URL: https://github.com/apache/iceberg/pull/12030#issuecomment-2677206849
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
github-actions[bot] commented on issue #8161:
URL: https://github.com/apache/iceberg/issues/8161#issuecomment-2677206628
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #11020:
URL: https://github.com/apache/iceberg/issues/11020#issuecomment-2677206785
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occur
github-actions[bot] commented on issue #10933:
URL: https://github.com/apache/iceberg/issues/10933#issuecomment-2677206702
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache
github-actions[bot] commented on issue #10927:
URL: https://github.com/apache/iceberg/issues/10927#issuecomment-2677206683
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache
github-actions[bot] commented on issue #10709:
URL: https://github.com/apache/iceberg/issues/10709#issuecomment-2677206660
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occur
github-actions[bot] commented on issue #10750:
URL: https://github.com/apache/iceberg/issues/10750#issuecomment-2677206670
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache
bryanck commented on PR #12372:
URL: https://github.com/apache/iceberg/pull/12372#issuecomment-2677156270
We should add some comments, and also tests if feasible. Also looks like
there are some code formatting issues.
--
This is an automated message from the Apache Git Service.
To respond
bryanck commented on code in PR #12372:
URL: https://github.com/apache/iceberg/pull/12372#discussion_r1966912973
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CommitterImpl.java:
##
@@ -57,49 +83,67 @@ public int compare(TopicPartition o1, Topic
bryanck commented on code in PR #12372:
URL: https://github.com/apache/iceberg/pull/12372#discussion_r1966912973
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CommitterImpl.java:
##
@@ -57,49 +83,67 @@ public int compare(TopicPartition o1, Topic
bryanck commented on code in PR #12372:
URL: https://github.com/apache/iceberg/pull/12372#discussion_r1966911457
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CommitterImpl.java:
##
@@ -57,49 +83,67 @@ public int compare(TopicPartition o1, Topic
bryanck commented on code in PR #12372:
URL: https://github.com/apache/iceberg/pull/12372#discussion_r1966910314
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CommitterImpl.java:
##
@@ -57,49 +83,67 @@ public int compare(TopicPartition o1, Topic
bryanck commented on code in PR #12372:
URL: https://github.com/apache/iceberg/pull/12372#discussion_r1966910819
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CommitterImpl.java:
##
@@ -57,49 +83,67 @@ public int compare(TopicPartition o1, Topic
bryanck commented on code in PR #12372:
URL: https://github.com/apache/iceberg/pull/12372#discussion_r1966910314
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CommitterImpl.java:
##
@@ -57,49 +83,67 @@ public int compare(TopicPartition o1, Topic
bryanck commented on code in PR #12372:
URL: https://github.com/apache/iceberg/pull/12372#discussion_r1966909662
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/ResourceType.java:
##
@@ -0,0 +1,27 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundati
bryanck commented on code in PR #12372:
URL: https://github.com/apache/iceberg/pull/12372#discussion_r1966908971
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java:
##
@@ -46,26 +45,31 @@ public String version() {
@Override
public
kevinjqliu commented on PR #1709:
URL: https://github.com/apache/iceberg-python/pull/1709#issuecomment-2677145552
Thanks for the suggestion @hussein-awala
I like this approach. My only question before proceeding is whether we want
the `resolve_s3_region` behavior to be on by default.
vinjai commented on PR #941:
URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2677114643
Hey @kevinjqliu
I have resolved all comments.
Will resolve the merge conflicts once you have gone through these changes
(to avoid rework).
Let me know once you have revie
Fokko commented on code in PR #1709:
URL: https://github.com/apache/iceberg-python/pull/1709#discussion_r1966885810
##
pyiceberg/io/pyarrow.py:
##
@@ -414,19 +421,19 @@ def _initialize_oss_fs(self) -> FileSystem:
return S3FileSystem(**client_kwargs)
def _initiali
vinjai commented on code in PR #941:
URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1966883670
##
tests/table/test_init.py:
##
@@ -982,28 +982,43 @@ def test_assert_table_uuid(table_v2: Table) -> None:
def test_assert_ref_snapshot_id(table_v2: Table) -> No
vinjai commented on code in PR #941:
URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1966882693
##
pyiceberg/table/__init__.py:
##
@@ -1003,22 +1015,27 @@ def overwrite(
overwrite_filter: ALWAYS_TRUE when you overwrite all the data,
vinjai commented on code in PR #941:
URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1966881022
##
tests/table/test_init.py:
##
@@ -982,28 +982,43 @@ def test_assert_table_uuid(table_v2: Table) -> None:
def test_assert_ref_snapshot_id(table_v2: Table) -> No
vinjai commented on code in PR #941:
URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1966876035
##
tests/integration/test_writes/test_writes.py:
##
@@ -1570,3 +1572,158 @@ def test_abort_table_transaction_on_exception(
# Validate the transaction is abor
vinjai commented on code in PR #941:
URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1966875880
##
pyiceberg/table/update/__init__.py:
##
@@ -609,11 +609,14 @@ class AssertRefSnapshotId(ValidatableTableRequirement):
type: Literal["assert-ref-snapshot-id
dttung2905 opened a new pull request, #315:
URL: https://github.com/apache/iceberg-go/pull/315
From the feedback
https://github.com/apache/iceberg-go/pull/306#discussion_r1960205322, I'm
adding golangci-lint in GIthub Action CI. There are many different linters but
I'm just adding the most
jonathanc-n commented on issue #980:
URL: https://github.com/apache/iceberg-rust/issues/980#issuecomment-2677064517
I'll work on this after #960 gets merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
jonathanc-n commented on issue #986:
URL: https://github.com/apache/iceberg-rust/issues/986#issuecomment-2677061604
i can probably write out some datafusion examples
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
ZENOTME opened a new pull request, #999:
URL: https://github.com/apache/iceberg-rust/pull/999
Part of #986. This PR adds more examples to refine the doc of writer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
iProdigy opened a new pull request, #12391:
URL: https://github.com/apache/iceberg/pull/12391
Closes #12378
Closes #12381
As of Gradle 8, not explicitly depending upon `junit-platform-launcher` is
[deprecated](https://docs.gradle.org/8.12/userguide/upgrading_version_8.html#test_fra
smaheshwar-pltr commented on code in PR #12162:
URL: https://github.com/apache/iceberg/pull/12162#discussion_r1966828077
##
format/spec.md:
##
@@ -975,6 +978,23 @@ The unified partition type looks like `Struct`.
and then the table has evolved into `spec#1` which has just one fi
smaheshwar-pltr commented on code in PR #12162:
URL: https://github.com/apache/iceberg/pull/12162#discussion_r1966827127
##
format/spec.md:
##
@@ -975,6 +978,23 @@ The unified partition type looks like `Struct`.
and then the table has evolved into `spec#1` which has just one fi
smaheshwar-pltr commented on code in PR #12162:
URL: https://github.com/apache/iceberg/pull/12162#discussion_r1966823087
##
format/spec.md:
##
@@ -975,6 +978,23 @@ The unified partition type looks like `Struct`.
and then the table has evolved into `spec#1` which has just one fi
manuzhang commented on PR #12378:
URL: https://github.com/apache/iceberg/pull/12378#issuecomment-2676935863
I tried upgrading `junit-platform` to 1.12.0 at the same time (as in #12381)
but still seeing the same error.
--
This is an automated message from the Apache Git Service.
To respond
ZENOTME commented on code in PR #987:
URL: https://github.com/apache/iceberg-rust/pull/987#discussion_r1966816961
##
.github/workflows/ci.yml:
##
@@ -152,6 +152,8 @@ jobs:
# Some dependencies don't correctly specify a minimal version for
their dependencies and will f
hussein-awala commented on code in PR #1709:
URL: https://github.com/apache/iceberg-python/pull/1709#discussion_r1966816889
##
pyiceberg/io/pyarrow.py:
##
@@ -414,19 +421,19 @@ def _initialize_oss_fs(self) -> FileSystem:
return S3FileSystem(**client_kwargs)
def _
manuzhang commented on PR #12378:
URL: https://github.com/apache/iceberg/pull/12378#issuecomment-2676910167
Tests failed with following exception
```
org.gradle.api.internal.tasks.testing.TestSuiteExecutionException: Could not
complete execution for Gradle Test Executor 2.
at
sdd commented on issue #630:
URL: https://github.com/apache/iceberg-rust/issues/630#issuecomment-2676912068
I've worked on an improved design for loading and parsing of delete files by
the `DeleteFileManager`. The code for this can be seen in
https://github.com/apache/iceberg-rust/pull/982.
xxchan commented on code in PR #998:
URL: https://github.com/apache/iceberg-rust/pull/998#discussion_r1966793025
##
crates/iceberg/src/scan.rs:
##
@@ -733,7 +733,7 @@ impl PlanContext {
manifest_list: Arc,
tx_data: Sender,
delete_file_idx_and_tx: Optio
xxchan commented on code in PR #998:
URL: https://github.com/apache/iceberg-rust/pull/998#discussion_r1966792744
##
crates/iceberg/src/arrow/record_batch_transformer.rs:
##
@@ -140,8 +140,8 @@ impl RecordBatchTransformer {
Ok(match &self.batch_transform {
S
xxchan opened a new pull request, #998:
URL: https://github.com/apache/iceberg-rust/pull/998
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
manuzhang commented on code in PR #12370:
URL: https://github.com/apache/iceberg/pull/12370#discussion_r1966792270
##
site/docs/multi-engine-support.md:
##
@@ -67,7 +67,7 @@ Each engine version undergoes the following lifecycle stages:
| 3.0| End of Life| 0.9.0
ajantha-bhat commented on code in PR #12370:
URL: https://github.com/apache/iceberg/pull/12370#discussion_r1966788144
##
site/docs/multi-engine-support.md:
##
@@ -67,7 +67,7 @@ Each engine version undergoes the following lifecycle stages:
| 3.0| End of Life| 0.9
manuzhang commented on code in PR #12370:
URL: https://github.com/apache/iceberg/pull/12370#discussion_r1966786480
##
site/docs/multi-engine-support.md:
##
@@ -67,7 +67,7 @@ Each engine version undergoes the following lifecycle stages:
| 3.0| End of Life| 0.9.0
ajantha-bhat commented on code in PR #12370:
URL: https://github.com/apache/iceberg/pull/12370#discussion_r1966783913
##
site/docs/multi-engine-support.md:
##
@@ -67,7 +67,7 @@ Each engine version undergoes the following lifecycle stages:
| 3.0| End of Life| 0.9
xxchan commented on issue #986:
URL: https://github.com/apache/iceberg-rust/issues/986#issuecomment-2676855461
perhaps duplicate with #429 :p
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
dependabot[bot] opened a new pull request, #996:
URL: https://github.com/apache/iceberg-rust/pull/996
Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.95 to 1.0.96.
Release notes
Sourced from https://github.com/dtolnay/anyhow/releases";>anyhow's
releases.
1.0.96
ajantha-bhat commented on PR #12389:
URL: https://github.com/apache/iceberg/pull/12389#issuecomment-2676845372
@adutra: Thanks for the quick fix. Once, nit is handled, please raise the
same PR against branch 1.8.x
https://github.com/apache/iceberg/tree/1.8.x
--
This is an automated mes
adutra commented on PR #12389:
URL: https://github.com/apache/iceberg/pull/12389#issuecomment-2676847699
@ajantha-bhat here is the 1.8.x PR: #12390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
xxchan commented on issue #298:
URL: https://github.com/apache/iceberg-rust/issues/298#issuecomment-2676846912
Seems we can close this one in favor of concrete tasks #981 #980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
xxchan commented on issue #344:
URL: https://github.com/apache/iceberg-rust/issues/344#issuecomment-2676846121
duplicate with #128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ajantha-bhat commented on code in PR #12389:
URL: https://github.com/apache/iceberg/pull/12389#discussion_r1966767782
##
core/src/main/java/org/apache/iceberg/rest/HTTPRequest.java:
##
@@ -53,13 +53,16 @@ enum HTTPMethod {
*/
@Value.Lazy
default URI requestUri() {
-
1 - 100 of 116 matches
Mail list logo
