xicm commented on code in PR #12392:
URL: https://github.com/apache/iceberg/pull/12392#discussion_r1967008682
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreLock.java:
##########
@@ -74,7 +77,10 @@ class MetastoreLock implements HiveLock {
private static final long HIVE_LOCK_CREATION_TIMEOUT_MS_DEFAULT = 3 * 60 *
1000; // 3 minutes
private static final long HIVE_LOCK_CREATION_MIN_WAIT_MS_DEFAULT = 50; // 50
milliseconds
private static final long HIVE_LOCK_CREATION_MAX_WAIT_MS_DEFAULT = 5 * 1000;
// 5 seconds
- private static final long HIVE_LOCK_HEARTBEAT_INTERVAL_MS_DEFAULT = 4 * 60 *
1000; // 4 minutes
+
+ @VisibleForTesting
+ static final long HIVE_LOCK_HEARTBEAT_INTERVAL_MS_DEFAULT = 60 * 1000; // 1
minutes
Review Comment:
HIVE_ACQUIRE_LOCK_TIMEOUT_MS_DEFAULT is 3 minutes,
HIVE_LOCK_HEARTBEAT_INTERVAL_MS_DEFAULT 4 minutes is too long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
