Re: [PR] feat: support scan nested type(struct, map, list) [iceberg-rust]

2025-01-12 Thread via GitHub
sdd commented on PR #882: URL: https://github.com/apache/iceberg-rust/pull/882#issuecomment-2586413839 This is looking great, especially now that we have this really comprehensive integration test. Just those two small typos to fix and I'll happily approve - thanks! -- This is an automat

Re: [PR] ParallelIterable: Queue Size w/ O(1) [iceberg]

2025-01-12 Thread via GitHub
shanielh commented on PR #11895: URL: https://github.com/apache/iceberg/pull/11895#issuecomment-2586412692 @RussellSpitzer, I see that #11768 is closed now, we use the PR in a forked version for over a week now and we've observed no issues, any chance to merge this? BTW, the fix for #11768

Re: [PR] feat: support scan nested type(struct, map, list) [iceberg-rust]

2025-01-12 Thread via GitHub
sdd commented on code in PR #882: URL: https://github.com/apache/iceberg-rust/pull/882#discussion_r1912775863 ## crates/iceberg/src/spec/datatypes.rs: ## @@ -36,9 +36,11 @@ use crate::spec::datatypes::_decimal::{MAX_PRECISION, REQUIRED_LENGTH}; use crate::spec::PrimitiveLitera

Re: [PR] feat: support scan nested type(struct, map, list) [iceberg-rust]

2025-01-12 Thread via GitHub
sdd commented on code in PR #882: URL: https://github.com/apache/iceberg-rust/pull/882#discussion_r1912774587 ## crates/iceberg/src/arrow/reader.rs: ## @@ -351,19 +383,26 @@ impl ArrowReader { true }); -if column_map.len() != field_ids

Re: [PR] Open-API: Fix compilation errors in generated Java classes due to mismatched return types [iceberg]

2025-01-12 Thread via GitHub
Fokko commented on code in PR #11806: URL: https://github.com/apache/iceberg/pull/11806#discussion_r1912770377 ## open-api/rest-catalog-open-api.py: ## @@ -267,26 +267,57 @@ class ViewVersion(BaseModel): default_namespace: Namespace = Field(..., alias='default-namespace')

Re: [PR] Add pyspark DataFusion integration test [iceberg-rust]

2025-01-12 Thread via GitHub
sdd commented on code in PR #850: URL: https://github.com/apache/iceberg-rust/pull/850#discussion_r1912758789 ## crates/integration_tests/Cargo.toml: ## @@ -27,9 +27,11 @@ rust-version = { workspace = true } [dependencies] arrow-array = { workspace = true } arrow-schema = { w

Re: [PR] Handle converting Utf8View & BinaryView to Iceberg schema [iceberg-rust]

2025-01-12 Thread via GitHub
sdd merged PR #831: URL: https://github.com/apache/iceberg-rust/pull/831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [I] [DISCUSSION] Set up documentation/website generator [iceberg-cpp]

2025-01-12 Thread via GitHub
wgtmac commented on issue #26: URL: https://github.com/apache/iceberg-cpp/issues/26#issuecomment-2586350059 Doxygen might be the best option from all the information we have so far :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Open-API: Fix compilation errors in generated Java classes due to mismatched return types [iceberg]

2025-01-12 Thread via GitHub
Fokko commented on code in PR #11806: URL: https://github.com/apache/iceberg/pull/11806#discussion_r1912746161 ## open-api/rest-catalog-open-api.py: ## @@ -267,26 +267,57 @@ class ViewVersion(BaseModel): default_namespace: Namespace = Field(..., alias='default-namespace')

Re: [PR] Open-API: Fix compilation errors in generated Java classes due to mismatched return types [iceberg]

2025-01-12 Thread via GitHub
Fokko commented on code in PR #11806: URL: https://github.com/apache/iceberg/pull/11806#discussion_r1912745602 ## open-api/rest-catalog-open-api.py: ## @@ -981,8 +966,33 @@ class ValueMap(BaseModel): ) +class ContentFile(BaseModel): +content: ContentEnum +file_p

[I] Getting all snapshots through table.inspect.snapshots() [iceberg-python]

2025-01-12 Thread via GitHub
muniatl opened a new issue, #1512: URL: https://github.com/apache/iceberg-python/issues/1512 ### Apache Iceberg version 0.8.1 (latest release) ### Please describe the bug šŸž Whenever I try to get a list of snapshots, I always get the latest snapshot with the snapshots arr

[I] insert branch failed:spark_catalog requires a single-part namespace, but got `iceberg_db`.`sample_oss_time_travel`. [iceberg]

2025-01-12 Thread via GitHub
SGITLOGIN opened a new issue, #11952: URL: https://github.com/apache/iceberg/issues/11952 ### Apache Iceberg version 1.6.1 ### Query engine Spark ### Please describe the bug šŸž ### Spark configuration spark.sql.catalog.spark_catalog = org.apache.iceberg.

Re: [I] [DISCUSS] Exceptions vs status codes [iceberg-cpp]

2025-01-12 Thread via GitHub
lidavidm commented on issue #14: URL: https://github.com/apache/iceberg-cpp/issues/14#issuecomment-2586312129 (FWIW, I believe the...expected...way of using std::expected when there is no return value is `std::expected`. You could always `using Status = expected` + `using Result = expected`

Re: [I] [DISCUSSION] Set up documentation/website generator [iceberg-cpp]

2025-01-12 Thread via GitHub
lidavidm commented on issue #26: URL: https://github.com/apache/iceberg-cpp/issues/26#issuecomment-2586291743 ChatGPT misses again! - Doxybook2 is no longer maintained. - docfx has no C++ support. We'd have to manually convert Doxygen output. - Standardese, maybe. It hasn't relea

Re: [PR] Spark 3.5: Display write metrics on SQL UI [iceberg]

2025-01-12 Thread via GitHub
Fokko commented on code in PR #11340: URL: https://github.com/apache/iceberg/pull/11340#discussion_r1912728141 ## spark/v3.5/spark/src/main/scala/org/apache/spark/sql/MetricsUtils.scala: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] support uri not end with character '/' in rest catalog [iceberg]

2025-01-12 Thread via GitHub
Fokko commented on PR #11392: URL: https://github.com/apache/iceberg/pull/11392#issuecomment-2586283209 @beyond-up Thanks, we're happy to take another look at this PR, but we need the CI to pass before we can merge it šŸ‘ -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Core, Rest: Read the max connection for rest client from properties [iceberg]

2025-01-12 Thread via GitHub
Fokko merged PR #11522: URL: https://github.com/apache/iceberg/pull/11522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Spark 3.5: Add query runner in test module [iceberg]

2025-01-12 Thread via GitHub
Fokko commented on PR #11758: URL: https://github.com/apache/iceberg/pull/11758#issuecomment-2586261239 Sorry for the late reply here @ebyhr. Personally, I rely on breakpoints in the code, but if anyone thinks this is valuable, I'm open to adding it. This would require a bit more documentat

Re: [PR] Build: Bump software.amazon.awssdk:bom from 2.29.45 to 2.29.50 [iceberg]

2025-01-12 Thread via GitHub
Fokko merged PR #11949: URL: https://github.com/apache/iceberg/pull/11949 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Update cmake instructions in README [iceberg-cpp]

2025-01-12 Thread via GitHub
zhjwpku commented on code in PR #24: URL: https://github.com/apache/iceberg-cpp/pull/24#discussion_r1912696116 ## .gitignore: ## @@ -16,6 +16,7 @@ # under the License. build/ +install/ Review Comment: > No, since we specify `CMAKE_INSTALL_PREFIX` in cmake, I think someon

Re: [PR] fix wrong copyright year range [iceberg-cpp]

2025-01-12 Thread via GitHub
Fokko merged PR #25: URL: https://github.com/apache/iceberg-cpp/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [I] [DISCUSS] Exceptions vs status codes [iceberg-cpp]

2025-01-12 Thread via GitHub
zhjwpku commented on issue #14: URL: https://github.com/apache/iceberg-cpp/issues/14#issuecomment-2586231279 While looking the std::expected usage, I'm thinking no matter we choose the std::expected way or Arrow's Result way, it is no harm that we add a Status data structure, it's useful in

Re: [PR] Hive: Remove Hive runtime [iceberg]

2025-01-12 Thread via GitHub
Fokko merged PR #11801: URL: https://github.com/apache/iceberg/pull/11801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] add Status data structure [iceberg-cpp]

2025-01-12 Thread via GitHub
zhjwpku commented on code in PR #8: URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1912677247 ## src/common/CMakeLists.txt: ## @@ -0,0 +1,28 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE

Re: [PR] add Status data structure [iceberg-cpp]

2025-01-12 Thread via GitHub
zhjwpku commented on code in PR #8: URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1912676682 ## api/iceberg/status.h: ## @@ -0,0 +1,435 @@ +// Copyright (c) 2011 The LevelDB Authors. All rights reserved. +// Use of this source code is governed by a BSD-style lice

Re: [PR] add Status data structure [iceberg-cpp]

2025-01-12 Thread via GitHub
zhjwpku commented on code in PR #8: URL: https://github.com/apache/iceberg-cpp/pull/8#discussion_r1912674267 ## api/iceberg/util/string_builder.h: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements.

Re: [I] [DISCUSSION] Set up documentation/website generator [iceberg-cpp]

2025-01-12 Thread via GitHub
wgtmac commented on issue #26: URL: https://github.com/apache/iceberg-cpp/issues/26#issuecomment-2586192832 I'm not an expert so I asked ChatGPT to search other alternatives for me: | Name | Pros | Cons | Links | |--|--|--|---| | MkDocs with Doxybook2 | • Modern,

Re: [PR] Update cmake instructions in README [iceberg-cpp]

2025-01-12 Thread via GitHub
zuyu commented on code in PR #24: URL: https://github.com/apache/iceberg-cpp/pull/24#discussion_r1912645714 ## README.md: ## @@ -32,7 +32,7 @@ C++ implementation of [Apache Icebergā„¢](https://iceberg.apache.org/). ```bash cd iceberg-cpp -cmake -S . -B build -DCMAKE_INSTALL_P

[I] Iceberg functions doesnt work [iceberg]

2025-01-12 Thread via GitHub
kosmldev opened a new issue, #11951: URL: https://github.com/apache/iceberg/issues/11951 ### Query engine Spark 3.5, Hive Metastore ### Question Functions CALL doesnt work, also doesnt work creating TAG and branches my code: ` conf = SparkConf() conf.set('

Re: [PR] Update cmake instructions in README [iceberg-cpp]

2025-01-12 Thread via GitHub
zuyu commented on code in PR #24: URL: https://github.com/apache/iceberg-cpp/pull/24#discussion_r191266 ## .gitignore: ## @@ -16,6 +16,7 @@ # under the License. build/ +install/ Review Comment: No, since we specify `CMAKE_INSTALL_PREFIX` in cmake, I think someone mig

Re: [PR] Hive: Remove Hive runtime [iceberg]

2025-01-12 Thread via GitHub
manuzhang closed pull request #11801: Hive: Remove Hive runtime URL: https://github.com/apache/iceberg/pull/11801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [I] [DISCUSSION] Project Goal [iceberg-cpp]

2025-01-12 Thread via GitHub
MisterRaindrop commented on issue #2: URL: https://github.com/apache/iceberg-cpp/issues/2#issuecomment-2586070803 Is it possible to allow users to customize and choose their own parser (like options) or use Arrow for parsing? Because I want a cleaner dependency. -- This is an automate

Re: [I] [DISCUSSION] Project Goal [iceberg-cpp]

2025-01-12 Thread via GitHub
lidavidm commented on issue #2: URL: https://github.com/apache/iceberg-cpp/issues/2#issuecomment-2586067035 @MisterRaindrop the earlier discussion in this thread is about exactly that topic - the plan is to have iceberg-core and a separate iceberg-arrow -- This is an automated message fro

Re: [I] [Discussion] googletest(gtest) or Catch2 [iceberg-cpp]

2025-01-12 Thread via GitHub
zhjwpku closed issue #12: [Discussion] googletest(gtest) or Catch2 URL: https://github.com/apache/iceberg-cpp/issues/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [I] [Discussion] googletest(gtest) or Catch2 [iceberg-cpp]

2025-01-12 Thread via GitHub
zhjwpku commented on issue #12: URL: https://github.com/apache/iceberg-cpp/issues/12#issuecomment-2586065251 In this discussion regarding the choice between Googletest and Catch2 for our testing framework, most of the developers have experience with Googletest, and while they are open to co

Re: [I] [DISCUSSION] Project Goal [iceberg-cpp]

2025-01-12 Thread via GitHub
MisterRaindrop commented on issue #2: URL: https://github.com/apache/iceberg-cpp/issues/2#issuecomment-2586063112 Due to the heavy reliance on Arrow, does Iceberg-cpp have plans to provide an abstract interface to allow integration with one’s own Parquet, Avro, etc., libraries without depen

Re: [PR] Integrate Googletest as Test Framework [iceberg-cpp]

2025-01-12 Thread via GitHub
Xuanwo merged PR #13: URL: https://github.com/apache/iceberg-cpp/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Integrate Googletest as Test Framework [iceberg-cpp]

2025-01-12 Thread via GitHub
zhjwpku commented on PR #13: URL: https://github.com/apache/iceberg-cpp/pull/13#issuecomment-2586051698 > @zhjwpku It is better to change the PR title to reflect that we have chosen googletest? Updated the PR title as well as the PR's first message, thanks for the suggestion ;) --

[I] Partition writes not creating expected directory hierarchy on S3 (MinIO) [iceberg-rust]

2025-01-12 Thread via GitHub
hackintoshrao opened a new issue, #891: URL: https://github.com/apache/iceberg-rust/issues/891 Hey folks, I created this PR to validate the issue: https://github.com/apache/iceberg-rust/pull/890 . Please let me know if I've made the assumptions in the integration test correctly.

Re: [PR] feat(core): expose remove_snapshots at Transaction API [iceberg-rust]

2025-01-12 Thread via GitHub
TennyZhuang commented on PR #884: URL: https://github.com/apache/iceberg-rust/pull/884#issuecomment-2586030157 https://github.com/apache/iceberg/blob/c7910bb401f7f7fd09010bede0d80f5d2164afd5/core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java#L547 This is a hard limit in t

Re: [PR] feat(core): expose remove_snapshots at Transaction API [iceberg-rust]

2025-01-12 Thread via GitHub
TennyZhuang commented on PR #884: URL: https://github.com/apache/iceberg-rust/pull/884#issuecomment-2586026257 I am not sure if this is a server issue or a client issue, more research is needed. If only one snapshot_id is passed, it can be successful. ``` table: TableIdent

[I] [DISCUSSION] Set up documentation/website generator [iceberg-cpp]

2025-01-12 Thread via GitHub
lidavidm opened a new issue, #26: URL: https://github.com/apache/iceberg-cpp/issues/26 There's already some question of where to put documentation: https://github.com/apache/iceberg-cpp/pull/24#discussion_r1911861722 Some candidates: - [Doxygen](https://www.doxygen.nl/) handles

Re: [PR] Update cmake instructions in README [iceberg-cpp]

2025-01-12 Thread via GitHub
lidavidm commented on code in PR #24: URL: https://github.com/apache/iceberg-cpp/pull/24#discussion_r1912577216 ## README.md: ## @@ -32,7 +32,7 @@ C++ implementation of [Apache Icebergā„¢](https://iceberg.apache.org/). ```bash cd iceberg-cpp -cmake -S . -B build -DCMAKE_INSTA

Re: [I] Concurrency issues in `o.a.i.hive.MetastoreLock` [iceberg]

2025-01-12 Thread via GitHub
github-actions[bot] commented on issue #10595: URL: https://github.com/apache/iceberg/issues/10595#issuecomment-2585982103 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [I] Overwrite with condition from spark failed [iceberg]

2025-01-12 Thread via GitHub
github-actions[bot] commented on issue #10619: URL: https://github.com/apache/iceberg/issues/10619#issuecomment-2585982125 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [PR] API: Make the Field-ID required on the `UnboundPartitionSpec` [iceberg]

2025-01-12 Thread via GitHub
github-actions[bot] commented on PR #11708: URL: https://github.com/apache/iceberg/pull/11708#issuecomment-2585982265 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] API: Make the Field-ID required on the `UnboundPartitionSpec` [iceberg]

2025-01-12 Thread via GitHub
github-actions[bot] closed pull request #11708: API: Make the Field-ID required on the `UnboundPartitionSpec` URL: https://github.com/apache/iceberg/pull/11708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Extend Snapshot Metadata Lifecycle [iceberg]

2025-01-12 Thread via GitHub
github-actions[bot] commented on issue #10646: URL: https://github.com/apache/iceberg/issues/10646#issuecomment-2585982137 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [I] Overwrite with condition from spark failed [iceberg]

2025-01-12 Thread via GitHub
github-actions[bot] closed issue #10619: Overwrite with condition from spark failed URL: https://github.com/apache/iceberg/issues/10619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [I] Concurrency issues in `o.a.i.hive.MetastoreLock` [iceberg]

2025-01-12 Thread via GitHub
github-actions[bot] closed issue #10595: Concurrency issues in `o.a.i.hive.MetastoreLock` URL: https://github.com/apache/iceberg/issues/10595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[PR] refactor: improve manifest scanning organization and concurrency [iceberg-go]

2025-01-12 Thread via GitHub
iskakaushik opened a new pull request, #252: URL: https://github.com/apache/iceberg-go/pull/252 This refactor breaks down the manifest scanning logic into more focused components in preparation for adding incremental scanners to allow reading changelog and diffs between two snapshots.

Re: [PR] Modified exception objects being thrown when converting Pyarrow tables [iceberg-python]

2025-01-12 Thread via GitHub
DevChrisCross commented on code in PR #1498: URL: https://github.com/apache/iceberg-python/pull/1498#discussion_r1912527246 ## tests/integration/test_add_files.py: ## @@ -616,13 +616,18 @@ def test_add_files_with_timestamp_tz_ns_fails(session_catalog: Catalog, format_v #

Re: [PR] Modified exception objects being thrown when converting Pyarrow tables [iceberg-python]

2025-01-12 Thread via GitHub
DevChrisCross commented on code in PR #1498: URL: https://github.com/apache/iceberg-python/pull/1498#discussion_r1912527246 ## tests/integration/test_add_files.py: ## @@ -616,13 +616,18 @@ def test_add_files_with_timestamp_tz_ns_fails(session_catalog: Catalog, format_v #

Re: [PR] Improve `LocationProvider` unit tests [iceberg-python]

2025-01-12 Thread via GitHub
smaheshwar-pltr commented on code in PR #1511: URL: https://github.com/apache/iceberg-python/pull/1511#discussion_r1912525715 ## tests/table/test_locations.py: ## @@ -82,19 +88,18 @@ def test_object_storage_injects_entropy() -> None: assert all(c in "01" for c in dir_na

Re: [PR] Improve `LocationProvider` unit tests [iceberg-python]

2025-01-12 Thread via GitHub
kevinjqliu commented on code in PR #1511: URL: https://github.com/apache/iceberg-python/pull/1511#discussion_r1912525003 ## tests/table/test_locations.py: ## @@ -82,19 +88,18 @@ def test_object_storage_injects_entropy() -> None: assert all(c in "01" for c in dir_name)

Re: [PR] Modified exception objects being thrown when converting Pyarrow tables [iceberg-python]

2025-01-12 Thread via GitHub
kevinjqliu commented on code in PR #1498: URL: https://github.com/apache/iceberg-python/pull/1498#discussion_r1912524672 ## tests/integration/test_add_files.py: ## @@ -616,13 +616,18 @@ def test_add_files_with_timestamp_tz_ns_fails(session_catalog: Catalog, format_v # ad

Re: [PR] Improve `LocationProvider` unit tests [iceberg-python]

2025-01-12 Thread via GitHub
smaheshwar-pltr commented on code in PR #1511: URL: https://github.com/apache/iceberg-python/pull/1511#discussion_r1912524325 ## tests/table/test_locations.py: ## @@ -82,19 +88,18 @@ def test_object_storage_injects_entropy() -> None: assert all(c in "01" for c in dir_na

Re: [PR] Improve `LocationProvider` unit tests [iceberg-python]

2025-01-12 Thread via GitHub
smaheshwar-pltr commented on code in PR #1511: URL: https://github.com/apache/iceberg-python/pull/1511#discussion_r1912524325 ## tests/table/test_locations.py: ## @@ -82,19 +88,18 @@ def test_object_storage_injects_entropy() -> None: assert all(c in "01" for c in dir_na

Re: [PR] Improve `LocationProvider` unit tests [iceberg-python]

2025-01-12 Thread via GitHub
kevinjqliu commented on code in PR #1511: URL: https://github.com/apache/iceberg-python/pull/1511#discussion_r1912522795 ## tests/table/test_locations.py: ## @@ -82,19 +88,18 @@ def test_object_storage_injects_entropy() -> None: assert all(c in "01" for c in dir_name)

Re: [PR] Improve `LocationProvider` unit tests [iceberg-python]

2025-01-12 Thread via GitHub
kevinjqliu commented on code in PR #1511: URL: https://github.com/apache/iceberg-python/pull/1511#discussion_r1912522795 ## tests/table/test_locations.py: ## @@ -82,19 +88,18 @@ def test_object_storage_injects_entropy() -> None: assert all(c in "01" for c in dir_name)

Re: [PR] chore(deps): Bump aws-config from 1.5.11 to 1.5.13 [iceberg-rust]

2025-01-12 Thread via GitHub
kevinjqliu merged PR #888: URL: https://github.com/apache/iceberg-rust/pull/888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] Modified exception objects being thrown when converting Pyarrow tables [iceberg-python]

2025-01-12 Thread via GitHub
DevChrisCross commented on code in PR #1498: URL: https://github.com/apache/iceberg-python/pull/1498#discussion_r1912522476 ## tests/integration/test_add_files.py: ## @@ -616,13 +616,18 @@ def test_add_files_with_timestamp_tz_ns_fails(session_catalog: Catalog, format_v #

Re: [PR] Improve `LocationProvider` unit tests [iceberg-python]

2025-01-12 Thread via GitHub
kevinjqliu commented on code in PR #1511: URL: https://github.com/apache/iceberg-python/pull/1511#discussion_r1912522361 ## tests/table/test_locations.py: ## @@ -82,19 +88,18 @@ def test_object_storage_injects_entropy() -> None: assert all(c in "01" for c in dir_name)

Re: [PR] Improve `LocationProvider` unit tests [iceberg-python]

2025-01-12 Thread via GitHub
smaheshwar-pltr commented on code in PR #1511: URL: https://github.com/apache/iceberg-python/pull/1511#discussion_r1912522117 ## tests/table/test_locations.py: ## @@ -82,19 +88,18 @@ def test_object_storage_injects_entropy() -> None: assert all(c in "01" for c in dir_na

Re: [PR] [Docs] Update spark-getting-started docs page to make the example valid [iceberg]

2025-01-12 Thread via GitHub
kevinjqliu commented on PR #11923: URL: https://github.com/apache/iceberg/pull/11923#issuecomment-2585889683 Great! Thank you. I'll post this in Iceberg Slack's #documentation channel to get more eyes on it. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] Modified exception objects being thrown when converting Pyarrow tables [iceberg-python]

2025-01-12 Thread via GitHub
kevinjqliu commented on code in PR #1498: URL: https://github.com/apache/iceberg-python/pull/1498#discussion_r1912521440 ## tests/io/test_pyarrow_visitor.py: ## @@ -625,6 +626,91 @@ def test_pyarrow_schema_ensure_large_types(pyarrow_schema_nested_without_ids: pa assert _p

Re: [PR] Improve `LocationProvider` unit tests [iceberg-python]

2025-01-12 Thread via GitHub
kevinjqliu commented on code in PR #1511: URL: https://github.com/apache/iceberg-python/pull/1511#discussion_r1912518714 ## tests/table/test_locations.py: ## @@ -82,19 +88,18 @@ def test_object_storage_injects_entropy() -> None: assert all(c in "01" for c in dir_name)

Re: [PR] chore(deps): Bump aws-config from 1.5.11 to 1.5.13 [iceberg-rust]

2025-01-12 Thread via GitHub
kevinjqliu commented on PR #888: URL: https://github.com/apache/iceberg-rust/pull/888#issuecomment-2585880916 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] chore(deps): Bump serde_json from 1.0.134 to 1.0.135 [iceberg-rust]

2025-01-12 Thread via GitHub
kevinjqliu merged PR #889: URL: https://github.com/apache/iceberg-rust/pull/889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] chore(deps): Bump aws-sdk-glue from 1.74.0 to 1.76.0 [iceberg-rust]

2025-01-12 Thread via GitHub
kevinjqliu merged PR #887: URL: https://github.com/apache/iceberg-rust/pull/887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] chore(deps): Bump tokio from 1.42.0 to 1.43.0 [iceberg-rust]

2025-01-12 Thread via GitHub
kevinjqliu merged PR #885: URL: https://github.com/apache/iceberg-rust/pull/885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] chore(deps): Bump moka from 0.12.9 to 0.12.10 [iceberg-rust]

2025-01-12 Thread via GitHub
kevinjqliu merged PR #886: URL: https://github.com/apache/iceberg-rust/pull/886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] Improve `LocationProvider` unit tests [iceberg-python]

2025-01-12 Thread via GitHub
smaheshwar-pltr commented on code in PR #1511: URL: https://github.com/apache/iceberg-python/pull/1511#discussion_r1912504667 ## tests/table/test_locations.py: ## @@ -82,19 +88,18 @@ def test_object_storage_injects_entropy() -> None: assert all(c in "01" for c in dir_na

Re: [PR] ci: check MSRV correctly [iceberg-rust]

2025-01-12 Thread via GitHub
xxchan commented on PR #849: URL: https://github.com/apache/iceberg-rust/pull/849#issuecomment-2585766380 cc @Xuanwo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] ci: check MSRV correctly [iceberg-rust]

2025-01-12 Thread via GitHub
xxchan commented on code in PR #849: URL: https://github.com/apache/iceberg-rust/pull/849#discussion_r1912469870 ## crates/catalog/s3tables/Cargo.toml: ## @@ -20,7 +20,7 @@ name = "iceberg-catalog-s3tables" version = { workspace = true } edition = { workspace = true } homepag

Re: [PR] ci: check MSRV correctly [iceberg-rust]

2025-01-12 Thread via GitHub
xxchan commented on PR #849: URL: https://github.com/apache/iceberg-rust/pull/849#issuecomment-2585765214 I tried to re-generate Cargo.lock using latest MSRV-aware resolver https://github.com/rust-lang/cargo/pull/14639 . `CARGO_RESOLVER_INCOMPATIBLE_RUST_VERSIONS=fallback cargo +stabl

Re: [PR] Integrate Test Framework [iceberg-cpp]

2025-01-12 Thread via GitHub
wgtmac commented on PR #13: URL: https://github.com/apache/iceberg-cpp/pull/13#issuecomment-2585760545 @zhjwpku It is better to change the PR title to reflect that we have chosen googletest? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Remove Hive 2 [iceberg]

2025-01-12 Thread via GitHub
manuzhang closed pull request #10996: Remove Hive 2 URL: https://github.com/apache/iceberg/pull/10996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: is

Re: [PR] Integrate Test Framework [iceberg-cpp]

2025-01-12 Thread via GitHub
wgtmac commented on PR #13: URL: https://github.com/apache/iceberg-cpp/pull/13#issuecomment-2585760084 @Fokko @Xuanwo Should we merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Update cmake instructions in README [iceberg-cpp]

2025-01-12 Thread via GitHub
wgtmac commented on code in PR #24: URL: https://github.com/apache/iceberg-cpp/pull/24#discussion_r1912457864 ## README.md: ## @@ -32,7 +32,7 @@ C++ implementation of [Apache Icebergā„¢](https://iceberg.apache.org/). ```bash cd iceberg-cpp -cmake -S . -B build -DCMAKE_INSTALL

[PR] chore(deps): Bump serde_json from 1.0.134 to 1.0.135 [iceberg-rust]

2025-01-12 Thread via GitHub
dependabot[bot] opened a new pull request, #889: URL: https://github.com/apache/iceberg-rust/pull/889 Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.134 to 1.0.135. Release notes Sourced from https://github.com/serde-rs/json/releases";>serde_json's releases. v

[PR] chore(deps): Bump aws-sdk-glue from 1.74.0 to 1.76.0 [iceberg-rust]

2025-01-12 Thread via GitHub
dependabot[bot] opened a new pull request, #887: URL: https://github.com/apache/iceberg-rust/pull/887 Bumps [aws-sdk-glue](https://github.com/awslabs/aws-sdk-rust) from 1.74.0 to 1.76.0. Commits See full diff in https://github.com/awslabs/aws-sdk-rust/commits";>compare view

[PR] chore(deps): Bump aws-config from 1.5.11 to 1.5.13 [iceberg-rust]

2025-01-12 Thread via GitHub
dependabot[bot] opened a new pull request, #888: URL: https://github.com/apache/iceberg-rust/pull/888 Bumps [aws-config](https://github.com/smithy-lang/smithy-rs) from 1.5.11 to 1.5.13. Commits See full diff in https://github.com/smithy-lang/smithy-rs/commits";>compare view

[PR] chore(deps): Bump moka from 0.12.9 to 0.12.10 [iceberg-rust]

2025-01-12 Thread via GitHub
dependabot[bot] opened a new pull request, #886: URL: https://github.com/apache/iceberg-rust/pull/886 Bumps [moka](https://github.com/moka-rs/moka) from 0.12.9 to 0.12.10. Changelog Sourced from https://github.com/moka-rs/moka/blob/main/CHANGELOG.md";>moka's changelog. Versi

[PR] chore(deps): Bump tokio from 1.42.0 to 1.43.0 [iceberg-rust]

2025-01-12 Thread via GitHub
dependabot[bot] opened a new pull request, #885: URL: https://github.com/apache/iceberg-rust/pull/885 Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.42.0 to 1.43.0. Release notes Sourced from https://github.com/tokio-rs/tokio/releases";>tokio's releases. Tokio v1.43.

Re: [I] [feat] add missing metadata tables [iceberg-python]

2025-01-12 Thread via GitHub
amitgilad3 commented on issue #1053: URL: https://github.com/apache/iceberg-python/issues/1053#issuecomment-2585675219 @soumya-ghosh , Ill will start with positional_deletes and see how fast i can finish it , once im done we can see about the rest -- This is an automated message from th

[I] Column statistics are not collected when the columns name is escaped [iceberg]

2025-01-12 Thread via GitHub
DimaRabkin opened a new issue, #11950: URL: https://github.com/apache/iceberg/issues/11950 ### Apache Iceberg version 1.7.1 (latest release) ### Query engine None ### Please describe the bug šŸž When an Iceberg has many columns, it calculates statistics only u

[PR] build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.28.7 to 1.28.10 [iceberg-go]

2025-01-12 Thread via GitHub
dependabot[bot] opened a new pull request, #251: URL: https://github.com/apache/iceberg-go/pull/251 Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.28.7 to 1.28.10. Commits https://github.com/aws/aws-sdk-go-v2/commit/7a7d202453f40928e19

[PR] build(deps): bump github.com/aws/aws-sdk-go-v2/credentials from 1.17.48 to 1.17.51 [iceberg-go]

2025-01-12 Thread via GitHub
dependabot[bot] opened a new pull request, #250: URL: https://github.com/apache/iceberg-go/pull/250 Bumps [github.com/aws/aws-sdk-go-v2/credentials](https://github.com/aws/aws-sdk-go-v2) from 1.17.48 to 1.17.51. Commits https://github.com/aws/aws-sdk-go-v2/commit/7a7d202453f40

[PR] build(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 from 1.72.0 to 1.72.2 [iceberg-go]

2025-01-12 Thread via GitHub
dependabot[bot] opened a new pull request, #249: URL: https://github.com/apache/iceberg-go/pull/249 Bumps [github.com/aws/aws-sdk-go-v2/service/s3](https://github.com/aws/aws-sdk-go-v2) from 1.72.0 to 1.72.2. Commits https://github.com/aws/aws-sdk-go-v2/commit/31c2f3f89b98bd55

[PR] build(deps): bump google.golang.org/api from 0.214.0 to 0.216.0 [iceberg-go]

2025-01-12 Thread via GitHub
dependabot[bot] opened a new pull request, #248: URL: https://github.com/apache/iceberg-go/pull/248 Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.214.0 to 0.216.0. Release notes Sourced from https://github.com/googleapis/google-api-go-cli

[PR] build(deps): bump github.com/aws/aws-sdk-go-v2/service/glue from 1.105.0 to 1.105.1 [iceberg-go]

2025-01-12 Thread via GitHub
dependabot[bot] opened a new pull request, #247: URL: https://github.com/apache/iceberg-go/pull/247 Bumps [github.com/aws/aws-sdk-go-v2/service/glue](https://github.com/aws/aws-sdk-go-v2) from 1.105.0 to 1.105.1. Changelog Sourced from https://github.com/aws/aws-sdk-go-v2/blob/ser