zuyu commented on code in PR #24:
URL: https://github.com/apache/iceberg-cpp/pull/24#discussion_r1912644446


##########
.gitignore:
##########
@@ -16,6 +16,7 @@
 # under the License.
 
 build/
+install/

Review Comment:
   No, since we specify `CMAKE_INSTALL_PREFIX` in cmake, I think someone might 
specify `CMAKE_INSTALL_PREFIX=install` in the repo directory as well. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to