smaheshwar-pltr commented on code in PR #1511:
URL: https://github.com/apache/iceberg-python/pull/1511#discussion_r1912524325
##########
tests/table/test_locations.py:
##########
@@ -82,19 +88,18 @@ def test_object_storage_injects_entropy() -> None:
assert all(c in "01" for c in dir_name)
-@pytest.mark.parametrize("object_storage", [True, False])
-def test_partition_value_in_path(object_storage: bool) -> None:
+def test_object_storage_with_partition() -> None:
Review Comment:
[`test_object_storage_injects_entropy`](https://github.com/apache/iceberg-python/pull/1511/files#diff-120d0073dd4792b7e8489e8398e6d9a2f7a914cf13cc4b101cd39f78881d7bd9R74)
does this - I could rename that to `test_object_storage_no_partition` and
maybe test the location itself (with hardcoded hash) to mirror the
`test_simple` ones.
But I'm also OK with how it is now and the raw locations here being tested
by
[`test_hash_injection`](https://github.com/apache/iceberg-python/pull/1511/files#diff-120d0073dd4792b7e8489e8398e6d9a2f7a914cf13cc4b101cd39f78881d7bd9R132)
instead (this tests the same case you've described above) and several times
over to verify hash function matches with Java side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
