Fokko commented on code in PR #11806:
URL: https://github.com/apache/iceberg/pull/11806#discussion_r1912745602
##########
open-api/rest-catalog-open-api.py:
##########
@@ -981,8 +966,33 @@ class ValueMap(BaseModel):
)
+class ContentFile(BaseModel):
+ content: ContentEnum
+ file_path: str = Field(..., alias='file-path')
+ file_format: FileFormat = Field(..., alias='file-format')
+ spec_id: int = Field(..., alias='spec-id')
+ partition: List[PrimitiveTypeValue] = Field(
+ ...,
+ description='A list of partition field values ordered based on the
fields of the partition spec specified by the `spec-id`',
+ example=[1, 'bar'],
+ )
+ file_size_in_bytes: int = Field(
+ ..., alias='file-size-in-bytes', description='Total file size in bytes'
+ )
+ record_count: int = Field(
+ ..., alias='record-count', description='Number of records in the file'
+ )
+ key_metadata: Optional[BinaryTypeValue] = Field(
+ None, alias='key-metadata', description='Encryption key metadata blob'
+ )
+ split_offsets: Optional[List[int]] = Field(
+ None, alias='split-offsets', description='List of splittable offsets'
+ )
+ sort_order_id: Optional[int] = Field(None, alias='sort-order-id')
+
+
class DataFile(ContentFile):
- content: Literal['data']
+ content: ContentEnum
Review Comment:
No, this file is just here for test purposes and to see what kind of code
changes the changes in the yaml produces. With the open-API spec, it can
sometimes be hard to see what the impact is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
