kevinjqliu commented on code in PR #1511:
URL: https://github.com/apache/iceberg-python/pull/1511#discussion_r1912522795
##########
tests/table/test_locations.py:
##########
@@ -82,19 +88,18 @@ def test_object_storage_injects_entropy() -> None:
assert all(c in "01" for c in dir_name)
[email protected]("object_storage", [True, False])
-def test_partition_value_in_path(object_storage: bool) -> None:
+def test_object_storage_with_partition() -> None:
Review Comment:
ok i mistyped, i wanted to mention adding a test for
ObjectStoreLocationProvider for non-partitioned table with
`write.object-storage.partitioned-paths` not set
The test below sets `"write.object-storage.partitioned-paths": "false",`
I guess this is confusing with #1509 changing the default value.
I want to test the default behavior of non-partitioned table with just
ObjectStoreLocationProvider enabled
similar to default behaviors for SimpleLocationProvider in
`test_simple_location_provider_no_partition` and
`test_simple_location_provider_with_partition`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
