Re: [PR] Core: add JSON serialization for BaseFilesTable.ManifestReadTask, AllManifestsTable.ManifestListReadTask, and BaseEntriesTable.ManifestReadTask [iceberg]

2024-07-20 Thread via GitHub
stevenzwu commented on code in PR #10735: URL: https://github.com/apache/iceberg/pull/10735#discussion_r1685644920 ## core/src/main/java/org/apache/iceberg/BaseEntriesTable.java: ## @@ -283,19 +276,28 @@ static class ManifestReadTask extends BaseFileScanTask implements DataTask

Re: [PR] Core: add JSON serialization for BaseFilesTable.ManifestReadTask, AllManifestsTable.ManifestListReadTask, and BaseEntriesTable.ManifestReadTask [iceberg]

2024-07-20 Thread via GitHub
stevenzwu commented on code in PR #10735: URL: https://github.com/apache/iceberg/pull/10735#discussion_r1685644366 ## core/src/main/java/org/apache/iceberg/AllManifestsTable.java: ## @@ -158,12 +168,14 @@ static class ManifestListReadTask implements DataTask { private DataF

Re: [PR] Flink: Fix duplicate data in Flink's upsert writer for format V2 [iceberg]

2024-07-20 Thread via GitHub
stevenzwu commented on code in PR #10526: URL: https://github.com/apache/iceberg/pull/10526#discussion_r1685640900 ## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java: ## @@ -426,30 +425,44 @@ private void commitOperation( } @Overr

[PR] Core: add JSON serialization for BaseFilesTable.ManifestReadTask, AllManifestsTable.ManifestListReadTask, and BaseEntriesTable.ManifestReadTask [iceberg]

2024-07-20 Thread via GitHub
stevenzwu opened a new pull request, #10735: URL: https://github.com/apache/iceberg/pull/10735 This completes the JSON parser for scan task. These scan tasks are for metadata tables. This would unblock Flink to switch to FLIP-27 source as the default. close issue #9597 .

[PR] Build: Bump mkdocs-material from 9.5.28 to 9.5.29 [iceberg]

2024-07-20 Thread via GitHub
dependabot[bot] opened a new pull request, #10734: URL: https://github.com/apache/iceberg/pull/10734 Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.28 to 9.5.29. Release notes Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mkdoc

Re: [PR] Build: Bump software.amazon.s3.accessgrants:aws-s3-accessgrants-java-plugin from 2.0.0 to 2.1.0 [iceberg]

2024-07-20 Thread via GitHub
dependabot[bot] commented on PR #10467: URL: https://github.com/apache/iceberg/pull/10467#issuecomment-2241457012 Superseded by #10732. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Build: Bump software.amazon.s3.accessgrants:aws-s3-accessgrants-java-plugin from 2.0.0 to 2.1.0 [iceberg]

2024-07-20 Thread via GitHub
dependabot[bot] closed pull request #10467: Build: Bump software.amazon.s3.accessgrants:aws-s3-accessgrants-java-plugin from 2.0.0 to 2.1.0 URL: https://github.com/apache/iceberg/pull/10467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] Build: Bump software.amazon.s3.accessgrants:aws-s3-accessgrants-java-plugin from 2.0.0 to 2.2.0 [iceberg]

2024-07-20 Thread via GitHub
dependabot[bot] opened a new pull request, #10732: URL: https://github.com/apache/iceberg/pull/10732 Bumps [software.amazon.s3.accessgrants:aws-s3-accessgrants-java-plugin](https://github.com/aws/aws-s3-accessgrants-plugin-java-v2) from 2.0.0 to 2.2.0. Changelog Sourced from https

[PR] Build: Bump com.google.errorprone:error_prone_annotations from 2.28.0 to 2.29.2 [iceberg]

2024-07-20 Thread via GitHub
dependabot[bot] opened a new pull request, #10731: URL: https://github.com/apache/iceberg/pull/10731 Bumps [com.google.errorprone:error_prone_annotations](https://github.com/google/error-prone) from 2.28.0 to 2.29.2. Release notes Sourced from https://github.com/google/error-prone

[PR] Build: Bump org.testcontainers:testcontainers from 1.19.8 to 1.20.0 [iceberg]

2024-07-20 Thread via GitHub
dependabot[bot] opened a new pull request, #10730: URL: https://github.com/apache/iceberg/pull/10730 Bumps [org.testcontainers:testcontainers](https://github.com/testcontainers/testcontainers-java) from 1.19.8 to 1.20.0. Release notes Sourced from https://github.com/testcontainers

[PR] Build: Bump software.amazon.awssdk:bom from 2.26.20 to 2.26.21 [iceberg]

2024-07-20 Thread via GitHub
dependabot[bot] opened a new pull request, #10729: URL: https://github.com/apache/iceberg/pull/10729 Bumps software.amazon.awssdk:bom from 2.26.20 to 2.26.21. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=soft

[PR] Build: Bump orc from 1.9.3 to 1.9.4 [iceberg]

2024-07-20 Thread via GitHub
dependabot[bot] opened a new pull request, #10728: URL: https://github.com/apache/iceberg/pull/10728 Bumps `orc` from 1.9.3 to 1.9.4. Updates `org.apache.orc:orc-core` from 1.9.3 to 1.9.4 Updates `org.apache.orc:orc-tools` from 1.9.3 to 1.9.4 Dependabot will resolve any c

[PR] Build: Bump org.roaringbitmap:RoaringBitmap from 1.2.0 to 1.2.1 [iceberg]

2024-07-20 Thread via GitHub
dependabot[bot] opened a new pull request, #10733: URL: https://github.com/apache/iceberg/pull/10733 Bumps [org.roaringbitmap:RoaringBitmap](https://github.com/RoaringBitmap/RoaringBitmap) from 1.2.0 to 1.2.1. Release notes Sourced from https://github.com/RoaringBitmap/RoaringBitm

[PR] Build: Bump nessie from 0.92.1 to 0.93.1 [iceberg]

2024-07-20 Thread via GitHub
dependabot[bot] opened a new pull request, #10727: URL: https://github.com/apache/iceberg/pull/10727 Bumps `nessie` from 0.92.1 to 0.93.1. Updates `org.projectnessie.nessie:nessie-client` from 0.92.1 to 0.93.1 Updates `org.projectnessie.nessie:nessie-jaxrs-testextension` from 0.92.1

[PR] Build: Bump io.netty:netty-buffer from 4.1.111.Final to 4.1.112.Final [iceberg]

2024-07-20 Thread via GitHub
dependabot[bot] opened a new pull request, #10726: URL: https://github.com/apache/iceberg/pull/10726 Bumps [io.netty:netty-buffer](https://github.com/netty/netty) from 4.1.111.Final to 4.1.112.Final. Commits https://github.com/netty/netty/commit/ebe2aa5b7cd36562a20b024d78ecff47

Re: [I] Issue with CALL parsing [iceberg]

2024-07-20 Thread via GitHub
kennyluke1023 commented on issue #8343: URL: https://github.com/apache/iceberg/issues/8343#issuecomment-2241397378 > in my case, adding `spark.sql.extensions=org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions` solve the problem hi bro, I face same problem too butI am

[I] [documentation] library version upgrade fails `test_version_format` [iceberg-python]

2024-07-20 Thread via GitHub
kevinjqliu opened a new issue, #949: URL: https://github.com/apache/iceberg-python/issues/949 ### Feature Request / Improvement When Pyiceberg upgrades its version, such as now from `0.6.1` -> `0.7.0`. The local repo will fail `test_version_format` until the library is reinstalled wi

Re: [I] Read delete files in parallel. [iceberg]

2024-07-20 Thread via GitHub
github-actions[bot] commented on issue #3118: URL: https://github.com/apache/iceberg/issues/3118#issuecomment-2241346712 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Docs: we need a matrix to maintain the compatibility relationship between engines and iceberg version. [iceberg]

2024-07-20 Thread via GitHub
github-actions[bot] commented on issue #3115: URL: https://github.com/apache/iceberg/issues/3115#issuecomment-2241346703 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Write the changelog whose primary key is DATE/TIMESTAMP type to iceberg through Flink, and throw an IllegalStateException when it is read out [iceberg]

2024-07-20 Thread via GitHub
github-actions[bot] commented on issue #3119: URL: https://github.com/apache/iceberg/issues/3119#issuecomment-2241346722 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] after set 'write.upsert.enable'='true' in flink sql, using flink sql read iceberg table will get exception: java.lang.IllegalArgumentException: Row arity: 3, but serializer arity: 2 [iceberg]

2024-07-20 Thread via GitHub
github-actions[bot] commented on issue #3114: URL: https://github.com/apache/iceberg/issues/3114#issuecomment-2241346692 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Docs: Add document how to export records from CDC/Upsert Stream into apache iceberg table. [iceberg]

2024-07-20 Thread via GitHub
github-actions[bot] commented on issue #3105: URL: https://github.com/apache/iceberg/issues/3105#issuecomment-2241346680 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] SparkSessionCatalog.listTables() does not list Iceberg tables [iceberg]

2024-07-20 Thread via GitHub
github-actions[bot] commented on issue #3109: URL: https://github.com/apache/iceberg/issues/3109#issuecomment-2241346687 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Flink: support insert options set equality fields columns [iceberg]

2024-07-20 Thread via GitHub
github-actions[bot] commented on PR #3101: URL: https://github.com/apache/iceberg/pull/3101#issuecomment-2241346673 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Core: Limit memory used by ParallelIterable [iceberg]

2024-07-20 Thread via GitHub
stevenzwu commented on code in PR #10691: URL: https://github.com/apache/iceberg/pull/10691#discussion_r1685542742 ## core/src/main/java/org/apache/iceberg/util/ParallelIterable.java: ## @@ -20,84 +20,117 @@ import java.io.Closeable; import java.io.IOException; +import java.

Re: [PR] Flink: handle rescale properly and refactor statistics [iceberg]

2024-07-20 Thread via GitHub
stevenzwu commented on PR #10457: URL: https://github.com/apache/iceberg/pull/10457#issuecomment-2241316120 > Hi Steven, I think we discussed every comment. Could we run the tests one more time before merging? It was a long time ago when they were running, and it might be good to double che

Re: [PR] Core: Limit memory used by ParallelIterable [iceberg]

2024-07-20 Thread via GitHub
stevenzwu commented on code in PR #10691: URL: https://github.com/apache/iceberg/pull/10691#discussion_r1685542742 ## core/src/main/java/org/apache/iceberg/util/ParallelIterable.java: ## @@ -20,84 +20,117 @@ import java.io.Closeable; import java.io.IOException; +import java.

Re: [PR] Core: Limit memory used by ParallelIterable [iceberg]

2024-07-20 Thread via GitHub
stevenzwu commented on code in PR #10691: URL: https://github.com/apache/iceberg/pull/10691#discussion_r1685541998 ## core/src/main/java/org/apache/iceberg/util/ParallelIterable.java: ## @@ -136,30 +169,33 @@ private boolean checkTasks() { } } - return !cl

Re: [I] Metadata field `last-updated-ms` is not updated for DDL operations [iceberg-python]

2024-07-20 Thread via GitHub
kevinjqliu commented on issue #948: URL: https://github.com/apache/iceberg-python/issues/948#issuecomment-2241305096 Great catch! According to the spec, https://iceberg.apache.org/spec/#table-metadata-fields ``` last-updated-ms Timestamp in milliseconds from the unix epoch whe

Re: [PR] Core: Limit memory used by ParallelIterable [iceberg]

2024-07-20 Thread via GitHub
stevenzwu commented on code in PR #10691: URL: https://github.com/apache/iceberg/pull/10691#discussion_r1685540696 ## core/src/main/java/org/apache/iceberg/util/ParallelIterable.java: ## @@ -136,30 +169,33 @@ private boolean checkTasks() { } } - return !cl

Re: [PR] Core: Limit memory used by ParallelIterable [iceberg]

2024-07-20 Thread via GitHub
stevenzwu commented on code in PR #10691: URL: https://github.com/apache/iceberg/pull/10691#discussion_r1685540498 ## core/src/test/java/org/apache/iceberg/util/TestParallelIterable.java: ## @@ -133,6 +140,47 @@ public CloseableIterator iterator() { .untilAsserted(() ->

[I] Metadata field `last-updated-ms` is not updated for DDL operations [iceberg-python]

2024-07-20 Thread via GitHub
soumya-ghosh opened a new issue, #948: URL: https://github.com/apache/iceberg-python/issues/948 ### Apache Iceberg version main (development) ### Please describe the bug 🐞 Executing DDL operations on Iceberg table using Pyiceberg is not updating `last-updated-ms` field i

Re: [PR] Support loading custom catalog impl [iceberg-python]

2024-07-20 Thread via GitHub
kevinjqliu commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685524899 ## pyiceberg/catalog/__init__.py: ## @@ -283,6 +292,20 @@ def delete_data_files(io: FileIO, manifests_to_delete: List[ManifestFile]) -> No del

Re: [PR] Support loading custom catalog impl [iceberg-python]

2024-07-20 Thread via GitHub
jackye1995 commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685513070 ## tests/catalog/test_glue.py: ## @@ -46,6 +47,23 @@ ) +@mock_aws +def test_load_catalog_from_impl() -> None: +assert isinstance( +load_catalog

Re: [PR] Support loading custom catalog impl [iceberg-python]

2024-07-20 Thread via GitHub
jackye1995 commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685512970 ## pyiceberg/catalog/__init__.py: ## @@ -283,6 +292,20 @@ def delete_data_files(io: FileIO, manifests_to_delete: List[ManifestFile]) -> No del

Re: [PR] Support loading custom catalog impl [iceberg-python]

2024-07-20 Thread via GitHub
jackye1995 commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685520033 ## pyiceberg/catalog/__init__.py: ## @@ -283,6 +292,20 @@ def delete_data_files(io: FileIO, manifests_to_delete: List[ManifestFile]) -> No del

Re: [PR] Support loading custom catalog impl [iceberg-python]

2024-07-20 Thread via GitHub
jackye1995 commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685519855 ## mkdocs/docs/configuration.md: ## @@ -139,7 +139,13 @@ For the FileIO there are several configuration options available: ## Catalogs -PyIceberg currentl

Re: [PR] Support loading custom catalog impl [iceberg-python]

2024-07-20 Thread via GitHub
jackye1995 commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685513070 ## tests/catalog/test_glue.py: ## @@ -46,6 +47,23 @@ ) +@mock_aws +def test_load_catalog_from_impl() -> None: +assert isinstance( +load_catalog

Re: [PR] Support loading custom catalog impl [iceberg-python]

2024-07-20 Thread via GitHub
jackye1995 commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685512970 ## pyiceberg/catalog/__init__.py: ## @@ -283,6 +292,20 @@ def delete_data_files(io: FileIO, manifests_to_delete: List[ManifestFile]) -> No del

Re: [PR] Support loading custom catalog impl [iceberg-python]

2024-07-20 Thread via GitHub
kevinjqliu commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685511390 ## mkdocs/docs/configuration.md: ## @@ -139,7 +139,13 @@ For the FileIO there are several configuration options available: ## Catalogs -PyIceberg currentl

Re: [PR] Core: Support appending files with different specs [iceberg]

2024-07-20 Thread via GitHub
fqaiser94 commented on PR #9860: URL: https://github.com/apache/iceberg/pull/9860#issuecomment-2241204364 > Really sorry for the delayed review on this @fqaiser94 I see this PR came up in discussion on the kafka commit coordination PR [#10351 (comment)](https://github.com/apache/iceberg/pul

Re: [PR] Core: Limit memory used by ParallelIterable [iceberg]

2024-07-20 Thread via GitHub
findepi commented on PR #10691: URL: https://github.com/apache/iceberg/pull/10691#issuecomment-2241150813 @stevenzwu thanks for your review! addressed comments, PTAL @rdblue i changed the default size limit + some other editorials, PTAL -- This is an automated message from the Apach

Re: [PR] Core: Limit memory used by ParallelIterable [iceberg]

2024-07-20 Thread via GitHub
findepi commented on code in PR #10691: URL: https://github.com/apache/iceberg/pull/10691#discussion_r1685432875 ## core/src/main/java/org/apache/iceberg/util/ParallelIterable.java: ## @@ -20,65 +20,69 @@ import java.io.Closeable; import java.io.IOException; +import java.uti

Re: [PR] Core: Limit memory used by ParallelIterable [iceberg]

2024-07-20 Thread via GitHub
findepi commented on code in PR #10691: URL: https://github.com/apache/iceberg/pull/10691#discussion_r1685431565 ## core/src/main/java/org/apache/iceberg/util/ParallelIterable.java: ## @@ -192,4 +228,78 @@ public synchronized T next() { return queue.poll(); } } +

Re: [PR] Core: Limit memory used by ParallelIterable [iceberg]

2024-07-20 Thread via GitHub
findepi commented on code in PR #10691: URL: https://github.com/apache/iceberg/pull/10691#discussion_r1685431047 ## core/src/main/java/org/apache/iceberg/util/ParallelIterable.java: ## @@ -192,4 +228,78 @@ public synchronized T next() { return queue.poll(); } } +

Re: [PR] Core: Limit memory used by ParallelIterable [iceberg]

2024-07-20 Thread via GitHub
findepi commented on code in PR #10691: URL: https://github.com/apache/iceberg/pull/10691#discussion_r1685430488 ## core/src/main/java/org/apache/iceberg/util/ParallelIterable.java: ## @@ -136,30 +169,33 @@ private boolean checkTasks() { } } - return !clos

Re: [PR] Core: Limit memory used by ParallelIterable [iceberg]

2024-07-20 Thread via GitHub
findepi commented on code in PR #10691: URL: https://github.com/apache/iceberg/pull/10691#discussion_r1685430355 ## core/src/main/java/org/apache/iceberg/util/ParallelIterable.java: ## @@ -192,4 +228,78 @@ public synchronized T next() { return queue.poll(); } } +

Re: [PR] Core: Limit memory used by ParallelIterable [iceberg]

2024-07-20 Thread via GitHub
findepi commented on code in PR #10691: URL: https://github.com/apache/iceberg/pull/10691#discussion_r1685430017 ## core/src/main/java/org/apache/iceberg/util/ParallelIterable.java: ## @@ -20,84 +20,115 @@ import java.io.Closeable; import java.io.IOException; +import java.io

Re: [PR] Core: Limit memory used by ParallelIterable [iceberg]

2024-07-20 Thread via GitHub
findepi commented on code in PR #10691: URL: https://github.com/apache/iceberg/pull/10691#discussion_r1685429769 ## core/src/main/java/org/apache/iceberg/util/ParallelIterable.java: ## @@ -107,15 +138,17 @@ public void close() { * * @return true if there are pending

Re: [PR] Core: Limit memory used by ParallelIterable [iceberg]

2024-07-20 Thread via GitHub
findepi commented on code in PR #10691: URL: https://github.com/apache/iceberg/pull/10691#discussion_r1685429472 ## core/src/main/java/org/apache/iceberg/util/ParallelIterable.java: ## @@ -136,30 +169,33 @@ private boolean checkTasks() { } } - return !clos

Re: [PR] feat: improve compatibility of S3 test minio connection [iceberg-rust]

2024-07-20 Thread via GitHub
Xuanwo commented on code in PR #470: URL: https://github.com/apache/iceberg-rust/pull/470#discussion_r1685428925 ## crates/iceberg/tests/file_io_s3_test.rs: ## @@ -49,12 +49,12 @@ async fn get_file_io() -> FileIO { let guard = DOCKER_COMPOSE_ENV.read().unwrap(); let

Re: [PR] Core: Limit memory used by ParallelIterable [iceberg]

2024-07-20 Thread via GitHub
findepi commented on code in PR #10691: URL: https://github.com/apache/iceberg/pull/10691#discussion_r1685428633 ## core/src/test/java/org/apache/iceberg/util/TestParallelIterable.java: ## @@ -133,6 +140,47 @@ public CloseableIterator iterator() { .untilAsserted(() -> a

Re: [PR] Core: Limit memory used by ParallelIterable [iceberg]

2024-07-20 Thread via GitHub
findepi commented on code in PR #10691: URL: https://github.com/apache/iceberg/pull/10691#discussion_r1685428388 ## core/src/test/java/org/apache/iceberg/util/TestParallelIterable.java: ## @@ -133,6 +140,47 @@ public CloseableIterator iterator() { .untilAsserted(() -> a

Re: [I] Formal verification discovers potential consistency issue [iceberg]

2024-07-20 Thread via GitHub
Vanlightly commented on issue #10720: URL: https://github.com/apache/iceberg/issues/10720#issuecomment-2241142730 Correct, I missed that check. I've added it to the model and that consistency violation is no longer occurring. Thanks. However, I'm now hitting a different consistency vi

Re: [PR] Metadata object cache [iceberg-rust]

2024-07-20 Thread via GitHub
sdd closed pull request #471: Metadata object cache URL: https://github.com/apache/iceberg-rust/pull/471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Metadata object cache [iceberg-rust]

2024-07-20 Thread via GitHub
sdd opened a new pull request, #471: URL: https://github.com/apache/iceberg-rust/pull/471 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[PR] feat: improve compatibility of S3 test minio connection [iceberg-rust]

2024-07-20 Thread via GitHub
sdd opened a new pull request, #470: URL: https://github.com/apache/iceberg-rust/pull/470 The file IO S3 tests do not work on OSX due to the connection to the docker container being blocked when connecting via the containers hostname. This change connects to the port that Docker has exposed

Re: [PR] Support loading custom catalog impl [iceberg-python]

2024-07-20 Thread via GitHub
HonahX commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685322960 ## tests/catalog/test_glue.py: ## @@ -46,6 +47,23 @@ ) +@mock_aws +def test_load_catalog_from_impl() -> None: +assert isinstance( +load_catalog( +

Re: [PR] Support loading custom catalog impl [iceberg-python]

2024-07-20 Thread via GitHub
HonahX commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685322960 ## tests/catalog/test_glue.py: ## @@ -46,6 +47,23 @@ ) +@mock_aws +def test_load_catalog_from_impl() -> None: +assert isinstance( +load_catalog( +

Re: [PR] Support loading custom catalog impl [iceberg-python]

2024-07-20 Thread via GitHub
HonahX commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685322288 ## pyiceberg/catalog/__init__.py: ## @@ -283,6 +292,20 @@ def delete_data_files(io: FileIO, manifests_to_delete: List[ManifestFile]) -> No deleted

Re: [PR] Support loading custom catalog impl [iceberg-python]

2024-07-20 Thread via GitHub
HonahX commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685322288 ## pyiceberg/catalog/__init__.py: ## @@ -283,6 +292,20 @@ def delete_data_files(io: FileIO, manifests_to_delete: List[ManifestFile]) -> No deleted

Re: [PR] Support loading custom catalog impl [iceberg-python]

2024-07-20 Thread via GitHub
HonahX commented on code in PR #947: URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685322960 ## tests/catalog/test_glue.py: ## @@ -46,6 +47,23 @@ ) +@mock_aws +def test_load_catalog_from_impl() -> None: +assert isinstance( +load_catalog( +

[I] How to query a specified partition data file? [iceberg]

2024-07-20 Thread via GitHub
(expression) does not take effect ```java DataFilesTable dataFilesTable = (DataFilesTable) MetadataTableUtils.createMetadataTableInstance(icebergTable, MetadataTableType.DATA_FILES); Expression expression = Expressions.and(Expressions.equal("partition.pt",