findepi commented on code in PR #10691:
URL: https://github.com/apache/iceberg/pull/10691#discussion_r1685429769
##########
core/src/main/java/org/apache/iceberg/util/ParallelIterable.java:
##########
@@ -107,15 +138,17 @@ public void close() {
*
* @return true if there are pending tasks, false otherwise
*/
- private boolean checkTasks() {
+ private synchronized boolean checkTasks() {
+ Preconditions.checkState(!closed.get(), "Already closed");
boolean hasRunningTask = false;
for (int i = 0; i < taskFutures.length; i += 1) {
if (taskFutures[i] == null || taskFutures[i].isDone()) {
if (taskFutures[i] != null) {
// check for task failure and re-throw any exception
Review Comment:
Will change to
```
// check for task failure and re-throw any exception. Enqueue continuation
if any.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
