HonahX commented on code in PR #947:
URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685322960
##########
tests/catalog/test_glue.py:
##########
@@ -46,6 +47,23 @@
)
+@mock_aws
+def test_load_catalog_from_impl() -> None:
+ assert isinstance(
+ load_catalog(
+ "catalog",
+ **{
+ PY_CATALOG_IMPL: "pyiceberg.catalog.glue.GlueCatalog",
Review Comment:
[Optional] I think it would be better to explicitly write the config name
"py-catalog-impl" in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
