jackye1995 commented on code in PR #947:
URL: https://github.com/apache/iceberg-python/pull/947#discussion_r1685519855
##########
mkdocs/docs/configuration.md:
##########
@@ -139,7 +139,13 @@ For the FileIO there are several configuration options
available:
## Catalogs
-PyIceberg currently has native support for REST, SQL, Hive, Glue and DynamoDB.
+PyIceberg currently has native catalog type support for REST, SQL, Hive, Glue
and DynamoDB.
+You can also set the catalog implementation explicitly:
+
+| Key | Example | Description
|
+| --------------- | ---------------------------- |
------------------------------------------------------------------------------------------------
|
+| type | rest | Type of catalog, one of
`rest`, `sql`, `hive`, `glue`, `dymamodb`. Default to `rest` |
Review Comment:
Good point, I added another test about this, and also used the wording
"Alternatively, you can also directly set the catalog implementation" at top.
Let me know if that looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
