Xuanwo commented on code in PR #470:
URL: https://github.com/apache/iceberg-rust/pull/470#discussion_r1685428925
##########
crates/iceberg/tests/file_io_s3_test.rs:
##########
@@ -49,12 +49,12 @@ async fn get_file_io() -> FileIO {
let guard = DOCKER_COMPOSE_ENV.read().unwrap();
let docker_compose = guard.as_ref().unwrap();
- let container_ip = docker_compose.get_container_ip("minio");
Review Comment:
I feel like we can use the docker's bridge ip instead, but I'm not sure
since I don't have a mac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
