Fokko merged PR #10652:
URL: https://github.com/apache/iceberg/pull/10652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
Fokko merged PR #898:
URL: https://github.com/apache/iceberg-python/pull/898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
dependabot[bot] opened a new pull request, #10655:
URL: https://github.com/apache/iceberg/pull/10655
Bumps
[org.roaringbitmap:RoaringBitmap](https://github.com/RoaringBitmap/RoaringBitmap)
from 1.1.0 to 1.2.0.
Release notes
Sourced from https://github.com/RoaringBitmap/RoaringBitm
dependabot[bot] opened a new pull request, #10654:
URL: https://github.com/apache/iceberg/pull/10654
Bumps `jetty` from 9.4.54.v20240208 to 9.4.55.v20240627.
Updates `org.eclipse.jetty:jetty-server` from 9.4.54.v20240208 to
9.4.55.v20240627
Updates `org.eclipse.jetty:jetty-servlet`
dependabot[bot] opened a new pull request, #10653:
URL: https://github.com/apache/iceberg/pull/10653
Bumps `kafka` from 3.7.0 to 3.7.1.
Updates `org.apache.kafka:kafka-clients` from 3.7.0 to 3.7.1
Updates `org.apache.kafka:connect-api` from 3.7.0 to 3.7.1
Updates `org.apache.
dependabot[bot] opened a new pull request, #10652:
URL: https://github.com/apache/iceberg/pull/10652
Bumps [com.azure:azure-sdk-bom](https://github.com/azure/azure-sdk-for-java)
from 1.2.24 to 1.2.25.
Release notes
Sourced from https://github.com/azure/azure-sdk-for-java/releases";
dependabot[bot] opened a new pull request, #10651:
URL: https://github.com/apache/iceberg/pull/10651
Bumps `jackson-bom` from 2.14.2 to 2.17.2.
Updates `com.fasterxml.jackson:jackson-bom` from 2.14.2 to 2.17.2
Commits
https://github.com/FasterXML/jackson-bom/commit/e239d65c23
dependabot[bot] commented on PR #10465:
URL: https://github.com/apache/iceberg/pull/10465#issuecomment-2212322625
Superseded by #10651.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
dependabot[bot] closed pull request #10465: Build: Bump jackson-bom from 2.14.2
to 2.17.1
URL: https://github.com/apache/iceberg/pull/10465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
dependabot[bot] opened a new pull request, #10650:
URL: https://github.com/apache/iceberg/pull/10650
Bumps software.amazon.awssdk:bom from 2.26.12 to 2.26.16.
[
from 0.25.7 to 0.25.8.
Release notes
Sourced from https://github.com/koxudaxi/datamodel-code-
dependabot[bot] opened a new pull request, #10648:
URL: https://github.com/apache/iceberg/pull/10648
Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from
9.5.27 to 9.5.28.
Release notes
Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mkdoc
Xuanwo commented on PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#issuecomment-2212312703
Perhaps we can update the contributing guide with the versions we used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Xuanwo commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667600760
##
.github/workflows/ci.yml:
##
@@ -29,6 +29,10 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
cancel-in-progress: tru
liurenjie1024 commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667600732
##
.github/actions/setup-builder/action.yml:
##
Review Comment:
This file is heavily inspire by
[datafusion](https://github.com/apache/datafusion/blob/ma
kevinjqliu commented on code in PR #900:
URL: https://github.com/apache/iceberg-python/pull/900#discussion_r1667536334
##
pyiceberg/manifest.py:
##
@@ -762,10 +762,10 @@ def add_entry(self, entry: ManifestEntry) ->
ManifestWriter:
if (
(entry.status == M
anuragmantri commented on issue #10646:
URL: https://github.com/apache/iceberg/issues/10646#issuecomment-2212065368
Thanks @szehon-ho. +1 to the general idea, I will take a look at the design
doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
soumya-ghosh commented on issue #893:
URL: https://github.com/apache/iceberg-python/issues/893#issuecomment-2211986191
@Fokko the PR https://github.com/apache/iceberg-python/pull/900 is ready for
review.
--
This is an automated message from the Apache Git Service.
To respond to the messag
soumya-ghosh opened a new pull request, #900:
URL: https://github.com/apache/iceberg-python/pull/900
Implements: https://github.com/apache/iceberg-python/issues/893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
Fokko merged PR #899:
URL: https://github.com/apache/iceberg-python/pull/899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko commented on code in PR #848:
URL: https://github.com/apache/iceberg-python/pull/848#discussion_r1667417979
##
pyiceberg/io/pyarrow.py:
##
@@ -918,11 +919,24 @@ def primitive(self, primitive: pa.DataType) ->
PrimitiveType:
return TimeType()
elif pa.t
Fokko commented on code in PR #848:
URL: https://github.com/apache/iceberg-python/pull/848#discussion_r1667417924
##
pyiceberg/catalog/__init__.py:
##
@@ -675,8 +675,11 @@ def _convert_schema_if_needed(schema: Union[Schema,
"pa.Schema"]) -> Schema:
from pyiceberg
Fokko merged PR #897:
URL: https://github.com/apache/iceberg-python/pull/897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
manuzhang opened a new pull request, #10647:
URL: https://github.com/apache/iceberg/pull/10647
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1667378383
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java:
##
@@ -0,0 +1,294 @@
+/*
+ * Licensed to the Apache Software Foundat
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1667378383
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java:
##
@@ -0,0 +1,294 @@
+/*
+ * Licensed to the Apache Software Foundat
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1667378924
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Channel.java:
##
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1667378695
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/KafkaUtils.java:
##
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundatio
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1667378606
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CommitState.java:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundat
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1667378383
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java:
##
@@ -0,0 +1,294 @@
+/*
+ * Licensed to the Apache Software Foundat
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1667378177
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Worker.java:
##
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software Foundation (
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1667377890
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/KafkaClientFactory.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software F
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1667377846
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/KafkaClientFactory.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software F
bryanck commented on code in PR #10351:
URL: https://github.com/apache/iceberg/pull/10351#discussion_r1667376742
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java:
##
@@ -0,0 +1,294 @@
+/*
+ * Licensed to the Apache Software Foundat
liurenjie1024 commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667368210
##
Makefile:
##
@@ -19,25 +19,31 @@
RUST_LOG = debug
+RUST_NIGHTLY_CHANNEL = nightly-2024-06-10
Review Comment:
Oh, I get your point. So you mean to m
Xuanwo commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667358433
##
Makefile:
##
@@ -19,25 +19,31 @@
RUST_LOG = debug
+RUST_NIGHTLY_CHANNEL = nightly-2024-06-10
Review Comment:
Hi, my current plan is we have three rust ver
Xuanwo commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667358433
##
Makefile:
##
@@ -19,25 +19,31 @@
RUST_LOG = debug
+RUST_NIGHTLY_CHANNEL = nightly-2024-06-10
Review Comment:
Hi, my current plan is we have three rust ver
Xuanwo commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667358433
##
Makefile:
##
@@ -19,25 +19,31 @@
RUST_LOG = debug
+RUST_NIGHTLY_CHANNEL = nightly-2024-06-10
Review Comment:
Hi, my current plan is we have three rust ver
liurenjie1024 commented on issue #446:
URL: https://github.com/apache/iceberg-rust/issues/446#issuecomment-2211735938
> For a high-level project like `iceberg`, perhaps we could avoid using
`unsafe`?
I agree that we should avoid using `unsafe` as much as possible, but it's
possible t
liurenjie1024 commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667347496
##
Makefile:
##
@@ -19,25 +19,31 @@
RUST_LOG = debug
+RUST_NIGHTLY_CHANNEL = nightly-2024-06-10
Review Comment:
I have concerns about smiply using lat
vinjai commented on code in PR #871:
URL: https://github.com/apache/iceberg-python/pull/871#discussion_r1667347220
##
pyiceberg/utils/arrow_sorting.py:
##
@@ -0,0 +1,110 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.
vinjai commented on code in PR #871:
URL: https://github.com/apache/iceberg-python/pull/871#discussion_r1667347220
##
pyiceberg/utils/arrow_sorting.py:
##
@@ -0,0 +1,110 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.
Xuanwo commented on issue #446:
URL: https://github.com/apache/iceberg-rust/issues/446#issuecomment-2211732825
For a high-level project like `iceberg`, perhaps we could avoid using
`unsafe`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Xuanwo commented on issue #429:
URL: https://github.com/apache/iceberg-rust/issues/429#issuecomment-2211732637
> I think eventually we will reach feature parity as iceberg-java to
implement iceberg spec, but integration with engines with be different.
Oh, I see. I got your point. The
Xuanwo commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667345517
##
Makefile:
##
@@ -19,25 +19,31 @@
RUST_LOG = debug
+RUST_NIGHTLY_CHANNEL = nightly-2024-06-10
Review Comment:
> Do you mean to use nightly to build?
liurenjie1024 merged PR #442:
URL: https://github.com/apache/iceberg-rust/pull/442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
liurenjie1024 commented on code in PR #442:
URL: https://github.com/apache/iceberg-rust/pull/442#discussion_r1667343368
##
crates/iceberg/src/runtime/mod.rs:
##
@@ -26,6 +26,8 @@ pub enum JoinHandle {
Tokio(tokio::task::JoinHandle),
#[cfg(all(feature = "async-std", not
liurenjie1024 commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667342779
##
Makefile:
##
@@ -19,25 +19,31 @@
RUST_LOG = debug
+RUST_NIGHTLY_CHANNEL = nightly-2024-06-10
Review Comment:
Do you mean to use nightly to build?
Xuanwo commented on code in PR #442:
URL: https://github.com/apache/iceberg-rust/pull/442#discussion_r1667337816
##
crates/iceberg/src/runtime/mod.rs:
##
@@ -26,6 +26,8 @@ pub enum JoinHandle {
Tokio(tokio::task::JoinHandle),
#[cfg(all(feature = "async-std", not(featur
Xuanwo commented on code in PR #442:
URL: https://github.com/apache/iceberg-rust/pull/442#discussion_r1667337922
##
crates/iceberg/src/runtime/mod.rs:
##
@@ -39,6 +41,8 @@ impl Future for JoinHandle {
.map(|h| h.expect("tokio spawned task failed")),
Xuanwo commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667337567
##
Makefile:
##
@@ -19,25 +19,31 @@
RUST_LOG = debug
+RUST_NIGHTLY_CHANNEL = nightly-2024-06-10
Review Comment:
Hi, as I proposed in https://github.com/apach
Xuanwo commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667337567
##
Makefile:
##
@@ -19,25 +19,31 @@
RUST_LOG = debug
+RUST_NIGHTLY_CHANNEL = nightly-2024-06-10
Review Comment:
Hi, as I proposed in https://github.com/apach
Xuanwo commented on issue #429:
URL: https://github.com/apache/iceberg-rust/issues/429#issuecomment-2211718931
> Currently I have grouped features into these components in [this
project](https://github.com/orgs/apache/projects/339), so I'm not sure what
kinds of issue you want? Maybe you ca
liurenjie1024 commented on PR #441:
URL: https://github.com/apache/iceberg-rust/pull/441#issuecomment-2211710233
Also it would be better to run check for all oses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
raphaelauv commented on issue #10635:
URL: https://github.com/apache/iceberg/issues/10635#issuecomment-2211708390
hey @nastra, I do not have the time to contribute this feature right now,
thanks for the proposition :+1:
until , I'm sharring an inefficient and hacky bypass :sweat_smi
QuakeWang commented on PR #441:
URL: https://github.com/apache/iceberg-rust/pull/441#issuecomment-2211708342
> Thanks @QuakeWang for this pr, LGTM! But please don't modify publish.yml.
Okay, I will update it later. Thanks for your review~
--
This is an automated message from the Apa
liurenjie1024 commented on issue #440:
URL: https://github.com/apache/iceberg-rust/issues/440#issuecomment-2211707545
I'm happy to take this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
liurenjie1024 commented on code in PR #441:
URL: https://github.com/apache/iceberg-rust/pull/441#discussion_r1667328431
##
.github/workflows/publish.yml:
##
@@ -30,11 +30,14 @@ on:
jobs:
publish:
-runs-on: ubuntu-latest
+runs-on: ${{ matrix.os }}
Review Comment:
liurenjie1024 commented on code in PR #442:
URL: https://github.com/apache/iceberg-rust/pull/442#discussion_r1667328171
##
crates/iceberg/src/runtime/mod.rs:
##
@@ -67,6 +74,9 @@ where
#[cfg(all(feature = "async-std", not(feature = "tokio")))]
return JoinHandle::Asyn
vinjai commented on issue #306:
URL: https://github.com/apache/iceberg-python/issues/306#issuecomment-2211703159
@kevinjqliu @Fokko
I can take this forward if no one is actively working on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
liurenjie1024 merged PR #443:
URL: https://github.com/apache/iceberg-rust/pull/443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
liurenjie1024 closed issue #139: refactor: Remove `async_trait` in `Catalog`
trait.
URL: https://github.com/apache/iceberg-rust/issues/139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
liurenjie1024 closed issue #139: refactor: Remove `async_trait` in `Catalog`
trait.
URL: https://github.com/apache/iceberg-rust/issues/139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
liurenjie1024 commented on issue #139:
URL: https://github.com/apache/iceberg-rust/issues/139#issuecomment-2211701858
+1, we can close this first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
liurenjie1024 closed issue #127: Pruning data files according to index,
statistics when reading.
URL: https://github.com/apache/iceberg-rust/issues/127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
liurenjie1024 closed issue #126: Pruning partitions using filter when reading
file.
URL: https://github.com/apache/iceberg-rust/issues/126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
liurenjie1024 commented on issue #123:
URL: https://github.com/apache/iceberg-rust/issues/123#issuecomment-2211701608
> Is this tracking issue still relevant? Should we start a new one to better
reflect the current status?
Most of them are closed, but size based planning still not fin
liurenjie1024 closed issue #124: Add runtime module to enable concurrent load
of manifest files.
URL: https://github.com/apache/iceberg-rust/issues/124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
liurenjie1024 commented on issue #124:
URL: https://github.com/apache/iceberg-rust/issues/124#issuecomment-2211701240
Close by #233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
liurenjie1024 commented on PR #444:
URL: https://github.com/apache/iceberg-rust/pull/444#issuecomment-2211700081
Let's wait to see if @Fokko have any suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
liurenjie1024 commented on issue #429:
URL: https://github.com/apache/iceberg-rust/issues/429#issuecomment-2211699094
> Hi, @liurenjie1024, could you start a tracking issue for all features that
we lack compared to java impl?
It maybe hard to enumerate all features java provided, but
71 matches
Mail list logo
