Xuanwo commented on code in PR #442:
URL: https://github.com/apache/iceberg-rust/pull/442#discussion_r1667337922
##########
crates/iceberg/src/runtime/mod.rs:
##########
@@ -39,6 +41,8 @@ impl<T: Send + 'static> Future for JoinHandle<T> {
.map(|h| h.expect("tokio spawned task failed")),
#[cfg(all(feature = "async-std", not(feature = "tokio")))]
JoinHandle::AsyncStd(handle) => Pin::new(handle).poll(cx),
+ #[cfg(all(not(feature = "async-std"), not(feature = "tokio")))]
Review Comment:
Hi, which way does `above` refer to? This case returns `unimplemented` while
no runtime has been enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
