Xuanwo commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667600760
##########
.github/workflows/ci.yml:
##########
@@ -29,6 +29,10 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
cancel-in-progress: true
+env:
+ rust_nightly: "nightly-2024-06-10"
+ rust_min: "1.77.1"
Review Comment:
How about using `RUST_MSRV` for more clear?
##########
.github/workflows/ci.yml:
##########
@@ -29,6 +29,10 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
cancel-in-progress: true
+env:
+ rust_nightly: "nightly-2024-06-10"
Review Comment:
We don't need to specify this as we load rust-toolchain by default.
##########
.github/workflows/ci.yml:
##########
@@ -38,6 +42,25 @@ jobs:
- name: Check License Header
uses: apache/skywalking-eyes/header@v0.6.0
+ - name: Install Rust ${{ env.rust_nightly }}
+ uses: dtolnay/rust-toolchain@stable
+ with:
+ toolchain: ${{ env.rust_nightly }}
+
+ - name: Install cargo-sort
+ uses: baptiste0928/cargo-install@v3
Review Comment:
Does this action approved by the ASF?
##########
.github/workflows/publish.yml:
##########
@@ -42,6 +46,14 @@ jobs:
- "crates/catalog/rest"
steps:
- uses: actions/checkout@v4
+
+ - name: Install Rust ${{ env.rust_min }}
Review Comment:
The same.
##########
.github/workflows/ci.yml:
##########
@@ -61,14 +84,29 @@ jobs:
- windows-latest
steps:
- uses: actions/checkout@v4
+
+ - name: Install Rust ${{ env.rust_min }}
Review Comment:
`stable` always pre-install in CI, so we don't need to setup it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
