liurenjie1024 commented on code in PR #445: URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667347496
########## Makefile: ########## @@ -19,25 +19,31 @@ RUST_LOG = debug +RUST_NIGHTLY_CHANNEL = nightly-2024-06-10 Review Comment: I have concerns about smiply using latest stable rust. As a library which is dependent on by downstream, we need to carefully choose MSRV, so that we don't force downstream lib/apps to always upgrade to latest version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org