liurenjie1024 commented on code in PR #442:
URL: https://github.com/apache/iceberg-rust/pull/442#discussion_r1667328171
##########
crates/iceberg/src/runtime/mod.rs:
##########
@@ -67,6 +74,9 @@ where
#[cfg(all(feature = "async-std", not(feature = "tokio")))]
return JoinHandle::AsyncStd(async_std::task::spawn_blocking(f));
+
+ #[cfg(all(not(feature = "async-std"), not(feature = "tokio")))]
+ unimplemented!("no runtime has been enabled")
Review Comment:
Ditto.
##########
crates/iceberg/src/runtime/mod.rs:
##########
@@ -54,6 +58,9 @@ where
#[cfg(all(feature = "async-std", not(feature = "tokio")))]
return JoinHandle::AsyncStd(async_std::task::spawn(f));
+
+ #[cfg(all(not(feature = "async-std"), not(feature = "tokio")))]
Review Comment:
Ditto
##########
crates/iceberg/src/runtime/mod.rs:
##########
@@ -39,6 +41,8 @@ impl<T: Send + 'static> Future for JoinHandle<T> {
.map(|h| h.expect("tokio spawned task failed")),
#[cfg(all(feature = "async-std", not(feature = "tokio")))]
JoinHandle::AsyncStd(handle) => Pin::new(handle).poll(cx),
+ #[cfg(all(not(feature = "async-std"), not(feature = "tokio")))]
Review Comment:
Ditto for above
##########
crates/iceberg/src/runtime/mod.rs:
##########
@@ -26,6 +26,8 @@ pub enum JoinHandle<T> {
Tokio(tokio::task::JoinHandle<T>),
#[cfg(all(feature = "async-std", not(feature = "tokio")))]
Review Comment:
Should we change this to `#[cfg(features="async-std")]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
