Re: [PATCH] testsuite: Fix gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c

2023-10-02 Thread Christophe Lyon
ping? maybe this counts as obvious? On Thu, 14 Sept 2023 at 11:13, Christophe Lyon wrote: > ping? > > On Fri, 8 Sept 2023 at 10:43, Christophe Lyon > wrote: > >> The test was declaring 'int *carry;' and wrote to '*carry' without >> initializing &

Re: [PATCH 1/2] testsuite: Add and use thread_fence effective-target

2023-10-02 Thread Christophe Lyon
ping? On Sun, 10 Sept 2023 at 21:31, Christophe Lyon wrote: > Some targets like arm-eabi with newlib and default settings rely on > __sync_synchronize() to ensure synchronization. Newlib does not > implement it by default, to make users aware they have to take special > care. >

Re: [PATCH] __atomic_test_and_set: Fall back to library, not non-atomic code

2023-10-03 Thread Christophe Lyon
Hi! On Tue, 26 Sept 2023 at 16:34, Hans-Peter Nilsson wrote: > Tested cris-elf, native x86_64-pc-linux-gnu and arm-eabi. > > For arm-eabi, notably lacking any atomic support for the > default multilib, with --target_board=arm-sim it regressed > 29_atomics/atomic_flag/cons/value_init.cc with the

Re: [PATCH] __atomic_test_and_set: Fall back to library, not non-atomic code

2023-10-04 Thread Christophe Lyon
list > > > From: Christophe Lyon > > Date: Tue, 3 Oct 2023 18:06:21 +0200 > > > On Tue, 3 Oct 2023 at 17:16, Hans-Peter Nilsson wrote: > > > > > > From: Christophe Lyon > > > > Date: Tue, 3 Oct 2023 15:20:39 +0200 > > > &

Re: Ping: [PATCH v2 1/2] testsuite: Add dg-require-atomic-cmpxchg-word

2023-10-12 Thread Christophe Lyon
LGTM but I'm not a maintainer ;-) On Thu, 12 Oct 2023 at 04:21, Hans-Peter Nilsson wrote: > > Ping. > > > From: Hans-Peter Nilsson > > Date: Wed, 4 Oct 2023 19:04:55 +0200 > > > > > From: Hans-Peter Nilsson > > > Date: Wed, 4 Oct 2023 17:15:28 +0200 > > > > > New version coming up. > > > > Usin

Re: Ping: [PATCH v2 2/2] testsuite: Replace many dg-require-thread-fence with dg-require-atomic-cmpxchg-word

2023-10-12 Thread Christophe Lyon
LGTM but I'm not a maintainer ;-) On Thu, 12 Oct 2023 at 04:22, Hans-Peter Nilsson wrote: > > Ping. > > > From: Hans-Peter Nilsson > > Date: Wed, 4 Oct 2023 19:08:16 +0200 > > > > s/atomic-exchange/atomic-cmpxchg-word/g. > > Tested as v1. > > > > Ok to commit? > > -- >8 -- > > These tests actual

Re: [14/n] PR85694: Rework overwidening detection

2018-07-02 Thread Christophe Lyon
On Fri, 29 Jun 2018 at 13:36, Richard Sandiford wrote: > > Richard Sandiford writes: > > This patch is the main part of PR85694. The aim is to recognise at least: > > > > signed char *a, *b, *c; > > ... > > for (int i = 0; i < 2048; i++) > > c[i] = (a[i] + b[i]) >> 1; > > > > as an ove

Re: [patch] jump threading multiple paths that start from the same BB

2018-07-02 Thread Christophe Lyon
On Sun, 1 Jul 2018 at 12:56, Aldy Hernandez wrote: > > > > On 06/29/2018 02:50 PM, Jeff Law wrote: > > [ Returning to another old patch... ] > > > > On 11/07/2017 10:33 AM, Aldy Hernandez wrote: > >> [One more time, but without rejected HTML mail, because apparently this > >> is my first post to g

Re: [PATCH][arm] Avoid STRD with odd register for TARGET_ARM in output_move_double

2018-07-02 Thread Christophe Lyon
config/arm/arm.c (output_move_double): Don't allow STRD instructions > if starting source register is not even. > > 2018-06-29 Kyrylo Tkachov > > * gcc.target/arm/arm-soft-strd-even.c: New test. gcc/testsuite/ChangeLog: 2018-07-02 Christophe Lyon * gc

Re: [PATCH] -fopt-info: add indentation via DUMP_VECT_SCOPE

2018-07-02 Thread Christophe Lyon
; > +#define AUTO_DUMP_SCOPE(NAME, LOC) \ > > + auto_dump_scope scope (NAME, LOC) > > + > > namespace gcc { > > > > class dump_manager > > diff --git a/gcc/tree-vectorizer.h b/gcc/tree-vectorizer.h > > index 94a0f38..a8406b3 100644 > > --- a/gcc/tree-vectorizer.h > > +++ b/gcc/tr

Re: [14/n] PR85694: Rework overwidening detection

2018-07-02 Thread Christophe Lyon
On Mon, 2 Jul 2018 at 15:37, Richard Sandiford wrote: > > Christophe Lyon writes: > > On Fri, 29 Jun 2018 at 13:36, Richard Sandiford > > wrote: > >> > >> Richard Sandiford writes: > >> > This patch is the main part of PR85694. The aim is to re

Re: [PATCH] -fopt-info: add indentation via DUMP_VECT_SCOPE

2018-07-02 Thread Christophe Lyon
On Mon, 2 Jul 2018 at 19:00, David Malcolm wrote: > > On Mon, 2018-07-02 at 14:23 +0200, Christophe Lyon wrote: > > On Fri, 29 Jun 2018 at 10:09, Richard Biener > com> wrote: > > > > > > On Tue, Jun 26, 2018 at 5:43 PM David Malcolm > > > wrote:

Re: [14/n] PR85694: Rework overwidening detection

2018-07-03 Thread Christophe Lyon
On Tue, 3 Jul 2018 at 12:02, Richard Sandiford wrote: > > Richard Biener writes: > > On Fri, Jun 29, 2018 at 1:36 PM Richard Sandiford > > wrote: > >> > >> Richard Sandiford writes: > >> > This patch is the main part of PR85694. The aim is to recognise at > >> > least: > >> > > >> > signed

Re: [PATCH] relax lower bound for infinite arguments in gimple-ssa-sprinf.c (PR 86274)

2018-07-04 Thread Christophe Lyon
Hi, On Wed, 4 Jul 2018 at 09:26, Richard Biener wrote: > > On Tue, 3 Jul 2018, Martin Sebor wrote: > > > Committed to trunk in r86274. Jakub/Richard, can you please > > also review and approve the corresponding fix for the release > > branches? > > If it is a regression and the patch was approve

Re: [PATCH] Add experimental::sample and experimental::shuffle from N4531

2018-07-05 Thread Christophe Lyon
On Wed, 4 Jul 2018 at 18:56, Jonathan Wakely wrote: > > On 29/06/18 10:45 +0100, Jonathan Wakely wrote: > >On 29/06/18 09:39 +0200, Christophe Lyon wrote: > >>On Fri, 29 Jun 2018 at 09:21, Jonathan Wakely wrote: > >>> > >>>On 29/06/18 08:55 +0200, Chr

Re: [PATCH] -fopt-info: add indentation via DUMP_VECT_SCOPE

2018-07-05 Thread Christophe Lyon
; > > > > > On Mon, 2018-07-02 at 14:23 +0200, Christophe Lyon wrote: > > > > > On Fri, 29 Jun 2018 at 10:09, Richard Biener > > > > ail. > > > > > com> wrote: > > > > > > > > > > > > On Tue, Jun 26, 2018 at 5:43

Re: [PATCH][GCC][AArch64] Simplify movmem code by always doing overlapping copies when larger than 8 bytes.

2018-07-06 Thread Christophe Lyon
Hi Tamar, On Tue, 3 Jul 2018 at 19:13, James Greenhalgh wrote: > > On Tue, Jun 19, 2018 at 09:09:27AM -0500, Tamar Christina wrote: > > Hi All, > > > > OK. > > Thanks, > James > > > Thanks, > > Tamar > > > > gcc/ > > 2018-06-19 Tamar Christina > > > > * config/aarch64/aarch64.c (aarch64

Re: [PATCH][GCC][ARM] Fix can_change_mode_class for big-endian

2018-07-06 Thread Christophe Lyon
Hi Tamar, On Wed, 20 Jun 2018 at 15:35, Kyrill Tkachov wrote: > > > On 20/06/18 11:33, Tamar Christina wrote: > > Hi Kyrill, > > > > Many thanks for the review! > > > > The 06/20/2018 09:43, Kyrill Tkachov wrote: > >> Hi Tamar, > >> > >> On 19/06/18 15:14, Tamar Christina wrote: > >>> Hi All, > >

Re: [PATCH][GCC][mid-end] Correct subreg no-op handling for big-endian vec_select.

2018-07-06 Thread Christophe Lyon
On Thu, 28 Jun 2018 at 05:11, Jeff Law wrote: > > On 06/19/2018 08:11 AM, Tamar Christina wrote: > > Hi All, > > > > Previously GCC's no-op detection could would consider something a no-op > > even when the > > mode change is not directly possible. This caused subregs that shouldn't > > be remo

Re: [committed][aarch64][gcc][patch] Fix -Wpedantic issue with testcase.

2018-07-06 Thread Christophe Lyon
On Fri, 6 Jul 2018 at 13:56, Ramana Radhakrishnan wrote: > > On Fri, Jul 6, 2018 at 10:16 AM, Tamar Christina > wrote: > > Hi All, > > > > This fixes a -Wpedantic error with the testcase because of extra ; left > > after the > > functions. > > > > Regtested single test on aarch64-none-elf and no

Re: [committed] [PR tree-optimization/86010] More aggressively trim partially dead mem* and str* calls

2018-07-06 Thread Christophe Lyon
Hi Jeff, On Fri, 6 Jul 2018 at 05:44, Jeff Law wrote: > > As noted in BZ 86010 we can be more aggressive when trimming tails of > mem* or str* calls in gimple DSE since trimming a tail doesn't affect > alignment and residuals are usually handled pretty efficiently in libc. > > Additionally, if th

Re: [PATCH] Remove "note: " prefix from some scan-tree-dump directives

2018-07-09 Thread Christophe Lyon
t; > > > On Tue, 2018-07-03 at 09:37 +0200, Richard Biener wrote: > > > > > On Mon, Jul 2, 2018 at 7:00 PM David Malcolm > > > > > > > > > > wrote: > > > > > > > > > > > > On Mon, 2018-07-02 at 14:23 +0200, Ch

[contrib] compare_tests: Print number of tests

2018-07-12 Thread Christophe Lyon
Hi, It can be useful to print the number of tests in each category, eg: Tests that now work, but didn't before (65 tests): instead of Tests that now work, but didn't before: This small patch does that. OK? Thanks, Christophe contrib/ChangeLog: 2018-07-12 Chris

Re: [PATCH] reject conflicting attributes before calling handlers (PR 86453)

2018-07-13 Thread Christophe Lyon
Hi, On Thu, 12 Jul 2018 at 00:04, Martin Sebor wrote: > > The attached change set adjusts the attribute exclusion code > to detect and reject incompatible attributes before attribute > handlers are called to have a chance to make changes despite > the exclusions. The handlers are not run when a

Re: [PATCH] reject conflicting attributes before calling handlers (PR 86453)

2018-07-13 Thread Christophe Lyon
On Fri, 13 Jul 2018 at 17:10, Martin Sebor wrote: > > On 07/13/2018 02:53 AM, Christophe Lyon wrote: > > Hi, > > > > On Thu, 12 Jul 2018 at 00:04, Martin Sebor wrote: > >> > >> The attached change set adjusts the attribute exclusion code > >>

[OBVIOUS][ARM][libgcc] Fix comment for code working on architectures >= 4

2018-07-30 Thread Christophe Lyon
Hi, In r261840 I added an inaccurate comment: the code works on architectures >= 4, not > 4. I committed this obvious fix as r263066: 2018-07-30 Christophe Lyon * config/arm/ieee754-df.S: Fix comment for code working on architectures >= 4. * config/arm/iee

Re: [PATCH][GCC][AARCH64] Canonicalize aarch64 widening simd plus insns

2018-07-30 Thread Christophe Lyon
Hi, On Tue, 24 Jul 2018 at 17:39, Kyrill Tkachov wrote: > > > On 24/07/18 16:12, James Greenhalgh wrote: > > On Thu, Jul 19, 2018 at 07:35:22AM -0500, Matthew Malcomson wrote: > > > Hi again. > > > > > > Providing an updated patch to include the formatting suggestions. > > > > Please try not to t

Re: [PATCH][Middle-end] disable strcmp/strncmp inlining with O2 below and Os

2018-07-30 Thread Christophe Lyon
On Wed, 25 Jul 2018 at 19:08, Qing Zhao wrote: > > Hi, > > As Wilco suggested, the new added strcmp/strncmp inlining should be only > enabled with O2 and above. > > this is the simple patch for this change. > > tested on both X86 and aarch64. > > Okay for thunk? > > Qing > > gcc/ChangeLog: > > +2

Re: [PATCH] combine: Allow combining two insns to two insns

2018-07-31 Thread Christophe Lyon
On Mon, 30 Jul 2018 at 18:09, Segher Boessenkool wrote: > > On Tue, Jul 24, 2018 at 05:18:41PM +, Segher Boessenkool wrote: > > This patch allows combine to combine two insns into two. This helps > > in many cases, by reducing instruction path length, and also allowing > > further combination

Re: [PATCH] combine: Allow combining two insns to two insns

2018-08-01 Thread Christophe Lyon
On Tue, 31 Jul 2018 at 15:57, Segher Boessenkool wrote: > > Hi Christophe, > > On Tue, Jul 31, 2018 at 02:34:06PM +0200, Christophe Lyon wrote: > > Since this was committed, I've noticed regressions > > on aarch64: > > FAIL: gcc.dg/zero_bits_compound-1.c scan-

Re: [PATCH] combine: Allow combining two insns to two insns

2018-08-01 Thread Christophe Lyon
On Wed, 1 Aug 2018 at 11:40, Segher Boessenkool wrote: > > On Wed, Aug 01, 2018 at 10:27:31AM +0200, Christophe Lyon wrote: > > On Tue, 31 Jul 2018 at 15:57, Segher Boessenkool > > wrote: > > > On Tue, Jul 31, 2018 at 02:34:06PM +0200, Christophe Lyon wrote: >

Re: [PATCH 1/2] testsuite: Add and use thread_fence effective-target

2023-10-24 Thread Christophe Lyon
Ping? Le lun. 2 oct. 2023, 10:24, Christophe Lyon a écrit : > ping? > > On Sun, 10 Sept 2023 at 21:31, Christophe Lyon > wrote: > >> Some targets like arm-eabi with newlib and default settings rely on >> __sync_synchronize() to ensure synchronization. Newlib

Re: [PATCH] testsuite: Fix gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c

2023-10-24 Thread Christophe Lyon
Ping? Le lun. 2 oct. 2023, 10:23, Christophe Lyon a écrit : > ping? maybe this counts as obvious? > > > On Thu, 14 Sept 2023 at 11:13, Christophe Lyon > wrote: > >> ping? >> >> On Fri, 8 Sept 2023 at 10:43, Christophe Lyon >> wrote: >> >&

Re: [PATCH] libcpp: Improve the diagnostic for poisoned identifiers [PR36887]

2023-10-26 Thread Christophe Lyon
Hi! On Wed, 20 Sept 2023 at 06:12, Lewis Hyatt wrote: > > Hello- > > This patch implements the PR's request to add more information to the > diagnostic issued for using a poisoned identifier. Bootstrapped + regtested > all languages on x86-64 Linux. Does it look OK please? Thanks! > > -Lewis > >

Re: [PATCH] libcpp: Improve the diagnostic for poisoned identifiers [PR36887]

2023-10-26 Thread Christophe Lyon
On Thu, 26 Oct 2023 at 18:18, Lewis Hyatt wrote: > > On Thu, Oct 26, 2023 at 4:49 AM Christophe Lyon > wrote: > > We have noticed that the new tests fail on aarch64 with: > > .../aarch64-unknown-linux-gnu/libc/usr/lib/crt1.o: in function `_start': > > .../sysdeps

Re: [PATCH] libcpp: Improve the diagnostic for poisoned identifiers [PR36887]

2023-10-26 Thread Christophe Lyon
On Thu, 26 Oct 2023 at 19:44, Lewis Hyatt wrote: > > On Thu, Oct 26, 2023 at 12:48 PM Christophe Lyon > wrote: > > > > On Thu, 26 Oct 2023 at 18:18, Lewis Hyatt wrote: > > > > > > On Thu, Oct 26, 2023 at 4:49 AM Christophe Lyon > > > wrote: &g

Re: [pushed] [RA]: Modify cost calculation for dealing with pseudo equivalences

2023-10-27 Thread Christophe Lyon
Hi Vladimir, On Thu, 26 Oct 2023 at 16:00, Vladimir Makarov wrote: > > This is the second attempt to improve RA cost calculation for pseudos > with equivalences. The patch explanation is in the log message. > > The patch was successfully bootstrapped and tested on x86-64, aarch64, > and ppc64le.

Re: [pushed] [RA]: Modify cost calculation for dealing with pseudo equivalences

2023-10-27 Thread Christophe Lyon
On Fri, 27 Oct 2023 at 16:19, Vladimir Makarov wrote: > > > On 10/27/23 09:56, Christophe Lyon wrote: > > Hi Vladimir, > > > > On Thu, 26 Oct 2023 at 16:00, Vladimir Makarov > > wrote: > >> This is the second attempt to improve RA cost calculation for

[PATCH] testsuite: Force use of -c when precompiling headers

2023-10-27 Thread Christophe Lyon
he linker. Arguably, this could be seen as a dejagnu bug: in gcc-dg-test-1 (in gcc-dg.exp), we set compile_type to "precompiled_header", which is not one of the supported values in dejagnu's default_target_compile (in target.exp). 2023-10-27 Christophe Lyon gcc/testsuite/

Re: [PATCH 00/29] [arm] Rewrite DImode arithmetic support

2019-10-23 Thread Christophe Lyon
On 21/10/2019 14:24, Richard Earnshaw (lists) wrote: On 21/10/2019 12:51, Christophe Lyon wrote: On 18/10/2019 21:48, Richard Earnshaw wrote: Each patch should produce a working compiler (it did when it was originally written), though since the patch set has been re-ordered slightly there is a

Re: [PATCH 00/29] [arm] Rewrite DImode arithmetic support

2019-10-24 Thread Christophe Lyon
On 23/10/2019 15:21, Richard Earnshaw (lists) wrote: On 23/10/2019 09:28, Christophe Lyon wrote: On 21/10/2019 14:24, Richard Earnshaw (lists) wrote: On 21/10/2019 12:51, Christophe Lyon wrote: On 18/10/2019 21:48, Richard Earnshaw wrote: Each patch should produce a working compiler (it did

Re: [PATCH 00/29] [arm] Rewrite DImode arithmetic support

2019-10-25 Thread Christophe Lyon
On Fri, 25 Oct 2019 at 12:08, Richard Earnshaw (lists) wrote: > > On 24/10/2019 17:10, Richard Earnshaw (lists) wrote: > > On 24/10/2019 11:16, Christophe Lyon wrote: > >> On 23/10/2019 15:21, Richard Earnshaw (lists) wrote: > >>> On 23/10/2019 09:28, Christophe

Re: [PATCH 1/2] [ARM,testsuite] Skip tests incompatible with -mpure-code

2019-11-03 Thread Christophe Lyon
Ping? https://gcc.gnu.org/ml/gcc-patches/2019-10/msg01357.html On Fri, 18 Oct 2019 at 15:18, Christophe Lyon wrote: > > Hi, > > All these tests fail when using -mpure-code: > * some force A or R profile > * some use Neon > * some use -fpic/-fPIC > all of which are not

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-11-03 Thread Christophe Lyon
Ping? https://gcc.gnu.org/ml/gcc-patches/2019-10/msg01356.html On Fri, 18 Oct 2019 at 15:18, Christophe Lyon wrote: > > Hi, > > This patch extends support for -mpure-code to all thumb-1 processors, > by removing the need for MOVT. > > Symbol addresses are built usin

Re: PR92163

2019-11-04 Thread Christophe Lyon
On Mon, 28 Oct 2019 at 16:03, Prathamesh Kulkarni wrote: > > On Mon, 28 Oct 2019 at 07:18, Richard Biener > wrote: > > > > On Fri, Oct 25, 2019 at 9:58 PM Prathamesh Kulkarni > > wrote: > > > > > > On Fri, 25 Oct 2019 at 13:19, Richard Biener > > > wrote: > > > > > > > > On Wed, Oct 23, 2019

Re: PR92163

2019-11-05 Thread Christophe Lyon
On Tue, 5 Nov 2019 at 05:46, Prathamesh Kulkarni wrote: > > On Mon, 4 Nov 2019 at 18:37, Christophe Lyon > wrote: > > > > On Mon, 28 Oct 2019 at 16:03, Prathamesh Kulkarni > > wrote: > > > > > > On Mon, 28 Oct 2019 at 07:18, Richard Biener > &g

Re: [PATCH 1/2] [ARM,testsuite] Skip tests incompatible with -mpure-code

2019-11-05 Thread Christophe Lyon
On Mon, 4 Nov 2019 at 17:54, Kyrill Tkachov wrote: > > Hi Christophe, > > On 10/18/19 2:18 PM, Christophe Lyon wrote: > > Hi, > > > > All these tests fail when using -mpure-code: > > * some force A or R profile > > * some use Neon > > * some use -

Re: [committed] Handle POLY_INT_CST in copy_reference_ops_from_ref

2019-11-10 Thread Christophe Lyon
On Fri, 8 Nov 2019 at 10:44, Richard Sandiford wrote: > > Tested on aarch64-linux-gnu and x86_64-linux-gnu. Applied as obvious. > Hi Richard, The new deref_2.c test fails with -mabi=ilp32: FAIL: gcc.target/aarch64/sve/acle/general/deref_2.c -march=armv8.2-a+sve (test for excess errors) Excess e

Re: [PATCH] Handle gimple_clobber_p stmts in store-merging (PR target/92038)

2019-11-10 Thread Christophe Lyon
On Thu, 7 Nov 2019 at 16:28, Jakub Jelinek wrote: > > Hi! > > The following patch adds handling of clobbers in store-merging. The intent > is if we have a clobber followed by some stores into the clobbered area, > even if don't store all the bytes in the area, we can avoid masking, because > the

Re: [PATCH] Fix PR92324

2019-11-11 Thread Christophe Lyon
On Fri, 8 Nov 2019 at 09:57, Richard Biener wrote: > > > I've been sitting on this for a few days since I'm not 100% happy > with how the code looks like. There's possibly still holes in it > (chains with mixed signed/unsigned adds for example might pick > up signed adds in the epilogue), but the

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-11-12 Thread Christophe Lyon
ping^2 ? On Sun, 3 Nov 2019 at 16:07, Christophe Lyon wrote: > > Ping? > > https://gcc.gnu.org/ml/gcc-patches/2019-10/msg01356.html > > On Fri, 18 Oct 2019 at 15:18, Christophe Lyon > wrote: > > > > Hi, > > > > This patch extends support for

Re: [PATCH] Fix PR92324

2019-11-12 Thread Christophe Lyon
On Mon, 11 Nov 2019 at 14:36, Richard Biener wrote: > > On Mon, 11 Nov 2019, Christophe Lyon wrote: > > > On Fri, 8 Nov 2019 at 09:57, Richard Biener wrote: > > > > > > > > > I've been sitting on this for a few days since I'm not 100% happy &

Re: [PATCH][arm][1/X] Add initial support for saturation intrinsics

2019-11-12 Thread Christophe Lyon
On Thu, 7 Nov 2019 at 11:26, Kyrill Tkachov wrote: > > Hi all, > > This patch adds the plumbing for and an implementation of the saturation > intrinsics from ACLE [1], in particular the __ssat, __usat intrinsics. > These intrinsics set the Q sticky bit in APSR if an overflow occurred. > ACLE allow

Re: [PATCH][arm][2/X] Implement __qadd, __qsub, __qdbl intrinsics

2019-11-12 Thread Christophe Lyon
On Thu, 7 Nov 2019 at 11:27, Kyrill Tkachov wrote: > > Hi all, > > This patch implements some more Q-bit-setting intrinsics from ACLE. > With the plumbing from patch 1 in place they are a simple builtin->RTL > affair. > > Bootstrapped and tested on arm-none-linux-gnueabihf. > > Committing to trunk

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-11-13 Thread Christophe Lyon
Hi Kyrill, On Tue, 12 Nov 2019 at 11:34, Kyrill Tkachov wrote: > > Hi Christophe, > > On 10/18/19 2:18 PM, Christophe Lyon wrote: > > Hi, > > > > This patch extends support for -mpure-code to all thumb-1 processors, > > by removing the need for MOVT. >

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-11-13 Thread Christophe Lyon
On Tue, 12 Nov 2019 at 12:13, Richard Earnshaw (lists) wrote: > > On 18/10/2019 14:18, Christophe Lyon wrote: > > + bool not_supported = arm_arch_notm || flag_pic || TARGET_NEON; > > > > This is a poor name in the context of the function as a whole. What's >

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-11-13 Thread Christophe Lyon
On Tue, 12 Nov 2019 at 12:17, Richard Earnshaw (lists) wrote: > > On 18/10/2019 14:18, Christophe Lyon wrote: > > +thumb1_gen_const_int (rtx op0, HOST_WIDE_INT op1) > > +{ > > + bool mov_done_p = false; > > + int i; > > + > > + /* Emit upper 3 bytes

Re: [ PATCH ] [ C++ ] Implementing P0767 - deprecate POD

2020-01-10 Thread Christophe Lyon
Hi, On Thu, 9 Jan 2020 at 22:21, Jonathan Wakely wrote: > > On 09/01/20 19:57 +, Jonathan Wakely wrote: > >I'll commit the attached patch after more testing. > > And this follow-up to fix some fallout. > I have noticed: FAIL: g++:g++.dg/cpp0x/std-layout1.C -std=c++2a (test for excess errors

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2020-01-14 Thread Christophe Lyon
On Mon, 13 Jan 2020 at 14:49, Kyrill Tkachov wrote: > > Hi Christophe, > > On 12/17/19 3:31 PM, Kyrill Tkachov wrote: > > > > On 12/17/19 2:33 PM, Christophe Lyon wrote: > >> On Tue, 17 Dec 2019 at 11:34, Kyrill Tkachov > >> wrote: > >>> Hi C

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2020-01-14 Thread Christophe Lyon
On Tue, 14 Jan 2020 at 14:54, Kyrill Tkachov wrote: > > > On 1/14/20 1:50 PM, Christophe Lyon wrote: > > On Mon, 13 Jan 2020 at 14:49, Kyrill Tkachov > > wrote: > >> Hi Christophe, > >> > >> On 12/17/19 3:31 PM, Kyrill Tkachov wrote: > >&g

Re: [PATCH v7] Missed function specialization + partial devirtualization

2020-01-15 Thread Christophe Lyon
Hi, On Tue, 14 Jan 2020 at 15:35, luoxhu wrote: > > Hi, > > On 2020/1/14 21:03, Martin Liška wrote: > > On 1/13/20 4:23 AM, luoxhu wrote: > >> Thanks a lot! Rebased & updated, will commit below patch shortly when > >> git push is ready. > > > > Hello. > > > > I'm pretty sure the patch contains

Re: [GCC][PATCH][ARM] Add Bfloat16_t scalar type, vector types and machine modes to ARM back-end [1/2]

2020-01-20 Thread Christophe Lyon
Hi, On Thu, 16 Jan 2020 at 16:59, Stam Markianos-Wright wrote: > > > > On 1/13/20 10:05 AM, Kyrill Tkachov wrote: > > Hi Stam, > > > > On 1/10/20 6:45 PM, Stam Markianos-Wright wrote: > >> Hi all, > >> > >> This is a respin of patch: > >> > >> https://gcc.gnu.org/ml/gcc-patches/2019-12/msg01448.

Re: [PATCH, GCC/ARM, 1/2] Add support for ASRL(reg) and LSLL(reg) instructions for Armv8.1-M Mainline

2020-01-20 Thread Christophe Lyon
On Thu, 14 Nov 2019 at 15:19, Mihail Ionescu wrote: > > Hi, > > This patch adds the new scalar shift instructions for Armv8.1-M > Mainline to the arm backend. > This patch is adding the following instructions: > > ASRL (reg) > LSLL (reg) > > > ChangeLog entry are as follow: > > *** gcc/ChangeLog *

Re: [PATCH, GCC/ARM, 2/2] Add support for ASRL(imm), LSLL(imm) and LSRL(imm) instructions for Armv8.1-M Mainline

2020-01-20 Thread Christophe Lyon
On Thu, 14 Nov 2019 at 15:19, Mihail Ionescu wrote: > > Hi, > > This is part of a series of patches where I am trying to add new > instructions for Armv8.1-M Mainline to the arm backend. > This patch is adding the following instructions: > > ASRL (imm) > LSLL (imm) > LSRL (imm) > > > ChangeLog ent

Re: [Patch] [AArch64] [SVE] Implement svld1ro intrinsic.

2020-01-20 Thread Christophe Lyon
On Thu, 9 Jan 2020 at 16:53, Matthew Malcomson wrote: > > We take no action to ensure the SVE vector size is large enough. It is > left to the user to check that before compiling this intrinsic or before > running such a program on a machine. > > The main difference between ld1ro and ld1rq is in

Re: [GCC][PATCH][ARM] Add Bfloat16_t scalar type, vector types and machine modes to ARM back-end [1/2]

2020-01-20 Thread Christophe Lyon
On Mon, 20 Jan 2020 at 16:02, Stam Markianos-Wright wrote: > > > > On 1/20/20 1:07 PM, Christophe Lyon wrote: > > Hi, > > > > > > On Thu, 16 Jan 2020 at 16:59, Stam Markianos-Wright > > wrote: > >> > >> > >> > >> On 1

Re: [PATCH, GCC/ARM] Fix MVE scalar shift tests

2020-01-23 Thread Christophe Lyon
On Mon, 20 Jan 2020 at 19:01, Mihail Ionescu wrote: > > Hi, > > This patch fixes the scalar shifts tests added in: > https://gcc.gnu.org/ml/gcc-patches/2019-11/msg01195.html > https://gcc.gnu.org/ml/gcc-patches/2019-11/msg01196.html > By adding mthumb and ensuring that the target supports > thumb2

Re: [PATCH] debug/92763 keep DIEs that might be used in DW_TAG_inlined_subroutine

2020-01-24 Thread Christophe Lyon
t; PR debug/92763 > > * dwarf2out.c (prune_unused_types): Unconditionally mark > > called function DIEs. > > > > * g++.dg/debug/pr92763.C: New testcase. > > Ok. > Hi, I have committed that attached patch as obvious: it requires the fopenmp ef

Re: [GCC][PATCH][ARM] Set profile to M for Armv8.1-M

2020-02-04 Thread Christophe Lyon
On Mon, 3 Feb 2020 at 18:20, Mihail Ionescu wrote: > > Hi, > > We noticed that the profile for armv8.1-m.main was not set in arm-cpus.in > , which led to TARGET_ARM_ARCH_PROFILE and _ARM_ARCH_PROFILE not being > defined properly. > > > > gcc/ChangeLog: > > 2020-02-03 Mihail Ionescu > >

[ARM] Fix -mpure-code for v6m

2020-02-07 Thread Christophe Lyon
isable_literal_pool && GET_CODE (operands[1]) == SYMBOL_REF" [(clobber (const_int 0))] " gen_thumb1_movsi_symbol_ref(operands[0], operands[1]); DONE; " ) and I put this in thumb1_movsi_insn: if (GET_CODE (operands[1]) == SYMBOL_REF && arm_disable_literal_pool) { return

Re: [ARM] Fix -mpure-code for v6m

2020-02-07 Thread Christophe Lyon
On Fri, 7 Feb 2020 at 14:49, Richard Earnshaw (lists) wrote: > > On 07/02/2020 13:19, Christophe Lyon wrote: > > When running the testsuite with -fdisable-rtl-fwprop2 and -mpure-code > > for cortex-m0, I noticed that some testcases were failing because we > > still genera

Re: [ARM] Fix -mpure-code for v6m

2020-02-10 Thread Christophe Lyon
On Fri, 7 Feb 2020 at 17:55, Richard Earnshaw (lists) wrote: > > On 07/02/2020 16:43, Christophe Lyon wrote: > > On Fri, 7 Feb 2020 at 14:49, Richard Earnshaw (lists) > > wrote: > >> > >> On 07/02/2020 13:19, Christophe Lyon wrote: > >>> When runn

Re: [PATCH] arm: Fix up arm installed unwind.h for use in pedantic modes [PR93615]

2020-02-10 Thread Christophe Lyon
.dg/pr93615.c: New test. > This broke the build of GCC for the arm-none-uclinuxfdpiceabi target (FDPIC). The attached patch fixes this by updating other uses of gnu_Unwind_Find_got. OK? Thanks, Christophe >From 667227c7d3d5c3e471be02adc0ce7dc2c4ebfd25 Mon Sep 17 00:00:00 2001 From: C

Re: [COMMITTED] c++: Fix ICE on nonsense requires-clause.

2020-02-10 Thread Christophe Lyon
On Fri, 7 Feb 2020 at 14:54, Jason Merrill wrote: > > Here we were swallowing all the syntax errors by parsing tentatively, and > returning error_mark_node without ever actually giving an error. Fixed by > using save_tokens/rollback_tokens instead. > > Tested x86_64-pc-linux-gnu, applying to trun

Re: [FYI] Patches that fix testing santiziers with qemu user mode

2020-02-10 Thread Christophe Lyon
Hi Andrew, On Sat, 8 Feb 2020 at 10:16, Andrew Pinski wrote: > > Hi, > These two patches are what I use to fix testing of the santizers > with qemu. The first one disables coloring always as for some reason > when running with qemu (but not normally), coloring is detected. I > have not gone

Re: [PATCH] arm: Fix up arm installed unwind.h for use in pedantic modes [PR93615]

2020-02-10 Thread Christophe Lyon
On Mon, 10 Feb 2020 at 14:26, Jakub Jelinek wrote: > > On Mon, Feb 10, 2020 at 02:03:47PM +0100, Christophe Lyon wrote: > > > 2020-02-07 Jakub Jelinek > > > > > > PR target/93615 > > > * config/arm/unw

Re: [COMMITTED] c++: Fix ICE on nonsense requires-clause.

2020-02-10 Thread Christophe Lyon
On Mon, 10 Feb 2020 at 14:53, Jason Merrill wrote: > > On Mon, Feb 10, 2020 at 2:13 PM Christophe Lyon > wrote: >> >> On Fri, 7 Feb 2020 at 14:54, Jason Merrill wrote: >> > >> > Here we were swallowing all the syntax errors by parsing tentatively, and

Re: [ARM] Fix -mpure-code for v6m

2020-02-13 Thread Christophe Lyon
On Mon, 10 Feb 2020 at 17:45, Richard Earnshaw (lists) wrote: > > On 10/02/2020 09:27, Christophe Lyon wrote: > > On Fri, 7 Feb 2020 at 17:55, Richard Earnshaw (lists) > > wrote: > >> > >> On 07/02/2020 16:43, Christophe Lyon wrote: > >>> On F

Re: [PATCH 4/4]: C++ P1423R3 char8_t remediation: New tests

2019-12-05 Thread Christophe Lyon
On Tue, 3 Dec 2019 at 10:16, Jonathan Wakely wrote: > > On 03/12/19 09:11 +0100, Christophe Lyon wrote: > >On Mon, 16 Sep 2019 at 04:34, Tom Honermann wrote: > >> > >> A revised patch is attached that modifies the tests for deleted ostream > >> inserters

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-12-05 Thread Christophe Lyon
ping? https://gcc.gnu.org/ml/gcc-patches/2019-11/msg01667.html Kyrill approved the previous version modulo a typo fix, but Richard wanted a better name for a variable. Is that version OK? Thanks, Christophe On Tue, 26 Nov 2019 at 16:29, Christophe Lyon wrote: > > ping? > > On

Re: [PATCH] Revert to uniform vector CTOR canonicalization

2019-12-05 Thread Christophe Lyon
Hi, On Tue, 3 Dec 2019 at 15:46, Richard Biener wrote: > > > The PR shows I added the bail-out prematurely. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. > > Richard. > > 2019-12-03 Richard Biener > > PR tree-optimization/92758 > * tree-ssa-forwprop.c (simp

Re: [PATCH] Revert to uniform vector CTOR canonicalization

2019-12-05 Thread Christophe Lyon
On Thu, 5 Dec 2019 at 12:59, Richard Biener wrote: > > On Thu, 5 Dec 2019, Christophe Lyon wrote: > > > Hi, > > > > > > On Tue, 3 Dec 2019 at 15:46, Richard Biener wrote: > > > > > > > > > The PR shows I added the bail-out prematurely.

Re: [PATCH 4/4]: C++ P1423R3 char8_t remediation: New tests

2019-12-05 Thread Christophe Lyon
On Thu, 5 Dec 2019 at 12:43, Jonathan Wakely wrote: > > On 05/12/19 09:00 +0100, Christophe Lyon wrote: > >On Tue, 3 Dec 2019 at 10:16, Jonathan Wakely wrote: > >> > >> On 03/12/19 09:11 +0100, Christophe Lyon wrote: > >> >On Mon, 16 Sep 2019 at 04:3

Re: [PATCH v2 2/2][ARM] Improve max_cond_insns setting for Cortex cores

2019-12-06 Thread Christophe Lyon
On Tue, 3 Dec 2019 at 14:45, Wilco Dijkstra wrote: > > Hi, > > Part 2, split off from > https://gcc.gnu.org/ml/gcc-patches/2019-11/msg00399.html > > To enable cores to use the correct max_cond_insns setting, use the > core-specific > tuning when a CPU/tune is selected unless -mrestrict-it is exp

[committed][testsuite][aarch64] type_redef_11.c: Update expected diagnostics.

2019-12-06 Thread Christophe Lyon
Hi, After the fix for PR c/36941 and PR c/88827 (r278976), this test emits a different error message and needs an update. I've committed this as r279039. Christophe 2019-12-06 Christophe Lyon PR c/36941 PR c/88827 * gcc.target/aarch64/sve/acle/gene

Re: [PATCH v2 2/2][ARM] Improve max_cond_insns setting for Cortex cores

2019-12-06 Thread Christophe Lyon
On Fri, 6 Dec 2019 at 11:47, Wilco Dijkstra wrote: > > Hi Christophe, > > > This patch (r278968) is causing regressions when building GCC > > --target arm-none-linux-gnueabihf > > --with-mode thumb > > --with-cpu cortex-a57 > > --with-fpu crypto-neon-fp-armv8 > > because the assembler (gas version

Re: [PATCH v2 2/2][ARM] Improve max_cond_insns setting for Cortex cores

2019-12-06 Thread Christophe Lyon
On Fri, 6 Dec 2019 at 16:03, Wilco Dijkstra wrote: > > Hi Christophe, > > I've added an option to allow the warning to be enabled/disabled: > https://sourceware.org/ml/binutils/2019-12/msg00093.html > Thanks. In practice, how do you activate it when running the GCC testsuite? Do you plan to send

Re: [PATCH] extend -Wstringop-overflow to allocated objects (PR 91582)

2019-12-06 Thread Christophe Lyon
On Thu, 5 Dec 2019 at 02:37, Martin Sebor wrote: > > On 12/2/19 10:06 AM, Jeff Law wrote: > > On 11/8/19 3:11 PM, Martin Sebor wrote: > >> Unless it's used with _FORTIFY_SOURCE, -Wstringop-overflow > >> doesn't consider out-of-bounds accesses to objects allocated > >> by alloca, malloc, other func

Re: [PATCH v2 2/2][ARM] Improve max_cond_insns setting for Cortex cores

2019-12-09 Thread Christophe Lyon
On Fri, 6 Dec 2019 at 19:47, Wilco Dijkstra wrote: > > Hi Christophe, > > > In practice, how do you activate it when running the GCC testsuite? Do > > you plan to send a GCC patch to enable this assembler flag, or do you > > locally enable that option by default in your binutils? > > The warning i

Re: Fwd: [PATCH, GCC, Vect] Fix costing for vector shifts

2019-12-10 Thread Christophe Lyon
Hi, On Mon, 9 Dec 2019 at 11:23, Sudakshina Das wrote: > > Hi Jeff > > On 07/12/2019 17:44, Jeff Law wrote: > > On Fri, 2019-12-06 at 14:05 +, Sudakshina Das wrote: > >> Hi > >> > >> While looking at the vectorization for following example, we > >> realized > >> that even though vectorizable_

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-12-11 Thread Christophe Lyon
Ping? Le jeu. 5 déc. 2019 à 11:13, Christophe Lyon a écrit : > ping? > https://gcc.gnu.org/ml/gcc-patches/2019-11/msg01667.html > > Kyrill approved the previous version modulo a typo fix, but Richard > wanted a better name for a variable. > Is that version OK? > >

Re: [testsuite][arm] Remove xfail for vect-epilogues test

2019-12-12 Thread Christophe Lyon
On Wed, 11 Dec 2019 at 12:27, Andre Vieira (lists) wrote: > > Hi, > > We can now vectorize an epilogue for this loop for arm too, so removing > xfail. > > Is this OK for trunk? Wasn't entirely sure whether I could commit this > under obvious. > This fails on armeb :-( > gcc/testsuite/ChangeLog:

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-12-17 Thread Christophe Lyon
Ping? On Wed, 11 Dec 2019 at 18:19, Christophe Lyon wrote: > > Ping? > > Le jeu. 5 déc. 2019 à 11:13, Christophe Lyon a > écrit : >> >> ping? >> https://gcc.gnu.org/ml/gcc-patches/2019-11/msg01667.html >> >> Kyrill approved the previous version modu

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-12-17 Thread Christophe Lyon
On Tue, 17 Dec 2019 at 11:34, Kyrill Tkachov wrote: > > Hi Christophe, > > On 11/18/19 9:00 AM, Christophe Lyon wrote: > > On Wed, 13 Nov 2019 at 15:46, Christophe Lyon > > wrote: > > > > > > On Tue, 12 Nov 2019 at 12:13, Richard Earnshaw (lists) > &g

Re: [PING 3][PATCH] track dynamic allocation in strlen (PR 91582)

2019-12-17 Thread Christophe Lyon
On Sat, 14 Dec 2019 at 22:35, Jeff Law wrote: > > On Fri, 2019-12-13 at 17:55 -0700, Martin Sebor wrote: > > After more testing by Jeff's buildbot and correcting the problems > > it exposed I have committed the attached patch in r279392. > And just to close the loop on this. Your last version fix

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2019-12-17 Thread Christophe Lyon
On Tue, 17 Dec 2019 at 16:31, Kyrill Tkachov wrote: > > > On 12/17/19 2:33 PM, Christophe Lyon wrote: > > On Tue, 17 Dec 2019 at 11:34, Kyrill Tkachov > > wrote: > >> Hi Christophe, > >> > >> On 11/18/19 9:00 AM, Christophe Lyon wrote: >

Re: [C++ PATCH] PR c++/92576 - redeclaration of variable template.

2019-12-19 Thread Christophe Lyon
On Tue, 17 Dec 2019 at 22:46, Jason Merrill wrote: > > The variable templates patch way back when forgot to add handling here. The > simplest answer seems to be recursing to the underlying declaration. > > Tested x86_64-pc-linux-gnu, applying to trunk. > > * decl.c (redeclaration_error_me

Re: [C++ PATCH] PR c++/92745 - bogus error when initializing array of vectors.

2020-01-02 Thread Christophe Lyon
On Fri, 20 Dec 2019 at 21:28, Marek Polacek wrote: > In r268428 I changed reshape_init_r in such a way that when it sees > a nested { } in a CONSTRUCTOR with missing braces, it just returns > the initializer: > + else if (COMPOUND_LITERAL_P (stripped_init) > ... > + ++d->cur; > +

Re: [C++ PATCH] PR c++/92745 - bogus error when initializing array of vectors.

2020-01-02 Thread Christophe Lyon
On Thu, 2 Jan 2020 at 15:45, Jakub Jelinek wrote: > On Thu, Jan 02, 2020 at 03:41:30PM +0100, Christophe Lyon wrote: > > The new test fails on aarch64: > > g++.dg/cpp0x/initlist118.C -std=c++14 (internal compiler error) > > g++.dg/cpp0x/initlist118.C -std=c++14 (t

Re: [PATCH] Fix a bug that propagation in recursive function uses wrong aggregate lattice (PR ipa/93084)

2020-01-09 Thread Christophe Lyon
On Tue, 7 Jan 2020 at 14:18, Martin Jambor wrote: > > Hi, > > On Fri, Jan 03 2020, Feng Xue OS wrote: > > When checking a self-recursively generated value for aggregate jump > > function, wrong aggregate lattice was used, which will cause infinite > > constant propagation. This patch is composed t

  1   2   3   4   5   6   7   8   9   10   >