Re: Delay RTL initialization until it is really needed

2014-06-25 Thread Jan Hubicka
> On 06/20/14 01:51, Jan Hubicka wrote: > >Hi, > >IRA initialization shows high in profiles even when building lto objects. > >This patch simply > >delays RTL backend initialization until we really decide to output a > >function. In some cases > >this avoids the initialization completely (like

Re: [PATCH 1/2] Enable setting sign and unsigned promoted mode (SPR_SIGNED_AND_UNSIGNED)

2014-06-25 Thread Kugan
>> +const unsigned int SRP_POINTER = -1; >> +const unsigned int SRP_SIGNED = 0; >> +const unsigned int SRP_UNSIGNED = 1; >> +const unsigned int SRP_SIGNED_AND_UNSIGNED = 2; > > But most importantly, I thought Richard Henderson suggested > to use SRP_POINTER 0, SRP_SIGNED 1, SRP_UNSIGNED 2, SRP_

Re: [PATCH 1/2] Enable setting sign and unsigned promoted mode (SPR_SIGNED_AND_UNSIGNED)

2014-06-25 Thread Jakub Jelinek
On Wed, Jun 25, 2014 at 05:21:08PM +1000, Kugan wrote: > The problem with SRP_POINTER 0, SRP_SIGNED 1, SRP_UNSIGNED 2, > SRP_SIGNED_AND_UNSIGNED 3 (as I understand) is that, it will be > incompatible with TYPE_UNSIGNED (tree) and defines of > POINTER_EXTEND_UNSIGNED values. We will have to then tra

Re: [PATCH][match-and-simplify] GENERIC code-gen

2014-06-25 Thread Richard Biener
On Tue, 24 Jun 2014, Prathamesh Kulkarni wrote: > On Tue, Jun 24, 2014 at 9:00 PM, Richard Biener wrote: > > > > This massages things so GENERIC code-gen works (well, is emitted > > and compiles). The GENERIC interface matches that of > > fold_{unary,binary,ternary} with also supporting calls he

Re: [GSoC][match-and-simplify] get rid of multiple def_stmt

2014-06-25 Thread Richard Biener
On Tue, Jun 24, 2014 at 6:49 PM, Prathamesh Kulkarni wrote: > This patch avoids multiple definitions of def_stmt in different > blocks, and moves it at > the beginning of gimple_match_and_simplify. > > * genmatch.c (decision_tree::gen_gimple): Call fprintf to generate > definition of def_stmt. >

Re: [RFC] Making fold-const sane WRT symbol visibilities

2014-06-25 Thread Richard Biener
On Tue, 24 Jun 2014, Jan Hubicka wrote: > > > The problem is that the patch fails testcases that assume we do such > > > folding at parsing > > > time. > > > > > > ./testsuite/gcc/gcc.sum:FAIL: gcc.dg/pr36901-1.c (test for excess errors) > > > ./testsuite/gcc/gcc.sum:FAIL: gcc.dg/pr36901-2.c (te

Re: [PATCH] Change default for --param allow-...-data-races to off

2014-06-25 Thread Richard Biener
On Tue, Jun 24, 2014 at 10:19 PM, Martin Jambor wrote: > On Mon, Jun 23, 2014 at 03:35:01PM +0200, Bernd Edlinger wrote: >> Hi Martin, >> >> >> >> >> Well actually, I am not sure if we ever wanted to have a race condition >> >> here. >> >> Have you seen any impact of --param allow-store-data-race

Re: [PATCH 2/2] Enable elimination of zext/sext

2014-06-25 Thread Kugan
On 24/06/14 22:21, Jakub Jelinek wrote: > On Tue, Jun 24, 2014 at 09:53:35PM +1000, Kugan wrote: >> 2014-06-24 Kugan Vivekanandarajah >> >> * gcc/calls.c (precompute_arguments: Check is_promoted_for_type >> and set the promoted mode. >> (is_promoted_for_type) : New function. >>

Re: [PATCH, PR 61540] Do not ICE on impossible devirtualization

2014-06-25 Thread Martin Jambor
Hi, On Mon, Jun 23, 2014 at 01:38:03PM +0100, James Greenhalgh wrote: > On Thu, Jun 19, 2014 at 12:49:55PM +0100, Martin Jambor wrote: > > Hi, > > > > On Wed, Jun 18, 2014 at 06:12:34PM +0200, Bernhard Reutner-Fischer wrote: > > > On 18 June 2014 10:24:16 Martin Jambor wrote: > > > > > > >@@ -3

Re: [patch] Do not generate useless integral conversions

2014-06-25 Thread Richard Biener
On Tue, Jun 24, 2014 at 11:16 PM, Eric Botcazou wrote: >> I think that was on purpose to avoid arithmetics in enum types. As those >> conversions are useless and thus stripped later is it really important >> to retain enum and boolean kind here? > > The problem is that convert.c is called by fron

[Patch ARM/testsuite] Adjust flags for gcc.target/vect-noalign.c

2014-06-25 Thread Ramana Radhakrishnan
The current set of flags used in this test cause issues with multilib testing where there is no neon vs neon support. Thereby adding neon specific flags through the proper interfaces. Applied to trunk after testing on arm-none-eabi with a multilib target list of {-marm/-march=armv7-a/-mfpu=vfp

Re: [Patch, AArch64] Restructure arm_neon.h vector types' implementation.

2014-06-25 Thread Yufeng Zhang
On 23 June 2014 16:47, Tejas Belagod wrote: > > Hi, > > Here is a patch that restructures neon builtins to use vector types based on > standard base types. We previously defined arm_neon.h's neon vector > types(int8x8_t) using gcc's front-end vector extensions. We now move away > from that and use

Re: [PATCH 2/2] Enable elimination of zext/sext

2014-06-25 Thread Jakub Jelinek
On Wed, Jun 25, 2014 at 06:14:57PM +1000, Kugan wrote: > For these flags, value ranges generated are not usable for extension > eliminations. Therefore, without this some of the test cases in > regression fails. For example: > > short a; > void > foo (void) > { > for (a = 0; a >= 0; a++) > ;

[PATCH] Fix PR61560

2014-06-25 Thread Richard Biener
Committed. Richard. 2014-06-25 Richard Biener PR testsuite/61560 * gcc.dg/tree-ssa/ssa-fre-32.c: Change to avoid differences for targets that return _Complex float in memory. Index: gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-32.c ==

Re: [PATCH] Change default for --param allow-...-data-races to off

2014-06-25 Thread Jakub Jelinek
On Wed, Jun 25, 2014 at 10:14:17AM +0200, Richard Biener wrote: > > Perhaps not unsurprisingly, the patch is very similar. Bootstrapped > > and tested on x86_64-linux. OK for trunk? > > Ok - please give the C++/atomics folks a chance to comment. > > This change of default behavior should also b

Re: Instructions vs Expressions in the backend (was Re: RFA: Rework FOR_BB_INSNS iterators)

2014-06-25 Thread Richard Sandiford
David Malcolm writes: > On Mon, 2014-06-09 at 20:32 +0100, Richard Sandiford wrote: >> Steven Bosscher writes: >> > On Sat, Jun 7, 2014 at 7:54 PM, Richard Sandiford wrote: >> >> The two parts of the loop condition are really handling two different >> >> kinds of block: ones like entry and exit t

Re: [PATCH] Change default for --param allow-...-data-races to off

2014-06-25 Thread Richard Biener
On Wed, Jun 25, 2014 at 10:54 AM, Jakub Jelinek wrote: > On Wed, Jun 25, 2014 at 10:14:17AM +0200, Richard Biener wrote: >> > Perhaps not unsurprisingly, the patch is very similar. Bootstrapped >> > and tested on x86_64-linux. OK for trunk? >> >> Ok - please give the C++/atomics folks a chance t

[PATCH] Fix forwprop pattern (T)(P + A) - (T)P -> (T)A, Part 2

2014-06-25 Thread Bernd Edlinger
Hi, this is part 2 of my patch, which uses the undefined behaviour, and emits a strict overflow warning. This fixes gnat.dg/opt37.adb again. The diff is relative to part 1: https://gcc.gnu.org/ml/gcc-patches/2014-06/msg01891.html Boot-strapped and regression-tested on x86_64-linux-gnu. OK fo

[committed] Support OpenMP linear clause with arrays

2014-06-25 Thread Jakub Jelinek
Hi! I've committed following patch to allow linear clause to be used on (integer) arrays (including allocatable) and scalar integer allocatables. For simplicity we force safelen(1) for these (I don't think such loops would be ever vectorizable anyway), so the only problem is with for simd or distr

Re: [BUILDROBOT] v850 fallout

2014-06-25 Thread Nicholas Clifton
Hi Guys, > Jan-Benedict Glaw wrote: I've been away for holidays and other stuff, so this is a bit late, but nevermind... The stringification of DECL_SECTION_NAME had some fallout, see eg. http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=272454 /home/jbglaw/repos/gcc/gcc/config/v

Re: [PATCH AARCH64] fix and enable non-const shuffle for bigendian using TBL instruction

2014-06-25 Thread Alan Lawrence
This one seems to have slipped under the radar. I've just rebased and run the regression tests on aarch64_be-none-elf, with no issues; ping? (patch applied straightforwardly, but rebased version below) --Alan Alan Lawrence wrote: At present vec_perm with non-const indices is not handled on big

Re: Instructions vs Expressions in the backend (was Re: RFA: Rework FOR_BB_INSNS iterators)

2014-06-25 Thread Richard Sandiford
Oleg Endo writes: > Personally, I'd like to see usage of standard STL-like iterator usage. > I've proposed something for edge_iterator a while ago, but people don't > seem very fond of it. See also > https://gcc.gnu.org/ml/gcc-patches/2013-12/msg01129.html > > Have you also considered passing the

[PATCH][match-and-simplify] Put GENERIC match-and-simplify to work

2014-06-25 Thread Richard Biener
The following patch enables running the GENERIC match-and-simplify portion via fold_{unary,binary,ternary}. One pattern needs disabling to avoid endless recursion from addr-expression expansion so I added the planned defines. I've also split the generated routines into three again (will help the

[PATCH] PR bootstrap/61598

2014-06-25 Thread tsaunders
From: Trevor Saunders Hi, Basically the same as the mingw issue, fixed similarly. Trev PR bootstrap/61598 * fold-const.c (fold_checksum_tree): fix const qualification of argument passed to hash_table::find_slot with a const_cast. diff --git a/gcc/ChangeLog b/gcc/ChangeL

Re: [PATCH] Change default for --param allow-...-data-races to off

2014-06-25 Thread Marc Glisse
On Wed, 25 Jun 2014, Richard Biener wrote: On Wed, Jun 25, 2014 at 10:54 AM, Jakub Jelinek wrote: On Wed, Jun 25, 2014 at 10:14:17AM +0200, Richard Biener wrote: Perhaps not unsurprisingly, the patch is very similar. Bootstrapped and tested on x86_64-linux. OK for trunk? Ok - please give

Re: Add used_by_single_function flag for static variables

2014-06-25 Thread Richard Biener
On Mon, 23 Jun 2014, Jan Hubicka wrote: > Hi, > this is patch to add the used_by_single_function flag to varpool. In full > generality > it is a simple dataflow problem, since the variable may be referred by other > variables > as long as all of them are used by one function only. I have > bo

Re: [Patch,testsuite] Fix tests that fail due to symbol visibility when -fPIC

2014-06-25 Thread Vidya Praveen
PING! On Wed, Jun 04, 2014 at 03:01:38PM +0100, Vidya Praveen wrote: > Hello, > > The following test cases fail when -fPIC is passed as dejagnu multilib > flag > since -fPIC causes the 'availability' of the functions to be overwritable. > I > have fixed this by adding bind_pic_locally to

Re: [Patch,testsuite] Fix bind_pic_locally

2014-06-25 Thread Vidya Praveen
PING! On Wed, Jun 04, 2014 at 02:56:00PM +0100, Vidya Praveen wrote: > Hello, > > This is to follow up the patch I had posted to fix bind_pic_locally some time > ago (sorry, this went in to my back log for a while). > > To summarize, multilib_flags when it contains -fpic or -fPIC, overrides -f

Re: [PATCH] Fix forwprop pattern (T)(P + A) - (T)P -> (T)A, Part 1

2014-06-25 Thread Richard Biener
On Tue, Jun 24, 2014 at 2:30 PM, Bernd Edlinger wrote: > Hi Richard, > > I have here part 1 of this patch, which does not use undefined behaviour. > > Currently I start to think that also TYPE_SATURATING just cannot happen > here, because only some targets have saturating types, for instance ARM,

Re: [PATCH] Fix forwprop pattern (T)(P + A) - (T)P -> (T)A, Part 2

2014-06-25 Thread Richard Biener
On Wed, Jun 25, 2014 at 11:12 AM, Bernd Edlinger wrote: > Hi, > > this is part 2 of my patch, which uses the undefined behaviour, and emits a > strict overflow warning. > This fixes gnat.dg/opt37.adb again. > > The diff is relative to part 1: > https://gcc.gnu.org/ml/gcc-patches/2014-06/msg01891

strlen: update datastructure when replacing malloc with calloc

2014-06-25 Thread Marc Glisse
Hello, in my calloc patch, I forgot to update the datastructure when replacing malloc with calloc. Bootstrap+testsuite on x86_64-linux-gnu. 2014-06-25 Marc Glisse PR tree-optimization/57742 gcc/ * tree-ssa-strlen.c (handle_builtin_memset): Update strinfo after repl

Re: strlen: update datastructure when replacing malloc with calloc

2014-06-25 Thread Jakub Jelinek
On Wed, Jun 25, 2014 at 01:16:38PM +0200, Marc Glisse wrote: > in my calloc patch, I forgot to update the datastructure when replacing > malloc with calloc. > > Bootstrap+testsuite on x86_64-linux-gnu. > > 2014-06-25 Marc Glisse > > PR tree-optimization/57742 > gcc/ > * tree-ssa-s

[PATCH] Generate more efficient memory barriers for LEON3

2014-06-25 Thread Daniel Cederman
Hello, The memory barriers generated for SPARC are targeting the weakest memory model allowed for SPARC. The LEON3/4 SPARC processors are using a stronger memory model and thus have less requirements on the memory barriers. For LEON3/4, StoreStore is compiler-only, instead of "stbar", and Sto

[C PATCH] Better column info for return stmts (PR c/61162)

2014-06-25 Thread Marek Polacek
This is the last piece to fix PR61162: it's better to point to the expression of the return statement (if any) than to the return keyword itself. Tested x86_64-unknown-linux-gnu, applying to trunk. 2014-06-25 Marek Polacek PR c/61162 * c-parser.c (c_parser_statement_after_labe

Re: [C++ Patch/RFC] PR 49132

2014-06-25 Thread Jason Merrill
OK. Jason

[PATCH] Fix ubsan/bounds-2.c

2014-06-25 Thread Marek Polacek
On IRC Ramana reported that on ARM ubsan/bounds-2.c test fails with -O0, since we write to out-of-bounds location and probably rewrite the frame pointer stored in the stack. This patch removes such stores and adds some asm magic so the compiler doesn't optimize loads away as uninitialized memory r

Re: [PATCH] Fix PR c++/61537

2014-06-25 Thread Jason Merrill
On 06/24/2014 07:04 PM, Adam Butcher wrote: I've fixed these issues up in my tree and moved the test to g++.dg. Please put it in g++.dg/template; I'd prefer not to clutter the top directory. + bool template_parm_lists_apply + = parser->num_template_parameter_lists; + for (

Re: [PATCH] Fix ubsan/bounds-2.c

2014-06-25 Thread Jakub Jelinek
On Wed, Jun 25, 2014 at 02:40:40PM +0200, Marek Polacek wrote: > On IRC Ramana reported that on ARM ubsan/bounds-2.c test fails with -O0, > since we write to out-of-bounds location and probably rewrite the > frame pointer stored in the stack. This patch removes such stores > and adds some asm magi

[patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Kai Tietz
Hello, so there seems to be a fallout caused by moving peephole2 pass. See PR/61608. So we need indeed 2 peephole2 passes. ChangeLog 2014-06-25 Kai Tietz PR rtl-optimization/61608 * passes.def (peephole2): Readd peephole2 pass before if-after-reload pass. Tested for arm*-none-*,

Re: [PATCH] Fix ubsan/bounds-2.c

2014-06-25 Thread Marek Polacek
On Wed, Jun 25, 2014 at 02:49:56PM +0200, Jakub Jelinek wrote: > On Wed, Jun 25, 2014 at 02:40:40PM +0200, Marek Polacek wrote: > > On IRC Ramana reported that on ARM ubsan/bounds-2.c test fails with -O0, > > since we write to out-of-bounds location and probably rewrite the > > frame pointer stored

Re: [PATCH] Fix ubsan/bounds-2.c

2014-06-25 Thread Jakub Jelinek
Hi! On Wed, Jun 25, 2014 at 03:36:38PM +0200, Marek Polacek wrote: > static void __attribute__ ((noinline, noclone)) > fn7 (void) > { > - int n = 5, i; > + int n = 5; > + volatile int i; >volatile int c[n][n][n]; > - c[5][2][2] = 2; > - c[2][5][2] = 2; > - c[2][2][5] = 2; > + asm (""

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Richard Biener
On Wed, Jun 25, 2014 at 3:35 PM, Kai Tietz wrote: > Hello, > > so there seems to be a fallout caused by moving peephole2 pass. See PR/61608. > So we need indeed 2 peephole2 passes. > > ChangeLog > > 2014-06-25 Kai Tietz > > PR rtl-optimization/61608 > * passes.def (peephole2): Readd pee

Re: Re: [c++-concepts] Fix assertion failure with cp_maybe_constrained_type_specifier

2014-06-25 Thread Andrew Sutton
> I did a full 3-stage bootstrap which is the default these days. > I'll try --disable-bootstrap and see what happens. I just did a full bootstrap build and got the same errors. The errors are correct for C++11, which was enabled by default in this branch. IIRC, aggregate initialization requires t

Re: [PATCH] Fix ubsan/bounds-2.c

2014-06-25 Thread Marek Polacek
On Wed, Jun 25, 2014 at 03:47:37PM +0200, Jakub Jelinek wrote: > Please don't invoke undefined behavior in the asm statements. > So, "r" (&c[5]) is fine, but not &c[5][2][2] is not, &x[-1] is not, etc. > I'd say it should be ok to always just take address of the base > variable in the asm. Otherwi

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Jeff Law
On 06/25/14 07:35, Kai Tietz wrote: Hello, so there seems to be a fallout caused by moving peephole2 pass. See PR/61608. So we need indeed 2 peephole2 passes. ChangeLog 2014-06-25 Kai Tietz PR rtl-optimization/61608 * passes.def (peephole2): Readd peephole2 pass before if-af

[PATCH] Fix parts of PR61607

2014-06-25 Thread Richard Biener
This removes restrictions in DOM cprop_operand that inhibit some optimizations. The volatile pointer thing is really realy old and no longer necessary while the loop-depth consideration is only valid for loop-closed PHI nodes (but we're not in loop-closed SSA in DOM) - the coalescing is handled i

[PATCH] Fix parts of PR61607

2014-06-25 Thread Richard Biener
This removes prematurely killing loops during jump threading and moves it to a spot where we know we didn't cancel the jump thread. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Ok? Thanks, Richard. 2014-06-25 Richard Biener PR tree-optimization/61607 * tre

Re: [PATCH 3/3] add hash_map class

2014-06-25 Thread Martin Liška
On 06/24/2014 09:31 PM, Richard Biener wrote: On June 24, 2014 9:16:34 PM CEST, Trevor Saunders wrote: On Tue, Jun 24, 2014 at 08:23:49PM +0200, Jan Hubicka wrote: On 06/20/2014 12:52 PM, tsaund...@mozilla.com wrote: From: Trevor Saunders Hi, This patch adds a hash_map class so we can con

Re: [PATCH] Add missing -fdump-* options

2014-06-25 Thread Teresa Johnson
On Tue, May 13, 2014 at 8:19 AM, Xinliang David Li wrote: > On Tue, May 13, 2014 at 1:39 AM, Richard Biener > wrote: >> On Fri, May 9, 2014 at 5:54 PM, Teresa Johnson wrote: >>> I discovered that the support for the documented -fdump-* options >>> "optimized", "missed", "note" and "optall" was m

Re: [fortran, patch] IEEE intrinsic modules (ping)

2014-06-25 Thread Steve Kargl
On Wed, Jun 25, 2014 at 01:41:02AM +0200, FX wrote: > > If I remove the previously installed gcc, the failure again occurs. > > So, it looks like the testsuite is picking up installed *.mod files > > over the freshly built *.mod files. This is not a showstopper. > > And this is not all the tests

Re: [PATCH, 2/10] prepare ccmp

2014-06-25 Thread Richard Earnshaw
On 23/06/14 07:57, Zhenqiang Chen wrote: > Hi, > > The patch makes several functions global, which will be used when > expanding ccmp instructions. > > The other change in this patch is to check CCMP when turning code into > jumpy sequence. > > OK for trunk? > This isn't a complete review. In

Re: [PATCH, 3/10] skip swapping operands used in ccmp

2014-06-25 Thread Richard Earnshaw
On 23/06/14 07:58, Zhenqiang Chen wrote: > Hi, > > Swapping operands in a ccmp will lead to illegal instructions. So the > patch disables it in simplify_while_replacing. > > The patch is separated from > https://gcc.gnu.org/ml/gcc-patches/2014-02/msg01407.html. > > To make it clean. The patch ad

RE: [Patch: RL78] Add support for 64-bit doubles

2014-06-25 Thread Kaushik Phatak
Hi DJ, >> I assume this should be "doubles" not "double" though... I had made this change as suggested, however we had some issue while integrating the tools with our eclipse plug-ins. The RX toolchain has a similar patch where the option is "doubles" while the folder name is "double". Would it

Re: [PATCH] Convert XCOFF ASM_DECLARE_FUNCTION_NAME to function

2014-06-25 Thread David Edelsohn
On Tue, Jun 24, 2014 at 2:53 PM, Jan Hubicka wrote: > We will also need to introduce ASM_DECLARE_OBJECT_NAME to handle the aliases > of variables. I can look into that probably later this week (it is last week > of my teaching and I need to do the finals) varasm.c defaults to ASM_OUTPUT_LABEL

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Kai Tietz
2014-06-25 16:04 GMT+02:00 Jeff Law : > So why is the peephole not working in its current location? > > Jeff Hi Jeff, that is what I read out of dumps: If peephole2 is executed early we see following pattern transformation: (insn 12 11 13 2 (set (reg:CC_NOOV 100 cc) (compare:CC_NOOV (ze

[PATCH] typeof: Remove type qualifiers for atomic types

2014-06-25 Thread Sebastian Huber
function ld: @ args = 0, pretend = 0, frame = 0 @ frame_needed = 0, uses_anonymous_args = 0 @ link register save eliminated. ldr r0, [r0] bx lr .size ld, .-ld .ident "GCC: (GNU) 4.9.1 20140625 (prerelease) gcc/c/ChangeLog 2014-06-25 Sebastian

Re: [PATCH, 4/10] expand ccmp

2014-06-25 Thread Richard Earnshaw
On 23/06/14 07:59, Zhenqiang Chen wrote: > Hi, > > This patch includes the main logic to expand ccmp instructions. > > In the patch, > * ccmp_candidate_p is used to identify the CCMP candidate > * expand_ccmp_expr is the main entry, which calls expand_ccmp_expr_1 > to expand CCMP. > * e

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Jeff Law
On 06/25/14 09:04, Kai Tietz wrote: 2014-06-25 16:04 GMT+02:00 Jeff Law : So why is the peephole not working in its current location? Jeff Hi Jeff, that is what I read out of dumps: If peephole2 is executed early we see following pattern transformation: [ ... ] Ask an ARM maintainer if the

Re: [PATCH, cpp] Fix line directive bug

2014-06-25 Thread Dodji Seketeli
Hello Nicholas, Nicholas Ormrod a écrit: > We currently have two possible approaches. I see the trade-offs between these > two solutions as follows: > > Adding full line directives is not implemented, and will be more > complicated than my patch. It will require someone else to implement > it,

[PATCH] Pass correct memory attributes for build constant

2014-06-25 Thread Kito Cheng
Hi all: This patch is fix constant memory's symbol_ref don't have right alignment info since `exp` don't set alignment (and should not set alignment info for `exp`) , use `decl` to set_mem_attributes for right alignment info. ChangLog 2014-06-25 Kito Cheng * varasm.c (build_constant

[c++-concepts] constraint folding

2014-06-25 Thread Andrew Sutton
Updating constraint parsing to match changes to spec. Constraints must always left unfolded, even when non-dependent, until they are evaluated. 2014-06-25 Andrew Sutton * gcc/cp/parser.c (cp_parser_requires_clause): Don't fold expressions when parsing a requires-clause.

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Ramana Radhakrishnan
[Apologies about the duplicates to folks - resending to make this hit the lists] On 25/06/14 16:28, Jeff Law wrote: On 06/25/14 09:04, Kai Tietz wrote: 2014-06-25 16:04 GMT+02:00 Jeff Law : So why is the peephole not working in its current location? Jeff Hi Jeff, that is what I read out o

Re: [RFC] Making fold-const sane WRT symbol visibilities

2014-06-25 Thread Joseph S. Myers
On Wed, 25 Jun 2014, Richard Biener wrote: > On Tue, 24 Jun 2014, Jan Hubicka wrote: > > > > > The problem is that the patch fails testcases that assume we do such > > > > folding at parsing > > > > time. > > > > > > > > ./testsuite/gcc/gcc.sum:FAIL: gcc.dg/pr36901-1.c (test for excess > > > >

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Richard Henderson
On 06/25/2014 08:28 AM, Jeff Law wrote: > Ask an ARM maintainer if the new code is actually better than the old code. It isn't. > It appears that with the peep2 pass moved that we actually if-convert the > fall-thru path of the conditional and eliminate the conditional. Which, on the > surface se

Re: [BUILDROBOT] xtensa fallout (was: Turn DECL_SECTION_NAME into string)

2014-06-25 Thread augustine.sterl...@gmail.com
On Tue, Jun 24, 2014 at 10:20 PM, Jan Hubicka wrote: >> Hi! >> >> This is the xtensa fallout, see >> http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=272418 >> >> g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions >> -fno-rtti -fasynchronous-unwind-tables -W -Wa

Re: [PATCH] typeof: Remove type qualifiers for atomic types

2014-06-25 Thread Joseph S. Myers
On Wed, 25 Jun 2014, Sebastian Huber wrote: > 2014-06-25 Sebastian Huber > > * c-parser.c (c_parser_declaration_or_fndef): Discard all type > qualifiers in __auto_type for atomic types. > (c_parser_typeof_specifier): Discard all type qualifiers in > __typeof__ for atomi

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Kai Tietz
2014-06-25 17:50 GMT+02:00 Richard Henderson : > On 06/25/2014 08:28 AM, Jeff Law wrote: >> Ask an ARM maintainer if the new code is actually better than the old code. > > It isn't. > >> It appears that with the peep2 pass moved that we actually if-convert the >> fall-thru path of the conditional a

[PATCH v2] PR bootstrap/61598

2014-06-25 Thread tsaunders
From: tbsaunde Hi, Actually we can just store const tre_node * in the hash table, and actually remove a const cast. bootstrapped with --enable-checking=fold on top of my original series on x86_64-unknown-linux-gnu, and aprovied by richi on IRC, commited. Trev gcc/ PR bootstrap/61598

Re: [PATCH] IPA REF: refactoring

2014-06-25 Thread Martin Liška
On 06/24/2014 08:21 PM, Jan Hubicka wrote: Hello, this patch changes IPA REF API to c++ style. Changes were suggested and consulted with Honza. Patch has been pre approved, will be committed if no comments. Bootstrapped on x86_64-pc-linux-gnu, no regressions. Thanks, Martin ChangeLog: 20

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Jeff Law
On 06/25/14 10:02, Kai Tietz wrote: 2014-06-25 17:50 GMT+02:00 Richard Henderson : On 06/25/2014 08:28 AM, Jeff Law wrote: Ask an ARM maintainer if the new code is actually better than the old code. It isn't. It appears that with the peep2 pass moved that we actually if-convert the fall-thr

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Jeff Law
On 06/25/14 09:50, Richard Henderson wrote: On 06/25/2014 08:28 AM, Jeff Law wrote: Ask an ARM maintainer if the new code is actually better than the old code. It isn't. It appears that with the peep2 pass moved that we actually if-convert the fall-thru path of the conditional and eliminate

Re: [PATCH] Detect a pack-unpack pattern in GCC vectorizer and optimize it.

2014-06-25 Thread Cong Hou
On Tue, Jun 24, 2014 at 4:05 AM, Richard Biener wrote: > On Sat, May 3, 2014 at 2:39 AM, Cong Hou wrote: >> On Mon, Apr 28, 2014 at 4:04 AM, Richard Biener wrote: >>> On Thu, 24 Apr 2014, Cong Hou wrote: >>> Given the following loop: int a[N]; short b[N*2]; for (int

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Kai Tietz
2014-06-25 19:15 GMT+02:00 Jeff Law : > On 06/25/14 10:02, Kai Tietz wrote: >> >> 2014-06-25 17:50 GMT+02:00 Richard Henderson : >>> >>> On 06/25/2014 08:28 AM, Jeff Law wrote: Ask an ARM maintainer if the new code is actually better than the old code. >>> >>> >>> It isn't. >>>

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Richard Henderson
On 06/25/2014 06:35 AM, Kai Tietz wrote: > Hello, > > so there seems to be a fallout caused by moving peephole2 pass. See PR/61608. > So we need indeed 2 peephole2 passes. We don't need a second peephole pass. Please try this. I think there's room for cleanup here, depending on when we leave cf

Re: [PATCH] typeof: Remove type qualifiers for atomic types

2014-06-25 Thread Sebastian Huber
On 06/25/2014 05:56 PM, Joseph S. Myers wrote: On Wed, 25 Jun 2014, Sebastian Huber wrote: 2014-06-25 Sebastian Huber * c-parser.c (c_parser_declaration_or_fndef): Discard all type qualifiers in __auto_type for atomic types. (c_parser_typeof_specifier): Discard all t

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Kai Tietz
2014-06-25 20:12 GMT+02:00 Richard Henderson : > On 06/25/2014 06:35 AM, Kai Tietz wrote: >> Hello, >> >> so there seems to be a fallout caused by moving peephole2 pass. See PR/61608. >> So we need indeed 2 peephole2 passes. > > We don't need a second peephole pass. Please try this. > > I think th

Re: [PATCH] Fix parts of PR61607

2014-06-25 Thread Jeff Law
On 06/25/14 08:05, Richard Biener wrote: This removes restrictions in DOM cprop_operand that inhibit some optimizations. The volatile pointer thing is really realy old and no longer necessary while the loop-depth consideration is only valid for loop-closed PHI nodes (but we're not in loop-close

Re: [PATCH] Fix parts of PR61607

2014-06-25 Thread Jeff Law
On 06/25/14 08:06, Richard Biener wrote: This removes prematurely killing loops during jump threading and moves it to a spot where we know we didn't cancel the jump thread. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Ok? Thanks, Richard. 2014-06-25 Richard Biener

Re: [Patch: RL78] Add support for 64-bit doubles

2014-06-25 Thread DJ Delorie
> The RX toolchain has a similar patch where the option is "doubles" > while the folder name is "double". There's no reason for one toolchain to be consistent with another, though. > Would it be ok to revert this line from "64-bit-doubles" to "64-bit-double" > as this? > +MULTILIB_DIRNAMES =

Re: testsuite allocators patch

2014-06-25 Thread François Dumont
Hi With the patch this time. I would like to finally propose this patch before the one on _Rb_tree, as a separate one. I have adopted the same evolution on the tracker_allocator with even a perfect forwarding constructor to allow its usage on top of the uneq_allocator which t

Re: [PATCH, ARM] Enable fuse-caller-save for ARM

2014-06-25 Thread Tom de Vries
On 19-06-14 18:43, Richard Henderson wrote: On 06/19/2014 09:37 AM, Tom de Vries wrote: On 19-06-14 05:59, Richard Henderson wrote: On 06/01/2014 04:27 AM, Tom de Vries wrote: + if (TARGET_AAPCS_BASED) +{ + /* For AAPCS, IP and CC can be clobbered by veneers inserted by the + lin

Three pending co-array patches

2014-06-25 Thread Paul Richard Thomas
Dear Tobias, I have taken a look through the following three patches: * https://gcc.gnu.org/ml/fortran/2014-06/msg00178.html * https://gcc.gnu.org/ml/fortran/2014-06/msg00183.html * https://gcc.gnu.org/ml/fortran/2014-06/msg00187.html I can find nothing to object to in any of them; on the contra

Re: [PATCH] Fix PR c++/61537

2014-06-25 Thread Adam Butcher
* parser.c (cp_parser_elaborated_type_specifier): Only consider template parameter lists outside of function parameter scope. * g++.dg/template/pr61537.C: New testcase. --- gcc/cp/parser.c | 31 ++- gcc/testsuite/g++.dg/t

Re: Instructions vs Expressions in the backend (was Re: RFA: Rework FOR_BB_INSNS iterators)

2014-06-25 Thread Jeff Law
On 06/25/14 03:36, Richard Sandiford wrote: I think this is an example of another problem with gcc coding style: that we're far too afraid of temporary variables. In David's scheme I think this would be: Historical coding style :(It's particularly bad in RTL land, but you see the same prob

Re: Instructions vs Expressions in the backend (was Re: RFA: Rework FOR_BB_INSNS iterators)

2014-06-25 Thread Jeff Law
On 06/25/14 02:54, Richard Sandiford wrote: and the code now uses "rtx_insn *" in hundreds of places where it would previously have used "rtx". This looks really good to me FWIW. The only thing I'm not sure about is how useful rtx_nonjump_insn would be. ISTM that jump_insn and call_insn real

Re: [PATCH] PR bootstrap/61598

2014-06-25 Thread Jeff Law
On 06/25/14 03:46, tsaund...@mozilla.com wrote: From: Trevor Saunders Hi, Basically the same as the mingw issue, fixed similarly. Trev PR bootstrap/61598 * fold-const.c (fold_checksum_tree): fix const qualification of argument passed to hash_table::find_slot with a

[patch] Simplify allocator use

2014-06-25 Thread Jonathan Wakely
A couple of related patches that came out of some work on std::list and std::string which is not ready yet. One adds an alias template to simplify rebinding allocators. The other adds an RAII type to help manage pointers obtained from allocators. The new type means I can remove several ugly try-

Re: Delay RTL initialization until it is really needed

2014-06-25 Thread Jeff Law
On 06/25/14 01:09, Jan Hubicka wrote: On 06/20/14 01:51, Jan Hubicka wrote: Hi, IRA initialization shows high in profiles even when building lto objects. This patch simply delays RTL backend initialization until we really decide to output a function. In some cases this avoids the initializat

Re: [PATCH] Fix PR c++/61537

2014-06-25 Thread Jason Merrill
OK, thanks. Jason

Re: [PATCH v2] PR bootstrap/61598

2014-06-25 Thread Jeff Law
On 06/25/14 10:05, tsaund...@mozilla.com wrote: From: tbsaunde Hi, Actually we can just store const tre_node * in the hash table, and actually remove a const cast. bootstrapped with --enable-checking=fold on top of my original series on x86_64-unknown-linux-gnu, and aprovied by richi on IRC,

Re: [PATCH] Pass correct memory attributes for build constant

2014-06-25 Thread Jeff Law
On 06/25/14 09:35, Kito Cheng wrote: Hi all: This patch is fix constant memory's symbol_ref don't have right alignment info since `exp` don't set alignment (and should not set alignment info for `exp`) , use `decl` to set_mem_attributes for right alignment info. ChangLog 2014-06-25 Kito Che

Re: [PATCH, 3/10] skip swapping operands used in ccmp

2014-06-25 Thread Jeff Law
On 06/25/14 08:44, Richard Earnshaw wrote: On 23/06/14 07:58, Zhenqiang Chen wrote: Hi, Swapping operands in a ccmp will lead to illegal instructions. So the patch disables it in simplify_while_replacing. The patch is separated from https://gcc.gnu.org/ml/gcc-patches/2014-02/msg01407.html. To

[PATCH] Fix vector rotate regression (PR tree-optimization/57233)

2014-06-25 Thread Jakub Jelinek
Hi! Since we've started folding (a << n) | (a >> (bitsize - n)) etc. into rotates even vectors, we've regressed code quality on targets where we do have vector shifts, but don't have vector rotates. The following patch attempts to fix it, by telling veclower pass not to actually lower it if we ha

Re: [Patch,testsuite] Fix bind_pic_locally

2014-06-25 Thread Jeff Law
On 06/25/14 04:07, Vidya Praveen wrote: PING! On Wed, Jun 04, 2014 at 02:56:00PM +0100, Vidya Praveen wrote: Hello, This is to follow up the patch I had posted to fix bind_pic_locally some time ago (sorry, this went in to my back log for a while). To summarize, multilib_flags when it contai

Re: [Patch,testsuite] Fix tests that fail due to symbol visibility when -fPIC

2014-06-25 Thread Jeff Law
On 06/25/14 04:06, Vidya Praveen wrote: PING! On Wed, Jun 04, 2014 at 03:01:38PM +0100, Vidya Praveen wrote: Hello, The following test cases fail when -fPIC is passed as dejagnu multilib flag since -fPIC causes the 'availability' of the functions to be overwritable. I have fixed this by a

Re: [PATCH v2] PR bootstrap/61598

2014-06-25 Thread Trevor Saunders
On Wed, Jun 25, 2014 at 03:00:33PM -0600, Jeff Law wrote: > On 06/25/14 10:05, tsaund...@mozilla.com wrote: > >From: tbsaunde > > > >Hi, > > > >Actually we can just store const tre_node * in the hash table, and actually > >remove a const cast. > > > >bootstrapped with --enable-checking=fold on top

Re: [PATCH] Change default for --param allow-...-data-races to off

2014-06-25 Thread Jeff Law
On 06/24/14 14:19, Martin Jambor wrote: On Mon, Jun 23, 2014 at 03:35:01PM +0200, Bernd Edlinger wrote: Hi Martin, Well actually, I am not sure if we ever wanted to have a race condition here. Have you seen any impact of --param allow-store-data-races on any benchmark? It's trivially to wri

Re: [PATCH] typeof: Remove type qualifiers for atomic types

2014-06-25 Thread Joseph S. Myers
On Wed, 25 Jun 2014, Sebastian Huber wrote: > On 06/25/2014 05:56 PM, Joseph S. Myers wrote: > > On Wed, 25 Jun 2014, Sebastian Huber wrote: > > > > > 2014-06-25 Sebastian Huber > > > > > > * c-parser.c (c_parser_declaration_or_fndef): Discard all type > > > qualifiers in __auto_type for

Re: [PATCH v2] gcc: fix segfault from calling free on non-malloc'd area

2014-06-25 Thread Jeff Law
On 06/24/14 14:05, Paul Gortmaker wrote: We see the following on a 32bit gcc installed on 64 bit host: Reading symbols from ./i586-pokymllib32-linux-gcc...done. (gdb) run Starting program: x86-pokymllib32-linux/lib32-gcc/4.9.0-r0/image/usr/bin/i586-pokymllib32-linux-gcc Program rec

Re: [PATCH, Cilk+, PR57541] Additional fix for issues witn array notations

2014-06-25 Thread Jeff Law
On 06/19/14 06:30, Zamyatin, Igor wrote: On 06/16/14 14:13, Zamyatin, Igor wrote: Hi All! The patch fixes ICE in array notation for the cases of incorrect arguments of Cilk+ builtins and undeclared initial index. Is it ok for trunk and 4.9? Thanks, Igor diff --git a/gcc/c/ChangeLog b/gcc/c

  1   2   >