On 23/06/14 07:57, Zhenqiang Chen wrote: > Hi, > > The patch makes several functions global, which will be used when > expanding ccmp instructions. > > The other change in this patch is to check CCMP when turning code into > jumpy sequence. > > OK for trunk? >
This isn't a complete review. In particular, I'd like one of the gimple experts to go over this again. However, some general issues do crop up. I'll deal with each patch as I spot something. enum rtx_code code; > @@ -6503,6 +6503,12 @@ get_rtx_code (enum tree_code tcode, bool unsignedp) > code = LTGT; > break; > > + case BIT_AND_EXPR: > + code = AND; > + break; > + case BIT_IOR_EXPR: > + code = IOR; > + break; Blank lines between case alternatives. R.