Re: [SH] PR 50749 - Auto-inc-dec does not find subsequent contiguous mem accesses

2012-06-12 Thread Oleg Endo
On Tue, 2012-06-12 at 10:33 +0900, Kaz Kojima wrote: > Hans-Peter Nilsson wrote: > > On Tue, 12 Jun 2012, Kaz Kojima wrote: > > > Oleg Endo wrote: > > > > Some of the tests pass, some of them don't because > > > > of the auto-inc-dec issues mentioned in the PR. > > > > > > I thought that the tes

Re: [Fortran, DRAFT patch] PR 46321 - [OOP] Polymorphic deallocation

2012-06-12 Thread Alessandro Fanfarillo
I don't know if there's already a PR but I get an ICE compiling this with a non-patched version. If x is not an array everything goes ok. 2012/6/11 Tobias Burnus : > On 06/11/2012 11:24 AM, Alessandro Fanfarillo wrote: >> >> gfortran.dg/coarray/poly_run_3.f90 > > > That one fails because I for for

Re: [PATCH] Hoist adjacent pointer loads

2012-06-12 Thread Richard Guenther
On Mon, Jun 11, 2012 at 7:16 PM, William J. Schmidt wrote: > On Mon, 2012-06-11 at 12:11 -0500, William J. Schmidt wrote: > >> I found this parameter that seems to correspond to well-predicted >> conditional jumps: >> >> /* When branch is predicted to be taken with probability lower than this >>  

Re: [PATCH] Hoist adjacent loads

2012-06-12 Thread Richard Guenther
On Mon, 11 Jun 2012, William J. Schmidt wrote: > OK, once more with feeling... :) > > This patch differs from the previous one in two respects: It disables > the optimization when either the then or else edge is well-predicted; > and it now uses the existing l1-cache-line-size parameter instead

Re: [RFC PR48941 / 51980] Rewrite arm_neon.h to use __builtin_shuffle

2012-06-12 Thread Richard Guenther
On Mon, Jun 11, 2012 at 5:46 PM, Ramana Radhakrishnan wrote: > Hi, > >        A number of the vector permute intrinsics in arm_neon.h end up > generating quite wasteful code because we end up packing these into > larger types. While looking at a particularly bad example and the > infamous PR48941

Re: [testsuite] gcc.dg/cpp: make message check lines unique in test summary

2012-06-12 Thread Richard Guenther
On Tue, Jun 12, 2012 at 4:32 AM, Janis Johnson wrote: > This test modifies dg-message test directives by adding comments that > will be added to lines in the test summary to eliminate non-unique lines > for checks of messages for the same line of source code in a test. > > Tested on i686-pc-linux-

Re: [testsuite] gcc.dg: make message check lines unique in test summary

2012-06-12 Thread Richard Guenther
On Tue, Jun 12, 2012 at 4:37 AM, Janis Johnson wrote: > This test modifies dg-error, dg-warning, dg-message, and dg-bogus test > directives by adding comments that will be added to lines in the test > summary to eliminate non-unique lines for checks of messages for the > same line of source code i

Re: [testsuite] gcc.c-torture/compile: make msg check lines unique in test summary

2012-06-12 Thread Richard Guenther
On Tue, Jun 12, 2012 at 4:39 AM, Janis Johnson wrote: > This test modifies dg-message test directives by adding comments that > will be added to lines in the test summary to eliminate non-unique lines > for checks of messages for the same line of source code in a test. > > Tested on i686-pc-linux-

[Ada] Fix error message printed for invalid access to atomic component

2012-06-12 Thread Arnaud Charlet
This changes the error message printed for an invalid access to an atomic component, which was: access to volatile object cannot yield access-to-non-volatile type into the more correct: access to atomic object cannot yield access-to-non-atomic type The problem was that Is_Atomic_Object returned

[Ada] Proper implementation of interfacing aspects.

2012-06-12 Thread Arnaud Charlet
This patch implements properly the aspects Convention, Import, Export, Link_ Name and External_Name, which replace the corresponding Ada 2005 pragmas. Compiling missing_convention.ads must yield: missing_convention.ads:3:07: missing Convention aspect for Export/Import --- function missing_conv

Re: [RFC PR48941 / 51980] Rewrite arm_neon.h to use __builtin_shuffle

2012-06-12 Thread Julian Brown
On Mon, 11 Jun 2012 16:46:27 +0100 Ramana Radhakrishnan wrote: > Hi, > > I don't like the ML bits of the patch as it stands today and before > committing I would like to clean up the ML bits quite a bit further > especially in areas where I've put FIXMEs [...] I had a go at this, see attached.

Re: arm-rtems switch default target to EABI

2012-06-12 Thread Sebastian Huber
On 06/05/2012 05:19 PM, Sebastian Huber wrote: Hi, what is the blocking point for the integration of these patches? Ping. -- Sebastian Huber, embedded brains GmbH Address : Obere Lagerstr. 30, D-82178 Puchheim, Germany Phone : +49 89 18 90 80 79-6 Fax : +49 89 18 90 80 79-9 E-Mail :

[Ada] Treat -fdump-scos as synonym of -gnateS

2012-06-12 Thread Arnaud Charlet
This change allows the use of -fdump-scos as a synonym of -gnateS to request the generation of SCOs in Ada ALI files. Tested on x86_64-pc-linux-gnu, committed on trunk 2012-06-12 Thomas Quinot * back_end.adb (Scan_Back_End_Switches): Treat -fdump-scos as synonym of -gnateS.

[Ada] Accidental overlodading in an instance

2012-06-12 Thread Arnaud Charlet
This patch handles a rare case of accidental overloading in an instance, when the profile of a subprogram body that depends on a formal type becomes compatible with that of a homonym whose profile in the generic mentions the actual type. execution of inst.adb must yield: expected T... In P (T) ex

[C++ PATCH] Disable -Wuninitialized warnings on NSDMI initialized fields (PR c++/53594)

2012-06-12 Thread Jakub Jelinek
Hi! As stated in the PR, the -Wuninitialized warnings are bogus if fields have NSDMI, as they are actually initialized then. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? What about 4.7.2? 2012-06-11 Jakub Jelinek PR c++/53594 * class.c (check_bases_and

[Ada] Handling of (illegal) null record unchecked union

2012-06-12 Thread Arnaud Charlet
A "null record" type does not have a variant part, so it is not a legal candidate for pragma Unchecked_Union. This change fixes the circuitry that enforces this rule so that it correctly rejects such illegal code instead of crashing the compiler. The following compilation must be rejected with the

[Ada] Dereferences and inferable discriminants

2012-06-12 Thread Arnaud Charlet
An implicit dereference of an access to constrained unchecked union subtype has inferable discriminants. This change fixes the Has_Inferable_Discriminants function to take this case into account properly. The following program must compile quietly and display "OK" when executed: with Ada.Text_IO;

[Ada] Adding information of exported entities to ALI files

2012-06-12 Thread Arnaud Charlet
This patch extends the information generated by the compiler in ALI files adding references to entities exported to foreign languages. This information can be used by cross reference tools and text editors (for example, GPS). Tested on x86_64-pc-linux-gnu, committed on trunk 2012-06-12 Javier Mi

[Ada] Add support for project file Install package.

2012-06-12 Thread Arnaud Charlet
This package will be used with the gprinstall tool. Tested on x86_64-pc-linux-gnu, committed on trunk 2012-06-12 Pascal Obry * prj-attr.adb: Add install package and corresponding attributes. * snames.ads-tmpl (Name_Active): New constant. (Name_Exec_Subdir): Likewise.

[Ada] Delete symbolic link silently.

2012-06-12 Thread Arnaud Charlet
The following test must run without raising an exception on systems supporting symbolic links: with Ada.Directories; use Ada.Directories; with Ada.Text_IO; use Ada.Text_IO; procedure Delln is F1 : constant String := "libname.so"; F2 : constant String := "libname.so.1"; File : File

[RFA PATCH, ia64]: Put soft-FP exception handler out-of-line

2012-06-12 Thread Uros Bizjak
Hello! Similar to x86, this patch puts soft-FP exception handler out-of-line. The patch also cleans asm constraints a bit (introduces "+"), but has no other functional changes. 2012-06-12 Uros Bizjak * config/ia64/sfp-machine.h (__sfp_handle_exceptions): New function declarati

[Ada] Ada 2012: AI05-0296, formal incomplete types.

2012-06-12 Thread Arnaud Charlet
This patch implements AI05-0296, concerning freeze rules in the presence of formal incomplete types: a formal abstract subprogram cannot have an incomplete controlling type, and the profile of the actual subprogram is not frozen if it includes a incomplete untagged type. Compiling abstr.ads in Ada

Re: [RFC PR48941 / 51980] Rewrite arm_neon.h to use __builtin_shuffle

2012-06-12 Thread Richard Guenther
On Tue, Jun 12, 2012 at 11:22 AM, Julian Brown wrote: > On Mon, 11 Jun 2012 16:46:27 +0100 > Ramana Radhakrishnan wrote: > >> Hi, >> >> I don't like the ML bits of the patch as it stands today and before >> committing I would like to clean up the ML bits quite a bit further >> especially in areas

[wwwdocs,4.6,committed]: Note on avr's progmem attribute, fix sparc

2012-06-12 Thread Georg-Johann Lay
Applied the following changes: - Note on avr's progmem attribute. - Fix -mfix-at697f which is a Sparc option. http://gcc.gnu.org/gcc-4.6/changes.html Johann Index: htdocs/gcc-4.6/changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/g

Re: [PATCH] Correct cost model for strided loads

2012-06-12 Thread Richard Guenther
On Mon, Jun 11, 2012 at 8:37 PM, Richard Guenther wrote: > On Mon, Jun 11, 2012 at 5:01 PM, William J. Schmidt > wrote: >> >> >> On Mon, 2012-06-11 at 16:10 +0200, Richard Guenther wrote: >>> On Mon, 11 Jun 2012, William J. Schmidt wrote: >>> >>> > >>> > >>> > On Mon, 2012-06-11 at 11:15 +0200, R

[Ada] Object declarations and finalization of transient variables

2012-06-12 Thread Arnaud Charlet
This patch adds code to recognize a scenario where an object is initialized by a sequence of nested function calls where one of them returns a controlled result. This in turn triggers the mechanism which exports such transient objects to the enclosing finalizer on the assumption that one of the cal

Re: [RFC PR48941 / 51980] Rewrite arm_neon.h to use __builtin_shuffle

2012-06-12 Thread Ramana Radhakrishnan
On 12 June 2012 11:46, Richard Guenther wrote: > On Tue, Jun 12, 2012 at 11:22 AM, Julian Brown > wrote: >> On Mon, 11 Jun 2012 16:46:27 +0100 >> Ramana Radhakrishnan wrote: >> >>> Hi, >>> >>> I don't like the ML bits of the patch as it stands today and before >>> committing I would like to cle

[Ada] Cleanup front end code (introduce N_Subprogram_Call)

2012-06-12 Thread Arnaud Charlet
This patch is a minor cleanup in the front end. It introduces a new subtype N_Subprogram_Call which includes N_Function_Call and N_Procedure_Call_Statement, and then uses this new subtype in many place in the front end where it simplifies the code. Since there is no change in behavior, no test is r

[Ada] Avoid memory exhaustion when using gnatmake -m

2012-06-12 Thread Arnaud Charlet
In large systems, gnatmake may crash when invoked with -m (minimal recompilation) when there are many sources that have been modified but have kept the same checksum. This patch fixes this. There is no simple test. Tested on x86_64-pc-linux-gnu, committed on trunk 2012-06-12 Vincent Celier

Re: [RFC PR48941 / 51980] Rewrite arm_neon.h to use __builtin_shuffle

2012-06-12 Thread Ramana Radhakrishnan
On 12 June 2012 10:22, Julian Brown wrote: > On Mon, 11 Jun 2012 16:46:27 +0100 > Ramana Radhakrishnan wrote: > >> Hi, >> >> I don't like the ML bits of the patch as it stands today and before >> committing I would like to clean up the ML bits quite a bit further >> especially in areas where I've

Re: arm-rtems switch default target to EABI

2012-06-12 Thread Ralf Corsepius
On 06/12/2012 11:53 AM, Sebastian Huber wrote: On 06/05/2012 05:19 PM, Sebastian Huber wrote: Hi, what is the blocking point for the integration of these patches? Ping. GCC uses a *-*-*eabi patterns to destinguish EABI toolchains from other ABIs. Your endeavour contradicts the spirit beh

Re: arm-rtems switch default target to EABI

2012-06-12 Thread Sebastian Huber
On 06/12/2012 01:23 PM, Ralf Corsepius wrote: On 06/12/2012 11:53 AM, Sebastian Huber wrote: On 06/05/2012 05:19 PM, Sebastian Huber wrote: Hi, what is the blocking point for the integration of these patches? Ping. GCC uses a *-*-*eabi patterns to destinguish EABI toolchains from other A

Re: [PATCH] Correct cost model for strided loads

2012-06-12 Thread William J. Schmidt
On Tue, 2012-06-12 at 12:59 +0200, Richard Guenther wrote: > Btw, with PR53533 I now have a case where multiplications of v4si are > really expensive on x86 without SSE 4.1. But we only have vect_stmt_cost > and no further subdivision ... > > Thus we'd need a tree_code argument to the cost hook.

Re: [RFC PR48941 / 51980] Rewrite arm_neon.h to use __builtin_shuffle

2012-06-12 Thread Richard Guenther
On Tue, Jun 12, 2012 at 1:07 PM, Ramana Radhakrishnan wrote: > On 12 June 2012 11:46, Richard Guenther wrote: >> On Tue, Jun 12, 2012 at 11:22 AM, Julian Brown >> wrote: >>> On Mon, 11 Jun 2012 16:46:27 +0100 >>> Ramana Radhakrishnan wrote: >>> Hi, I don't like the ML bits of th

Re: [Ping] Fix gcc/gcov.c and libgcc/libgcov.c to fix build on VxWorks

2012-06-12 Thread rbmj
On 06/11/2012 08:01 AM, Paolo Bonzini wrote: Il 11/06/2012 13:56, rbmj ha scritto: ... simply pass the extra mode argument in unconditionally, as it should be transparent to the function and ignored if it is variadic (I'm no expert on calling conventions though). Yes, please do this. Done. VxW

Re: [RFC PR48941 / 51980] Rewrite arm_neon.h to use __builtin_shuffle

2012-06-12 Thread Richard Guenther
On Tue, Jun 12, 2012 at 2:12 PM, Richard Guenther wrote: > On Tue, Jun 12, 2012 at 1:07 PM, Ramana Radhakrishnan > wrote: >> On 12 June 2012 11:46, Richard Guenther wrote: >>> On Tue, Jun 12, 2012 at 11:22 AM, Julian Brown >>> wrote: On Mon, 11 Jun 2012 16:46:27 +0100 Ramana Radhakri

Re: [RFC PR48941 / 51980] Rewrite arm_neon.h to use __builtin_shuffle

2012-06-12 Thread Ramana Radhakrishnan
> > +  if (TREE_CODE (mask) == SSA_NAME) > +    { > +      gimple def_stmt = SSA_NAME_DEF_STMT (mask); > +      if (is_gimple_assign (def_stmt) > +         && gimple_assign_rhs_code (def_stmt) == VECTOR_CST) > +       mask = gimple_assign_rhs1 (def_stmt); > +    } > + >   if (TREE_CODE (mask) == VE

Re: [RFC PR48941 / 51980] Rewrite arm_neon.h to use __builtin_shuffle

2012-06-12 Thread Richard Guenther
On Tue, Jun 12, 2012 at 2:23 PM, Ramana Radhakrishnan wrote: >> >> +  if (TREE_CODE (mask) == SSA_NAME) >> +    { >> +      gimple def_stmt = SSA_NAME_DEF_STMT (mask); >> +      if (is_gimple_assign (def_stmt) >> +         && gimple_assign_rhs_code (def_stmt) == VECTOR_CST) >> +       mask = gimpl

[Ada] New variant of -gnatn to specify inlining level

2012-06-12 Thread Arnaud Charlet
With this change, the compiler now supports the -gnatn[d] switch, where 'd' is a digit and can only be '1' or '2' for the time being, to let the user specify the level of inlining across modules. If the old form `-gnatn' is used, the compiler will pick the inlining level based on the optimization l

[Ada] Preliminary work to support SEH on Windows 64

2012-06-12 Thread Arnaud Charlet
No functional change. Tested on x86_64-pc-linux-gnu, committed on trunk 2012-06-12 Tristan Gingold * a-exexpr-gcc.adb (Unwind_Exception): Add 4 more private fields. Index: a-exexpr-gcc.adb === --- a-exexpr-gcc.adb(re

[Ada] Interplay between exception handlers and finalization

2012-06-12 Thread Arnaud Charlet
This patch corrects the machinery which detects controlled objects inside a block created for the purposes of avoiding interference of exception handlers and At_End handlers. -- Source -- -- types.ads with Ada.Finalization; use Ada.Finalization; package Types is ty

Re: [gimplefe] patch that fixes the bug for the failure test case

2012-06-12 Thread Diego Novillo
On 12-06-08 22:25 , Sandeep Soni wrote: Hi, This patch fixes the failure test case that I had submitted the last time. The changeLog is testsuite/gChangeLog.gimplefe is as follows. 2012-06-09 Sandeep Soni * gimple.dg/20120605-2.gimple : New. While the changelog in gimple/Chan

Re: [PATCH 3/3] rs6000: Rewrite sync patterns for atomic; expand early.

2012-06-12 Thread Richard Henderson
On 2012-06-11 18:40, David Edelsohn wrote: > On Sat, Jun 9, 2012 at 10:40 AM, Richard Henderson wrote: > >> Nope. I do see the obvious mistake in the atomic_load pattern though: >> The mode iterator should have been INT1 not INT. > > Did you want to commit the fix for the iterator? Yes. I'm j

[PATCH H8300] Added offset bits of MOVA/Sz assembly instruction for memory access

2012-06-12 Thread Sandeep Kumar Singh
Hi, Please find the attached patch that adds offset bits for mova/Sz assembly instruction of memory access in H8SX target. Please review the patch and let me know if there should be any modifications in it? Tested with h8300-elf. No new regressions. Regards, Sandeep Kumar Singh, KPIT Cummi

Re: [C PATCH] Diagnose compound literals with incomplete type (PR c/53532)

2012-06-12 Thread Joseph S. Myers
On Sat, 2 Jun 2012, Jakub Jelinek wrote: > Hi! > > As the testcase shows, we weren't diagnosing compound literals with > incomplete type at all. Fixed thusly, bootstrapped/regtested on > x86_64-linux and i686-linux, ok for trunk? OK with the various testcases from the other duplicates of this b

Re: [RFA:] Caveat for ARM in gcc-4.7/changes.html: unaligned accesses

2012-06-12 Thread Hans-Peter Nilsson
> From: Hans-Peter Nilsson > Date: Mon, 11 Jun 2012 00:59:57 +0200 > > From: Michael Hope > > Date: Mon, 11 Jun 2012 00:04:19 +0200 > > > On 8 June 2012 16:53, Hans-Peter Nilsson > > wrote: > > >> From: Hans-Peter Nilsson > > >> Date: Fri, 8 Jun 2012 06:29:04 +0200 > > > > > >> > From: Micha

Re: [PATCH] Option to build bare-metal ARM cross-compiler for arm-none-eabi target without libunwind

2012-06-12 Thread Joseph S. Myers
You need to provide a self-contained explanation of what the problem is that your patch is fixing and why you chose that approach to fixing it - with reference to the ARM EABI documentes (RTABI etc.) for why your approach is valid according to the ARM EABI. libunwind is a library separate from

Re: [testsuite] gcc.dg/torture/stackalign: make compile lines unique in test summary

2012-06-12 Thread Janis Johnson
On 06/11/2012 09:05 PM, H.J. Lu wrote: > On Mon, Jun 11, 2012 at 7:41 PM, Janis Johnson > wrote: >> The tests in gcc.dg/torture/stackalign use two sets of torture options: >> the usual optimization sets used as default for torture tests, and up to >> four sets of options that are specific to stac

Re: [Ada] Preliminary work to support SEH on Windows 64

2012-06-12 Thread Gabriel Dos Reis
On Tue, Jun 12, 2012 at 7:33 AM, Arnaud Charlet wrote: > No functional change. > > Tested on x86_64-pc-linux-gnu, committed on trunk > > 2012-06-12  Tristan Gingold   > >        * a-exexpr-gcc.adb (Unwind_Exception): Add 4 more private fields. > Does this mean that GCC will officially support SEH

Re: MIPS testsuite patch for --with-synci configurations

2012-06-12 Thread Steve Ellcey
On Mon, 2012-06-11 at 18:24 -0700, David Daney wrote: > > This patch addes the -mno-synci flag to MIPS tests that specify an > > architecture that does not support synci, thus getting rid of the > > warning message and making the tests pass. Tested with the mips-linux-gnu > > and mips-sde-elf tar

Re: [PATCH] Option to build bare-metal ARM cross-compiler for arm-none-eabi target without libunwind

2012-06-12 Thread Sebastian Huber
On 06/12/2012 04:37 PM, Joseph S. Myers wrote: You need to provide a self-contained explanation of what the problem is that your patch is fixing and why you chose that approach to fixing it - with reference to the ARM EABI documentes (RTABI etc.) for why your approach is valid according to the AR

Re: [patch][gcc47] Deprecate -fconserve-space

2012-06-12 Thread Joseph S. Myers
On Mon, 4 Jun 2012, Jason Merrill wrote: > On 06/04/2012 04:30 PM, Steven Bosscher wrote: > > How about this: > > OK, looks good. > > > There is still a file config/arm/aout.h > > I noticed that, but it seems to be used together with elfos.h, so it seems not > to be a.out-specific. :) I comme

Re: [Ada] Preliminary work to support SEH on Windows 64

2012-06-12 Thread Tristan Gingold
On Jun 12, 2012, at 5:00 PM, Gabriel Dos Reis wrote: > On Tue, Jun 12, 2012 at 7:33 AM, Arnaud Charlet wrote: >> No functional change. >> >> Tested on x86_64-pc-linux-gnu, committed on trunk >> >> 2012-06-12 Tristan Gingold >> >>* a-exexpr-gcc.adb (Unwind_Exception): Add 4 more pri

Re: [Ada] Preliminary work to support SEH on Windows 64

2012-06-12 Thread Gabriel Dos Reis
On Tue, Jun 12, 2012 at 10:18 AM, Tristan Gingold wrote: > > On Jun 12, 2012, at 5:00 PM, Gabriel Dos Reis wrote: > >> On Tue, Jun 12, 2012 at 7:33 AM, Arnaud Charlet wrote: >>> No functional change. >>> >>> Tested on x86_64-pc-linux-gnu, committed on trunk >>> >>> 2012-06-12  Tristan Gingold   >

Re: [Patch, ARM][0/8] Epilogue in RTL: introduction (Sameera's patches, Part I)

2012-06-12 Thread Richard Earnshaw
On 31/05/12 19:18, Paul Brook wrote: >> * The patches have not been explicitly tested with any FPA variants (which >> are deprecated in 4.7 and expected to become obsolete in 4.8). > > I'm not keen on breaking these without actually removing them. > > Paul > Ok, so lets remove them... R.

Re: [PATCH H8300] Added offset bits of MOVA/Sz assembly instruction for memory access

2012-06-12 Thread Jeff Law
On 06/12/2012 07:55 AM, Sandeep Kumar Singh wrote: Hi, Please find the attached patch that adds offset bits for mova/Sz assembly instruction of memory access in H8SX target. Please review the patch and let me know if there should be any modifications in it? Tested with h8300-elf. No new re

Re: [testsuite] gcc.dg/torture/stackalign: make compile lines unique in test summary

2012-06-12 Thread H.J. Lu
On Tue, Jun 12, 2012 at 7:59 AM, Janis Johnson wrote: > On 06/11/2012 09:05 PM, H.J. Lu wrote: >> On Mon, Jun 11, 2012 at 7:41 PM, Janis Johnson >> wrote: >>> The tests in gcc.dg/torture/stackalign use two sets of torture options: >>> the usual optimization sets used as default for torture tests

Re: [PATCH] Hoist adjacent loads

2012-06-12 Thread H.J. Lu
On Mon, Jun 11, 2012 at 1:37 PM, William J. Schmidt wrote: > OK, once more with feeling... :) > > This patch differs from the previous one in two respects:  It disables > the optimization when either the then or else edge is well-predicted; > and it now uses the existing l1-cache-line-size paramet

Re: [PATCH 3/7] Add stdint.h wrapper for VxWorks.

2012-06-12 Thread Joseph S. Myers
On Wed, 6 Jun 2012, rbmj wrote: > The stdint.h doesn't have all the typedefs needed for standards > compliance, so add a hack that adds all of the needed typedefs > to be fully compliant to the standard. Fixes broken libstdc++. If you're touching VxWorks stdint.h perhaps you could also define th

Re: [PATCH 3/3] rs6000: Rewrite sync patterns for atomic; expand early.

2012-06-12 Thread Richard Henderson
On 2012-06-11 18:40, David Edelsohn wrote: >> > Nope. I do see the obvious mistake in the atomic_load pattern though: >> > The mode iterator should have been INT1 not INT. > Did you want to commit the fix for the iterator? > Applied the following to mainline. It ought to go onto the 4.7 branch

[Google 4.6] Backport C++ canonicalization patch (issue6297080)

2012-06-12 Thread Sterling Augustine
The enclosed patch for Google 4.6 backports the final pubnames-canonicalization patch from top of trunk. It differs slightly from the earlier one because google/4.6 had an earlier implementation already present. OK for Google 4.6? Sterling 2012-06-11 Sterling Augustine * gcc/c-famil

Re: RFA: Alternative iterator implementation

2012-06-12 Thread Tejas Belagod
Richard Sandiford wrote: Thanks for the update. Tejas Belagod writes: +/* Implementations of the iterator_group callbacks for ints. */ + +/* Since GCC does not construct a table of valid constants, + we have to accept any int as valid. No cross-checking can + be done. */ + +static int +

Re: [Google 4.6] Backport C++ canonicalization patch (issue6297080)

2012-06-12 Thread Diego Novillo
On 12-06-12 11:58 , Sterling Augustine wrote: +/* Wrap lang_decl_name with options appropriate for dwarf. */ + +const char * +lang_decl_dwarf_name (tree decl, int v, bool translate) +{ + const char *name; + /* Curiously, reinit_cxx_pp doesn't reset the flags field, so setting the flag +

Re: [Google 4.6] Backport C++ canonicalization patch (issue6297080)

2012-06-12 Thread Sterling Augustine
On Tue, Jun 12, 2012 at 9:36 AM, Diego Novillo wrote: > On 12-06-12 11:58 , Sterling Augustine wrote: > >> +/* Wrap lang_decl_name with options appropriate for dwarf.  */ >> + >> +const char * >> +lang_decl_dwarf_name (tree decl, int v, bool translate) >> +{ >> +  const char *name; >> +  /* Curiou

Re: [Google 4.6] Backport C++ canonicalization patch (issue6297080)

2012-06-12 Thread Diego Novillo
On 12-06-12 12:57 , Sterling Augustine wrote: The wrapper code is the same, but the internal call is not--"lang_decl_name" and "decl_as_string" return different strings, and their interface is different so it wouldn't be easy to pass a function pointer. So, I'm not sure how you would combine th

Re: [testsuite] c-c++-common: make message check lines unique in test summary

2012-06-12 Thread Mike Stump
On Jun 11, 2012, at 7:33 PM, Janis Johnson wrote: > This test modifies dg-error and dg-warning test directives by adding > comments that will be added to lines in the test summary to eliminate > non-unique lines for checks of messages for the same line of source code > in a test. > > OK for mainli

Re: [testsuite] gcc.target/arm: make message check lines unique in test summary

2012-06-12 Thread Mike Stump
On Jun 11, 2012, at 7:40 PM, Janis Johnson wrote: > This test modifies dg-message test directives by adding comments that > will be added to lines in the test summary to eliminate non-unique lines > for checks of messages for the same line of source code in a test. > OK for mainline? Ok.

[SH] PR 53511 - Remove obsolete PR 51340 test cases

2012-06-12 Thread Oleg Endo
Hello, As mentioned in http://gcc.gnu.org/ml/gcc-patches/2012-06/msg00544.html the PR 51340 test cases are obsolete. The attached patch deletes them. OK? Cheers, Oleg testsuite/ChangeLog: PR target/53511 * gcc.target/sh/pr51340-1.c: Delete obsolete test case. * gcc.tar

Re: [testsuite] gcc.dg/torture/stackalign: make compile lines unique in test summary

2012-06-12 Thread Mike Stump
On Jun 11, 2012, at 7:41 PM, Janis Johnson wrote: > The tests in gcc.dg/torture/stackalign use two sets of torture options: > OK for mainline? Ok, if H.J. is happy.

Re: [testsuite] gcc.dg/torture/stackalign: make compile lines unique in test summary

2012-06-12 Thread H.J. Lu
On Tue, Jun 12, 2012 at 10:22 AM, Mike Stump wrote: > On Jun 11, 2012, at 7:41 PM, Janis Johnson wrote: >> The tests in gcc.dg/torture/stackalign use two sets of torture options: > >> OK for mainline? > > Ok, if H.J. is happy. It is OK for me. Thanks. -- H.J.

Re: [PATCH 3/3] rs6000: Rewrite sync patterns for atomic; expand early.

2012-06-12 Thread Mike Stump
On Jun 12, 2012, at 6:40 AM, Richard Henderson wrote: > On 2012-06-11 18:40, David Edelsohn wrote: >> On Sat, Jun 9, 2012 at 10:40 AM, Richard Henderson wrote: >> >>> Nope. I do see the obvious mistake in the atomic_load pattern though: >>> The mode iterator should have been INT1 not INT. >> >>

Re: [SH] PR 53511 - Remove obsolete PR 51340 test cases

2012-06-12 Thread Mike Stump
On Jun 12, 2012, at 10:05 AM, Oleg Endo wrote: > As mentioned in http://gcc.gnu.org/ml/gcc-patches/2012-06/msg00544.html > the PR 51340 test cases are obsolete. The attached patch deletes them. > > OK? Ok. Didn't Kaz already pre-approve the concept?

Re: libgo patch committed: Update to Go 1.0.1 release

2012-06-12 Thread Mike Stump
On Jun 11, 2012, at 10:11 PM, Ian Lance Taylor wrote: > Mike Stump writes: >> On May 4, 2012, at 8:01 AM, Ian Lance Taylor wrote: >>> This patch updates libgo to the Go 1.0.1 release. This is a relatively >>> small collection of bug fixes, with no API changes. >> >> So, it is an important part o

Re: [gimplefe] patch that fixes the bug for the failure test case

2012-06-12 Thread Sandeep Soni
On Tue, Jun 12, 2012 at 6:57 PM, Diego Novillo wrote: > On 12-06-08 22:25 , Sandeep Soni wrote: >> >> Hi, >> >> This patch fixes the failure test case that I had submitted the last time. >> >> The changeLog is testsuite/gChangeLog.gimplefe is as follows. >> >> 2012-06-09   Sandeep Soni >>        

[gimplefe] Tests for type declarations and variable declarations

2012-06-12 Thread Sandeep Soni
The patch adds some preliminary tests for type declarations and varaible declarations for the gimple front end. Following is the ChangeLog Entry. 2012-06-12 Sandeep Soni gimple.dg/20120611-1.gimple : New. gimple.dg/20120611-2.gimple : New. gimple.dg/20120611-3.gimple : N

Re: [gimplefe] patch that fixes the bug for the failure test case

2012-06-12 Thread Diego Novillo
On 12-06-12 13:52 , Sandeep Soni wrote: On Tue, Jun 12, 2012 at 6:57 PM, Diego Novillo wrote: On 12-06-08 22:25 , Sandeep Soni wrote: Hi, This patch fixes the failure test case that I had submitted the last time. The changeLog is testsuite/gChangeLog.gimplefe is as follows. 2012-06-09 Sa

Re: [gimplefe] Tests for type declarations and variable declarations

2012-06-12 Thread Diego Novillo
On 12-06-12 14:20 , Sandeep Soni wrote: 2012-06-12 Sandeep Soni gimple.dg/20120611-1.gimple : New. gimple.dg/20120611-2.gimple : New. gimple.dg/20120611-3.gimple : New. gimple.dg/20120611-4.gimple : New. gimple.dg/type-1.gimple : New. gimple

Re: RFA: Alternative iterator implementation

2012-06-12 Thread Richard Sandiford
Tejas Belagod writes: > New patch attached. OK? > +There are two standard integer attributes: @code{int}, the name of the > +code in lower case, and @code{INT}, the name of the code in upper case. I don't think this is true. So the surrounding paragraph reduces to: It is possible to define a

Re: [SH] PR 53511 - Remove obsolete PR 51340 test cases

2012-06-12 Thread Oleg Endo
On Tue, 2012-06-12 at 10:46 -0700, Mike Stump wrote: > On Jun 12, 2012, at 10:05 AM, Oleg Endo wrote: > > As mentioned in http://gcc.gnu.org/ml/gcc-patches/2012-06/msg00544.html > > the PR 51340 test cases are obsolete. The attached patch deletes them. > > > > OK? > > Ok. Didn't Kaz already pre

Re: C++ PATCH for c++/53599 (ICE with local class in template)

2012-06-12 Thread Jason Merrill
On 06/07/2012 04:29 PM, Jason Merrill wrote: The problem here was that when we instantiate G::bar, we want to instantiate F, and end up improperly pushing the declaration inside G, which leads to the ICE. Adjusting the call to pushclass is enough to fix this, which is what I propose doing for the

Re: Updated to respond to various email comments from Jason, Diego and Cary (issue6197069)

2012-06-12 Thread Sterling Augustine
On Fri, Jun 8, 2012 at 3:03 PM, Sterling Augustine wrote: [Regarding generating pubnames] > OK, I've updated the patch with all these additional comments. Just > waiting on the decision between -f and -g. I'll repost and then commit > it when that is settled--hopefully soon. > > Next up, the big

Re: constant that doesn't fit in 32bits in alpha.c

2012-06-12 Thread Joseph S. Myers
I'd rather have a macro HOST_WIDE_INT_C in hwint.h (like INTMAX_C etc. in stdint.h). HOST_WIDE_INT_1 is already defined in hwint.h to either 1L or 1LL; I'd suggest defining HOST_WIDE_INT_C to concatenate with either L or LL (and then HOST_WIDE_INT_1 can be HOST_WIDE_INT_C (1), unconditionally).

Re: [PATCH 3/7] Add stdint.h wrapper for VxWorks.

2012-06-12 Thread rbmj
On 06/12/2012 11:47 AM, Joseph S. Myers wrote: On Wed, 6 Jun 2012, rbmj wrote: The stdint.h doesn't have all the typedefs needed for standards compliance, so add a hack that adds all of the needed typedefs to be fully compliant to the standard. Fixes broken libstdc++. If you're touching VxWor

Re: [PATCH 3/7] Add stdint.h wrapper for VxWorks.

2012-06-12 Thread Joseph S. Myers
On Tue, 12 Jun 2012, rbmj wrote: > On 06/12/2012 11:47 AM, Joseph S. Myers wrote: > > On Wed, 6 Jun 2012, rbmj wrote: > > > > > The stdint.h doesn't have all the typedefs needed for standards > > > compliance, so add a hack that adds all of the needed typedefs > > > to be fully compliant to the s

Go patch committed: Handle package path like gc compiler

2012-06-12 Thread Ian Lance Taylor
This patch to the Go frontend and the runtime library handles the package path like the other Go compiler. Gccgo needs to canonicalize type names based on the reflection string, so that types defined in shared libraries work correctly. That means that it needs to include the package path in the r

Re: [PR49888, VTA] don't keep VALUEs bound to modified MEMs

2012-06-12 Thread Richard Henderson
On 2012-06-05 12:33, Alexandre Oliva wrote: > for gcc/ChangeLog > from Alexandre Oliva > > PR debug/49888 > * var-tracking.c: Include alias.h. > (overlapping_mems): New struct. > (drop_overlapping_mem_locs): New. > (clobber_overlapping_mems): New. > (var_mem

Re: Committed: atomic support for CRIS

2012-06-12 Thread Richard Henderson
On 2012-05-31 22:58, Hans-Peter Nilsson wrote: > +(define_expand "atomic_compare_and_swap" > + [(match_operand:SI 0 "register_operand") > + (match_operand:BWD 1 "register_operand") > + (match_operand:BWD 2 "memory_operand") > + (match_operand:BWD 3 "general_operand") > + (match_operand:BWD

[PATCH] Add anddi_1 -> andsi_1_zext splitter (PR target/53639)

2012-06-12 Thread Jakub Jelinek
Hi! The combiner combines (set (reg:SI x) (and:SI (reg:SI y) (const_int 1234))) (set (reg:DI z) (zero_extend:DI (reg:SI x))) into (set (reg:DI z) (and:DI (subreg:DI (reg:SI (y) 0) (const_int 1234 which unfortunately isn't the best form on x86_64 from RA POV, because if y needs to be moved arou

Re: RFA: Alternative iterator implementation

2012-06-12 Thread Richard Henderson
On 2012-06-12 11:26, Richard Sandiford wrote: > Tejas Belagod writes: >> New patch attached. OK? > >> +There are two standard integer attributes: @code{int}, the name of the >> +code in lower case, and @code{INT}, the name of the code in upper case. > > I don't think this is true. So the surrou

Re: [PATCH] Add anddi_1 -> andsi_1_zext splitter (PR target/53639)

2012-06-12 Thread Richard Henderson
On 2012-06-12 14:22, Jakub Jelinek wrote: > PR target/53639 > * config/i386/i386.md (*anddi_1 into *andsi_1_zext splitter): New. Ok. r~

Re: [SH] PR 53511 - Remove obsolete PR 51340 test cases

2012-06-12 Thread Kaz Kojima
Oleg Endo wrote: > As mentioned in http://gcc.gnu.org/ml/gcc-patches/2012-06/msg00544.html > the PR 51340 test cases are obsolete. The attached patch deletes them. > > OK? OK. Regards, kaz

Re: [RFA:] Caveat for ARM in gcc-4.7/changes.html: unaligned accesses

2012-06-12 Thread Michael Hope
On 13 June 2012 02:32, Hans-Peter Nilsson wrote: >> From: Hans-Peter Nilsson >> Date: Mon, 11 Jun 2012 00:59:57 +0200 > >> > From: Michael Hope >> > Date: Mon, 11 Jun 2012 00:04:19 +0200 >> >> > On 8 June 2012 16:53, Hans-Peter Nilsson >> > wrote: >> > >> From: Hans-Peter Nilsson >> > >> Date

Re: [PATCH 3/3] rs6000: Rewrite sync patterns for atomic; expand early.

2012-06-12 Thread David Edelsohn
On Tue, Jun 12, 2012 at 11:51 AM, Richard Henderson wrote: > On 2012-06-11 18:40, David Edelsohn wrote: >>> > Nope.  I do see the obvious mistake in the atomic_load pattern though: >>> > The mode iterator should have been INT1 not INT. >> Did you want to commit the fix for the iterator? >> > > App

Re: [PATCH 3/3] rs6000: Rewrite sync patterns for atomic; expand early.

2012-06-12 Thread David Edelsohn
On Tue, Jun 12, 2012 at 9:40 AM, Richard Henderson wrote: >> I like your suggestion, but the PowerPC developer community does not >> uniformly appreciate that behavior. > > Surely there's a difference between gratuitously using fp registers > and that being the *only* way to implement a particula

Re: Committed: atomic support for CRIS

2012-06-12 Thread Hans-Peter Nilsson
> From: Richard Henderson > Date: Tue, 12 Jun 2012 23:04:02 +0200 > On 2012-05-31 22:58, Hans-Peter Nilsson wrote: > > +(define_expand "atomic_compare_and_swap" > > + [(match_operand:SI 0 "register_operand") > > + (match_operand:BWD 1 "register_operand") > > + (match_operand:BWD 2 "memory_op

Re: [RFA:] Caveat for ARM in gcc-4.7/changes.html: unaligned accesses

2012-06-12 Thread Hans-Peter Nilsson
> From: Michael Hope > Date: Wed, 13 Jun 2012 00:43:47 +0200 > On 13 June 2012 02:32, Hans-Peter Nilsson wrote: > >> From: Hans-Peter Nilsson > >> Date: Mon, 11 Jun 2012 00:59:57 +0200 > >> > > user-space code".  Maybe the kernel too, I can't say; there was > >> > > IIRC no sign of it. > > But

[PATCH, RFC] First cut at using vec_construct for strided loads

2012-06-12 Thread William J. Schmidt
This patch is a follow-up to the discussion generated by http://gcc.gnu.org/ml/gcc-patches/2012-06/msg00546.html. I've added vec_construct to the cost model for use in vect_model_load_cost, and implemented a cost calculation that makes sense to me for PowerPC. I'm less certain about the default,

Re: Updated to respond to various email comments from Jason, Diego and Cary (issue6197069)

2012-06-12 Thread Jason Merrill
On 06/08/2012 05:22 PM, Cary Coutant wrote: I kind of prefer -g, but I did notice that it's -fdebug-types-section, so I could go with -f[no-]pubnames (or, as Jakub suggests, -f[no-]debug-pubnames-section). On the other hand, there's -g[no-]record-gcc-switches. What would you prefer? If we change

libgo patch committed: Use Entersyscall when reading directories

2012-06-12 Thread Ian Lance Taylor
This patch to libgo uses Entersyscall and Exitsyscall when reading directory entries. This matters when reading a directory from something that can stall, such as NFS or a user-mounted file system. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -

Re: C++ PATCH for c++/48370 (extending lifetime of temps in aggregate initialization)

2012-06-12 Thread H.J. Lu
On Thu, Nov 3, 2011 at 8:50 PM, Jason Merrill wrote: > 12.2 states that a temporary bound to a reference lives as long as the > reference itself.  We have done that for reference variables, but not in > other cases, such as aggregate initialization of a struct with reference > members.  In C++11,

  1   2   >