On Tue, 2012-06-12 at 12:59 +0200, Richard Guenther wrote: > Btw, with PR53533 I now have a case where multiplications of v4si are > really expensive on x86 without SSE 4.1. But we only have vect_stmt_cost > and no further subdivision ... > > Thus we'd need a tree_code argument to the cost hook. Though it gets > quite overloaded then, so maybe splitting it into one handling loads/stores > (and get the misalign parameter) and one handling only vector_stmt but > with a tree_code argument. Or splitting it even further, seeing > cond_branch_taken ...
Yes, I think subdividing the hook for the vector_stmt kind is pretty much inevitable -- more situations like this expensive multiply will arise. I agree with the interface starting to get messy also. Splitting it is probably the way to go -- a little painful but keeping it all in one hook is going to get ugly. Bill > > Richard. >
