Re: [patch] New backend header reduction

2015-10-30 Thread Andreas Schwab
../../gcc/ggc-common.c: In function 'void init_ggc_heuristics()': ../../gcc/ggc-common.c:822: error: 'GGC_MIN_EXPAND' was not declared in this scope ../../gcc/ggc-common.c:822: error: 'set_default_param_value' was not declared in this scope ../../gcc/ggc-common.c:823: error: 'GGC_MIN_HEAPSIZE' wa

Re: [PATCH 4/5] remove usage of BIGGEST_FIELD_ALIGNMENT in encoding.c

2015-10-30 Thread Andrew Pinski
On Fri, Oct 30, 2015 at 7:48 PM, wrote: > From: Trevor Saunders > > Similar to ROUND_TYPE_ALIGN it seems to make sense to copy the > information in the target macros to libobjc as an incremental step. Its > worth noting a large portion of the definitions of this macro only exist > to work aroun

Re: [PATCH 3/5] stop using ROUND_TYPE_ALIGN in libobjc/

2015-10-30 Thread Andrew Pinski
On Fri, Oct 30, 2015 at 7:48 PM, wrote: > From: Trevor Saunders > > Given the layering violation that using ROUND_TYPE_ALIGN in target libs > is, and the hacks needed to make it work just coppying the relevant code > into encoding.c seems to make sense as an incremental improvement. The > epiph

Re: [PATCH 2/5] remove usage of ROUND_TYPE_SIZE from encoding.c

2015-10-30 Thread Andrew Pinski
On Fri, Oct 30, 2015 at 7:48 PM, wrote: > From: Trevor Saunders > > gcc got rid of this target macro in 2003, so it seems safe to assume the > alternate path works fine on all targets. This is ok. > > libobjc/ChangeLog: > > 2015-10-30 Trevor Saunders > > PR libobjc/24775 >

Re: more accurate omp in fortran

2015-10-30 Thread Dominique d'Humières
> diff --git a/gcc/fortran/openmp.c b/gcc/fortran/openmp.c Revision r229609 breaks bootstrap: ../../work/gcc/fortran/openmp.c: In function 'void resolve_omp_clauses(gfc_code*, gfc_omp_clauses*, gfc_namespace*, bool)': ../../work/gcc/fortran/openmp.c:2925:27: error: format '%L' expects argument o

[PATCH] [ARM] PR61551 RFC: Improve costs for NEON addressing modes

2015-10-30 Thread Charles Baylis
Hi Ramana, [revisiting https://gcc.gnu.org/ml/gcc-patches/2015-06/msg01593.html] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61551 This patch is an initial attempt to rework the ARM rtx costs to better handle the costs of various addressing modes, in particular to remove the incorrect large cos

libgo patch committed: Update to Go 1.5 release

2015-10-30 Thread Ian Lance Taylor
I have committed a patch to libgo to update it to the Go 1.5 release. As usual for libgo updates, the actual patch is too large to attach to this e-mail message. I've attached the changes to the gccgo-specific files. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainlin

Go patch committed: build pointer type to types with methods

2015-10-30 Thread Ian Lance Taylor
The Go compiler always builds the pointer type for any named type, so that it can attach methods in case the program calls reflect.PtrTo. However, it didn't do that for unnamed types that happened to have methods due to inheritance. This patch fixes that problem. Bootstrapped and ran Go testsuite

Re: cgraph offloading error?

2015-10-30 Thread Nathan Sidwell
On 10/30/15 15:30, Jeff Law wrote: On 10/30/2015 04:16 PM, Nathan Sidwell wrote: Cool. I'll go ahead and add nvptx-elf to the list shortly on the assumption this stuff will get fixed on way or another. I've just committed nvptx-none Index: ChangeLog

Re: cgraph offloading error?

2015-10-30 Thread Jeff Law
On 10/30/2015 04:16 PM, Nathan Sidwell wrote: On 10/30/15 14:28, Jeff Law wrote: So when we don't use src_reg or dst_mode, we'll get a warning about the unused variable. I guess this is the first port where HARD_REGNO_NREGS is a constant. Yeah, I noticed that when first lookingat the port, b

Re: cgraph offloading error?

2015-10-30 Thread Nathan Sidwell
On 10/30/15 15:16, Nathan Sidwell wrote: Testing attached ... ... with parens on void cast args ... nathan

Re: cgraph offloading error?

2015-10-30 Thread Nathan Sidwell
On 10/30/15 14:28, Jeff Law wrote: So when we don't use src_reg or dst_mode, we'll get a warning about the unused variable. I guess this is the first port where HARD_REGNO_NREGS is a constant. Yeah, I noticed that when first lookingat the port, but as it wasn't (apparently) broken ... Sec

Re: [patch] New backend header reduction

2015-10-30 Thread Jeff Law
On 10/30/2015 02:23 PM, Cesar Philippidis wrote: On 10/30/2015 01:20 PM, Andrew MacLeod wrote: On 10/30/2015 02:09 PM, Andrew MacLeod wrote: On 10/30/2015 01:56 PM, Cesar Philippidis wrote: On 10/23/2015 12:24 PM, Jeff Law wrote: On 10/23/2015 10:53 AM, Andrew MacLeod wrote: There's a littl

Re: cgraph offloading error?

2015-10-30 Thread Jeff Law
On 10/30/2015 03:04 PM, Nathan Sidwell wrote: On 10/30/15 13:54, Jeff Law wrote: On 10/30/2015 02:52 PM, Nathan Sidwell wrote: This bit of trunk code in cgraph_node::create at around line 500 of cgraph.c looks wrong. Specifically the contents of the #ifdef -- it's uncompilable as there's no '

Re: [OpenACC] num_gangs, num_workers and vector_length in c++

2015-10-30 Thread Cesar Philippidis
On 10/30/2015 10:05 AM, Jakub Jelinek wrote: > On Fri, Oct 30, 2015 at 07:42:39AM -0700, Cesar Philippidis wrote: >>> Another thing is what Jason as C++ maintainer wants, it is nice to get rid >>> of some code redundancies, on the other side the fact that there is one >>> function per non-terminal

Re: cgraph offloading error?

2015-10-30 Thread Nathan Sidwell
On 10/30/15 13:54, Jeff Law wrote: On 10/30/2015 02:52 PM, Nathan Sidwell wrote: This bit of trunk code in cgraph_node::create at around line 500 of cgraph.c looks wrong. Specifically the contents of the #ifdef -- it's uncompilable as there's no 'g'. if ((flag_openacc || flag_openmp)

Re: cgraph offloading error?

2015-10-30 Thread Jeff Law
On 10/30/2015 02:52 PM, Nathan Sidwell wrote: This bit of trunk code in cgraph_node::create at around line 500 of cgraph.c looks wrong. Specifically the contents of the #ifdef -- it's uncompilable as there's no 'g'. if ((flag_openacc || flag_openmp) && lookup_attribute ("omp declare t

cgraph offloading error?

2015-10-30 Thread Nathan Sidwell
This bit of trunk code in cgraph_node::create at around line 500 of cgraph.c looks wrong. Specifically the contents of the #ifdef -- it's uncompilable as there's no 'g'. if ((flag_openacc || flag_openmp) && lookup_attribute ("omp declare target", DECL_ATTRIBUTES (decl))) { no

Re: [patch] New backend header reduction

2015-10-30 Thread Jeff Law
On 10/30/2015 02:23 PM, Cesar Philippidis wrote: On 10/30/2015 01:20 PM, Andrew MacLeod wrote: On 10/30/2015 02:09 PM, Andrew MacLeod wrote: On 10/30/2015 01:56 PM, Cesar Philippidis wrote: On 10/23/2015 12:24 PM, Jeff Law wrote: On 10/23/2015 10:53 AM, Andrew MacLeod wrote: There's a littl

Re: [PATCH][PR tree-optimization/67892] Use FSM threader to handle backedges

2015-10-30 Thread Jeff Law
On 10/30/2015 07:57 AM, Andreas Schwab wrote: I'm getting this regression on m68k: FAIL: gcc.dg/tree-ssa/ssa-thread-11.c scan-tree-dump vrp2 "FSM" The generated code looks equivalent, though. Definitely an artifact of differences in branch costing. Pondering the best way to fix. jeff

Re: [patch] New backend header reduction

2015-10-30 Thread Cesar Philippidis
On 10/30/2015 01:20 PM, Andrew MacLeod wrote: > On 10/30/2015 02:09 PM, Andrew MacLeod wrote: >> On 10/30/2015 01:56 PM, Cesar Philippidis wrote: >>> On 10/23/2015 12:24 PM, Jeff Law wrote: On 10/23/2015 10:53 AM, Andrew MacLeod wrote: >>> There's a little bit of fallout with this patch w

Re: [patch] New backend header reduction

2015-10-30 Thread Andrew MacLeod
On 10/30/2015 02:09 PM, Andrew MacLeod wrote: On 10/30/2015 01:56 PM, Cesar Philippidis wrote: On 10/23/2015 12:24 PM, Jeff Law wrote: On 10/23/2015 10:53 AM, Andrew MacLeod wrote: There's a little bit of fallout with this patch when building an offloaded compiler for openacc. It looks like c

Re: [PATCH][PR tree-optimization/67892] Use FSM threader to handle backedges

2015-10-30 Thread Jeff Law
On 10/30/2015 07:57 AM, Andreas Schwab wrote: I'm getting this regression on m68k: FAIL: gcc.dg/tree-ssa/ssa-thread-11.c scan-tree-dump vrp2 "FSM" The generated code looks equivalent, though. How cool. This test also shows the FSM bits creating an irreducible loop in cases where it's no likel

Re: [PATCH 4b] diagnostic-show-locus.c changes: Insertions

2015-10-30 Thread David Malcolm
On Thu, 2015-10-29 at 22:49 -0600, Jeff Law wrote: > On 10/28/2015 12:09 PM, David Malcolm wrote: > > gcc/ChangeLog: > > * diagnostic-show-locus.c (struct point_state): New struct. > > (class colorizer): New class. > > (class layout_point): New class. > > (class layout_range): New c

Re: C++ PATCH for C++14 sized deallocation

2015-10-30 Thread Jason Merrill
On 12/15/2014 01:30 PM, Jason Merrill wrote: This patch implements the last remaining language feature for C++14, global sized deallocation. C++ has always had sized deallocation at class scope, but didn't for deletes that use the global operator delete. The support can be controlled separately

[PATCH,committed] PR fortran/46588 -- add testcase

2015-10-30 Thread Steve Kargl
I've committed a testcase for PR fortran/46588 to trunk. The patches for PR 67805 and 68108 fixed this 46588, but the testcase goes through a differenti compiler path. 2015-10-30 Steven G. Kargl PR fortran/46588 * gfortran.dg/pr46588.f90: New test. Index: gcc/testsuite/gfortr

Re: [gomp4.1] Handle new form of #pragma omp declare target

2015-10-30 Thread Jakub Jelinek
On Fri, Oct 30, 2015 at 08:44:07PM +0300, Ilya Verbin wrote: > On Wed, Oct 28, 2015 at 00:11:03 +0300, Ilya Verbin wrote: > > On Fri, Jul 17, 2015 at 15:05:59 +0200, Jakub Jelinek wrote: > > > As the testcases show, #pragma omp declare target has now a new form > > > (well, > > > two; with some is

[PATCH,committed] PR fortran/51993 -- Convert assert() to if-statement

2015-10-30 Thread Steve Kargl
I've committed the attached patch as obvious. It converts a gcc_assert() into an if-statement, which then allows gfortran to issue a sensible error message. 2015-10-15 Steven G. Kargl PR fortran/51993 * decl.c (gfc_set_constant_character_len): Convert gcc_assert into an

Re: [patch] New backend header reduction

2015-10-30 Thread Andrew MacLeod
On 10/30/2015 01:56 PM, Cesar Philippidis wrote: On 10/23/2015 12:24 PM, Jeff Law wrote: On 10/23/2015 10:53 AM, Andrew MacLeod wrote: There's a little bit of fallout with this patch when building an offloaded compiler for openacc. It looks like cgraph.c needs to include context.h and varpool.

Re: [PR68083] stop ifcombine from moving uninitialized uses before their guards

2015-10-30 Thread Alexandre Oliva
On Oct 30, 2015, Alexandre Oliva wrote: > Incidentally, bb_no_side_effects_p (inner_cond_bb) is called in all four > tests in tree_ssa_ifcombine_bb_1, for each outer_cond_bb that > tree_ssa_ifcombine_bb might choose. Is there any reason to not factor > it out to the test that checks whether the

Re: [Patch ifcvt] Teach RTL ifcvt to handle multiple simple set instructions

2015-10-30 Thread James Greenhalgh
On Thu, Sep 10, 2015 at 07:23:28PM +0100, Bernd Schmidt wrote: > On 09/08/2015 04:53 PM, James Greenhalgh wrote: > > One big question I have with this patch is how I ought to write a meaningful > > cost model I've used. It seems like yet another misuse of RTX costs, and > > another bit of stuff fo

Re: [patch] New backend header reduction

2015-10-30 Thread Cesar Philippidis
On 10/23/2015 12:24 PM, Jeff Law wrote: > On 10/23/2015 10:53 AM, Andrew MacLeod wrote: >> Just finished running... I think the external hard drive was slowing >> down this run :-P It took quite a while. >> >> Anyway, this is the reduction patch independent of the header-ordering >> patch... ie,

Re: [PATCH][PR tree-optimization/67892] Use FSM threader to handle backedges

2015-10-30 Thread Jeff Law
On 10/30/2015 07:57 AM, Andreas Schwab wrote: I'm getting this regression on m68k: FAIL: gcc.dg/tree-ssa/ssa-thread-11.c scan-tree-dump vrp2 "FSM" The generated code looks equivalent, though. This looks to be an issue with logicals & short-circuiting.. I wouldn't be surprised if we end up wit

patch to fix PR68106

2015-10-30 Thread Vladimir Makarov
The following patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68106 The patch was bootstrapped and tested on x86/x86-64 and tested on aarch64. Committed as rev. 229593. Index: ChangeLog === --- ChangeLog (revision

Re: [gomp4.1] Handle new form of #pragma omp declare target

2015-10-30 Thread Ilya Verbin
On Wed, Oct 28, 2015 at 00:11:03 +0300, Ilya Verbin wrote: > On Fri, Jul 17, 2015 at 15:05:59 +0200, Jakub Jelinek wrote: > > As the testcases show, #pragma omp declare target has now a new form (well, > > two; with some issues on it pending), where it is used just as a single > > declarative direc

Re: [PATCH] replace BITS_PER_UNIT with __CHAR_BIT__ in target libs

2015-10-30 Thread Bernd Schmidt
On 10/30/2015 06:10 PM, DJ Delorie wrote: $subject as far as I am aware these are the same on all supported targets. The documentation for __CHAR_BIT__ says not to use it... @item __CHAR_BIT__ Defined to the number of bits used in the representation of the @code{char} data type. It e

Re: [PATCH] libitm: Support sized delete.

2015-10-30 Thread Richard Henderson
> #define _ZnwXS(_Znw,MANGLE_SIZE_T) > #define _ZnaXS(_Zna,MANGLE_SIZE_T) > +#define _ZdlPvX S(_ZdlPv,MANGLE_SIZE_T) > #define _ZnwXRKSt9nothrow_t S(S(_Znw,MANGLE_SIZE_T),RKSt9nothrow_t) > #define _ZnaXRKSt9nothrow_t S(S(_Zn

Re: [OpenACC] num_gangs, num_workers and vector_length in c++

2015-10-30 Thread Jakub Jelinek
On Fri, Oct 30, 2015 at 07:42:39AM -0700, Cesar Philippidis wrote: > The openacc spec doesn't actually define int-expr, but we take to me > mean a single integral value. In general, the openacc spec uses the term > list to describe comma separated expressions. So we've been assuming So does OpenMP

Re: [PATCH] replace BITS_PER_UNIT with __CHAR_BIT__ in target libs

2015-10-30 Thread DJ Delorie
> $subject as far as I am aware these are the same on all supported targets. The documentation for __CHAR_BIT__ says not to use it... @item __CHAR_BIT__ Defined to the number of bits used in the representation of the @code{char} data type. It exists to make the standard header given num

Re: more accurate omp in fortran

2015-10-30 Thread Jakub Jelinek
Hi! On Fri, Oct 30, 2015 at 10:03:23AM -0700, Cesar Philippidis wrote: This looks good to me, iff you write ChangeLog entry for it. > diff --git a/gcc/fortran/gfortran.h b/gcc/fortran/gfortran.h > index 90f63cf..13e730f 100644 > --- a/gcc/fortran/gfortran.h > +++ b/gcc/fortran/gfortran.h > @@ -1

Re: more accurate omp in fortran

2015-10-30 Thread Cesar Philippidis
On 10/30/2015 09:58 AM, Jakub Jelinek wrote: > What I meant not just the above changes, but also all changes that > replace where with &n->where and the like, so pretty much everything > except for the oacc_compatible_clauses removal and addition of > resolve_omp_duplicate_list. That is kind of u

Re: more accurate omp in fortran

2015-10-30 Thread Jakub Jelinek
On Fri, Oct 30, 2015 at 08:02:12AM -0700, Cesar Philippidis wrote: > On 10/30/2015 07:47 AM, Jakub Jelinek wrote: > > On Thu, Oct 22, 2015 at 08:21:35AM -0700, Cesar Philippidis wrote: > >> diff --git a/gcc/fortran/gfortran.h b/gcc/fortran/gfortran.h > >> index b2894cc..93adb7b 100644 > >> --- a/gc

Re: [gomp4 05/14] omp-low: set 'omp target entrypoint' only on entypoints

2015-10-30 Thread Alexander Monakov
On Wed, 21 Oct 2015, Jakub Jelinek wrote: > > At the moment the attribute setting logic in omp-low.c is such that if a > > function that should be present in target code does not already have 'omp > > declare target' attribute, it receives 'omp target entrypoint'. That is > > wasteful: clearly not

[gomp4] Merge trunk r229562 (2015-10-30) into gomp-4_0-branch

2015-10-30 Thread Thomas Schwinge
Hi! Even if apparently Go programming language/libgo testing is largely busted (lots of FAILs; checking whether that's the case on trunk, too), committed to gomp-4_0-branch in r229589: commit ff52336e019500085958f58376d5aa56d67b6126 Merge: a027af2 da6fe89 Author: tschwinge Date: Fri Oct 30 16:

Re: [patch] New 'all' front end header reduction

2015-10-30 Thread Mike Stump
On Oct 30, 2015, at 9:20 AM, Andrew MacLeod wrote: > On 10/30/2015 12:07 PM, Mike Stump wrote: >> On Oct 30, 2015, at 6:37 AM, Andrew MacLeod wrote: >>> OK, here's the much delayed front end reduction patch based on the >>> reordering already being checked in. >> So, Objective-C++ should be togg

Re: [patch] New 'all' front end header reduction

2015-10-30 Thread Andrew MacLeod
On 10/30/2015 12:07 PM, Mike Stump wrote: On Oct 30, 2015, at 6:37 AM, Andrew MacLeod wrote: OK, here's the much delayed front end reduction patch based on the reordering already being checked in. So, Objective-C++ should be toggled on at least once for this. If it builds, it should be fine

Re: [patch] New 'all' front end header reduction

2015-10-30 Thread Mike Stump
On Oct 30, 2015, at 6:37 AM, Andrew MacLeod wrote: > OK, here's the much delayed front end reduction patch based on the reordering > already being checked in. So, Objective-C++ should be toggled on at least once for this. If it builds, it should be fine; though the entire objc++ test suite is

Re: [PATCH 00/16] Unit tests framework (v3)

2015-10-30 Thread Jeff Law
On 10/30/2015 04:54 AM, Bernd Schmidt wrote: The counter is that when grepping, you should probably be using find/xargs grep :-) There's actually a tool called ack which automates that. But we've often seen cases where people fail to spot occurrences in config/ directories. We certainly have.

Re: [AArch64][PATCH 6/7] Add NEON intrinsics vqrdmlah and vqrdmlsh.

2015-10-30 Thread Matthew Wahab
On 30/10/15 12:51, Christophe Lyon wrote: On 23 October 2015 at 14:26, Matthew Wahab wrote: The ARMv8.1 architecture extension adds two Adv.SIMD instructions, sqrdmlah and sqrdmlsh. This patch adds the NEON intrinsics vqrdmlah and vqrdmlsh for these instructions. The new intrinsics are of the f

Re: [Docs] Reword the documentation for -fdump-rtl-

2015-10-30 Thread James Greenhalgh
On Thu, Oct 29, 2015 at 11:09:32AM -0600, Sandra Loosemore wrote: > On 10/29/2015 10:55 AM, James Greenhalgh wrote: > > >diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi > >index 76fdc31..5549f17 100644 > >--- a/gcc/doc/invoke.texi > >+++ b/gcc/doc/invoke.texi > >@@ -6665,17 +6665,19 @@ Says

Re: [PATCH][ARM] Fix checking RTL error in cortex_a9_sched_adjust_cost

2015-10-30 Thread Kyrill Tkachov
On 30/10/15 14:37, Ramana Radhakrishnan wrote: On 29/10/15 16:02, Kyrill Tkachov wrote: Hi all, An arm-none-eabi build with RTL checking and --with-cpu=cortex-a9 fails because cortex_a9_sched_adjust_cost tries to access the SET_DEST of a PARALLEL. The correct thing to do is to call single_set

Re: [PATCH 0/5] remove tm.h from encoding.c

2015-10-30 Thread Mike Stump
On Oct 30, 2015, at 4:48 AM, tbsaunde+...@tbsaunde.org wrote: > Its not the nicest code in the world, and there's definitely room for > cleanups, > however it seems like an improvement. After this series the only usage of > tm.h > in libobjc is thr.c which only uses tm.h so it can include gthr.h

Re: [PATCH 0/4] -Wmisleading-indentation

2015-10-30 Thread Mike Stump
On Oct 29, 2015, at 10:39 PM, Andi Kleen wrote: > David Malcolm writes: >> >> * adds -Wmisleading-indentation to -Wall > > I have doubts this is a good idea. I'm sure this will break > a bazillion packages which (misguidedly) ship with -Wall -Werror. > > Would be better to leave the user the

Re: Add VIEW_CONVERT_EXPR to operand_equal_p

2015-10-30 Thread Jan Hubicka
> > Yeah, I suppose we'd need to either build a new function type for each > variadic call > then or somehow represent 'fntype' differently (note that function > attributes also > need to be preserved). Why we can't keep fntype as it is, but simply add a new set of parameters to call stmt that l

Re: Add VIEW_CONVERT_EXPR to operand_equal_p

2015-10-30 Thread Jan Hubicka
> > > But yes, the VIEW_CONVERT "stripping" is a bit fragile and I don't > > > remember what exactly we gain from it (when not done on registers). > > > > I guess gain is really limited to Ada - there are very few cases we do VCE > > otherwise. (I think we could do more of them). We can make > >

Move constant folds for maths functions to new file

2015-10-30 Thread Richard Sandiford
The new routines operate on the built-in enum rather than on tree decls. The idea is to extend this to handle internal functions too, with a combined enum for both. The patch also moves fold_fma too, with the same prototype. The long-term plan is to replace FMA_EXPR with an internal function, for

Re: more accurate omp in fortran

2015-10-30 Thread Cesar Philippidis
On 10/30/2015 07:47 AM, Jakub Jelinek wrote: > On Thu, Oct 22, 2015 at 08:21:35AM -0700, Cesar Philippidis wrote: >> diff --git a/gcc/fortran/gfortran.h b/gcc/fortran/gfortran.h >> index b2894cc..93adb7b 100644 >> --- a/gcc/fortran/gfortran.h >> +++ b/gcc/fortran/gfortran.h >> @@ -1123,6 +1123,7 @@

[PATCH] Better error messages for merge-conflict markers (v3)

2015-10-30 Thread David Malcolm
This is a rebased version of this patch from back in April: v2: https://gcc.gnu.org/ml/gcc-patches/2015-04/msg00944.html which in turn is a rewrite of this one: v1: https://gcc.gnu.org/ml/gcc-patches/2015-03/msg01087.html The idea is to more gracefully handle merger conflict markers in the sou

Re: [AArch64] Update comments on the usage of X30 in FIXED_REGISTERS and CALL_USED_REGISTERS

2015-10-30 Thread Jiong Wang
On 16/10/15 15:36, Jiong Wang wrote: The patch https://gcc.gnu.org/ml/gcc-patches/2014-09/msg02654.html from last year changed the definition of LR in CALL_USED_REGISTERS, but didn't update the comment above the #define to reflect the new usage. This patch bring the comment inline with the imple

Re: more accurate omp in fortran

2015-10-30 Thread Jakub Jelinek
On Thu, Oct 22, 2015 at 08:21:35AM -0700, Cesar Philippidis wrote: > diff --git a/gcc/fortran/gfortran.h b/gcc/fortran/gfortran.h > index b2894cc..93adb7b 100644 > --- a/gcc/fortran/gfortran.h > +++ b/gcc/fortran/gfortran.h > @@ -1123,6 +1123,7 @@ typedef struct gfc_omp_namelist > } u; >st

Re: [patch 2/6] scalar-storage-order merge: C front-end

2015-10-30 Thread Mike Stump
On Oct 30, 2015, at 1:56 AM, Eric Botcazou wrote: >> It won’t. Fixing the language line for the options and a make to ensure it >> still builds for you is enough testing. > > I was talking about the feature itself though, not about the option per se. > The feature is tested for C & C++ but not

Re: [PATCH] [ARM] neon-testgen.ml typo

2015-10-30 Thread Christophe Lyon
On 30 October 2015 at 15:33, Ramana Radhakrishnan wrote: > > > On 29/10/15 17:23, Jim Wilson wrote: >> I noticed a comment typo in this file while using grep to look for >> other stuff. The typo is easy to fix. >> >> I tried running neon-testgen.ml to verify, but it is apparently no >> longer val

Re: [OpenACC] num_gangs, num_workers and vector_length in c++

2015-10-30 Thread Cesar Philippidis
On 10/30/2015 06:37 AM, Jakub Jelinek wrote: > On Thu, Oct 29, 2015 at 04:02:11PM -0700, Cesar Philippidis wrote: >> I noticed that num_gangs, num_workers and vector_length are parsed in >> somewhat insistent ways in the c++ FE. Both vector_length and num_gangs >> bail out whenever as soon as they

Re: [PATCH][ARM] Fix checking RTL error in cortex_a9_sched_adjust_cost

2015-10-30 Thread Ramana Radhakrishnan
On 29/10/15 16:02, Kyrill Tkachov wrote: > Hi all, > > An arm-none-eabi build with RTL checking and --with-cpu=cortex-a9 fails > because > cortex_a9_sched_adjust_cost tries to access the SET_DEST of a PARALLEL. > The correct thing to do is to call single_set on dep, which will return a > simpl

Re: [PATCH] [ARM] neon-testgen.ml typo

2015-10-30 Thread Ramana Radhakrishnan
On 29/10/15 17:23, Jim Wilson wrote: > I noticed a comment typo in this file while using grep to look for > other stuff. The typo is easy to fix. > > I tried running neon-testgen.ml to verify, but it is apparently no > longer valid ocaml, as it doesn't work with the ocamlc 4.01.0 I have > on Ub

Re: [PATCH][PR tree-optimization/67892] Use FSM threader to handle backedges

2015-10-30 Thread Jeff Law
On 10/30/2015 07:57 AM, Andreas Schwab wrote: I'm getting this regression on m68k: FAIL: gcc.dg/tree-ssa/ssa-thread-11.c scan-tree-dump vrp2 "FSM" The generated code looks equivalent, though. I'll take a look. THanks, jeff

Re: [PATCH 1/2] s/390: Implement "target" attribute.

2015-10-30 Thread Andreas Krebbel
Hi Dominik, on-top of the discussions we had off-list I only have a few additional comments/questions. Apart from that the patch looks good to me. Thanks! Bye, -Andreas- > diff --git a/gcc/common/config/s390/s390-common.c > b/gcc/common/config/s390/s390-common.c > index 43459c8..4cf0df7 10064

Re: using scratchpads to enhance RTL-level if-conversion: revised patch

2015-10-30 Thread Bernd Schmidt
(Jakub Cc'd because of code he added for PR23567). On 10/27/2015 11:35 PM, Abe wrote: Thanks for all your feedback. I have integrated as much of it as I could in the available time. Unfortunately not all of it - I still think we need to have a better strategy of selecting a scratchpad than a

Re: [PATCH][PR tree-optimization/67892] Use FSM threader to handle backedges

2015-10-30 Thread Andreas Schwab
I'm getting this regression on m68k: FAIL: gcc.dg/tree-ssa/ssa-thread-11.c scan-tree-dump vrp2 "FSM" The generated code looks equivalent, though. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something co

[PR68083] stop ifcombine from moving uninitialized uses before their guards

2015-10-30 Thread Alexandre Oliva
The ifcombine pass may move a conditional access to an uninitialized value before the condition that ensures it is always well-defined, thus introducing undefined behavior. Stop it from doing so. Regstrapped on x86_64-linux-gnu and i686-linux-gnu. Ok to install? Incidentally, bb_no_side_effect

[gomp4, committed] Backport tree-ssa-structalias.c fixes from trunk

2015-10-30 Thread Tom de Vries
Hi, this patch backports my commits to trunk of this week in tree-ssa-structalias.c. Committed to gomp-4_0-branch. Thanks, - Tom Backport tree-ssa-structalias.c fixes from trunk 2015-10-30 Tom de Vries backport from trunk: 2015-10-30 Tom de Vries * tree-ssa-structalias.c (ipa_pta_

[patch] New 'all' front end header reduction

2015-10-30 Thread Andrew MacLeod
OK, here's the much delayed front end reduction patch based on the reordering already being checked in. I discovered that my targets builds were only building c/c++, so the other languages were being reduced based only on the host x86_64-pc-linux-gnu build. Thats *probably* ok, but I wanted

Re: [OpenACC] num_gangs, num_workers and vector_length in c++

2015-10-30 Thread Jakub Jelinek
On Thu, Oct 29, 2015 at 04:02:11PM -0700, Cesar Philippidis wrote: > I noticed that num_gangs, num_workers and vector_length are parsed in > somewhat insistent ways in the c++ FE. Both vector_length and num_gangs > bail out whenever as soon as they detect errors, whereas num_workers > does not. Bes

Re: [gomp4 04/14] nvptx: fix output of _Bool global variables

2015-10-30 Thread Bernd Schmidt
The following patch passes testing with make -k check-c DEJAGNU=.../dejagnu.exp RUNTESTFLAGS=--target_board=nvptx-none-run with no new regressions, and fixes 1 test: -FAIL: gcc.dg/compat/struct-align-1 c_compat_x_tst.o-c_compat_y_tst.o execute Ok. Thanks! Bernd

RE: [Patch] [x86_64] libgcc changes to add znver1

2015-10-30 Thread Kumar, Venkataramanan
Hi Uros, > -Original Message- > From: Uros Bizjak [mailto:ubiz...@gmail.com] > Sent: Friday, October 30, 2015 2:33 PM > To: Kumar, Venkataramanan > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [Patch] [x86_64] libgcc changes to add znver1 > > On Thu, Oct 29, 2015 at 2:16 PM, Kumar, Venkatar

Re: [gomp4] declare directive [3/5]

2015-10-30 Thread Thomas Schwinge
Hi! On Mon, 8 Jun 2015 10:04:11 -0500, James Norris wrote: > --- a/gcc/fortran/gfortran.h > +++ b/gcc/fortran/gfortran.h > @@ -1174,6 +1183,7 @@ enum >OMP_LIST_FROM, >OMP_LIST_REDUCTION, >OMP_LIST_DEVICE_RESIDENT, > + OMP_LIST_LINK, >OMP_LIST_USE_DEVICE, >OMP_LIST_CACHE, >

Re: [gomp4 04/14] nvptx: fix output of _Bool global variables

2015-10-30 Thread Alexander Monakov
On Thu, 29 Oct 2015, Bernd Schmidt wrote: > On 10/28/2015 08:29 PM, Alexander Monakov wrote: > > > Anything wrong with the simple fix: pick an integer type with the largest > > size > > dividing the original struct type size? > > Try it and run it through the testsuite. The following patch pa

Re: [gomp4] openacc reduction simplification

2015-10-30 Thread Thomas Schwinge
Hi Nathan! On Thu, 29 Oct 2015 13:28:02 -0700, Nathan Sidwell wrote: > I've committed this to gomp4. It removes a no-longer needed field from > omp_context & simplifies the dummy head/tail generation needed for > reductions > at the outermost level. Also incorporates the simplification I c

Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

2015-10-30 Thread Bernd Schmidt
On 10/30/2015 01:47 PM, Richard Biener wrote: On Fri, Oct 30, 2015 at 1:28 PM, Bernd Schmidt wrote: it's not target independent code. Are you suggesting to add a config/ to libobjc? IMHO for a not really mantained frontend / target lib that's an excessive requirement. If necessary, then y

Re: Try to update dominance info in tree-call-cdce.c

2015-10-30 Thread Richard Sandiford
Richard Biener writes: > On Fri, Oct 30, 2015 at 1:14 PM, Richard Sandiford > wrote: >> Richard Biener writes: >>> On Fri, Oct 30, 2015 at 12:18 PM, Richard Sandiford >>> wrote: The pass would free the dominance info after making a change, but it should be pretty easy to keep the info

Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

2015-10-30 Thread Trevor Saunders
On Fri, Oct 30, 2015 at 01:16:16PM +0100, Richard Biener wrote: > On Fri, Oct 30, 2015 at 1:06 PM, Bernd Schmidt wrote: > > On 10/30/2015 12:48 PM, tbsaunde+...@tbsaunde.org wrote: > >> > >> -#ifdef ADJUST_FIELD_ALIGN > >> - desired_align = ADJUST_FIELD_ALIGN (type, desired_align); > >> +#if defi

Re: [PR 68064] Do not create jump functions with zero alignment

2015-10-30 Thread Richard Biener
On Fri, Oct 30, 2015 at 1:44 PM, Martin Jambor wrote: > Hi, > > in PR 68064, IPA-CP hits an assert upon encountering a jump function > claiming that a pointer has known alignment of zero. That is actually > what get_pointer_alignment_1 returns when asked what is the alignment > of iftmp.0_1 in: >

Re: [PATCH] Pass manager: add support for termination of pass list

2015-10-30 Thread Martin Liška
On 10/30/2015 01:13 PM, Richard Biener wrote: > So I suggest to do the push/pop of cfun there. > do_per_function_toporder can be made static btw. > > Richard. Right, I've done that and it works (bootstrap has been currently running), feasible for HSA branch too. tree-pass.h: /* Declare for plug

Re: [AArch64][PATCH 6/7] Add NEON intrinsics vqrdmlah and vqrdmlsh.

2015-10-30 Thread Christophe Lyon
On 23 October 2015 at 14:26, Matthew Wahab wrote: > The ARMv8.1 architecture extension adds two Adv.SIMD instructions, > sqrdmlah and sqrdmlsh. This patch adds the NEON intrinsics vqrdmlah and > vqrdmlsh for these instructions. The new intrinsics are of the form > vqrdml{as}h[q]_. > > Tested the s

Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

2015-10-30 Thread Richard Biener
On Fri, Oct 30, 2015 at 1:28 PM, Bernd Schmidt wrote: >> >> it's not target independent code. Are you suggesting to add a config/ >> to libobjc? IMHO for a not really mantained frontend / target lib that's >> an excessive requirement. > > > If necessary, then yes that would be a better solution.

Re: Try to avoid mark_virtual_operands_for_renmaing in call-cdce

2015-10-30 Thread Richard Biener
On Fri, Oct 30, 2015 at 1:21 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Fri, Oct 30, 2015 at 12:18 PM, Richard Sandiford >> wrote: >>> It's fairly easy to update the virtual ops when the call has no EH edges, >>> which should be cheaper than mark_virtual_operands_for_renaming. >

[PR 68064] Do not create jump functions with zero alignment

2015-10-30 Thread Martin Jambor
Hi, in PR 68064, IPA-CP hits an assert upon encountering a jump function claiming that a pointer has known alignment of zero. That is actually what get_pointer_alignment_1 returns when asked what is the alignment of iftmp.0_1 in: : # iftmp.0_1 = PHI <0B(2), 2147483648B(3)> {anonymous}::fn1

Re: Try to update dominance info in tree-call-cdce.c

2015-10-30 Thread Richard Biener
On Fri, Oct 30, 2015 at 1:14 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Fri, Oct 30, 2015 at 12:18 PM, Richard Sandiford >> wrote: >>> The pass would free the dominance info after making a change, but it >>> should be pretty easy to keep the information up-to-date when the call

[PATCH 2/2] C FE: suggest corrections for misspelled field names

2015-10-30 Thread David Malcolm
This is similar to the field-name part of the v2 patch: https://gcc.gnu.org/ml/gcc-patches/2015-09/msg01090.html with the following changes: - don't call unit tests from lookup_field_fuzzy (instead, see patch 1 in the kit) - use a cutoff: if more than half of the letters were misspelle

[PATCH 1/2] Implement Levenshtein distance

2015-10-30 Thread David Malcolm
This patch adds an implementation of Levenshtein distance to gcc, along with unit testing of the algorithm. The unit testing is implemented via a plugin within gcc.dg/plugin. (I'd prefer to do this via the unit testing patches I've been proposing in a separate patch kit, but to avoid depending on

[PATCH 0/2] Levenshtein-based suggestions (v3)

2015-10-30 Thread David Malcolm
On Thu, 2015-09-17 at 13:31 -0600, Jeff Law wrote: > On 09/16/2015 02:34 AM, Richard Biener wrote: > > > > Btw, this looks quite expensive - I'm sure we want to limit the effort > > here a bit. > A limiter is reasonable, though as it's been pointed out this only fires > during error processing, so

Re: [PATCH] New attribute to create target clones

2015-10-30 Thread Evgeny Stupachenko
I've fixed the misprint and vertical spaces. I'll ask to commit the patch when x86 bootstrap and make check finished. Thanks, Evgeny Updated ChangeLog: 2015-10-30 Evgeny Stupachenko gcc/ * Makefile.in (OBJS): Add multiple_target.o. * attrib.c (make_attribute): Moved from conf

Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

2015-10-30 Thread Bernd Schmidt
it's not target independent code. Are you suggesting to add a config/ to libobjc? IMHO for a not really mantained frontend / target lib that's an excessive requirement. If necessary, then yes that would be a better solution. Even just keeping the abstraction of the macro and putting definiti

Re: [PATCH 1/5] 2015-01-25 Paul Thomas

2015-10-30 Thread Trevor Saunders
On Fri, Oct 30, 2015 at 01:10:32PM +0100, Bernd Schmidt wrote: > On 10/30/2015 12:48 PM, tbsaunde+...@tbsaunde.org wrote: > >From: pault > > > > PR fortran/67171 > > * trans-array.c (structure_alloc_comps): On deallocation of > > class components, reset the vptr to the declared type vt

Re: Try to avoid mark_virtual_operands_for_renmaing in call-cdce

2015-10-30 Thread Richard Sandiford
Richard Biener writes: > On Fri, Oct 30, 2015 at 12:18 PM, Richard Sandiford > wrote: >> It's fairly easy to update the virtual ops when the call has no EH edges, >> which should be cheaper than mark_virtual_operands_for_renaming. >> >> Tested on x86_64-linux-gnu, arm-linux-gnueabi and aarch64-li

Re: [PATCH] Remove fold () dispatch from fold_gimple_assign

2015-10-30 Thread Richard Biener
On Thu, 29 Oct 2015, Richard Biener wrote: > > After > > Index: gcc/gimple-fold.c > === > --- gcc/gimple-fold.c (revision 229518) > +++ gcc/gimple-fold.c (working copy) > @@ -398,7 +398,10 @@ fold_gimple_assign (gimple_stmt_iter

Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

2015-10-30 Thread Richard Biener
On Fri, Oct 30, 2015 at 1:06 PM, Bernd Schmidt wrote: > On 10/30/2015 12:48 PM, tbsaunde+...@tbsaunde.org wrote: >> >> -#ifdef ADJUST_FIELD_ALIGN >> - desired_align = ADJUST_FIELD_ALIGN (type, desired_align); >> +#if defined __arc__ || defined _AIX >> + if (TYPE_MODE (strip_array_types (TREE_TYP

Re: Try to update dominance info in tree-call-cdce.c

2015-10-30 Thread Richard Sandiford
Richard Biener writes: > On Fri, Oct 30, 2015 at 12:18 PM, Richard Sandiford > wrote: >> The pass would free the dominance info after making a change, but it >> should be pretty easy to keep the information up-to-date when the call >> has no EH edges. In a way the main hurdle was split_block, wh

Re: [PATCH] Pass manager: add support for termination of pass list

2015-10-30 Thread Richard Biener
On Fri, Oct 30, 2015 at 12:59 PM, Martin Liška wrote: > On 10/30/2015 09:54 AM, Richard Biener wrote: >> On Thu, Oct 29, 2015 at 3:50 PM, Martin Liška wrote: >>> On 10/29/2015 02:15 PM, Richard Biener wrote: On Thu, Oct 29, 2015 at 10:49 AM, Martin Liška wrote: > On 10/28/2015 04:23 PM,

Re: [PATCH 1/5] 2015-01-25 Paul Thomas

2015-10-30 Thread Bernd Schmidt
On 10/30/2015 12:48 PM, tbsaunde+...@tbsaunde.org wrote: From: pault PR fortran/67171 * trans-array.c (structure_alloc_comps): On deallocation of class components, reset the vptr to the declared type vtable and reset the _len field of unlimited polymorphic compon

  1   2   >