On Fri, Oct 30, 2015 at 1:06 PM, Bernd Schmidt <bschm...@redhat.com> wrote: > On 10/30/2015 12:48 PM, tbsaunde+...@tbsaunde.org wrote: >> >> -#ifdef ADJUST_FIELD_ALIGN >> - desired_align = ADJUST_FIELD_ALIGN (type, desired_align); >> +#if defined __arc__ || defined _AIX >> + if (TYPE_MODE (strip_array_types (TREE_TYPE (type))) == DFmode) >> + desired_align = MIN (desired_align, 32); >> +#elif __POWERPC__ && __APPLE__ >> + if (desired_align != 128) >> + desired_align = MIN (desired_align, 32); >> #endif > > > No way. We never use this kind of test in target-independent code.
it's not target independent code. Are you suggesting to add a config/ to libobjc? IMHO for a not really mantained frontend / target lib that's an excessive requirement. For any such replacements as in the patch I suggest to at least keep a comment before it indicating the origin of the inlined vairants (in this case refer to ADJUST_FIELD_ALIGN). In general I'm happy with this kind of patches (maybe not the BIGGEST_FIELD_ALIGN one which could be made a CPP macro when -fbuilding-libgcc) Richard. > > Bernd
