On 10/30/2015 01:47 PM, Richard Biener wrote:
On Fri, Oct 30, 2015 at 1:28 PM, Bernd Schmidt <bschm...@redhat.com> wrote:

it's not target independent code.  Are you suggesting to add a config/
to libobjc?  IMHO for a not really mantained frontend / target lib that's
an excessive requirement.


If necessary, then yes that would be a better solution.

Even just keeping the abstraction of the macro and putting definitions of it
inside #ifdef at the top of the file would be an improvement over the
submitted patch, but IMO still not really compatible with our standards.

I agree, that would make the source of the copy more obvious.

If we go down that path, there's another minimum requirement - adjust the docs to say that the macro must be defined in two places. That's my main worry, someone creating a new port, completely oblivious that they'd have to modify library code for it to work.


Bernd

Reply via email to