Martin Peřina has posted comments on this change.
Change subject: tools: move set of OVIRT_LOGGING_PROPERTIES to designated
scripts
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39886
To unsubscribe
Martin Peřina has posted comments on this change.
Change subject: engine: add the proper message for not auth terminate session
..
Patch Set 1: Code-Review+1 Verified+1
When user without SuperUser role tries to terminate sessio
Martin Peřina has uploaded a new change for review.
Change subject: core: Fix db upgrage scripts numbering check
..
core: Fix db upgrage scripts numbering check
Fixes issue in db upgrade scripts numbering check to prevent duplic
Martin Peřina has posted comments on this change.
Change subject: core: Fix db upgrage scripts numbering check
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/39942
To unsubscribe, visit https://gerrit.ov
Martin Peřina has posted comments on this change.
Change subject: core: Fix db upgrage scripts numbering check
..
Patch Set 1: Code-Review+1
Thanks for this, I'm stupid
--
To view, visit https://gerrit.ovirt.org/39947
To unsu
Martin Peřina has uploaded a new change for review.
Change subject: core: Fix Coverity issues in FenceProxyLocatorTest
..
core: Fix Coverity issues in FenceProxyLocatorTest
Fixes Coverity issues found in FenceProxyLocatorTest.
Martin Peřina has posted comments on this change.
Change subject: core: Fix Coverity issues in FenceProxyLocatorTest
..
Patch Set 1: Verified+1
Marked as verified, because test works as expected, but I'm not sure if this
chang
Martin Peřina has uploaded a new change for review.
Change subject: core: Use ToStringBuilder in gluster classes
..
core: Use ToStringBuilder in gluster classes
Refactor existing toString() methods to use ToStringBuilder in glus
Martin Peřina has uploaded a new change for review.
Change subject: core: Use ToStringBuilder in sla classes
..
core: Use ToStringBuilder in sla classes
Refactor existing toString() methods to use ToStringBuilder in sla
classes.
Martin Peřina has uploaded a new change for review.
Change subject: core: Use ToStringBuilder in virt classes
..
core: Use ToStringBuilder in virt classes
Refactor existing toString() methods to use ToStringBuilder in virt
class
Martin Peřina has uploaded a new change for review.
Change subject: core: Use ToStringBuilder in network classes
..
core: Use ToStringBuilder in network classes
Refactor existing toString() methods to use ToStringBuilder in netw
Martin Peřina has uploaded a new change for review.
Change subject: core: Use ToStringBuilder in storage classes
..
core: Use ToStringBuilder in storage classes
Refactor existing toString() methods to use ToStringBuilder in stor
Martin Peřina has posted comments on this change.
Change subject: core: Use ToStringBuilder in infra and common classes
..
Patch Set 3: Verified+1
Original patch is split by classes per team. This patch contains infra classes
Martin Peřina has posted comments on this change.
Change subject: core: Use ToStringBuilder in virt classes
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/39979
To unsubscribe, visit https://gerrit.ovirt
Martin Peřina has posted comments on this change.
Change subject: core: Use ToStringBuilder in storage classes
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/39983
To unsubscribe, visit https://gerrit.ov
Martin Peřina has posted comments on this change.
Change subject: core: Use ToStringBuilder in network classes
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/39982
To unsubscribe, visit https://gerrit.ov
Martin Peřina has posted comments on this change.
Change subject: core: Use ToStringBuilder in sla classes
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/39981
To unsubscribe, visit https://gerrit.ovirt.
Martin Peřina has posted comments on this change.
Change subject: core: Use ToStringBuilder in gluster classes
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/39980
To unsubscribe, visit https://gerrit.ov
Martin Peřina has posted comments on this change.
Change subject: core: Use ToStringBuilder in infra and common classes
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/39721/3/backend/manager/modules/builtin-extension
Martin Peřina has posted comments on this change.
Change subject: core: Use ToStringBuilder in gluster classes
..
Patch Set 1:
If agreed, could you please merged it?
Thanks
Martin
--
To view, visit https://gerrit.ovirt.org/
Martin Peřina has posted comments on this change.
Change subject: core: Use ToStringBuilder in sla classes
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/39981/1/backend/manager/modules/common/src/main/java/org/ovirt
Martin Peřina has uploaded a new change for review.
Change subject: core: Fix used matchers in
GetManagementNetworkCandidatesQueryTest
..
core: Fix used matchers in GetManagementNetworkCandidatesQueryTest
Replaces
assertThat(
Martin Peřina has uploaded a new change for review.
Change subject: core: Fix CDI in dal module to work with EAP/WildFly
..
core: Fix CDI in dal module to work with EAP/WildFly
1. Removes infra for injecting beans in external JA
Martin Peřina has uploaded a new change for review.
Change subject: restapi: Introduce current filter
..
restapi: Introduce current filter
The RESTAPI application needs to access data associated to the current
request in several
Martin Peřina has posted comments on this change.
Change subject: restapi: Introduce current filter
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40150
To unsubscribe, visit https://gerrit.ovirt.org/set
Martin Peřina has uploaded a new change for review.
Change subject: setup: Adds service configuration based on provided JBoss
..
setup: Adds service configuration based on provided JBoss
Adds detection of provided JBoss version
Martin Peřina has posted comments on this change.
Change subject: setup: Adds service configuration based on provided JBoss
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40152
To unsubscribe, visit http
Martin Peřina has posted comments on this change.
Change subject: core: Fix CDI in dal module to work with EAP/WildFly
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40151
To unsubscribe, visit https://g
Martin Peřina has posted comments on this change.
Change subject: core: Fix used matchers in
GetManagementNetworkCandidatesQueryTest
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40149
To unsubscribe,
Martin Peřina has posted comments on this change.
Change subject: core: Fix CDI in dal module to work with EAP/WildFly
..
Patch Set 2: Verified+1
Readded test-beans.xml which was accidentally dropped on my last rebase to fix
D
Martin Peřina has posted comments on this change.
Change subject: setup: Adds service configuration based on provided JBoss
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/40152/1/packaging/setup/plugins/ovirt-engine-
Martin Peřina has posted comments on this change.
Change subject: core: Adds service configuration based on provided JBoss
..
Patch Set 2: Verified+1
Moved JBoss detection to service startup
--
To view, visit https://gerrit.o
Martin Peřina has posted comments on this change.
Change subject: core: Fix CDI in dal module to work with EAP/WildFly
..
Patch Set 3: Verified+1
Fixed ear dependency on dal module in META-INF which fixed CDI errors in
WildFly
Martin Peřina has posted comments on this change.
Change subject: core: Fix CDI in dal module to work with EAP/WildFly
..
Patch Set 3:
@Liran:
EAP 6 will be minimal supported platform, so we will stick to CDI 1.0, but EAP
con
Martin Peřina has posted comments on this change.
Change subject: core: Fix used matchers in
GetManagementNetworkCandidatesQueryTest
..
Patch Set 2:
Yevgeny,
when I removed infra for injecting beans in external JAR (40151), u
Martin Peřina has posted comments on this change.
Change subject: core: Use ToStringBuilder in storage classes
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/39983/1/backend/manager/modules/common/src/main/java/org/
Martin Peřina has posted comments on this change.
Change subject: core: Use ToStringBuilder in storage classes
..
Patch Set 2: Verified+1
Changes:
1. Added StoragePoolIsoMap.toString()
2. Removed ReconstructMasterVDSCommandPar
Martin Peřina has posted comments on this change.
Change subject: core: Fix CDI in dal module to work with EAP/WildFly
..
Patch Set 3:
@New is deprecated in CDI 1.1.
I tried to use @Named without specific name on producer meth
Martin Peřina has posted comments on this change.
Change subject: PendingResourceManager for tracking resources in WaitForLaunch
..
Patch Set 6:
(3 comments)
https://gerrit.ovirt.org/#/c/40136/6/backend/manager/modules/bll/src
Martin Peřina has posted comments on this change.
Change subject: core: using JPA for engine backup awareness
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/40091/9/backend/manager/modules/common/src/main/java/org/ov
Martin Peřina has uploaded a new change for review.
Change subject: core: Fix query size limit handling in AuthzUtils
..
core: Fix query size limit handling in AuthzUtils
Fixes query size limit handling in AuthzUtils.populateGro
Martin Peřina has posted comments on this change.
Change subject: core: Fix query size limit handling in AuthzUtils
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37890
To unsubscribe, visit http://gerrit
Martin Peřina has uploaded a new change for review.
Change subject: core: Move LdapUser and LdapGroup to kerberosldap extension
..
core: Move LdapUser and LdapGroup to kerberosldap extension
Moves LdapUser and LdapGroup into leg
Martin Peřina has posted comments on this change.
Change subject: core: Move LdapUser and LdapGroup to kerberosldap extension
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37891
To unsubscribe, visit htt
Martin Peřina has posted comments on this change.
Change subject: core: Fix query size limit handling in AuthzUtils
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/37890/1/backend/manager/modules/aaa/src/main/java/org/
Martin Peřina has posted comments on this change.
Change subject: core: Fix query size limit handling in AuthzUtils
..
Patch Set 1:
This patch just unifies result size limit logic for users and groups. So, do we
want this to b
Martin Peřina has posted comments on this change.
Change subject: core: Fix CDI API dependency
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Peřina has uploaded a new change for review.
Change subject: core: Fix CDI API dependency
..
core: Fix CDI API dependency
Fixes CDI API dependency in module bll, where duplicate dependency was
added in patch I3b3c2c57178b
Martin Peřina has posted comments on this change.
Change subject: core: Fix query size limit handling in AuthzUtils
..
Patch Set 1:
Give me a few sec, I will upload new patch
--
To view, visit http://gerrit.ovirt.org/37890
To
Martin Peřina has posted comments on this change.
Change subject: core: Unify query size limit handling in AuthzUtils
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/37890
To unsubscribe, visit http://gerr
Martin Peřina has posted comments on this change.
Change subject: core: Unify query size limit handling in AuthzUtils
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/37890/2/backend/manager/modules/aaa/src/main/java/or
Martin Peřina has posted comments on this change.
Change subject: core: Unify query size limit handling in AuthzUtils
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/37890
To unsubscribe, visit http://gerr
Martin Peřina has posted comments on this change.
Change subject: core: Unify query size limit handling in AuthzUtils
..
Patch Set 4:
Rebased to bypass Jenkins build failures
--
To view, visit http://gerrit.ovirt.org/37890
To
Martin Peřina has posted comments on this change.
Change subject: aaa: AuthzUtils: Unify query size limit handling
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/37890/4//COMMIT_MSG
Commit Message:
Line 3: AuthorDate
Martin Peřina has posted comments on this change.
Change subject: core: Fix skipped status in fencing
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/37839
To unsubscribe, visit http://gerrit.ovirt.org/set
Martin Peřina has posted comments on this change.
Change subject: core: Fix skipped status in fencing
..
Patch Set 5:
Can we merge? Jenkins failures are unrelated, local unit and DAO tests passed
successfully.
--
To view, vi
Martin Peřina has posted comments on this change.
Change subject: core: Fix skipped status in fencing
..
Patch Set 3:
Jenkins build errors are unrelated, local build, unit and DAO tests are
successful
--
To view, visit http:
Martin Peřina has uploaded a new change for review.
Change subject: core: Refactor FenceActionType
..
core: Refactor FenceActionType
1. Moves enum to org.ovirt.engine.core.common.businessentities.pm
package
2. Renames enum v
Martin Peřina has uploaded a new change for review.
Change subject: core: FenceVdsVDSCommandParameters code cleanup
..
core: FenceVdsVDSCommandParameters code cleanup
1. Use FenceAgent class instead of its attributes
2. Code cle
Martin Peřina has uploaded a new change for review.
Change subject: core: FenceVdsVDSCommand code cleanup
..
core: FenceVdsVDSCommand code cleanup
1. User getDbFacade() to get the instance
2. Do parameters conversions and call t
Martin Peřina has uploaded a new change for review.
Change subject: core: Introduce FenceAgentExecutor
..
core: Introduce FenceAgentExecutor
Introduces FenceAgentExecutor which is responsible to execute fence
action on one agent
Martin Peřina has uploaded a new change for review.
Change subject: core: Refactor FenceVdsVDSCommand return value
..
core: Refactor FenceVdsVDSCommand return value
Introduces FenceOperationResult which will provider better supp
Martin Peřina has posted comments on this change.
Change subject: core: Refactor FenceActionType
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/38059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Peřina has posted comments on this change.
Change subject: core: FenceVdsVDSCommand code cleanup
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/38060
To unsubscribe, visit http://gerrit.ovirt.org/s
Martin Peřina has posted comments on this change.
Change subject: core: FenceVdsVDSCommandParameters code cleanup
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/38061
To unsubscribe, visit http://gerrit.o
Martin Peřina has posted comments on this change.
Change subject: core: FenceVdsVDSCommand code cleanup
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/38060
To unsubscribe, visit http://gerrit.ovirt.org/s
Martin Peřina has posted comments on this change.
Change subject: core: FenceVdsVDSCommandParameters code cleanup
..
Patch Set 2:
(3 comments)
http://gerrit.ovirt.org/#/c/38061/2/backend/manager/modules/bll/src/main/java/org/o
Martin Peřina has posted comments on this change.
Change subject: core: FenceVdsVDSCommandParameters code cleanup
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38061/2/backend/manager/modules/common/src/main/java/or
Martin Peřina has posted comments on this change.
Change subject: core: FenceVdsVDSCommandParameters code cleanup
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/38061
To unsubscribe, visit https://gerrit
Martin Peřina has posted comments on this change.
Change subject: sdk: Manually remove action broker
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/37863
To unsubscribe, visit https://gerrit.ovirt.org
Martin Peřina has posted comments on this change.
Change subject: sdk: Manually fix host storage broker class
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/37866
To unsubscribe, visit https://gerrit.
Martin Peřina has posted comments on this change.
Change subject: sdk: Manually fix scheduling policy naming issue
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/37862
To unsubscribe, visit https://ge
Martin Peřina has posted comments on this change.
Change subject: codegen: Avoid calculation of singulars and plurals
..
Patch Set 4: Code-Review+1
This is away beyond my SDK knowledge, but it makes sense to remove the
calcula
Martin Peřina has uploaded a new change for review.
Change subject: core: Provide copy constructor for FenceAgent
..
core: Provide copy constructor for FenceAgent
Provides copy contsructor for FenceAgent
Change-Id: I382e01d35af
Martin Peřina has posted comments on this change.
Change subject: core: Provide copy constructor for FenceAgent
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/38163
To unsubscribe, visit https://gerrit.o
Martin Peřina has posted comments on this change.
Change subject: core: FenceVdsVDSCommandParameters code cleanup
..
Patch Set 5: Verified+1
Fixed mapping to real agent and merging agent options with default options
--
To vie
Martin Peřina has posted comments on this change.
Change subject: codegen: Use commons-io instead of custom code
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38191
To unsubscribe, visit https://gerr
Martin Peřina has posted comments on this change.
Change subject: codegen: Avoid calculation of singulars and plurals
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38194
To unsubscribe, visit https:/
Martin Peřina has posted comments on this change.
Change subject: codegen: Use the same broker naming rules than the Java SDK
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38221
To unsubscribe, visit
Martin Peřina has uploaded a new change for review.
Change subject: core: Prepare FenceVdsVDSCommand params on caller
..
core: Prepare FenceVdsVDSCommand params on caller
Moves all FenceVdsVDSCommand parameters conversion to cal
Martin Peřina has posted comments on this change.
Change subject: core: Prepare FenceVdsVDSCommand params on caller
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/38232
To unsubscribe, visit https://gerr
Martin Peřina has uploaded a new change for review.
Change subject: core: Add number of in/out migrations to VdsDynamic
..
core: Add number of in/out migrations to VdsDynamic
Adds number of incoming and outgoing migrations to Vd
Martin Peřina has uploaded a new change for review.
Change subject: webadmin: Display number if in/out migrations per host
..
webadmin: Display number if in/out migrations per host
Displays number of incoming and outgoing migrat
Martin Peřina has uploaded a new change for review.
Change subject: core: Refresh number of in/out migrations in HostMonitoring
..
core: Refresh number of in/out migrations in HostMonitoring
Refreshes number of incoming and outg
Martin Peřina has posted comments on this change.
Change subject: core: Refresh number of in/out migrations in HostMonitoring
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/38325
To unsubscribe, visit ht
Martin Peřina has posted comments on this change.
Change subject: core: Add number of in/out migrations to VdsDynamic
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/38324
To unsubscribe, visit https://ge
Martin Peřina has posted comments on this change.
Change subject: webadmin: Display number if in/out migrations per host
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/38326
To unsubscribe, visit https:/
Martin Peřina has posted comments on this change.
Change subject: core: Refresh number of in/out migrations in HostMonitoring
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/38325/1/backend/manager/modules/vdsbroker/
Martin Peřina has uploaded a new change for review.
Change subject: core: Introduce SingleAgentPmActionExecutor
..
core: Introduce SingleAgentPmActionExecutor
Introduces SignleAgentPmActionExecutor which is responsible to execut
Martin Peřina has posted comments on this change.
Change subject: core: Refresh number of in/out migrations in HostMonitoring
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38325/1/backend/manager/modules/vdsbroker/s
Martin Peřina has posted comments on this change.
Change subject: core: Introduce SingleAgentPmActionExecutor
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/38358/2//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2
Martin Peřina has posted comments on this change.
Change subject: core: Introduce SingleAgentPmActionExecutor
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38358/2/backend/manager/modules/bll/src/main/java/org/ovirt
Martin Peřina has posted comments on this change.
Change subject: engine: make EngineSession queriable
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/38378/1/backend/manager/modules/common/src/main/java
Martin Peřina has posted comments on this change.
Change subject: engine: make EngineSession queriable
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38378/1/backend/manager/modules/common/src/main/java/org/ovirt/eng
Martin Peřina has posted comments on this change.
Change subject: engine: refactor PermissionsCommandBase.isSystemSuperUser
method out
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38379
To unsubscr
Martin Peřina has posted comments on this change.
Change subject: engine: make EngineSession.engineSessionId transient
..
Patch Set 1: Code-Review-1
Please see my comment about transient in patch 38378
--
To view, visit https
Martin Peřina has posted comments on this change.
Change subject: engine: add TerminateSession command
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/38382/1/backend/manager/modules/bll/src/main/java/or
Martin Peřina has posted comments on this change.
Change subject: engine: define auto-completion for EngineSession objects
..
Patch Set 1:
I'm not an UI expert, but this searching sessions feature seems like an
overkill to me.
Martin Peřina has posted comments on this change.
Change subject: engine: make EngineSession queriable
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38378/1/backend/manager/modules/common/src/main/java/org/ovirt/eng
Martin Peřina has posted comments on this change.
Change subject: engine: make EngineSession queriable
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38378/1/backend/manager/modules/common/src/main/java/org/ovirt/eng
1 - 100 of 2425 matches
Mail list logo
