Martin Peřina has posted comments on this change. Change subject: core: Use ToStringBuilder in infra and common classes ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/39721/3/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/dns/DnsSRVLocator.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/dns/DnsSRVLocator.java: Line 57: .append("valid", valid) Line 58: .append("sum", sum) Line 59: .append("priority", priority) Line 60: .append("weight", weight) Line 61: .append("hostport", address) > i know this is how it was written originally and shouldn't be modified with Well it's "hostport" and not "hotspot", but I agree it's not ideal name for this attribute Line 62: .build(); Line 63: } Line 64: Line 65: public SrvRecord(int priority, int weight, String hostPort) { -- To view, visit https://gerrit.ovirt.org/39721 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia476fbb99b5d8ca79171f597375157b8caa4d831 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
