Martin Peřina has posted comments on this change.

Change subject: setup: Adds service configuration based on provided JBoss
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/40152/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/jboss.py
File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/jboss.py:

Line 97:                         oengcommcons.ConfigEnv.JBOSS_HOME
Line 98:                     ],
Line 99:                 ),
Line 100:                 '-v',
Line 101:             ),
> we must not run standalone as it will create indexes, logs and other stuff 
I don't understand you. I executed:

  standalone.sh -v

to get the version only. And I verified that it returned correct version.

You are right that server.log was created at JBOSS_HOME/standalone/log, but 
this could be prevented using

 standalone -v -Djboss.server.log.dir=/tmp

I just verified that using this we can get version even when JBOSS_HOME and its 
subdirectories are readonly.
Line 102:             # We need to bypass return code check, because by default
Line 103:             # standalone.sh -v returns 1
Line 104:             raiseOnError=False,
Line 105:             envAppend={


-- 
To view, visit https://gerrit.ovirt.org/40152
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic35f8a0c276735b9685affea1e068f6ef7298f8c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to