Martin Peřina has posted comments on this change.

Change subject: core: Introduce SingleAgentPmActionExecutor
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/38358/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SingleAgentPmActionExecutor.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SingleAgentPmActionExecutor.java:

Line 15: import org.slf4j.Logger;
Line 16: import org.slf4j.LoggerFactory;
Line 17: 
Line 18: /**
Line 19:  * Manages fence execution for the host using specified fence agent
> Well, that's a bit tricky :-)
On the other hand you may be right, because:

1. Fence actions are start (on), stop (off) and status
2. Power management action are start, stop, restart and status

So I will rename the class in next patch.

Thanks
Line 20:  */
Line 21: public class SingleAgentPmActionExecutor {
Line 22:     private static final Logger log = 
LoggerFactory.getLogger(SingleAgentPmActionExecutor.class);
Line 23: 


-- 
To view, visit https://gerrit.ovirt.org/38358
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95958b4821fa8f55ee8913e926f9528ae56e20e8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to