Martin Peřina has uploaded a new change for review.
Change subject: core: Use ToStringBuilder in sla classes
......................................................................
core: Use ToStringBuilder in sla classes
Refactor existing toString() methods to use ToStringBuilder in sla
classes.
Change-Id: I0ed7b26ec4fbade8b1f63aaa7138de4e6ce49937
Signed-off-by: Martin Perina <mper...@redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/CpuProfile.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/DiskProfile.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/ProfileBase.java
3 files changed, 19 insertions(+), 19 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/81/39981/1
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/CpuProfile.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/CpuProfile.java
index 0d7c440..789a834 100644
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/CpuProfile.java
+++
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/CpuProfile.java
@@ -4,6 +4,7 @@
import javax.validation.constraints.NotNull;
+import org.ovirt.engine.core.common.utils.ToStringBuilder;
import org.ovirt.engine.core.common.validation.group.CreateEntity;
import org.ovirt.engine.core.common.validation.group.UpdateEntity;
import org.ovirt.engine.core.compat.Guid;
@@ -52,8 +53,8 @@
}
@Override
- public String toString() {
- return super.toString() + ", cluster id=" + getClusterId() + "}";
+ protected ToStringBuilder appendAttributes(ToStringBuilder tsb) {
+ return super.appendAttributes(tsb)
+ .append("clusterId", getClusterId());
}
-
}
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/DiskProfile.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/DiskProfile.java
index 769a08f..f9b498a 100644
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/DiskProfile.java
+++
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/DiskProfile.java
@@ -4,6 +4,7 @@
import javax.validation.constraints.NotNull;
+import org.ovirt.engine.core.common.utils.ToStringBuilder;
import org.ovirt.engine.core.common.validation.group.CreateEntity;
import org.ovirt.engine.core.common.validation.group.UpdateEntity;
import org.ovirt.engine.core.compat.Guid;
@@ -52,8 +53,8 @@
}
@Override
- public String toString() {
- return super.toString() + ", storage domain id=" +
getStorageDomainId() + "}";
+ protected ToStringBuilder appendAttributes(ToStringBuilder tsb) {
+ return super.appendAttributes(tsb)
+ .append("storageDomainId", getStorageDomainId());
}
-
}
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/ProfileBase.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/ProfileBase.java
index 24870a8..e7d6303 100644
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/ProfileBase.java
+++
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/ProfileBase.java
@@ -9,6 +9,7 @@
import org.ovirt.engine.core.common.businessentities.BusinessEntity;
import org.ovirt.engine.core.common.businessentities.IVdcQueryable;
import org.ovirt.engine.core.common.businessentities.Nameable;
+import org.ovirt.engine.core.common.utils.ToStringBuilder;
import org.ovirt.engine.core.common.validation.annotation.ValidName;
import org.ovirt.engine.core.common.validation.group.CreateEntity;
import org.ovirt.engine.core.common.validation.group.RemoveEntity;
@@ -130,19 +131,16 @@
return true;
}
- @Override
- public String toString() {
- StringBuilder builder = new StringBuilder();
- builder.append(getName())
- .append(" {id=")
- .append(getId())
- .append(", description=")
- .append(getDescription())
- .append(", profile type=")
- .append(getProfileType().name())
- .append(", qosId=")
- .append(getQosId());
- return builder.toString();
+ protected ToStringBuilder appendAttributes(ToStringBuilder tsb) {
+ return tsb.append("id", getId())
+ .append("description", getDescription())
+ .append("profileType", getProfileType())
+ .append("qosId", getQosId());
+
}
+ @Override
+ public String toString() {
+ return appendAttributes(ToStringBuilder.forInstance(this)).build();
+ }
}
--
To view, visit https://gerrit.ovirt.org/39981
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ed7b26ec4fbade8b1f63aaa7138de4e6ce49937
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
