Daniel Erez has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 32: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9328
To unsubscribe, visit http://gerrit.ovir
Daniel Erez has submitted this change and it was merged.
Change subject: core: introducing OvfAutoUpdate
..
core: introducing OvfAutoUpdate
VM/template configurations (including disks info) are stored on the
master storage doma
Liron Aravot has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 32: Verified
--
To view, visit http://gerrit.ovirt.org/9328
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Daniel Erez has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 30: Verified; Looks good to me, approved
Verified by Liron and Leonid
--
To view, visit http://gerrit.ovirt.org/9328
Leonid Natapov has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 29: Verified
tested on iscsi and nfs. used 2 storage domains for both. (2 NFS and 2 iscsi).
'OvfUpdateIntervalInMin
Allon Mureinik has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 25: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9328
To unsubscribe, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 24: I would prefer that you didn't submit this
Liron, please note Yair's comment in http://gerrit.ovirt.org/#/c/982
Maor Lipchuk has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 24: Looks good to me, approved
(3 inline comments)
See minor comments
.
Allon Mureinik has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 23: Looks good to me, but someone else must approve
(2 inline comments)
Generally speaking - looks OK.
There are s
Maor Lipchuk has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 23: (14 inline comments)
File backend/manager/dbscripts/vms_sp.s
Liron Aravot has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 21: (7 inline comments)
File backend/manager/dbscripts/storages_
Allon Mureinik has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 21: No score; I would prefer that you didn't submit this
marked -1 in verified instead of code review my mistake.
Allon Mureinik has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 21: Fails
(7 inline comments)
-1 given for missing validation code that was mistakenly pushed in the next
patch i
Allon Mureinik has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 20: (2 inline comments)
File
backend/manager/modules/common/s
liron aravot has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 18: (6 inline comments)
File backend/manager/dbscripts/vms_sp.sq
Liron Aravot has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 20: (29 inline comments)
File backend/manager/dbscripts/storages
Maor Lipchuk has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 20: (1 inline comment)
File backend/manager/dbscripts/upgrade/03
Maor Lipchuk has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 20: (1 inline comment)
File backend/manager/dbscripts/upgrade/03
Allon Mureinik has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 20: I would prefer that you didn't submit this
(27 inline comments)
see inline.
Also, see answers inline for patc
Allon Mureinik has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 18: (7 inline comments)
patchset 18: Answered Liron's comments inline.
...
Liron Aravot has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 19: (8 inline comments)
File backend/manager/dbscripts/storages_
Maor Lipchuk has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 19: (10 inline comments)
File backend/manager/dbscripts/upgrade/
Maor Lipchuk has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 19: (3 inline comments)
please fix TWS
File backend/manager/dbs
Liron Aravot has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 19: (1 inline comment)
File backend/manager/dbscripts/storages_s
Liron Aravot has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 18: (58 inline comments)
File backend/manager/dbscripts/storages
Allon Mureinik has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 18: (47 inline comments)
1. See inline implementation issues
2. Please add a test to the new behavior in OvfWriter
Michael Kublin has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 18: I would prefer that you didn't submit this
(5 inline comments)
...
Moti Asayag has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 18: (5 inline comments)
File
backend/manager/modules/common/src/
Maor Lipchuk has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 18: (6 inline comments)
Partial reviewed
File backend/manager/d
Liron Aravot has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 18: (1 inline comment)
File backend/manager/dbscripts/upgrade/03
Liron Aravot has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 14: (1 inline comment)
File backend/manager/dbscripts/vms_sp.sql
Liron Aravot has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 16: (4 inline comments)
File backend/manager/dbscripts/storages_
Liron Aravot has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 14: (56 inline comments)
File backend/manager/dbscripts/storages
Michael Kublin has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 14: I would prefer that you didn't submit this
(10 inline comments)
..
Allon Mureinik has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 14: I would prefer that you didn't submit this
(56 inline comments)
Please fix (or at least address) the inline co
Liron Aravot has uploaded a new change for review.
Change subject: core: introducing OvfAutoUpdate
..
core: introducing OvfAutoUpdate
vm/template configurations (including disks info) are stored on the master
storage
domain for
36 matches
Mail list logo
