Maor Lipchuk has posted comments on this change. Change subject: core: introducing OvfAutoUpdate ......................................................................
Patch Set 18: (6 inline comments) Partial reviewed .................................................... File backend/manager/dbscripts/storages_sp.sql Line 97: WHERE vm_id IN ( Line 98: SELECT vm_guid Line 99: FROM vms Line 100: WHERE storage_pool_id = v_id); Line 101: delete FROM vm_static where vm_guid in (select vm_guid from vms where storage_pool_id = v_id); Please remove spaces Line 102: -- Get (and keep) a shared lock with "right to upgrade to exclusive" Line 103: -- in order to force locking parent before children Line 104: select id INTO v_val FROM storage_pool WHERE id = v_id FOR UPDATE; Line 105: .................................................... File backend/manager/dbscripts/vms_sp.sql Line 66: AS $procedure$ Line 67: BEGIN Line 68: RETURN QUERY SELECT templates.vmt_guid as vm_guid Line 69: FROM vm_templates_view templates, vm_ovf_generations generations Line 70: WHERE generations.vm_guid = templates.vmt_guid Please remove space at the EOL Line 71: AND templates.db_generation > generations.ovf_generation Line 72: AND templates.storage_pool_id = v_storage_pool_id; Line 73: END; $procedure$ Line 74: LANGUAGE plpgsql; Line 425: AS $procedure$ Line 426: BEGIN Line 427: INSERT INTO vm_static(description, mem_size_mb, os, vds_group_id, vm_guid, VM_NAME, vmt_guid,domain,creation_date,num_of_monitors,allow_console_reconnect,is_initialized,is_auto_suspend,num_of_sockets,cpu_per_socket,usb_policy, time_zone,auto_startup,is_stateless,dedicated_vm_for_vds, fail_back, default_boot_sequence, vm_type, nice_level, default_display_type, priority,iso_path,origin,initrd_url,kernel_url,kernel_params,migration_support,predefined_properties,userdefined_properties,min_allocated_mem, entity_type, quota_id, cpu_pinning, is_smartcard_enabled,is_delete_protected) Line 428: VALUES(v_description, v_mem_size_mb, v_os, v_vds_group_id, v_vm_guid, v_vm_name, v_vmt_guid, v_domain, v_creation_date, v_num_of_monitors, v_allow_console_reconnect, v_is_initialized, v_is_auto_suspend, v_num_of_sockets, v_cpu_per_socket, v_usb_policy, v_time_zone, v_auto_startup,v_is_stateless,v_dedicated_vm_for_vds,v_fail_back, v_default_boot_sequence, v_vm_type, v_nice_level, v_default_display_type, v_priority,v_iso_path,v_origin,v_initrd_url,v_kernel_url,v_kernel_params,v_migration_support,v_predefined_properties,v_userdefined_properties,v_min_allocated_mem, 'VM', v_quota_id, v_cpu_pinning, v_is_smartcard_enabled,v_is_delete_protected); Line 429: INSERT INTO vm_ovf_generations(vm_guid, storage_pool_id) VALUES (v_vm_guid, (select storage_pool_id from vds_groups vg where vg.vds_group_id = v_vds_group_id)); same here Line 430: END; $procedure$ Line 431: LANGUAGE plpgsql; Line 432: Line 433: .................................................... File backend/manager/dbscripts/vm_templates_sp.sql Line 128: INSERT INTO vm_ovf_generations(vm_guid, storage_pool_id) VALUES (v_vmt_guid, (select storage_pool_id from vds_groups vg where vg.vds_group_id = v_vds_group_id)); Line 129: END; $procedure$ Line 130: LANGUAGE plpgsql; Line 131: Line 132: Please remove empty lines Line 133: Line 134: Line 135: Line 136: .................................................... Commit Message Line 11: abillity to run VMs without having a running engine/db. Currently OVF Line 12: update is done synchronously when performing various operations on Line 13: VMs/templates - update, save, adding/removing a disk, etc. What's more, Line 14: currently updating the OVF (updateVM vdsm call) is usually done within a Line 15: transcation. /s/transcation/transaction Line 16: Line 17: The idea behined OvfAutoUpdater is to perform a batch OVF update Line 18: operations that aggregate all pending updates per data center. These Line 19: updates will be done in specified time intervals which will reduce Line 13: VMs/templates - update, save, adding/removing a disk, etc. What's more, Line 14: currently updating the OVF (updateVM vdsm call) is usually done within a Line 15: transcation. Line 16: Line 17: The idea behined OvfAutoUpdater is to perform a batch OVF update /s/behined/behind Line 18: operations that aggregate all pending updates per data center. These Line 19: updates will be done in specified time intervals which will reduce Line 20: XML-RPC calls and will enable the removal of this syncronous vdsm call Line 21: from all over the code. -- To view, visit http://gerrit.ovirt.org/9328 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b5132300fb1f1fd94f771cab15efe5246dbeca8 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
