Maor Lipchuk has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
......................................................................
Patch Set 24: Looks good to me, approved
(3 inline comments)
See minor comments
....................................................
File backend/manager/dbscripts/vm_templates_sp.sql
Line 252:
Line 253:
Line 254:
Line 255:
Line 256: Create or replace FUNCTION GetVmTemplatesByIds(v_vms_tremplates_ids
VARCHAR(5000)) RETURNS SETOF vm_templates_view
Please change vms_tremplates_ids with vms_templates_ids
Line 257: AS $procedure$
Line 258: BEGIN
Line 259: RETURN QUERY SELECT vm_templates.*
Line 260: FROM vm_templates_view vm_templates
Line 257: AS $procedure$
Line 258: BEGIN
Line 259: RETURN QUERY SELECT vm_templates.*
Line 260: FROM vm_templates_view vm_templates
Line 261: WHERE vm_templates.vmt_guid in (SELECT ID from
fnSplitterUuid(v_vms_tremplates_ids));
same here
Line 262: END; $procedure$
Line 263: LANGUAGE plpgsql;
Line 264:
Line 265:
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java
Line 62: @Override
Line 63: public List<VmTemplate> getVmTemplatesByIds(List<Guid>
templatesIds) {
Line 64: return getCallsHandler().executeReadList("GetVmTemplatesByIds",
Line 65: VMTemplateRowMapper.instance,
Line 66:
getCustomMapSqlParameterSource().addValue("vms_tremplates_ids",
StringUtils.join(templatesIds,',')));
Please change vms_tremplates_ids with vms_templates_ids
Line 67: }
Line 68:
Line 69: @Override
Line 70: public List<VmTemplate> getAllForStorageDomain(Guid storageDomain)
{
--
To view, visit http://gerrit.ovirt.org/9328
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b5132300fb1f1fd94f771cab15efe5246dbeca8
Gerrit-PatchSet: 24
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
