Liron Aravot has posted comments on this change. Change subject: core: introducing OvfAutoUpdate ......................................................................
Patch Set 14: (1 inline comment) .................................................... File backend/manager/dbscripts/vms_sp.sql Line 35: AS $procedure$ Line 36: BEGIN Line 37: RETURN QUERY SELECT ovf.vm_guid as vm_guid Line 38: FROM vm_ovf_generations ovf Line 39: WHERE NOT EXISTS (SELECT 1 FROM vm_static v WHERE v.vm_guid = ovf.vm_guid) AND just for the record, atleast in postgres exists should generally perform better in that case - but as we don't want to rely only on postgres implementation for it i've changed it to in. Line 40: ovf.storage_pool_id = v_storage_pool_id; Line 41: END; $procedure$ Line 42: LANGUAGE plpgsql; Line 43: -- To view, visit http://gerrit.ovirt.org/9328 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b5132300fb1f1fd94f771cab15efe5246dbeca8 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
