Liron Aravot has posted comments on this change.

Change subject: core: introducing OvfAutoUpdate
......................................................................


Patch Set 16: (4 inline comments)

....................................................
File backend/manager/dbscripts/storages_sp.sql
Line 98:         SELECT vm_guid
Line 99:         FROM   vms
Line 100:         WHERE  storage_pool_id = v_id);
Line 101:     delete FROM vm_static where vm_guid in (select vm_guid from vms 
where storage_pool_id = v_id);
Line 102:     
will be removed
Line 103:       -- Get (and keep) a shared lock with "right to upgrade to 
exclusive"
Line 104:       -- in order to force locking parent before children
Line 105:    select   id INTO v_val FROM storage_pool  WHERE id = v_id     FOR 
UPDATE;
Line 106: 


....................................................
File backend/manager/dbscripts/upgrade/03_01_1530_add_vm_generation_columns.sql
Line 6:    vm_guid UUID PRIMARY KEY,
Line 7:    storage_pool_id UUID REFERENCES storage_pool(id) ON DELETE CASCADE,
Line 8:    ovf_generation BIGINT DEFAULT 1
Line 9: );
Line 10: 
tws here will be removed
Line 11: INSERT into vm_ovf_generations 
Line 12: (SELECT vm.vm_guid, sp.id 
Line 13: FROM vm_static vm ,storage_pool sp, vds_groups vg WHERE 
Line 14: vg.storage_pool_id = sp.id AND vm.vds_group_id = vg.vds_group_id);


....................................................
File backend/manager/dbscripts/vms_sp.sql
Line 424:    AS $procedure$
Line 425: BEGIN
Line 426: INSERT INTO vm_static(description, mem_size_mb, os, vds_group_id, 
vm_guid, VM_NAME, 
vmt_guid,domain,creation_date,num_of_monitors,allow_console_reconnect,is_initialized,is_auto_suspend,num_of_sockets,cpu_per_socket,usb_policy,
 time_zone,auto_startup,is_stateless,dedicated_vm_for_vds, fail_back, 
default_boot_sequence, vm_type, nice_level, default_display_type, 
priority,iso_path,origin,initrd_url,kernel_url,kernel_params,migration_support,predefined_properties,userdefined_properties,min_allocated_mem,
 entity_type, quota_id, cpu_pinning, is_smartcard_enabled)
Line 427:       VALUES(v_description,  v_mem_size_mb, v_os, v_vds_group_id, 
v_vm_guid, v_vm_name, v_vmt_guid, v_domain, v_creation_date, v_num_of_monitors, 
v_allow_console_reconnect, v_is_initialized, v_is_auto_suspend, 
v_num_of_sockets, v_cpu_per_socket, v_usb_policy, v_time_zone, 
v_auto_startup,v_is_stateless,v_dedicated_vm_for_vds,v_fail_back, 
v_default_boot_sequence, v_vm_type, v_nice_level, v_default_display_type, 
v_priority,v_iso_path,v_origin,v_initrd_url,v_kernel_url,v_kernel_params,v_migration_support,v_predefined_properties,v_userdefined_properties,v_min_allocated_mem,
 'VM', v_quota_id, v_cpu_pinning, v_is_smartcard_enabled);
Line 428: INSERT INTO vm_ovf_generations(vm_guid, storage_pool_id) VALUES 
(v_vm_guid, (select storage_pool_id from vds_groups vg where vg.vds_group_id = 
v_vds_group_id)); 
tws will be removed
Line 429: END; $procedure$
Line 430: LANGUAGE plpgsql;
Line 431: 
Line 432: 


Line 493: Create or replace FUNCTION 
IncrementDbGenerationForAllInStoragePool(v_storage_pool_id UUID)
Line 494: RETURNS VOID
Line 495:    AS $procedure$
Line 496: BEGIN
Line 497:       UPDATE vm_static 
tws will be removed
Line 498:       SET db_generation  = db_generation + 1
Line 499:       WHERE storage_pool_id IN (SELECT v.vds_group_id FROM vds_groups 
v, storage_pool sp where sp.id=v_storage_pool_id);
Line 500: END; $procedure$
Line 501: LANGUAGE plpgsql;


--
To view, visit http://gerrit.ovirt.org/9328
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b5132300fb1f1fd94f771cab15efe5246dbeca8
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to