oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_dao-unit-tests_merged/8414/ :
SUCCESS
http://j
Oved Ourfali has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/31499
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-M
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit http://gerrit.
Oved Ourfali has submitted this change and it was merged.
Change subject: aaa: Fix add users
..
aaa: Fix add users
Topic: AAA
Change-Id: Ie0384bab5abb6b8e1b1c9d1582bc630ea012cd4f
Signed-off-by: Yair Zaslavsky
---
M
backend/ma
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 7: Code-Review+1
we handle the other issues at different patch
1. move the \ group notation into builtin extension.
2. search on
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 7: Verified+1
Verified also with IPA (legacy) - at past we had issues with add groups there...
--
To view, visit http://gerrit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/31160/
: SUCCESS
htt
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 7:
Fixed minor issues.
Alon, please response according to the email I've sent you -
I saw at the unit tests that -
a. if you pas
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 6:
(2 comments)
http://gerrit.ovirt.org/#/c/31499/6/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/rest
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 6:
(2 comments)
http://gerrit.ovirt.org/#/c/31499/6/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/re
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 6:
But still I will have to perform hex.decode, right? (for domain_entry_id).
--
To view, visit http://gerrit.ovirt.org/31499
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 6:
(2 comments)
http://gerrit.ovirt.org/#/c/31499/6/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/rest
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 6:
why? I thought that post is whatever get gets... if id="uuid" then this is what
I post...
--
To view, visit http://gerrit.ov
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 6:
(7 comments)
http://gerrit.ovirt.org/#/c/31499/6/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/re
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 6:
btw, you are correct, PUT is not implemented.
I would really prefer we handle update via PUT, and not mimic bad behaviors of
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 6:
not sure if i wrote in previous comment - when posting a user id ==
directory_entry_id .
The format should be hex.encode(gu
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 6:
btw, why are you re-posting with guid format and not the hex.encode(guid)
format?
--
To view, visit http://gerrit.ovirt.or
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 6:
PUT is not working on /users
so the id= handling is incorrect anyway, either ignore it from POST or print
proper error?
--
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 6:
Please use PUT to update,
the re-add at UI is not ideal IMHO.
--
To view, visit http://gerrit.ovirt.org/31499
To unsubscrib
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 6:
great, works:
1. namespace
2. domain_entry_id
3. user name
one strange issue...
1. add user
2. repost with
3. res
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 6:
(7 comments)
http://gerrit.ovirt.org/#/c/31499/6/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/rest
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/31143/
: SUCCESS
htt
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 6: Verified+1
domain_entry_id is fixed.
--
To view, visit http://gerrit.ovirt.org/31499
To unsubscribe, visit http://gerrit.ov
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 6:
domain_entry_id is fixed.
--
To view, visit http://gerrit.ovirt.org/31499
To unsubscribe, visit http://gerrit.ovirt.org/set
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 5:
(4 comments)
http://gerrit.ovirt.org/#/c/31499/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/q
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 5:
i'll add domain_entry_id.
--
To view, visit http://gerrit.ovirt.org/31499
To unsubscribe, visit http://gerrit.ovirt.org/set
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 5:
Did you try to use id? or just domain_entry_id ?
When you take a user from /api/domains/xxx/users -
(same with groups)
id
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 5:
namespace support - ok
name search - partial - search by PrincipalRecord.NAME only in separate patch
id support - not ok, as
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 5:
(3 comments)
http://gerrit.ovirt.org/#/c/31499/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/que
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/31136/
: SUCCESS
htt
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/31499/5/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/resta
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/31499
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Me
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 5:
Chopping @xxx was moved to API.
--
To view, visit http://gerrit.ovirt.org/31499
To unsubscribe, visit http://gerrit.ovirt.o
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/31134/
: SUCCESS
htt
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/31499/3/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SearchQuer
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/31130/
: SUCCESS
htt
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 4:
so i think using a set is nicer...
--
To view, visit http://gerrit.ovirt.org/31499
To unsubscribe, visit http://gerrit.ovir
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 3:
this is not a user you can login into
--
To view, visit http://gerrit.ovirt.org/31499
To unsubscribe, visit http://gerrit.ovi
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/31499/3/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SearchQu
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 2:
Alon, I have noticed for a few users that that first name is not presented at
ui, for generic-ldap , can you please check?
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 2:
As agreed with Alon, we will deal with search later.
the first issue he brought up must be fixed.
--
To view, visit http://
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 2:
Patch Set 2: Verified-1
the fake suffix of the user is sent to the extension.
> I'll check that.
also, I do not expect the
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 2: Verified-1
the fake suffix of the user is sent to the extension.
also, I do not expect the restapi search by anything but Prin
Oved Ourfali has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 2:
please verify adding users and groups through the API.
--
To view, visit http://gerrit.ovirt.org/31499
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/31102/
: SUCCESS
htt
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/31094/
: SUCCESS
htt
Yair Zaslavsky has uploaded a new change for review.
Change subject: aaa: Fix add users
..
aaa: Fix add users
Topic: AAA
Change-Id: Ie0384bab5abb6b8e1b1c9d1582bc630ea012cd4f
Signed-off-by: Yair Zaslavsky
---
M
backend/manager/
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: Fix add users
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
54 matches
Mail list logo
