Alon Bar-Lev has posted comments on this change.

Change subject: aaa: Fix add users
......................................................................


Patch Set 2: Verified-1

the fake suffix of the user is sent to the extension.

also, I do not expect the restapi search by anything but PrincipalRecord.NAME, 
currently like the ui it searches or statement with lots of attributes, this is 
invalid.

 filter {Extkey[name=AAA_AUTHZ_QUERY_FILTER_OPERATOR;type=class 
java.lang.Integer;uuid=AAA_AUTHZ_QUERY_FILTER_OPERATOR[c8588111-25a3-40e9-bf82-44acd3d0049d];]=102,
 Extkey[name=AAA_AUTHZ_QUERY_ENTITY;type=class 
org.ovirt.engine.api.extensions.ExtUUID;uuid=AAA_AUTHZ_QUERY_ENTITY[d0a55f21-b604-43c4-84a0-2bf459b32fa8];]=AAA_AUTHZ_QUERY_ENTITY_PRINCIPAL[1695cd36-4656-474f-b7bc-4466e12634e4],
 Extkey[name=AAA_AUTHZ_QUERY_FILTER_FILTER;type=interface 
java.util.Collection;uuid=AAA_AUTHZ_QUERY_FILTER_FILTER[a84d8b7a-0436-46bc-a49a-4dfda94e3a51];]=[{Extkey[name=AAA_AUTHZ_QUERY_FILTER_OPERATOR;type=class
 
java.lang.Integer;uuid=AAA_AUTHZ_QUERY_FILTER_OPERATOR[c8588111-25a3-40e9-bf82-44acd3d0049d];]=0,
 Extkey[name=AAA_AUTHZ_PRINCIPAL_FIRST_NAME;type=class 
java.lang.String;uuid=AAA_AUTHZ_PRINCIPAL_FIRST_NAME[654c2738-581b-45d4-a486-362d891d2db2];]=Paikov@ldap-authz-ad_qa,
 Extkey[name=AAA_AUTHZ_QUERY_FILTER_OPERATOR_KEY;type=class 
org.ovirt.engine.api.extensions.ExtKey;uuid=AAA_AUTHZ_QUERY_!
 
FILTER_OPERATOR_KEY[2be62864-6a4c-4a1b-80f0-bed68d9eb529];]=Extkey[name=AAA_AUTHZ_PRINCIPAL_FIRST_NAME;type=class
 
java.lang.String;uuid=AAA_AUTHZ_PRINCIPAL_FIRST_NAME[654c2738-581b-45d4-a486-362d891d2db2];]},
 {Extkey[name=AAA_AUTHZ_PRINCIPAL_LAST_NAME;type=class 
java.lang.String;uuid=AAA_AUTHZ_PRINCIPAL_LAST_NAME[d1479cd7-a19e-4bd8-a639-1e9db7f398d8];]=Paikov@ldap-authz-ad_qa,
 Extkey[name=AAA_AUTHZ_QUERY_FILTER_OPERATOR;type=class 
java.lang.Integer;uuid=AAA_AUTHZ_QUERY_FILTER_OPERATOR[c8588111-25a3-40e9-bf82-44acd3d0049d];]=0,
 Extkey[name=AAA_AUTHZ_QUERY_FILTER_OPERATOR_KEY;type=class 
org.ovirt.engine.api.extensions.ExtKey;uuid=AAA_AUTHZ_QUERY_FILTER_OPERATOR_KEY[2be62864-6a4c-4a1b-80f0-bed68d9eb529];]=Extkey[name=AAA_AUTHZ_PRINCIPAL_LAST_NAME;type=class
 
java.lang.String;uuid=AAA_AUTHZ_PRINCIPAL_LAST_NAME[d1479cd7-a19e-4bd8-a639-1e9db7f398d8];]},
 {Extkey[name=AAA_AUTHZ_PRINCIPAL_DISPLAY_NAME;type=class 
java.lang.String;uuid=AAA_AUTHZ_PRINCIPAL_DISPLAY_NAME[1687a9e2-d951-4ee!
 6-9409-36bca8e83ed1];]=Paikov@ldap-authz-ad_qa, 
Extkey[name=AAA_AUTHZ_QUERY_FILTER_OPERATOR;type=class 
java.lang.Integer;uuid=AAA_AUTHZ_QUERY_FILTER_OPERATOR[c8588111-25a3-40e9-bf82-44acd3d0049d];]=0,
 Extkey[name=AAA_AUTHZ_QUERY_FILTER_OPERATOR_KEY;type=class 
org.ovirt.engine.api.extensions.ExtKey;uuid=AAA_AUTHZ_QUERY_FILTER_OPERATOR_KEY[2be62864-6a4c-4a1b-80f0-bed68d9eb529];]=Extkey[name=AAA_AUTHZ_PRINCIPAL_DISPLAY_NAME;type=class
 
java.lang.String;uuid=AAA_AUTHZ_PRINCIPAL_DISPLAY_NAME[1687a9e2-d951-4ee6-9409-36bca8e83ed1];]},
 {Extkey[name=AAA_AUTHZ_QUERY_FILTER_OPERATOR;type=class 
java.lang.Integer;uuid=AAA_AUTHZ_QUERY_FILTER_OPERATOR[c8588111-25a3-40e9-bf82-44acd3d0049d];]=0,
 Extkey[name=AAA_AUTHZ_PRINCIPAL_NAME;type=class 
java.lang.String;uuid=AAA_AUTHZ_PRINCIPAL_NAME[a0df5bcc-6ead-40a2-8565-2f5cc8773bdd];]=Paikov@ldap-authz-ad_qa,
 Extkey[name=AAA_AUTHZ_QUERY_FILTER_OPERATOR_KEY;type=class 
org.ovirt.engine.api.extensions.ExtKey;uuid=AAA_AUTHZ_QUERY_FILTER_OPERATOR_KEY[2be
 62864-6a4c-4a1b-80f0-bed68d9eb529];]=Extkey[name=AAA_AUTHZ_PRINCIPAL_N!
 AME;type=class 
java.lang.String;uuid=AAA_AUTHZ_PRINCIPAL_NAME[a0df5bcc-6ead-40a2-8565-2f5cc8773bdd];]}]}

-- 
To view, visit http://gerrit.ovirt.org/31499
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0384bab5abb6b8e1b1c9d1582bc630ea012cd4f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to