Yair Zaslavsky has posted comments on this change. Change subject: aaa: Fix add users ......................................................................
Patch Set 7: Fixed minor issues. Alon, please response according to the email I've sent you - I saw at the unit tests that - a. if you pass "id" - search at directory should be done according to it (hence , "id" must be the "external_id" :( ) c. Similar to user@xxxx , which allows to have only a mandatory field of user_name (whtout the need for domain id) the format of xxx/yyy/zzzzz can be used to provide an implict domain name for groups (see BackendUsersResourceTest and BackendGroupsResourceTest). Please suggest how to proceed with these, bare in mind that with generic-ldap, you will simply need to provide group name + domain id in the case of group addition. -- To view, visit http://gerrit.ovirt.org/31499 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0384bab5abb6b8e1b1c9d1582bc630ea012cd4f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
