Yair Zaslavsky has posted comments on this change. Change subject: aaa: Fix add users ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/31499/3/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SearchQueryParsingUtils.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SearchQueryParsingUtils.java: Line 128: private static String adjustValueForExtension(String field, String value, ExtUUID queryEntity) { Line 129: String result = value; Line 130: if (queryEntity.equals(Authz.QueryEntity.PRINCIPAL)) { Line 131: // Department and title do not contain any name related string. Line 132: if (!(field.equals("$DEPARTMENT") || field.equals("$TITLE"))) { as the search is composed from OR on several conditions, i have chopped off the @xxx prefix from those who are not name related. if you wish we can defined a "whitelist" set of field names that we should not chop what do you think? Line 133: result = value.contains("@") ? value.substring(0, value.indexOf("@")) : value; Line 134: } Line 135: } Line 136: return result; -- To view, visit http://gerrit.ovirt.org/31499 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0384bab5abb6b8e1b1c9d1582bc630ea012cd4f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
