Yair Zaslavsky has posted comments on this change. Change subject: aaa: Fix add users ......................................................................
Patch Set 5: (4 comments) http://gerrit.ovirt.org/#/c/31499/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/DirectoryIdQueryParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/DirectoryIdQueryParameters.java: Line 49: return id; Line 50: } Line 51: Line 52: public boolean constainsNamespace() { Line 53: return namespace != null && !namespace.isEmpty(); > StringUTils.isempty? Sorry, no StringUtils here, this is common :( Line 54: } http://gerrit.ovirt.org/#/c/31499/5/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendDomainGroupsResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendDomainGroupsResource.java: Line 23: */ Line 24: public class BackendDomainGroupsResource Line 25: extends AbstractBackendSubResource<Group, DirectoryGroup> Line 26: implements DomainGroupsResource { Line 27: private static final String SEARCH_TEMPLATE = ResourceConstants.AAA_GROUPS_SEARCH_TEMPLATE; > why do you need constant over constant :))) simply did not erase the old one, i will fix. Line 28: Line 29: private BackendDomainResource parent; Line 30: Line 31: public BackendDomainGroupsResource(String id, BackendDomainResource parent) { http://gerrit.ovirt.org/#/c/31499/5/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResource.java: Line 46: /** Line 47: * This search pattern is used when searching for the directory group that will be added to the database when the Line 48: * {@code add} operation is performed. Line 49: */ Line 50: private static final String DIRECTORY_GROUP_SEARCH_TEMPLATE = ResourceConstants.AAA_GROUPS_SEARCH_TEMPLATE; > constant over constant? Done Line 51: public BackendGroupsResource() { Line 52: super(Group.class, DbGroup.class, SUB_COLLECTIONS); Line 53: } Line 54: http://gerrit.ovirt.org/#/c/31499/5/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResource.java: Line 222: result = getEntity( Line 223: DirectoryUser.class, Line 224: SearchType.DirectoryUser, Line 225: getDirectoryUserSearchPattern( Line 226: user.getUserName().contains("@") ? user.getUserName().substring(0, user.getUserName().indexOf("@")) : user.getUserName(), > last index of please Done Line 227: user.getNamespace(), Line 228: directoryName) Line 229: ); Line 230: -- To view, visit http://gerrit.ovirt.org/31499 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0384bab5abb6b8e1b1c9d1582bc630ea012cd4f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
