Michael Kublin has abandoned this change.
Change subject: engine: Improve of RecoveryStoragePool
..
Patch Set 3: Abandoned
--
To view, visit http://gerrit.ovirt.org/11868
To unsubscribe, visit http://gerrit.ovirt.org/settings
Michael Kublin has abandoned this change.
Change subject: engine: War aginst long transaction - migration of vms
..
Patch Set 1: Abandoned
I prefer not to merge
--
To view, visit http://gerrit.ovirt.org/13103
To unsubscribe, v
Michael Kublin has abandoned this change.
Change subject: engine: Removing opening of global transaction from endAction
..
Patch Set 1: Abandoned
I don't care
--
To view, visit http://gerrit.ovirt.org/12010
To unsubscribe, vis
Michael Kublin has posted comments on this change.
Change subject: core: Remove GlobalCatalogSrvLocator
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14549
To unsubscribe, visit http://ger
Michael Kublin has posted comments on this change.
Change subject: engine: Added Quartz clean up listener
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14543
To unsubscribe, visit http://gerrit.ovirt.org/se
Michael Kublin has uploaded a new change for review.
Change subject: engine: Added Quartz clean up listener
..
engine: Added Quartz clean up listener
This listener should be added in order to clean thread context for Quartz
thr
Michael Kublin has posted comments on this change.
Change subject: engine: Adding quartz configuration to standalone.xml
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14504
To un
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Adding quartz configuration to standalone.xml
..
engine: Adding quartz configuration to standalone.xml
In order to configure a quartz scheduler
Michael Kublin has posted comments on this change.
Change subject: engine: Adding quartz configuration to standalone.xml
..
Patch Set 1:
Do you mean that the existing properties file has been ignored since we moved
to AS 7? If
Michael Kublin has posted comments on this change.
Change subject: core: Add log when task could not end action.
..
Patch Set 3: I would prefer that you didn't submit this
I don't understand how this patch is related to bug, an
Michael Kublin has posted comments on this change.
Change subject: engine: Adding quartz configuration to standalone.xml
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14504
To unsubscribe, visit http://gerr
Michael Kublin has uploaded a new change for review.
Change subject: engine: Adding quartz configuration to standalone.xml
..
engine: Adding quartz configuration to standalone.xml
In order to configure a quartz scheduler his con
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Fixing NPE in CollectVdsNetworkDataVDSCommand
..
engine: Fixing NPE in CollectVdsNetworkDataVDSCommand
The NPE is occuring because of some chan
Michael Kublin has posted comments on this change.
Change subject: engine: Fixing NPE in CollectVdsNetworkDataVDSCommand
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/14
Michael Kublin has posted comments on this change.
Change subject: engine: Fixing NPE in CollectVdsNetworkDataVDSCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14501
To unsubscribe, visit http://gerr
Michael Kublin has uploaded a new change for review.
Change subject: engine: Fixing NPE in CollectVdsNetworkDataVDSCommand
..
engine: Fixing NPE in CollectVdsNetworkDataVDSCommand
The NPE is occuring because of some changes in B
Michael Kublin has posted comments on this change.
Change subject: engine: ConcurrentModificationException failing domain/host
fail process
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14496
To unsubscrib
Michael Kublin has uploaded a new change for review.
Change subject: engine: ConcurrentModificationException failing domain/host
fail process
..
engine: ConcurrentModificationException failing domain/host fail process
The follo
Michael Kublin has abandoned this change.
Change subject: core: Remove global lock on SPM calls from engine side
..
Patch Set 5: Abandoned
This change will not be merged.
Instead of improving a system, we prefer to stuck a bott
Michael Kublin has posted comments on this change.
Change subject: core: avoid logging in ERROR on cancelled event.
..
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
...
Michael Kublin has posted comments on this change.
Change subject: core: InitVdsOnUp- proceed regardless of
ConnectHostToStoragePoolServers
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.o
Michael Kublin has posted comments on this change.
Change subject: engine: Fixing correlationId in MultipleActionRunner
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/143
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Fixing correlationId in MultipleActionRunner
..
engine: Fixing correlationId in MultipleActionRunner
The following patch should connect canDoAc
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Replacing getVds() query by getVdsStatic() query in
VDSCommands
..
engine: Replacing getVds() query by getVdsStatic() query in VDSCommands
The
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Removing date creation from MultipleActionsRunner
during logging
..
engine: Removing date creation from MultipleActionsRunner during logging
R
Michael Kublin has posted comments on this change.
Change subject: engine: Removing date creation from MultipleActionsRunner
during logging
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http:/
Michael Kublin has posted comments on this change.
Change subject: engine: Replacing getVds() query by getVdsStatic() query in
VDSCommands
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://
Michael Kublin has posted comments on this change.
Change subject: core: InitVdsOnUp- proceed regardless of
ConnectHostToStoragePoolServers
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
...
Michael Kublin has submitted this change and it was merged.
Change subject: core: initVdsOnUp- remove reconstruct and host status.
..
core: initVdsOnUp- remove reconstruct and host status.
*Host that runs through init vds on
Michael Kublin has posted comments on this change.
Change subject: core: initVdsOnUp- remove reconstruct and host status.
..
Patch Set 10: Verified; Looks good to me, approved
for backport you will need commit I0bd38cd75706ff7
Michael Kublin has submitted this change and it was merged.
Change subject: core: initialize vds - select random host
..
core: initialize vds - select random host
when attempting to initialize vds, attempt to perform it through
Michael Kublin has posted comments on this change.
Change subject: core: initialize vds - select random host
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13881
To unsubscribe, visit http:
Michael Kublin has posted comments on this change.
Change subject: core: initialize vds - select random host
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/13881
To unsubscribe, visit http://gerrit.ovirt.org
Michael Kublin has posted comments on this change.
Change subject: core: inactive domain can be selected as master
..
Patch Set 7: I would prefer that you didn't submit this
I don't see reason to increase master domain version
Michael Kublin has posted comments on this change.
Change subject: engine: fetch gluster host uuid during InitVdsOnUp
..
Patch Set 3: (1 inline comment)
File
backend/manager
Michael Kublin has posted comments on this change.
Change subject: core: wip: initVdsOnUp- remove reconstruct and host status.
..
Patch Set 9: (3 inline comments)
File
backe
Michael Kublin has posted comments on this change.
Change subject: core: wip: initVdsOnUp- remove reconstruct and host status.
..
Patch Set 9: (1 inline comment)
File
backen
Michael Kublin has posted comments on this change.
Change subject: engine: Removing date creation from MultipleActionsRunner
during logging
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14328
To unsubscrib
Michael Kublin has posted comments on this change.
Change subject: engine: Fixing correlationId in MultipleActionRunner
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14329
To unsubscribe, visit http://gerri
Michael Kublin has uploaded a new change for review.
Change subject: engine: Removing date creation from MultipleActionsRunner
during logging
..
engine: Removing date creation from MultipleActionsRunner during logging
Removed e
Michael Kublin has uploaded a new change for review.
Change subject: engine: Fixing correlationId in MultipleActionRunner
..
engine: Fixing correlationId in MultipleActionRunner
The following patch should connect canDoAction wit
Michael Kublin has posted comments on this change.
Change subject: core: Remvoing useless AtomicInteger from EntityAsyncTask
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14320
To unsubscr
Michael Kublin has posted comments on this change.
Change subject: engine: Replacing getVds() query by getVdsStatic() query in
VDSCommands
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14321
To unsubscribe
Michael Kublin has uploaded a new change for review.
Change subject: engine: Replacing getVds() query by getVdsStatic() query in
VDSCommands
..
engine: Replacing getVds() query by getVdsStatic() query in VDSCommands
The followi
Michael Kublin has submitted this change and it was merged.
Change subject: engine: ApplicationException - removed
..
engine: ApplicationException - removed
We are not C# project, removing C# inheritance
Change-Id: I681f44a577
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Exception handling - VDSCommandBase
..
engine: Exception handling - VDSCommandBase
The following patch will simplify exception handling in case
Michael Kublin has posted comments on this change.
Change subject: engine: Exception handling - VDSCommandBase
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14312
To unsubscribe, visit htt
Michael Kublin has posted comments on this change.
Change subject: engine: ApplicationException - removed
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14241
To unsubscribe, visi
Michael Kublin has posted comments on this change.
Change subject: core: inactive domain can be selected as master
..
Patch Set 5:
"The patch will cause insufficient reconstructs in 99%" - in which cases? can
you please give e
Michael Kublin has posted comments on this change.
Change subject: engine: Exception handling - VDSCommandBase
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14312
To unsubscribe, visit http://gerrit.ovirt.o
Michael Kublin has uploaded a new change for review.
Change subject: engine: Exception handling - VDSCommandBase
..
engine: Exception handling - VDSCommandBase
The following patch will simplify exception handling in case of fail
Michael Kublin has posted comments on this change.
Change subject: core: InitVdsOnUp- proceed regardless of
ConnectHostToStoragePoolServers
..
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
Bad au
Michael Kublin has posted comments on this change.
Change subject: core: wip: initVdsOnUp- remove reconstruct and host status.
..
Patch Set 9: I would prefer that you didn't submit this
(1 inline comment)
.
Michael Kublin has posted comments on this change.
Change subject: engine: ApplicationException - removed
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14241
To unsubscribe, visit http://gerrit.ovirt.org/se
Michael Kublin has uploaded a new change for review.
Change subject: engine: ApplicationException - removed
..
engine: ApplicationException - removed
We are not C# project, removing C# inheritance
Change-Id: I681f44a5772e0ed2c2
Michael Kublin has posted comments on this change.
Change subject: core: inactive domain can be selected as master
..
Patch Set 5: I would prefer that you didn't submit this
After second look on this patch, I can say implementa
Michael Kublin has posted comments on this change.
Change subject: core: initVdsOnUp - remove reconstruct and host status.
..
Patch Set 7: (2 inline comments)
File
backend/m
Michael Kublin has posted comments on this change.
Change subject: core: initVdsOnUp - remove reconstruct and host status.
..
Patch Set 7: Fails; I would prefer that you didn't submit this
(1 inline comment)
The patch is not v
Michael Kublin has posted comments on this change.
Change subject: engine: remve command serialVersionUid fields
..
Patch Set 2:
Hi, you can merge this patch. A cache is not using TimeOutBaseObject
--
To view, visit http://ger
Michael Kublin has submitted this change and it was merged.
Change subject: engine: TimeoutBase - Improving memory footprint - continue
..
engine: TimeoutBase - Improving memory footprint - continue
After changes inside Timeout
Michael Kublin has posted comments on this change.
Change subject: engine: TimeoutBase - Improving memory footprint - continue
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.
Michael Kublin has posted comments on this change.
Change subject: core: server fails to load on wrong custom property regex
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14181
To unsubscr
Michael Kublin has posted comments on this change.
Change subject: engine: TmeoutBase - Improving memory footprint - continue
..
Patch Set 1: (2 inline comments)
File
backen
Michael Kublin has posted comments on this change.
Change subject: core: avoid logging in ERROR on cancelled event.
..
Patch Set 3: (1 inline comment)
File
backend/manager/m
Michael Kublin has posted comments on this change.
Change subject: engine: TmeoutBase - Improving memory footprint - continue
..
Patch Set 1: Verified
This is a fourth patch which is dealing with memory, and I think that we sti
Michael Kublin has uploaded a new change for review.
Change subject: engine: TmeoutBase - Improving memory footprint - continue
..
engine: TmeoutBase - Improving memory footprint - continue
After changes inside TimeoutBase, I fo
Michael Kublin has posted comments on this change.
Change subject: core: avoid logging in ERROR on cancelled event.
..
Patch Set 3: (1 inline comment)
File
backend/manager/m
Michael Kublin has posted comments on this change.
Change subject: engine: remove ObjectStreamSerializer default constructor
..
Patch Set 2:
Actually you can remove the whole class , it used only inside test
--
To view, visit
Michael Kublin has posted comments on this change.
Change subject: engine: remve command serialVersionUid fields
..
Patch Set 2: Looks good to me, approved
please fix typo
--
To view, visit http://gerrit.ovirt.org/13946
To uns
Michael Kublin has posted comments on this change.
Change subject: engine: TimeoutBase does not have to be serialized
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13945
To unsubscribe, vi
Michael Kublin has posted comments on this change.
Change subject: engine: remove unused roles_relations
..
Patch Set 1: Looks good to me, approved
please rebase and update version of the upgrade script
--
To view, visit http:
Michael Kublin has posted comments on this change.
Change subject: engine: Remove DbUser.iconPath property
..
Patch Set 3: Looks good to me, approved
please rebase and update version of the upgrade script
--
To view, visit htt
Michael Kublin has posted comments on this change.
Change subject: engine: remove DBUser.desktopDevice
..
Patch Set 5: Looks good to me, approved
please rebase and update version of sql upgrade scrip
--
To view, visit http://g
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Introducing using of Infinispan cache at TimeoutBase
..
engine: Introducing using of Infinispan cache at TimeoutBase
The TimeoutBase was used f
Michael Kublin has posted comments on this change.
Change subject: engine: Introducing using of Infinispan cache at TimeoutBase
..
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt
Michael Kublin has posted comments on this change.
Change subject: engine: Introducing using of Infinispan cache at TimeoutBase
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14117
To unsubscribe, visit http
Michael Kublin has posted comments on this change.
Change subject: engine: Introducing using of Infinispan cache at TimeoutBase
..
Patch Set 2:
All comments applied
--
To view, visit http://gerrit.ovirt.org/14117
To unsubscrib
Michael Kublin has posted comments on this change.
Change subject: engine: Introducing using of Infinispan cache at TimeoutBase
..
Patch Set 1:
In next patch I will apply comments of Juan , meanwhile waiting for comments
from
Michael Kublin has posted comments on this change.
Change subject: engine: Introducing using of Infinispan cache at TimeoutBase
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14117
To unsubscribe, visit http
Michael Kublin has uploaded a new change for review.
Change subject: engine: Introducing using of Infinispan cache at TimeoutBase
..
engine: Introducing using of Infinispan cache at TimeoutBase
The TimeoutBase was ysed for the f
Michael Kublin has posted comments on this change.
Change subject: core: avoid logging in ERROR on cancelled event.
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Removing XmlRpcStruct
..
engine: Removing XmlRpcStruct
The following patch is removing XmlRpcStruct.
The XmlRpcStruct was wrapper for HahsMap,
Michael Kublin has posted comments on this change.
Change subject: engine: Removing XmlRpcStruct
..
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/14032
To unsubscribe, visi
Michael Kublin has posted comments on this change.
Change subject: engine: Removing XmlRpcStruct
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14032
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Michael Kublin has posted comments on this change.
Change subject: engine: Removing XmlRpcStruct
..
Patch Set 1:
@Yair - patch is big, in general I prefer Map, but possible I
missed couple places.
Also generic is not well imp
Michael Kublin has posted comments on this change.
Change subject: core: avoid logging in ERROR on cancelled event.
..
Patch Set 2:
Verified? Why depends on another patch which is not related?
--
To view, visit http://gerrit.o
Michael Kublin has posted comments on this change.
Change subject: engine: Removing XmlRpcStruct
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14032
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Michael Kublin has posted comments on this change.
Change subject: core: Remove get image info call before images commands
..
Patch Set 1: Looks good to me, approved
drop the dead
--
To view, visit http://gerrit.ovirt.org/1399
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Fixing update of host status during restart host
..
engine: Fixing update of host status during restart host
If we failed during restart a host
Michael Kublin has posted comments on this change.
Change subject: engine: Fixing update of host status during restart host
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org
Michael Kublin has posted comments on this change.
Change subject: core: use local TX in AddVm flow
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll/src/m
Michael Kublin has uploaded a new change for review.
Change subject: engine: Fixing update of host status during restart host
..
engine: Fixing update of host status during restart host
If we failed during restart a host status
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Improving memory footprint - JSON part
..
engine: Improving memory footprint - JSON part
The following patch should imprtove a used memory in a
Michael Kublin has posted comments on this change.
Change subject: engine: Improving memory footprint - JSON part
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/13879
To
Michael Kublin has posted comments on this change.
Change subject: core: use local TX in AddVm flow
..
Patch Set 2: (4 inline comments)
File
backend/manager/modules/bll/src/
Michael Kublin has posted comments on this change.
Change subject: core: ReconstructMasterDomain - select random host
..
Patch Set 2: (1 inline comment)
File
backend/manager
Michael Kublin has posted comments on this change.
Change subject: core: when running initVdsOnUp inActive domain can be selected
as master
..
Patch Set 4: (1 inline comment)
patch look ok to me, will be acked with whole serie
Michael Kublin has posted comments on this change.
Change subject: core: InitVdsOnUp- proceed regardless of
ConnectHostToStoragePoolServers
..
Patch Set 1: (2 inline comments)
..
Michael Kublin has posted comments on this change.
Change subject: core: initVdsOnUp - remove reconstruct and host status.
..
Patch Set 6: (4 inline comments)
File
backend/m
Michael Kublin has posted comments on this change.
Change subject: core:we are fencing a host when putting it in...
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13746
To unsubscribe, visi
1 - 100 of 3013 matches
Mail list logo