[Engine-patches] Change in ovirt-engine[master]: engine: Improve of RecoveryStoragePool

2013-05-27 Thread mkublin
Michael Kublin has abandoned this change. Change subject: engine: Improve of RecoveryStoragePool .. Patch Set 3: Abandoned -- To view, visit http://gerrit.ovirt.org/11868 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: engine: War aginst long transaction - migration of vms

2013-05-27 Thread mkublin
Michael Kublin has abandoned this change. Change subject: engine: War aginst long transaction - migration of vms .. Patch Set 1: Abandoned I prefer not to merge -- To view, visit http://gerrit.ovirt.org/13103 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: engine: Removing opening of global transaction from endActio...

2013-05-27 Thread mkublin
Michael Kublin has abandoned this change. Change subject: engine: Removing opening of global transaction from endAction .. Patch Set 1: Abandoned I don't care -- To view, visit http://gerrit.ovirt.org/12010 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: core: Remove GlobalCatalogSrvLocator

2013-05-07 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: Remove GlobalCatalogSrvLocator .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14549 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: engine: Added Quartz clean up listener

2013-05-07 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Added Quartz clean up listener .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/14543 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[master]: engine: Added Quartz clean up listener

2013-05-07 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: engine: Added Quartz clean up listener .. engine: Added Quartz clean up listener This listener should be added in order to clean thread context for Quartz thr

[Engine-patches] Change in ovirt-engine[master]: engine: Adding quartz configuration to standalone.xml

2013-05-06 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Adding quartz configuration to standalone.xml .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14504 To un

[Engine-patches] Change in ovirt-engine[master]: engine: Adding quartz configuration to standalone.xml

2013-05-06 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: engine: Adding quartz configuration to standalone.xml .. engine: Adding quartz configuration to standalone.xml In order to configure a quartz scheduler

[Engine-patches] Change in ovirt-engine[master]: engine: Adding quartz configuration to standalone.xml

2013-05-06 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Adding quartz configuration to standalone.xml .. Patch Set 1: Do you mean that the existing properties file has been ignored since we moved to AS 7? If

[Engine-patches] Change in ovirt-engine[master]: core: Add log when task could not end action.

2013-05-06 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: Add log when task could not end action. .. Patch Set 3: I would prefer that you didn't submit this I don't understand how this patch is related to bug, an

[Engine-patches] Change in ovirt-engine[master]: engine: Adding quartz configuration to standalone.xml

2013-05-06 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Adding quartz configuration to standalone.xml .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/14504 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: engine: Adding quartz configuration to standalone.xml

2013-05-06 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: engine: Adding quartz configuration to standalone.xml .. engine: Adding quartz configuration to standalone.xml In order to configure a quartz scheduler his con

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing NPE in CollectVdsNetworkDataVDSCommand

2013-05-06 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: engine: Fixing NPE in CollectVdsNetworkDataVDSCommand .. engine: Fixing NPE in CollectVdsNetworkDataVDSCommand The NPE is occuring because of some chan

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing NPE in CollectVdsNetworkDataVDSCommand

2013-05-06 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Fixing NPE in CollectVdsNetworkDataVDSCommand .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/14

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing NPE in CollectVdsNetworkDataVDSCommand

2013-05-06 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Fixing NPE in CollectVdsNetworkDataVDSCommand .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/14501 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing NPE in CollectVdsNetworkDataVDSCommand

2013-05-06 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: engine: Fixing NPE in CollectVdsNetworkDataVDSCommand .. engine: Fixing NPE in CollectVdsNetworkDataVDSCommand The NPE is occuring because of some changes in B

[Engine-patches] Change in ovirt-engine[master]: engine: ConcurrentModificationException failing domain/host ...

2013-05-06 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: ConcurrentModificationException failing domain/host fail process .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/14496 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: engine: ConcurrentModificationException failing domain/host ...

2013-05-06 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: engine: ConcurrentModificationException failing domain/host fail process .. engine: ConcurrentModificationException failing domain/host fail process The follo

[Engine-patches] Change in ovirt-engine[master]: core: Remove global lock on SPM calls from engine side

2013-05-05 Thread mkublin
Michael Kublin has abandoned this change. Change subject: core: Remove global lock on SPM calls from engine side .. Patch Set 5: Abandoned This change will not be merged. Instead of improving a system, we prefer to stuck a bott

[Engine-patches] Change in ovirt-engine[master]: core: avoid logging in ERROR on cancelled event.

2013-05-02 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: avoid logging in ERROR on cancelled event. .. Patch Set 4: I would prefer that you didn't submit this (2 inline comments) ...

[Engine-patches] Change in ovirt-engine[master]: core: InitVdsOnUp- proceed regardless of ConnectHostToStorag...

2013-05-01 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: InitVdsOnUp- proceed regardless of ConnectHostToStoragePoolServers .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing correlationId in MultipleActionRunner

2013-05-01 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Fixing correlationId in MultipleActionRunner .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/143

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing correlationId in MultipleActionRunner

2013-05-01 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: engine: Fixing correlationId in MultipleActionRunner .. engine: Fixing correlationId in MultipleActionRunner The following patch should connect canDoAc

[Engine-patches] Change in ovirt-engine[master]: engine: Replacing getVds() query by getVdsStatic() query in ...

2013-05-01 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: engine: Replacing getVds() query by getVdsStatic() query in VDSCommands .. engine: Replacing getVds() query by getVdsStatic() query in VDSCommands The

[Engine-patches] Change in ovirt-engine[master]: engine: Removing date creation from MultipleActionsRunner du...

2013-05-01 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: engine: Removing date creation from MultipleActionsRunner during logging .. engine: Removing date creation from MultipleActionsRunner during logging R

[Engine-patches] Change in ovirt-engine[master]: engine: Removing date creation from MultipleActionsRunner du...

2013-05-01 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Removing date creation from MultipleActionsRunner during logging .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http:/

[Engine-patches] Change in ovirt-engine[master]: engine: Replacing getVds() query by getVdsStatic() query in ...

2013-05-01 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Replacing getVds() query by getVdsStatic() query in VDSCommands .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://

[Engine-patches] Change in ovirt-engine[master]: core: InitVdsOnUp- proceed regardless of ConnectHostToStorag...

2013-05-01 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: InitVdsOnUp- proceed regardless of ConnectHostToStoragePoolServers .. Patch Set 3: I would prefer that you didn't submit this (1 inline comment) ...

[Engine-patches] Change in ovirt-engine[master]: core: initVdsOnUp- remove reconstruct and host status.

2013-05-01 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: core: initVdsOnUp- remove reconstruct and host status. .. core: initVdsOnUp- remove reconstruct and host status. *Host that runs through init vds on

[Engine-patches] Change in ovirt-engine[master]: core: initVdsOnUp- remove reconstruct and host status.

2013-05-01 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: initVdsOnUp- remove reconstruct and host status. .. Patch Set 10: Verified; Looks good to me, approved for backport you will need commit I0bd38cd75706ff7

[Engine-patches] Change in ovirt-engine[master]: core: initialize vds - select random host

2013-05-01 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: core: initialize vds - select random host .. core: initialize vds - select random host when attempting to initialize vds, attempt to perform it through

[Engine-patches] Change in ovirt-engine[master]: core: initialize vds - select random host

2013-05-01 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: initialize vds - select random host .. Patch Set 6: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13881 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: core: initialize vds - select random host

2013-05-01 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: initialize vds - select random host .. Patch Set 6: Verified -- To view, visit http://gerrit.ovirt.org/13881 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: core: inactive domain can be selected as master

2013-05-01 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: inactive domain can be selected as master .. Patch Set 7: I would prefer that you didn't submit this I don't see reason to increase master domain version

[Engine-patches] Change in ovirt-engine[master]: engine: fetch gluster host uuid during InitVdsOnUp

2013-05-01 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: fetch gluster host uuid during InitVdsOnUp .. Patch Set 3: (1 inline comment) File backend/manager

[Engine-patches] Change in ovirt-engine[master]: core: wip: initVdsOnUp- remove reconstruct and host status.

2013-04-30 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: wip: initVdsOnUp- remove reconstruct and host status. .. Patch Set 9: (3 inline comments) File backe

[Engine-patches] Change in ovirt-engine[master]: core: wip: initVdsOnUp- remove reconstruct and host status.

2013-04-30 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: wip: initVdsOnUp- remove reconstruct and host status. .. Patch Set 9: (1 inline comment) File backen

[Engine-patches] Change in ovirt-engine[master]: engine: Removing date creation from MultipleActionsRunner du...

2013-04-29 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Removing date creation from MultipleActionsRunner during logging .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/14328 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing correlationId in MultipleActionRunner

2013-04-29 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Fixing correlationId in MultipleActionRunner .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/14329 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: engine: Removing date creation from MultipleActionsRunner du...

2013-04-29 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: engine: Removing date creation from MultipleActionsRunner during logging .. engine: Removing date creation from MultipleActionsRunner during logging Removed e

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing correlationId in MultipleActionRunner

2013-04-29 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: engine: Fixing correlationId in MultipleActionRunner .. engine: Fixing correlationId in MultipleActionRunner The following patch should connect canDoAction wit

[Engine-patches] Change in ovirt-engine[master]: core: Remvoing useless AtomicInteger from EntityAsyncTask

2013-04-29 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: Remvoing useless AtomicInteger from EntityAsyncTask .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14320 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: engine: Replacing getVds() query by getVdsStatic() query in ...

2013-04-29 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Replacing getVds() query by getVdsStatic() query in VDSCommands .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/14321 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: engine: Replacing getVds() query by getVdsStatic() query in ...

2013-04-29 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: engine: Replacing getVds() query by getVdsStatic() query in VDSCommands .. engine: Replacing getVds() query by getVdsStatic() query in VDSCommands The followi

[Engine-patches] Change in ovirt-engine[master]: engine: ApplicationException - removed

2013-04-29 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: engine: ApplicationException - removed .. engine: ApplicationException - removed We are not C# project, removing C# inheritance Change-Id: I681f44a577

[Engine-patches] Change in ovirt-engine[master]: engine: Exception handling - VDSCommandBase

2013-04-29 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: engine: Exception handling - VDSCommandBase .. engine: Exception handling - VDSCommandBase The following patch will simplify exception handling in case

[Engine-patches] Change in ovirt-engine[master]: engine: Exception handling - VDSCommandBase

2013-04-29 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Exception handling - VDSCommandBase .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14312 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: engine: ApplicationException - removed

2013-04-29 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: ApplicationException - removed .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14241 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: core: inactive domain can be selected as master

2013-04-29 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: inactive domain can be selected as master .. Patch Set 5: "The patch will cause insufficient reconstructs in 99%" - in which cases? can you please give e

[Engine-patches] Change in ovirt-engine[master]: engine: Exception handling - VDSCommandBase

2013-04-29 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Exception handling - VDSCommandBase .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/14312 To unsubscribe, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: engine: Exception handling - VDSCommandBase

2013-04-29 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: engine: Exception handling - VDSCommandBase .. engine: Exception handling - VDSCommandBase The following patch will simplify exception handling in case of fail

[Engine-patches] Change in ovirt-engine[master]: core: InitVdsOnUp- proceed regardless of ConnectHostToStorag...

2013-04-28 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: InitVdsOnUp- proceed regardless of ConnectHostToStoragePoolServers .. Patch Set 2: I would prefer that you didn't submit this (2 inline comments) Bad au

[Engine-patches] Change in ovirt-engine[master]: core: wip: initVdsOnUp- remove reconstruct and host status.

2013-04-28 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: wip: initVdsOnUp- remove reconstruct and host status. .. Patch Set 9: I would prefer that you didn't submit this (1 inline comment) .

[Engine-patches] Change in ovirt-engine[master]: engine: ApplicationException - removed

2013-04-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: ApplicationException - removed .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/14241 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[master]: engine: ApplicationException - removed

2013-04-25 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: engine: ApplicationException - removed .. engine: ApplicationException - removed We are not C# project, removing C# inheritance Change-Id: I681f44a5772e0ed2c2

[Engine-patches] Change in ovirt-engine[master]: core: inactive domain can be selected as master

2013-04-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: inactive domain can be selected as master .. Patch Set 5: I would prefer that you didn't submit this After second look on this patch, I can say implementa

[Engine-patches] Change in ovirt-engine[master]: core: initVdsOnUp - remove reconstruct and host status.

2013-04-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: initVdsOnUp - remove reconstruct and host status. .. Patch Set 7: (2 inline comments) File backend/m

[Engine-patches] Change in ovirt-engine[master]: core: initVdsOnUp - remove reconstruct and host status.

2013-04-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: initVdsOnUp - remove reconstruct and host status. .. Patch Set 7: Fails; I would prefer that you didn't submit this (1 inline comment) The patch is not v

[Engine-patches] Change in ovirt-engine[master]: engine: remve command serialVersionUid fields

2013-04-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: remve command serialVersionUid fields .. Patch Set 2: Hi, you can merge this patch. A cache is not using TimeOutBaseObject -- To view, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: engine: TimeoutBase - Improving memory footprint - continue

2013-04-24 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: engine: TimeoutBase - Improving memory footprint - continue .. engine: TimeoutBase - Improving memory footprint - continue After changes inside Timeout

[Engine-patches] Change in ovirt-engine[master]: engine: TimeoutBase - Improving memory footprint - continue

2013-04-24 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: TimeoutBase - Improving memory footprint - continue .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: core: server fails to load on wrong custom property regex

2013-04-24 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: server fails to load on wrong custom property regex .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14181 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: engine: TmeoutBase - Improving memory footprint - continue

2013-04-24 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: TmeoutBase - Improving memory footprint - continue .. Patch Set 1: (2 inline comments) File backen

[Engine-patches] Change in ovirt-engine[master]: core: avoid logging in ERROR on cancelled event.

2013-04-24 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: avoid logging in ERROR on cancelled event. .. Patch Set 3: (1 inline comment) File backend/manager/m

[Engine-patches] Change in ovirt-engine[master]: engine: TmeoutBase - Improving memory footprint - continue

2013-04-23 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: TmeoutBase - Improving memory footprint - continue .. Patch Set 1: Verified This is a fourth patch which is dealing with memory, and I think that we sti

[Engine-patches] Change in ovirt-engine[master]: engine: TmeoutBase - Improving memory footprint - continue

2013-04-23 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: engine: TmeoutBase - Improving memory footprint - continue .. engine: TmeoutBase - Improving memory footprint - continue After changes inside TimeoutBase, I fo

[Engine-patches] Change in ovirt-engine[master]: core: avoid logging in ERROR on cancelled event.

2013-04-23 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: avoid logging in ERROR on cancelled event. .. Patch Set 3: (1 inline comment) File backend/manager/m

[Engine-patches] Change in ovirt-engine[master]: engine: remove ObjectStreamSerializer default constructor

2013-04-23 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: remove ObjectStreamSerializer default constructor .. Patch Set 2: Actually you can remove the whole class , it used only inside test -- To view, visit

[Engine-patches] Change in ovirt-engine[master]: engine: remve command serialVersionUid fields

2013-04-23 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: remve command serialVersionUid fields .. Patch Set 2: Looks good to me, approved please fix typo -- To view, visit http://gerrit.ovirt.org/13946 To uns

[Engine-patches] Change in ovirt-engine[master]: engine: TimeoutBase does not have to be serialized

2013-04-23 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: TimeoutBase does not have to be serialized .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13945 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: engine: remove unused roles_relations

2013-04-23 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: remove unused roles_relations .. Patch Set 1: Looks good to me, approved please rebase and update version of the upgrade script -- To view, visit http:

[Engine-patches] Change in ovirt-engine[master]: engine: Remove DbUser.iconPath property

2013-04-23 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Remove DbUser.iconPath property .. Patch Set 3: Looks good to me, approved please rebase and update version of the upgrade script -- To view, visit htt

[Engine-patches] Change in ovirt-engine[master]: engine: remove DBUser.desktopDevice

2013-04-23 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: remove DBUser.desktopDevice .. Patch Set 5: Looks good to me, approved please rebase and update version of sql upgrade scrip -- To view, visit http://g

[Engine-patches] Change in ovirt-engine[master]: engine: Introducing using of Infinispan cache at TimeoutBase

2013-04-23 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: engine: Introducing using of Infinispan cache at TimeoutBase .. engine: Introducing using of Infinispan cache at TimeoutBase The TimeoutBase was used f

[Engine-patches] Change in ovirt-engine[master]: engine: Introducing using of Infinispan cache at TimeoutBase

2013-04-23 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Introducing using of Infinispan cache at TimeoutBase .. Patch Set 3: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: engine: Introducing using of Infinispan cache at TimeoutBase

2013-04-22 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Introducing using of Infinispan cache at TimeoutBase .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/14117 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: engine: Introducing using of Infinispan cache at TimeoutBase

2013-04-22 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Introducing using of Infinispan cache at TimeoutBase .. Patch Set 2: All comments applied -- To view, visit http://gerrit.ovirt.org/14117 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: engine: Introducing using of Infinispan cache at TimeoutBase

2013-04-22 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Introducing using of Infinispan cache at TimeoutBase .. Patch Set 1: In next patch I will apply comments of Juan , meanwhile waiting for comments from

[Engine-patches] Change in ovirt-engine[master]: engine: Introducing using of Infinispan cache at TimeoutBase

2013-04-22 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Introducing using of Infinispan cache at TimeoutBase .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/14117 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: engine: Introducing using of Infinispan cache at TimeoutBase

2013-04-22 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: engine: Introducing using of Infinispan cache at TimeoutBase .. engine: Introducing using of Infinispan cache at TimeoutBase The TimeoutBase was ysed for the f

[Engine-patches] Change in ovirt-engine[master]: core: avoid logging in ERROR on cancelled event.

2013-04-21 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: avoid logging in ERROR on cancelled event. .. Patch Set 3: I would prefer that you didn't submit this (1 inline comment)

[Engine-patches] Change in ovirt-engine[master]: engine: Removing XmlRpcStruct

2013-04-18 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: engine: Removing XmlRpcStruct .. engine: Removing XmlRpcStruct The following patch is removing XmlRpcStruct. The XmlRpcStruct was wrapper for HahsMap,

[Engine-patches] Change in ovirt-engine[master]: engine: Removing XmlRpcStruct

2013-04-18 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Removing XmlRpcStruct .. Patch Set 3: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/14032 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: engine: Removing XmlRpcStruct

2013-04-18 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Removing XmlRpcStruct .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/14032 To unsubscribe, visit http://gerrit.ovirt.org/settings G

[Engine-patches] Change in ovirt-engine[master]: engine: Removing XmlRpcStruct

2013-04-18 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Removing XmlRpcStruct .. Patch Set 1: @Yair - patch is big, in general I prefer Map, but possible I missed couple places. Also generic is not well imp

[Engine-patches] Change in ovirt-engine[master]: core: avoid logging in ERROR on cancelled event.

2013-04-18 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: avoid logging in ERROR on cancelled event. .. Patch Set 2: Verified? Why depends on another patch which is not related? -- To view, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: engine: Removing XmlRpcStruct

2013-04-18 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Removing XmlRpcStruct .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/14032 To unsubscribe, visit http://gerrit.ovirt.org/settings G

[Engine-patches] Change in ovirt-engine[master]: core: Remove get image info call before images commands

2013-04-18 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: Remove get image info call before images commands .. Patch Set 1: Looks good to me, approved drop the dead -- To view, visit http://gerrit.ovirt.org/1399

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing update of host status during restart host

2013-04-17 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: engine: Fixing update of host status during restart host .. engine: Fixing update of host status during restart host If we failed during restart a host

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing update of host status during restart host

2013-04-17 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Fixing update of host status during restart host .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: core: use local TX in AddVm flow

2013-04-17 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: use local TX in AddVm flow .. Patch Set 2: (1 inline comment) File backend/manager/modules/bll/src/m

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing update of host status during restart host

2013-04-14 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: engine: Fixing update of host status during restart host .. engine: Fixing update of host status during restart host If we failed during restart a host status

[Engine-patches] Change in ovirt-engine[master]: engine: Improving memory footprint - JSON part

2013-04-14 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: engine: Improving memory footprint - JSON part .. engine: Improving memory footprint - JSON part The following patch should imprtove a used memory in a

[Engine-patches] Change in ovirt-engine[master]: engine: Improving memory footprint - JSON part

2013-04-14 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Improving memory footprint - JSON part .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/13879 To

[Engine-patches] Change in ovirt-engine[master]: core: use local TX in AddVm flow

2013-04-14 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: use local TX in AddVm flow .. Patch Set 2: (4 inline comments) File backend/manager/modules/bll/src/

[Engine-patches] Change in ovirt-engine[master]: core: ReconstructMasterDomain - select random host

2013-04-14 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: ReconstructMasterDomain - select random host .. Patch Set 2: (1 inline comment) File backend/manager

[Engine-patches] Change in ovirt-engine[master]: core: when running initVdsOnUp inActive domain can be select...

2013-04-14 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: when running initVdsOnUp inActive domain can be selected as master .. Patch Set 4: (1 inline comment) patch look ok to me, will be acked with whole serie

[Engine-patches] Change in ovirt-engine[master]: core: InitVdsOnUp- proceed regardless of ConnectHostToStorag...

2013-04-14 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: InitVdsOnUp- proceed regardless of ConnectHostToStoragePoolServers .. Patch Set 1: (2 inline comments) ..

[Engine-patches] Change in ovirt-engine[master]: core: initVdsOnUp - remove reconstruct and host status.

2013-04-14 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: initVdsOnUp - remove reconstruct and host status. .. Patch Set 6: (4 inline comments) File backend/m

[Engine-patches] Change in ovirt-engine[master]: core:we are fencing a host when putting it in...

2013-04-14 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core:we are fencing a host when putting it in... .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13746 To unsubscribe, visi

  1   2   3   4   5   6   7   8   9   10   >